From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Phil Yang <Phil.Yang@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
ZY Qiu <tgw_team@tencent.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>,
nd <nd@arm.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>,
"reshma.pattan@intel.com" <reshma.pattan@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH 2/2] lib/ethdev: fix memory ordering for call back functions
Date: Tue, 13 Oct 2020 15:25:47 +0000 [thread overview]
Message-ID: <DBAPR08MB58143A563D343F4A11C202D998040@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <b77f8cad-fcee-92b8-ca32-326bea48c30a@intel.com>
<snip>
> Subject: Re: [PATCH 2/2] lib/ethdev: fix memory ordering for call back
> functions
>
> On 10/2/2020 1:07 AM, Honnappa Nagarahalli wrote:
> > Call back functions are registered on the control plane. They are
> > accessed from the data plane. Hence, correct memory orderings should
> > be used to avoid race conditions.
> >
> > Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks")
> > Fixes: c8231c63ddcb ("ethdev: insert Rx callback as head of list")
> > Cc: bruce.richardson@intel.com
> > Cc: john.mcnamara@intel.com
> > Cc: reshma.pattan@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>
>
> +Konstantin & Jerin,
>
> Can you please help reviewing this one too?
>
> @Honnappa,
>
> Is this patch supersedes the following one in the queue by ZY Qiu:
> https://patches.dpdk.org/patch/66301/
Yes, my patch should supersede. I will create a V2 to address the issue ZY Qiu's patch is trying to address.
next prev parent reply other threads:[~2020-10-13 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201002000711.41511-1-honnappa.nagarahalli@arm.com>
2020-10-02 0:07 ` Honnappa Nagarahalli
2020-10-09 2:34 ` Phil Yang
2020-10-13 10:32 ` Ferruh Yigit
2020-10-13 15:25 ` Honnappa Nagarahalli [this message]
2020-10-13 14:25 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
[not found] ` <20201013162537.24029-1-honnappa.nagarahalli@arm.com>
2020-10-13 16:25 ` [dpdk-stable] [PATCH v2 " Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB58143A563D343F4A11C202D998040@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Phil.Yang@arm.com \
--cc=abhinandan.gujjar@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=tgw_team@tencent.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).