From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Feifei Wang <Feifei.Wang2@arm.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Gavin Hu <Gavin.Hu@arm.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Feifei Wang <Feifei.Wang2@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v2 2/4] test/ring: fix wrong size used in memcmp
Date: Wed, 26 Aug 2020 20:51:41 +0000 [thread overview]
Message-ID: <DBAPR08MB581461B099C64077C79BA13E98540@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200805061421.13037-3-feifei.wang2@arm.com>
<snip>
>
> When using memcmp function to check data, the third param should be the
> size of all elements, rather than the number of the elements.
>
> Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests")
> Cc: honnappa.nagarahalli@arm.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> app/test/test_ring.c | 31 +++++++++++++++++++++----------
> 1 file changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/app/test/test_ring.c b/app/test/test_ring.c index
> 0ae97d341..c508a13a9 100644
> --- a/app/test/test_ring.c
> +++ b/app/test/test_ring.c
> @@ -444,7 +444,12 @@ test_ring_burst_bulk_tests1(unsigned int test_idx)
> TEST_RING_VERIFY(rte_ring_empty(r));
>
> /* check data */
> - TEST_RING_VERIFY(memcmp(src, dst, rsz) == 0);
> + if (esize[i] == -1) {
> + TEST_RING_VERIFY(memcmp(src, dst,
> + rsz * sizeof(void *)) == 0);
> + } else
> + TEST_RING_VERIFY(memcmp(src, dst,
> + rsz * esize[i]) == 0);
Can you implement a function similar to 'test_ring_mem_init' to do this comparison?
> }
>
> /* Free memory before test completed */ @@ -538,9 +543,11
> @@ test_ring_burst_bulk_tests2(unsigned int test_idx)
> cur_dst = test_ring_inc_ptr(cur_dst, esize[i], MAX_BULK);
>
> /* check data */
> - if (memcmp(src, dst, cur_dst - dst)) {
> - rte_hexdump(stdout, "src", src, cur_src - src);
> - rte_hexdump(stdout, "dst", dst, cur_dst - dst);
> + if (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {
> + rte_hexdump(stdout, "src", src,
> + RTE_PTR_DIFF(cur_src, src));
> + rte_hexdump(stdout, "dst", dst,
> + RTE_PTR_DIFF(cur_dst, dst));
I do not think, this change and the rest below are bug fixes. Can you please separate them into another commit?
> printf("data after dequeue is not the same\n");
> goto fail;
> }
> @@ -614,9 +621,11 @@ test_ring_burst_bulk_tests3(unsigned int test_idx)
> }
>
> /* check data */
> - if (memcmp(src, dst, cur_dst - dst)) {
> - rte_hexdump(stdout, "src", src, cur_src - src);
> - rte_hexdump(stdout, "dst", dst, cur_dst - dst);
> + if (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {
> + rte_hexdump(stdout, "src", src,
> + RTE_PTR_DIFF(cur_src, src));
> + rte_hexdump(stdout, "dst", dst,
> + RTE_PTR_DIFF(cur_dst, dst));
> printf("data after dequeue is not the same\n");
> goto fail;
> }
> @@ -747,9 +756,11 @@ test_ring_burst_bulk_tests4(unsigned int test_idx)
> goto fail;
>
> /* check data */
> - if (memcmp(src, dst, cur_dst - dst)) {
> - rte_hexdump(stdout, "src", src, cur_src - src);
> - rte_hexdump(stdout, "dst", dst, cur_dst - dst);
> + if (memcmp(src, dst, RTE_PTR_DIFF(cur_dst, dst))) {
> + rte_hexdump(stdout, "src", src,
> + RTE_PTR_DIFF(cur_src, src));
> + rte_hexdump(stdout, "dst", dst,
> + RTE_PTR_DIFF(cur_dst, dst));
> printf("data after dequeue is not the same\n");
> goto fail;
> }
> --
> 2.17.1
next prev parent reply other threads:[~2020-08-26 20:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200729063105.11299-1-feifei.wang2@arm.com>
2020-07-29 6:31 ` [dpdk-stable] [PATCH v1 1/2] ring: fix the misdescription of the param Feifei Wang
2020-07-29 15:59 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 16:24 ` Ananyev, Konstantin
2020-07-29 19:34 ` Honnappa Nagarahalli
2020-07-30 10:16 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-31 5:26 ` [dpdk-stable] " Honnappa Nagarahalli
2020-07-29 6:31 ` [dpdk-stable] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs Feifei Wang
2020-07-29 13:48 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 14:16 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-29 14:21 ` [dpdk-stable] " David Marchand
2020-07-29 15:03 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-29 21:24 ` [dpdk-stable] " Honnappa Nagarahalli
2020-07-30 10:28 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-31 6:25 ` Feifei Wang
[not found] ` <20200805061421.13037-1-feifei.wang2@arm.com>
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 1/4] test/ring: fix wrong parameter " Feifei Wang
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 2/4] test/ring: fix wrong size used in memcmp Feifei Wang
2020-08-26 20:51 ` Honnappa Nagarahalli [this message]
2020-08-27 9:05 ` [dpdk-stable] 回复: " Feifei Wang
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 3/4] test/ring: fix the wrong number of enq/deq elements Feifei Wang
2020-08-26 20:51 ` Honnappa Nagarahalli
2020-08-27 8:54 ` [dpdk-stable] 回复: " Feifei Wang
[not found] ` <20200911161002.19816-1-feifei.wang2@arm.com>
2020-09-11 16:09 ` [dpdk-stable] [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-14 4:28 ` Honnappa Nagarahalli
2020-09-11 16:10 ` [dpdk-stable] [PATCH v3 4/6] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-14 4:31 ` Honnappa Nagarahalli
2020-09-11 16:10 ` [dpdk-stable] [PATCH v3 5/6] test/ring: fix wrong size used in memcmp Feifei Wang
2020-09-14 4:37 ` Honnappa Nagarahalli
2020-09-14 9:20 ` David Marchand
[not found] ` <20200914143350.18650-1-feifei.wang2@arm.com>
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 2/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 4/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 5/7] test/ring: fix wrong size used in memcmp Feifei Wang
[not found] ` <20200915062749.21374-1-feifei.wang2@arm.com>
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 1/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 2/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 3/7] test/ring: fix wrong size used in memcmp Feifei Wang
[not found] ` <20200920114856.20697-1-feifei.wang2@arm.com>
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 1/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 2/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 3/7] test/ring: fix wrong size used in memcmp Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB581461B099C64077C79BA13E98540@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Feifei.Wang2@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).