Re: [dpdk-stable] [19.11] [PATCH 1/1] config: add Graviton2(arm64) defconfig

[Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>]

<snip>

> 
> On 10/7/20 2:18 AM, Luca Boccassi wrote:
> >
> > On Tue, 2020-10-06 at 11:44 -0700, Vimal Chungath wrote:
> >> On 10/6/20 1:12 AM, Luca Boccassi wrote:
> >>>
> >>> On Mon, 2020-10-05 at 11:50 -0700, Vimal Chungath wrote:
> >>>> This patch adds make build configuration for AWS Graviton2 platform
> >>>> based on ARM Neoverse N1. Meson build works but uses configuration
> >>>> for
> >>>> N1 SDP that is not optimal. Rework in meson build system for ARM
> >>>> SoCs is planned so I have chosen not to add meson configuration for
> >>>> this
> >>>> 19.11 patch.
> >>>>
> >>>> Vimal Chungath (1):
> >>>>   config: add Graviton2(arm64) defconfig
> >>>>
> >>>>  config/defconfig_arm64-graviton2-linux-gcc    |  1 +
> >>>>  config/defconfig_arm64-graviton2-linuxapp-gcc | 13 +++++++++++
> >>>>  config/defconfig_graviton2                    |  1 +
> >>>>  mk/machine/graviton2/rte.vars.mk              | 33
> +++++++++++++++++++++++++++
> >>>>  4 files changed, 48 insertions(+)
> >>>>  create mode 120000 config/defconfig_arm64-graviton2-linux-gcc
> >>>>  create mode 100644 config/defconfig_arm64-graviton2-linuxapp-gcc
> >>>>  create mode 120000 config/defconfig_graviton2  create mode 100644
> >>>> mk/machine/graviton2/rte.vars.mk
> >>>
> >>> Hi,
> >>>
> >>> Is this adding support for a new driver for 19.11? I don't see it in
> >>> the main branch?
> >>
> >> Hi Luca,
> >>
> >> This patch is adding optimal build flags for Graviton2 SoC.
> >> No new driver is being added. Main branch is no longer accepting make
> >> build patches as it is deprecated. For 19.11, I assume make is still the
> default.
> >>
> >> This is the meson patch in review for main branch:
> >> https://patches.dpdk.org/patch/76981/
> >>
> >> Regards,
> >> Vimal
> >
> > I see - normally we are careful with new feature/support in LTS
> > branches, but this seems self-contained enough to be very low risk so
> > it seems acceptable to me. But Meson is fully supported, so please
> > update the patchset so that it applies to both build systems.
> 
> Meson build works as Neoverse N1 configuration already exists so I chose to
> not add an explicit patch for it.
> Unfortunately, getting meson to choose the same flags as make is currently
> not possible as meson does not accept choosing the exact Arm SoC. More
> details in the patchwork link above.
> Meson rework is being planned on main branch to bridge this gap but I'm not
> sure if it will be backported to 19.11.
> Honnappa, let us know what you think?
I would like to backport the Arm related changes to meson build. If for any reason, we cannot backport, I am ok to change the N1 configuration to support Graviton2 for stable releases.

> 
> >
> > --
> > Kind regards,
> > Luca Boccassi