From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
Phil Yang <Phil.Yang@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Gavin Hu <Gavin.Hu@arm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>,
Joyce Kong <Joyce.Kong@arm.com>, nd <nd@arm.com>,
"Stable@dpdk.org" <Stable@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v3 08/12] service: remove redundant code
Date: Sun, 5 Apr 2020 18:35:04 +0000 [thread overview]
Message-ID: <DBBPR08MB4646D2CAE03861DDF706EAB698C50@DBBPR08MB4646.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB3143191EBB61DDEAF5991F03D7C70@BYAPR11MB3143.namprd11.prod.outlook.com>
<snip>
> >
> > The service id validation is verified in the calling function, remove
> > the redundant code inside the service_update function.
> >
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Cc: Stable@dpdk.org
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>
>
> Same comment as patch 7/12, is this really a "Fix"? This functionality is not
> "broken" in the current code? And is there value in porting to stable? I'd see
> this as unnecessary churn.
>
> As before, it is a valid cleanup (thanks), and I'd like to take it for new DPDK
> releases.
>
> Happy to Ack without Fixes or Cc Stable, if that's acceptable to you?
Agreed.
>
>
>
> > ---
> > lib/librte_eal/common/rte_service.c | 31
> > ++++++++++++-------------------
> > 1 file changed, 12 insertions(+), 19 deletions(-)
> >
> > diff --git a/lib/librte_eal/common/rte_service.c
> > b/lib/librte_eal/common/rte_service.c
> > index 2117726..557b5a9 100644
> > --- a/lib/librte_eal/common/rte_service.c
> > +++ b/lib/librte_eal/common/rte_service.c
> > @@ -552,21 +552,10 @@ rte_service_start_with_defaults(void)
> > }
> >
> > static int32_t
> > -service_update(struct rte_service_spec *service, uint32_t lcore,
> > +service_update(uint32_t sid, uint32_t lcore,
> > uint32_t *set, uint32_t *enabled)
'set' parameter does not need be passed by reference, pass by value is enough.
> > {
> > - uint32_t i;
> > - int32_t sid = -1;
> > -
> > - for (i = 0; i < RTE_SERVICE_NUM_MAX; i++) {
> > - if ((struct rte_service_spec *)&rte_services[i] == service &&
> > - service_valid(i)) {
> > - sid = i;
> > - break;
> > - }
> > - }
> > -
> > - if (sid == -1 || lcore >= RTE_MAX_LCORE)
> > + if (lcore >= RTE_MAX_LCORE)
> > return -EINVAL;
The validations look somewhat inconsistent in service_update function, we are validating some parameters and not some.
Suggest bringing the validation of the service id also into this function and remove it from the calling functions.
> >
> > if (!lcore_states[lcore].is_service_core)
> > @@ -598,19 +587,23 @@ service_update(struct rte_service_spec *service,
> > uint32_t lcore, int32_t rte_service_map_lcore_set(uint32_t id,
> > uint32_t lcore, uint32_t enabled) {
> > - struct rte_service_spec_impl *s;
> > - SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);
> > + /* validate ID, or return error value */
> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
> > + return -EINVAL;
> > +
> > uint32_t on = enabled > 0;
We do not need the above line. 'enabled' can be passed directly to 'service_update'.
> > - return service_update(&s->spec, lcore, &on, 0);
> > + return service_update(id, lcore, &on, 0);
> > }
> >
> > int32_t
> > rte_service_map_lcore_get(uint32_t id, uint32_t lcore) {
> > - struct rte_service_spec_impl *s;
> > - SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);
> > + /* validate ID, or return error value */
> > + if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
> > + return -EINVAL;
> > +
> > uint32_t enabled;
> > - int ret = service_update(&s->spec, lcore, 0, &enabled);
> > + int ret = service_update(id, lcore, 0, &enabled);
> > if (ret == 0)
> > return enabled;
> > return ret;
> > --
> > 2.7.4
next prev parent reply other threads:[~2020-04-05 18:35 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1583862551-2049-1-git-send-email-phil.yang@arm.com>
2020-03-10 17:49 ` [dpdk-stable] [PATCH 05/10] service: remove rte prefix from static functions Phil Yang
2020-03-10 17:49 ` [dpdk-stable] [PATCH 06/10] service: remove redundant code Phil Yang
2020-03-10 17:49 ` [dpdk-stable] [PATCH 07/10] service: avoid race condition for MT unsafe service Phil Yang
2020-03-10 17:49 ` [dpdk-stable] [PATCH 08/10] service: identify service running on another core correctly Phil Yang
[not found] ` <1583993624-20446-1-git-send-email-phil.yang@arm.com>
2020-03-12 6:13 ` [dpdk-stable] [PATCH v2 05/10] service: remove rte prefix from static functions Phil Yang
2020-03-12 6:13 ` [dpdk-stable] [PATCH v2 06/10] service: remove redundant code Phil Yang
2020-03-12 6:13 ` [dpdk-stable] [PATCH v2 07/10] service: avoid race condition for MT unsafe service Phil Yang
2020-03-12 6:13 ` [dpdk-stable] [PATCH v2 08/10] service: identify service running on another core correctly Phil Yang
[not found] ` <1583999071-22872-1-git-send-email-phil.yang@arm.com>
2020-03-12 7:44 ` [dpdk-stable] [PATCH v2 05/10] service: remove rte prefix from static functions Phil Yang
2020-03-12 7:44 ` [dpdk-stable] [PATCH v2 06/10] service: remove redundant code Phil Yang
2020-03-12 7:44 ` [dpdk-stable] [PATCH v2 07/10] service: avoid race condition for MT unsafe service Phil Yang
2020-03-12 7:44 ` [dpdk-stable] [PATCH v2 08/10] service: identify service running on another core correctly Phil Yang
[not found] ` <1584407863-774-1-git-send-email-phil.yang@arm.com>
2020-03-17 1:17 ` [dpdk-stable] [PATCH v3 07/12] service: remove rte prefix from static functions Phil Yang
2020-04-03 11:57 ` Van Haaren, Harry
2020-04-08 10:14 ` Phil Yang
2020-04-08 10:36 ` Van Haaren, Harry
2020-04-08 10:49 ` Phil Yang
2020-04-05 21:35 ` Honnappa Nagarahalli
2020-04-08 10:14 ` Phil Yang
[not found] ` <1587659482-27133-1-git-send-email-phil.yang@arm.com>
2020-04-23 16:31 ` [dpdk-stable] [PATCH v2 1/6] service: fix race condition for MT unsafe service Phil Yang
2020-04-29 16:51 ` Van Haaren, Harry
2020-04-29 22:48 ` Honnappa Nagarahalli
2020-05-01 14:21 ` Van Haaren, Harry
2020-05-01 14:56 ` Honnappa Nagarahalli
2020-05-01 17:51 ` Van Haaren, Harry
2020-04-23 16:31 ` [dpdk-stable] [PATCH v2 2/6] service: identify service running on another core correctly Phil Yang
[not found] ` <20200502000245.11071-1-honnappa.nagarahalli@arm.com>
2020-05-02 0:02 ` [dpdk-stable] [PATCH v3 1/6] service: fix race condition for MT unsafe service Honnappa Nagarahalli
2020-05-05 14:48 ` Van Haaren, Harry
2020-05-02 0:02 ` [dpdk-stable] [PATCH v3 2/6] service: identify service running on another core correctly Honnappa Nagarahalli
2020-05-05 14:48 ` Van Haaren, Harry
[not found] ` <20200505211732.25291-1-honnappa.nagarahalli@arm.com>
2020-05-05 21:17 ` [dpdk-stable] [PATCH v4 1/6] service: fix race condition for MT unsafe service Honnappa Nagarahalli
2020-05-05 21:17 ` [dpdk-stable] [PATCH v4 2/6] service: fix identification of service running on other lcore Honnappa Nagarahalli
[not found] ` <1588760683-11027-1-git-send-email-phil.yang@arm.com>
2020-05-06 10:24 ` [dpdk-stable] [PATCH v5 1/6] service: fix race condition for MT unsafe service Phil Yang
2020-05-06 10:24 ` [dpdk-stable] [PATCH v5 2/6] service: fix identification of service running on other lcore Phil Yang
[not found] ` <1588778884-13047-1-git-send-email-phil.yang@arm.com>
2020-05-06 15:27 ` [dpdk-stable] [PATCH v6 1/6] service: fix race condition for MT unsafe service Phil Yang
2020-05-06 15:28 ` [dpdk-stable] [PATCH v6 2/6] service: fix identification of service running on other lcore Phil Yang
2020-03-17 1:17 ` [dpdk-stable] [PATCH v3 08/12] service: remove redundant code Phil Yang
2020-04-03 11:58 ` Van Haaren, Harry
2020-04-05 18:35 ` Honnappa Nagarahalli [this message]
2020-04-08 10:15 ` Phil Yang
2020-03-17 1:17 ` [dpdk-stable] [PATCH v3 09/12] service: avoid race condition for MT unsafe service Phil Yang
2020-04-03 11:58 ` Van Haaren, Harry
2020-04-04 18:03 ` Honnappa Nagarahalli
2020-04-08 18:05 ` Van Haaren, Harry
2020-04-09 1:31 ` Honnappa Nagarahalli
2020-04-09 16:46 ` Van Haaren, Harry
2020-04-18 6:21 ` Honnappa Nagarahalli
2020-04-21 17:43 ` Van Haaren, Harry
2020-03-17 1:17 ` [dpdk-stable] [PATCH v3 10/12] service: identify service running on another core correctly Phil Yang
2020-04-03 11:58 ` Van Haaren, Harry
2020-04-05 2:43 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBBPR08MB4646D2CAE03861DDF706EAB698C50@DBBPR08MB4646.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=Stable@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).