From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5471E48ACF for ; Wed, 19 Nov 2025 15:42:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26F1840267; Wed, 19 Nov 2025 15:42:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4569940262 for ; Wed, 19 Nov 2025 15:42:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763563364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=blSweLmLEC50GPF4V700MwSYM5ZXGBhUa8g4RsrAHcE=; b=cvi1hXpG6Lnayo7Csvpc38FxW2ktExb17uiBmfU1lhC2YsjSD2TH4ME/NtRecb1XS1nmaR Xq2YfpnMfTL57p1sJyiNZNl2iTdGdWN5XOI49CF10yw+QuOQHBNVahDx48LUpBWeAf+hSw WITZ9M5SkN6rh24NHOmT1nUEZF8+Li8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-u-eEo6jPOBS-qJ1IQvQdKw-1; Wed, 19 Nov 2025 09:42:43 -0500 X-MC-Unique: u-eEo6jPOBS-qJ1IQvQdKw-1 X-Mimecast-MFC-AGG-ID: u-eEo6jPOBS-qJ1IQvQdKw_1763563362 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477a11d9e67so26367375e9.2 for ; Wed, 19 Nov 2025 06:42:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763563362; x=1764168162; h=in-reply-to:references:user-agent:subject:to:from:cc:message-id :date:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=blSweLmLEC50GPF4V700MwSYM5ZXGBhUa8g4RsrAHcE=; b=ogf0ls5O+YuoZfy4OcMdBoHxrWJEUEzOh899BMM0/9shHD+L8FqZ8QjAnjWGI4hsOm ZEhbtUX8RASMldjYOYdG3sVrng6TRM7+TqWuRFTaGPOLNwc/NwyW61zeuu+4ROf5rkLX 4jaHmerAIHHJfRQWkghPJ3pnfOPqwnHBNEW88aGKpzn0YwEc06L4GCsWkYaOP0zZMzU2 LaJzmNvv7qcOGzp977Eghi7vD/t8/pgCrcSveAami0fZjorpN9yf9/T6II6d94zaMR09 qh+fkFFbYMc6lwp0oTXghXMhPPCLEUKcBcKj+au5vaAy1SeRriqLw2r6KONorAxKWijA ouww== X-Forwarded-Encrypted: i=1; AJvYcCVDasVILWaX6tGo1AphgmlmgIDk1y5yv59F331PgI5DDD0lYCBTEEw6oJUmD+7OT5dSUsNFBoo=@dpdk.org X-Gm-Message-State: AOJu0YwmFwN1pjkHzlmg1yxQvM1Iw+TrQsuTEzoiAsu4wn/PvbGB3WHx TMNAwHhnZjUP1qFLPi5C33dzWzbYeERxyUw8Q5SOtwdmGvzfltMVXO9cHBba5k0LU2u0wa6NsVA ttCpr14Nri/p8XvVRVWr3+Mulk0p5iXvWmcH+gE7r/TWhXtl2 X-Gm-Gg: ASbGnctcSUSt3oRdkRWRldeD4LsnqND6UQ5ZPZGi4BMJ+j/HQlrYgZZlUR+t6rS4Kh6 2HS/U3M3DosIHZ0vrq8crUc6px6tapkS7sFEO6/72oPk/Msm1okMUhyNBjH2rvL6A1HaKrwGXG+ x4h/iJkdXZQ8BMSIzNCtYeLw9Zh3X8NAHuqVoFXoKFMVIJ6b5Tdr9uitgeR9VvJLbiPP5/fLACO Z2TNcKVzw5MORlezN9PnngMQDcGcSqEbghrQ1dENLTEvA1ctNXASCw5zOCsyqtwPSLmXT+fFQFe gnSMPPTbFu5ucwbHuCq84doXjlGc2hg4UUlNmQuB2tq8823sCFVZskp1eslhY9rMsNLr7Dz+VZC ht+QnL8g5wd3gM0Tnjqu/wV6DM9kEYsPrtrUs5pm0mlJnVQlNTATtbn3stqjmP18qbCGi X-Received: by 2002:a05:600c:4f07:b0:477:63b5:6f3a with SMTP id 5b1f17b1804b1-4778fead9a4mr191839645e9.27.1763563362110; Wed, 19 Nov 2025 06:42:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7YipzOw7j2+Oxh6zu9NJAvOkx95S7VVbmIlSfWU3zxg00wNBqVjbDs+R2c5daxIWzqCpv2A== X-Received: by 2002:a05:600c:4f07:b0:477:63b5:6f3a with SMTP id 5b1f17b1804b1-4778fead9a4mr191839305e9.27.1763563361650; Wed, 19 Nov 2025 06:42:41 -0800 (PST) Received: from localhost (2a01cb00021ec000b06e6b63494bd4c5.ipv6.abo.wanadoo.fr. [2a01:cb00:21e:c000:b06e:6b63:494b:d4c5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b1035c78sm51807145e9.11.2025.11.19.06.42.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 06:42:41 -0800 (PST) Mime-Version: 1.0 Date: Wed, 19 Nov 2025 15:42:40 +0100 Message-Id: Cc: "Stephen Hemminger" , , From: "Robin Jarry" To: "Thomas Monjalon" , "Christophe Fontaine" Subject: Re: [PATCH dpdk v2] net: ipv6 link local compliance with rfc 4291 User-Agent: aerc/0.21.0-33-gc811101f9a96 References: <20251114105751.54802-3-rjarry@redhat.com> <20251118174526.321856-1-rjarry@redhat.com> <3249247.iZASKD2KPV@thomas> <4832942.kQq0lBPeGt@thomas> In-Reply-To: <4832942.kQq0lBPeGt@thomas> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rANxtQWnOSrqIdygn1kuakD_2WC1ffnNhn4PfjGJhQ8_1763563362 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Thomas Monjalon, Nov 19, 2025 at 01:27: > After checking with Stephen, it appears that XOR is really desired. > This bit must be inverted, so 0 is local and 1 is universal. > > Adding this comment in the code to avoid confusion in future: > /* > * The "u" bit (universal/local bit in IEEE EUI-64 terminology) > * must be inverted for IPv6 link local address. > * 0 means local scope, 1 means universal scope. > */ > > Applied, thanks. Thanks Thomas. That XOR is described in the RFCs as "flipping the 'u' bit". I.e. the bit should be 1 if the address is "global/universal" and 0 if the address is "local/administratively configured". Here's the corresponding code in Linux and BSD: https://github.com/torvalds/linux/blob/v6.17/include/net/addrconf.h#L201 https://github.com/freebsd/freebsd-src/blob/release/14.3.0/sys/netinet6/in6= _ifattach.c#L97 --=20 Robin > No animals were injured.