From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4 1/2] app/testpmd: update forward engine beginning
Date: Wed, 22 Sep 2021 05:59:17 +0000 [thread overview]
Message-ID: <DM4PR11MB55347BFA12B9B8B4C9B6DDF799A29@DM4PR11MB5534.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210922024952.11848-1-alvinx.zhang@intel.com>
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Wednesday, September 22, 2021 10:50
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v4 1/2] app/testpmd: update forward engine beginning
>
> For each forward engine, there may be some special conditions must be met
> before the forwarding runs.
>
> Adding checks for these conditions in configuring is not suitable, because one
> condition may rely on multiple configurations, and the conditions required by
> each forward engine is not general.
>
> The best solution is each forward engine has a callback to check whether these
> conditions are met, and then testpmd can call the callback to determine whether
> the forwarding can be started.
>
> There was a void callback 'port_fwd_begin' in forward engine, it did some
> initialization for forwarding, this patch updates its return value then we can add
> some checks in it to confirm whether the forwarding can be started. In addition,
> this patch calls the callback before the forwarding stats is reset and then
> launches the forwarding engine.
>
> Bugzilla ID: 797
> Cc: stable@dpdk.org
Not sure if you should add the same fixline as patch 2
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Except that, Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
next prev parent reply other threads:[~2021-09-22 5:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 8:20 [dpdk-stable] [PATCH] app/testpmd: fix random number of Tx segments Alvin Zhang
2021-09-06 8:58 ` Li, Xiaoyun
2021-09-06 10:03 ` Zhang, AlvinX
2021-09-06 10:54 ` Li, Xiaoyun
2021-09-07 2:25 ` Zhang, AlvinX
2021-09-07 8:05 ` Li, Xiaoyun
[not found] ` <20210917013923.4004-1-alvinx.zhang@intel.com>
2021-09-17 1:39 ` [dpdk-stable] [PATCH v2 2/2] app/testpmd: fix txonly forwording Alvin Zhang
[not found] ` <20210918030659.12448-1-alvinx.zhang@intel.com>
2021-09-18 3:06 ` [dpdk-stable] [PATCH v3 " Alvin Zhang
2021-09-18 8:20 ` Li, Xiaoyun
2021-09-22 2:49 ` [dpdk-stable] [PATCH v4 1/2] app/testpmd: update forward engine beginning Alvin Zhang
2021-09-22 2:49 ` [dpdk-stable] [PATCH v4 2/2] app/testpmd: fix txonly forwording Alvin Zhang
2021-09-22 5:58 ` Li, Xiaoyun
2021-09-22 5:59 ` Li, Xiaoyun [this message]
2021-09-23 1:49 ` [dpdk-stable] [PATCH v5 1/2] app/testpmd: update forward engine beginning Alvin Zhang
2021-09-23 1:49 ` [dpdk-stable] [PATCH v5 2/2] app/testpmd: fix txonly forwording Alvin Zhang
2021-09-23 4:25 ` Ivan Malov
2021-09-23 5:11 ` Zhang, AlvinX
2021-09-23 8:01 ` [dpdk-stable] [PATCH v6 1/2] app/testpmd: update forward engine beginning Alvin Zhang
2021-09-23 8:01 ` [dpdk-stable] [PATCH v6 2/2] app/testpmd: fix txonly forwarding Alvin Zhang
2021-10-08 17:01 ` [dpdk-stable] [PATCH v6 1/2] app/testpmd: update forward engine beginning Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB55347BFA12B9B8B4C9B6DDF799A29@DM4PR11MB5534.namprd11.prod.outlook.com \
--to=xiaoyun.li@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).