From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF948A0C45 for <public@inbox.dpdk.org>; Wed, 22 Sep 2021 07:59:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 916B04118A; Wed, 22 Sep 2021 07:59:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 590F84003C; Wed, 22 Sep 2021 07:59:20 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="221635180" X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="221635180" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 22:59:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,312,1624345200"; d="scan'208";a="585269555" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 21 Sep 2021 22:59:19 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 21 Sep 2021 22:59:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 21 Sep 2021 22:59:18 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 21 Sep 2021 22:59:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpqsS2/cPIbt3qshWo64P+GvAifLJl74h8D+Uag49WOnAL7xKYMjtZyLxOtnKBCfvmBWcNg4wYowsEaazJRyG5jSHFI/g0xyVI93s5aG9xO53JJiF3fZePNN1X66pSu/8rwP9si02eYgmbWZMXm10Waz479SToi9AtgNWG3w18ZmnOK6D8q8GCUAPcQvikXYR882paxozrcdaCtOGFjo0K+7Klt8hQmWTPj5yGqbtiIuQBoWoz9T11BzqSts6yWt1RsyFHdvLUxpjxnEOdpQVZrQ48O6vFWAasdvPpA8Ji8JFv/EbTKK6H+9mQHAvKw1X8jql23SZ7AWOzTqWugrUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=frpJzIvSeNK0fgsW2LGFXa58Rkrms6EzNMhHQg8XXrk=; b=D7Dw5MNCz14gdAL5jwM6Q03PIVhMmHgde+xj4LghMsJ/RaMC8vTgw8ptNShiLg0dvCKhF/JnFpZFV1OC7keUiwVUl62+3e8yBbPGZ11XDCrD1i7DE7z56V+kvAeYrcS4JrZmkNk7UmbpvsuAV/00Iuwd3GvES743djsWzqLnktoP73A/LsXDU/pPg5vXLXwtDJBJUWHL95kBuSehlMLR+7HNNWd0sfBUpVYt9kOgOwIiGqfeaVh6D3JuzxZXzG9yBCh8ayuQDwOCCcpHwmD6OR/AqNQLGX4mF4N8RsoysWnMuwOyOuEXoO/fAUFZ5yvQxHUkTjDAa3qdNJPyNCYcPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=frpJzIvSeNK0fgsW2LGFXa58Rkrms6EzNMhHQg8XXrk=; b=fRPluF/POS78y/hgoo6mb1IH8W4JXqbYAXyiJXmaN1KF9Mj6PYbykSxoHBcwkLuULMwFqLaVvFexfvCGRv5wsvy9dELPHJzDidFpzCtsJ/fDmLmmsg9TR/8bZwd+BZbhmKKZDvIqbkVkuEwdE5OhRMSA5tLKGiUVcJPIG+5BZYQ= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB3465.namprd11.prod.outlook.com (2603:10b6:5:b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Wed, 22 Sep 2021 05:59:17 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::3d9b:76d7:e274:bad3]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::3d9b:76d7:e274:bad3%3]) with mapi id 15.20.4523.020; Wed, 22 Sep 2021 05:59:17 +0000 From: "Li, Xiaoyun" <xiaoyun.li@intel.com> To: "Zhang, AlvinX" <alvinx.zhang@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH v4 1/2] app/testpmd: update forward engine beginning Thread-Index: AQHXr1yNaPI5qdb9UEi9r6kPMSXkTquvjvGQ Date: Wed, 22 Sep 2021 05:59:17 +0000 Message-ID: <DM4PR11MB55347BFA12B9B8B4C9B6DDF799A29@DM4PR11MB5534.namprd11.prod.outlook.com> References: <20210918030659.12448-1-alvinx.zhang@intel.com> <20210922024952.11848-1-alvinx.zhang@intel.com> In-Reply-To: <20210922024952.11848-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2802b80a-3b40-4427-5618-08d97d8e1d0f x-ms-traffictypediagnostic: DM6PR11MB3465: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <DM6PR11MB346557D87B9D0938CBBF72D799A29@DM6PR11MB3465.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ky9ycz0VnrmcoikEr7Cebrk7DkJBCeXWfT7Z/Vm5t/9jFPbNR51Z+hz6kwnY4hmaErLtg+5XtfEiNpKCKDcKcYKccYRT89FRrwyDlisizC0RvaptlJfAbHbJoNY5KyOVoOm571LMR0MOsm+LM8MSAXRGNl9O1QSAXY+S1ywdSloSHAgFh4EM7uzVD27izYJye5uDaMfe/q3XrgsbimZhe0jJDTlMt7e+oXgCa2gwFeeDKfoKQTewOm0X2DVg4ano8lG4YAN/MF94RmYhHxfHWM3k5JIi0ez+0IV8t8zKVJWt0myZpUHIp2/vRrmv8erDsO3w1rY9HT8aiG8D21MJ9Ad/qjnUB2+NIzMUfKZHfh9lQE58X1Il5N8pBgJfk8wFeAih3xc/KCPcOwvkLWqqXJUdbVYk/lh3SGwhyUK+uZv3NLXcY7raj89778OT4EKgxGaKLS1XaYhoTdtMyafLgKRBE6lByxZQC9f8COJ7z+khBtOBg+CGFfkwuwOpF/7MtDjqfFjAIShfPxC54Hur7E0Qeb9f0VnVyx9rxhfOSM6Fy2rHwcpOeSYzAdD4Qtm9lgkk6SzOa/Nco4anLDWyqmeBNpBHOCj76tfDtyLWyvRff7RyG69NGaHxFYDZ+28vjv+mJvlxMhHCYDIoXYhe9lQpsmAJ52pyIBYoARSFrl8MjfYlM45c+LpqK5t5mljI+YV3WQpQyTQXZ1eBMb8sIw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(5660300002)(508600001)(83380400001)(33656002)(7696005)(53546011)(9686003)(55016002)(316002)(6506007)(71200400001)(15650500001)(2906002)(54906003)(6636002)(8676002)(52536014)(38100700002)(4326008)(450100002)(122000001)(186003)(26005)(66946007)(66476007)(76116006)(8936002)(64756008)(66556008)(38070700005)(66446008)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PpqNB1dTgw8AjIYSeLupr3ubLcMzfwootjg+E38Y+ZLWaPSzKckJA0jMoJ94?= =?us-ascii?Q?kiheeW+6tlwyXid/4yC8+uaGAHa9LNPZ5wjJ55eiTJLsVQWaBGS30TXYfIYU?= =?us-ascii?Q?Bh3HDLEeOK1xhDkfw9Nm8fN3bOwZa6COvzr8S7irHKNAVxCChw5Uv7zYv+uq?= =?us-ascii?Q?44rLKS6BDiu6iK/mk/X7amdVDCRirnpeeTHy392QfYCWGURW2BlgAHG1Ek2b?= =?us-ascii?Q?hmo7AYtuHJ/E/paYQg6odkhx4zGOveZlsmJNmScphdm+IKFiXFW79oBjZ3It?= =?us-ascii?Q?wLZGsMYfS81sPCWXbkeFHVlI7GkYb5Z8PImLcZCSLLxnYh0kMWiy20u9hc02?= =?us-ascii?Q?mEJzaS306Op3dDj8obx5FGM5l8w7J4Rl9c+3iqrn4dsShbzY4C64ClCxN0lU?= =?us-ascii?Q?OYfei6SV4aQHh02u25/bQlGD7jTgt3z2QhOG7j/j58A5b/q78GujQAmQ3Ovz?= =?us-ascii?Q?WkpSNl4aGDcVwTZPmkOvMoB7h58gaqx53trtEymYC9xfaF40GTluLMAPxa6V?= =?us-ascii?Q?UxZMWt41zl/Gri2TC1deKvTqvLxAF5BDNPtoUic1ZP5Ddqp7YlX1dlj/7qmU?= =?us-ascii?Q?qv0a3jUKJM5fiOD9QnZAXINkcLnuRjrKX8Ptp3kwa1E65BRbap3yAVXbqnxC?= =?us-ascii?Q?wm1i0GmXTgMpp0WDFOvjPyKSJljEflf2lXFKTtR6XGqoFd0oJwBWhM8MoYgf?= =?us-ascii?Q?h5cCnz5xW8WThVxHDii2iTCb8u6FPsdV3xPHFHDUe39DAZ5HFgR4glAp7d9X?= =?us-ascii?Q?Mbr8rAay1Mx1p89qRJkowIUKf4SxoIT1IOUz7/wnRstDKzIYt8YIHF9lLyyg?= =?us-ascii?Q?IDArE8EUr3FnGpYJ/CJr9cDMdKeB0WepcsSW/EgV/u0QcOUspet6Yi90vP1j?= =?us-ascii?Q?yhNFcJCcFRy6wz/yZfS60aNNSWLJwCdU0qDzqim9NOohcmyFiW0jBtBsogO5?= =?us-ascii?Q?o34Xlv8HxrhE/EYqLxQ5fMMYU9Gu52kSLJn9lrOvGwOFo9UnrYY3oCkinF/b?= =?us-ascii?Q?mCnO3iD0A9cw7ZfzGSEXOeH7TWXq1DQ823fWztwKRGwrLasTt+/azWK2NZ7G?= =?us-ascii?Q?wcedo2cSpVHuTK5O6l43hooeFf/3PKFavElKOAUFtDiA06mJkqeey0WDMGF0?= =?us-ascii?Q?twOXHccL93xNK/55J12JfENxXJjQ01ftaP9EfkdY3MUmNV1JUg8bJ6bqrTbU?= =?us-ascii?Q?DLRW60FaeR9zGF3ZDSOjQjncxDXQp8fQq0FoejwV+kRTK3H57bdbZA99peUW?= =?us-ascii?Q?5wI3B2hX2WRZ0hmgwUPhHLtlVBphFE//bcNngiBNocpthe2q4v+PhfI+FQUc?= =?us-ascii?Q?ze0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2802b80a-3b40-4427-5618-08d97d8e1d0f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 05:59:17.4913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QotBX7Jph3xnElXJtG8BpwEOJFzeTSnPe8otvlAEgwaHxqM64ETfcxSgNjhTEEIwZecjF2btfVMC3Q+A6b8DhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3465 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v4 1/2] app/testpmd: update forward engine beginning X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org Sender: "stable" <stable-bounces@dpdk.org> > -----Original Message----- > From: Zhang, AlvinX <alvinx.zhang@intel.com> > Sent: Wednesday, September 22, 2021 10:50 > To: Li, Xiaoyun <xiaoyun.li@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org > Subject: [PATCH v4 1/2] app/testpmd: update forward engine beginning >=20 > For each forward engine, there may be some special conditions must be met > before the forwarding runs. >=20 > Adding checks for these conditions in configuring is not suitable, becaus= e one > condition may rely on multiple configurations, and the conditions require= d by > each forward engine is not general. >=20 > The best solution is each forward engine has a callback to check whether = these > conditions are met, and then testpmd can call the callback to determine w= hether > the forwarding can be started. >=20 > There was a void callback 'port_fwd_begin' in forward engine, it did some > initialization for forwarding, this patch updates its return value then w= e can add > some checks in it to confirm whether the forwarding can be started. In ad= dition, > this patch calls the callback before the forwarding stats is reset and th= en > launches the forwarding engine. >=20 > Bugzilla ID: 797 > Cc: stable@dpdk.org Not sure if you should add the same fixline as patch 2 >=20 > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com> Except that, Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>