From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly attached port
Date: Tue, 13 Jul 2021 05:37:33 +0000 [thread overview]
Message-ID: <DM4PR11MB5534B689D303BCCB3A7F98D999149@DM4PR11MB5534.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210712124053.29989-1-viacheslavo@nvidia.com>
> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Viacheslav Ovsiienko
> Sent: Monday, July 12, 2021 20:41
> To: dev@dpdk.org
> Cc: Singh, Aman Deep <aman.deep.singh@intel.com>;
> arybchenko@solarflare.com; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly
> attached port
>
> For the newly attached ports (with "port attach" command) the default offloads
> settings, configured from application command line, were not applied, causing
> port start failure following the attach.
>
> For example, if scattering offload was configured in command line and rxpkts
> was configured for multiple segments, the newly attached port start was failed
> due to missing scattering offload enable in the new port settings. The missing
> code to apply the offloads to the new device and its queues is added.
>
> The new local routine init_config_port_offloads() is introduced, embracing the
> shared part of port offloads initialization code.
>
> Cc: stable@dpdk.org
> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v1: http://patches.dpdk.org/project/dpdk/patch/20210619154012.27295-1-
> viacheslavo@nvidia.com/
> v2: http://patches.dpdk.org/project/dpdk/patch/20210712102440.12491-1-
> viacheslavo@nvidia.com/
> - comments addressed - common code is presented as dedicated routine
> v3: - uninitialized socket_id issue (reported by CI)
> - removed dead code for port_per_socket from init_config()
>
> app/test-pmd/testpmd.c | 151 +++++++++++++++++++----------------------
> 1 file changed, 68 insertions(+), 83 deletions(-)
>
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
next prev parent reply other threads:[~2021-07-13 5:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 15:40 [dpdk-stable] [PATCH] " Viacheslav Ovsiienko
2021-07-01 14:01 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-12 10:24 ` [dpdk-stable] [PATCH v2] " Viacheslav Ovsiienko
2021-07-12 12:40 ` [dpdk-stable] [PATCH v3] " Viacheslav Ovsiienko
2021-07-13 5:37 ` Li, Xiaoyun [this message]
2021-07-13 9:50 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5534B689D303BCCB3A7F98D999149@DM4PR11MB5534.namprd11.prod.outlook.com \
--to=xiaoyun.li@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).