From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ori Kam <orika@nvidia.com>, Bing Zhao <bingz@nvidia.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Jens Freimann" <jfreimann@redhat.com>,
Kevin Traynor <ktraynor@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-stable] [PATCH v4 11/11] app/testpmd: fix usage text
Date: Mon, 22 Mar 2021 01:45:08 +0000 [thread overview]
Message-ID: <DM4PR11MB5534B6ED7BB7472D3E46F4F499659@DM4PR11MB5534.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210321223116.1340974-12-thomas@monjalon.net>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, March 22, 2021 06:31
> To: dev@dpdk.org
> Cc: david.marchand@redhat.com; stable@dpdk.org; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; Li, Xiaoyun <xiaoyun.li@intel.com>; Ori
> Kam <orika@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Jens Freimann <jfreimann@redhat.com>;
> Kevin Traynor <ktraynor@redhat.com>; Stephen Hemminger
> <stephen@networkplumber.org>; Maciej Czekaj
> <maciej.czekaj@caviumnetworks.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v4 11/11] app/testpmd: fix usage text
>
> The options help text was including an incomplete and redundant summary of
> the options before explaining each. The summary is dropped.
>
> The details of the option --hairpin-mode had an extra space, breaking the
> alignment with the next line.
>
> There were some mismatches between options in the usage text
> sed -rn 's/.*\(" *--([a-z-]*)[=: ].*/\1/p' app/test-pmd/parameters.c and
> the options declared in lgopts array
> sed -rn 's/.*\{.*"(.*)",.*,.*,.*},.*/\1/p' app/test-pmd/parameters.c The
> misses were:
> --no-numa
> --enable-scatter
> --tx-ip
> --tx-udp
> --noisy-lkup-num-reads-writes
> The option --ports was not implemented.
>
> Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup")
> Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode")
> Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
> Fixes: 0499793854f5 ("app/testpmd: add scatter enabling option")
> Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default")
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
next prev parent reply other threads:[~2021-03-22 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210309233116.1934666-1-thomas@monjalon.net>
[not found] ` <20210321223116.1340974-1-thomas@monjalon.net>
2021-03-21 22:31 ` [dpdk-stable] [PATCH v4 10/11] app/regex: " Thomas Monjalon
2021-03-21 22:31 ` [dpdk-stable] [PATCH v4 11/11] app/testpmd: " Thomas Monjalon
2021-03-22 1:45 ` Li, Xiaoyun [this message]
2021-03-22 8:27 ` [dpdk-stable] [dpdk-dev] " Jens Freimann
2021-03-22 9:05 ` Bing Zhao
[not found] ` <20210405193325.1114795-1-thomas@monjalon.net>
2021-04-05 19:33 ` [dpdk-stable] [PATCH v5 2/3] app/regex: " Thomas Monjalon
2021-04-05 19:33 ` [dpdk-stable] [PATCH v5 3/3] app/testpmd: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5534B6ED7BB7472D3E46F4F499659@DM4PR11MB5534.namprd11.prod.outlook.com \
--to=xiaoyun.li@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bernard.iremonger@intel.com \
--cc=bingz@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=ktraynor@redhat.com \
--cc=maciej.czekaj@caviumnetworks.com \
--cc=orika@nvidia.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).