From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE8CC42CB3 for ; Wed, 14 Jun 2023 08:23:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC25C41101; Wed, 14 Jun 2023 08:23:17 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 05BE440DDB; Wed, 14 Jun 2023 08:23:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686723795; x=1718259795; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fulNwV0WUu+UshvkCT4vB8ydI/vCvJNRXzbU72Q6vls=; b=ElH7j6/Hu+THn2eoj4pfh3yVKp45Mf3AbmEQo392JzKMYIxjTZTGl0Fh iuzhGZrwlLHWvdEVTIX+nTu6CCYosfq7J6OVXTz7UJqLat/4FeyqUnTsJ oQsFXLj18xIM3uNY2L0xLbzRTeIyy9bQcex/yjKO7pC/v0SgV51t1Sh1k 3oWwKJhYkk/tSuiK9MHRuT34p04xshBntrDS+0I1WlB6Gg1Q3mioj126R 0/B4ZJlE1ux1V76urMTSTkfc3OXYCDpqI1D7qsmc334QS1/piI/eYwRGP C8Z9WRNxr0OxdDiebax9mk/9x9oEsHyaSQwwwBnJKRaOOauzRRv2yXUhw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="361014358" X-IronPort-AV: E=Sophos;i="6.00,241,1681196400"; d="scan'208";a="361014358" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 23:23:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="706089778" X-IronPort-AV: E=Sophos;i="6.00,241,1681196400"; d="scan'208";a="706089778" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 13 Jun 2023 23:23:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 23:23:13 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 23:23:13 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 13 Jun 2023 23:23:13 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 13 Jun 2023 23:23:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+W7Bu4bN+DgptAR0FC2Ju4s9ypKGT5ETHBuDXjg994gw96L7Qy4oCqHiAOmNhkRksUOWiLkj1Vrdr6nED7dTeEM/9GL+O/NujpvKWyNEhdOUWjo58Olb2P9bqVRfJc1IKizvGa8dhkNIHe9qkRceeaCgFfmDFw7AUYBjjhubptBKJPrXxQRM0lSwOqX1N0eghX6qle2BwHWCeAzrreLPRELk5oauzng4g9iw6XcHNsnqW6b/RgAexxtkYR/X3q9/zmpZfjvRgkz97ubkhJ+9WBeK/6H4o0K7+NEIKlUqNS5YjmvqZUw4ZEaWmSikvUY6u1qUsEU4jsmdZil7zVIYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YaTPvd2+jHhk+3Shruy7pqPT6L+eFVMoWaEKVY+Cyd4=; b=ChtxeD5l0L5fcgSvb5yiQF9n0KDTSRNXzJmVerBzsOIIOJRL5mup7QQtCxTYJy5MIiqgruFXZHI7DpO8RXN8tNZzd6qrokJ9nxUS94y+DA54HqPp2ohHamQo+fOXkxB2wrXQVA6XFg5ygyu35tj5SKghYokwJFc3Ff2Z0Jxivbf5qOHO3RrdN5TQBLC9gw1Pir801se8oJQb8f7/CPPi/x/TT+zPRSkjqah04Gz7NYiw9g29oXg5Pg0xQ2Ne7EKCYu6g6dJAzqmVQTAOwPR8cPIWT8LufraBtL810YsiB6F/TCYsaDLm+rwZUiNP2jfvISvEqbXBejp6T5amr2xpJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CY8PR11MB7244.namprd11.prod.outlook.com (2603:10b6:930:97::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.44; Wed, 14 Jun 2023 06:23:09 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6477.037; Wed, 14 Jun 2023 06:23:09 +0000 From: "Zhang, Qi Z" To: "Zhang, Qi Z" , "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Topic: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Index: AQHZmdL+I848w4U1/k+6isYKcDm7HK+Bs5PwgAAbaACABVFl4IACvMcA Date: Wed, 14 Jun 2023 06:23:08 +0000 Message-ID: References: <20230608062305.99819-1-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CY8PR11MB7244:EE_ x-ms-office365-filtering-correlation-id: bbd1fde1-30d9-45c1-3eb7-08db6c9fd27c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mMhAv0SBDlCkpjCk8Q+X3LmOeAAEhtIN708w8PqfJIiXcRNejMziSpPJnkPSnRkYIauHhbcEZoyeEgqIBSSF/1dMieNbjHZLCqJQrJGD/vIzyef5Cv3EtqE2V3kvwo/UhhoI2G0TapdTHtsYKrdTb5aOcfZSVCvaj8vCK/vSYxKkCSocs9F0f3bTkOony+HDTNaHFI60JXRBPfZCVyP1oVe5YhWDavOHj0Yr31TkdjVr4pAAU2bejLp4nyOM7pjFxBQnogv71WB3ffci4FwebGeiBRsnhCMeXkZ8pib/waMK2PgSomXZUUky3shpRtRTtujpeBqrqDq4IncEP+mP2Ic5gVxwyTUBGZTw+36BvTNg2dIXlb7Y65aI2PTmjrPmK116Vg2izUTuYXv1n7YAY55MyWjyr6GXTZL1BpHbLzFWJRO29WjJUe82coEb1UY6dr+jkSRc/iwUesJPx6Dj/WBmM+thfbZpKMVtG6wU+68KZYfsO889Axz8P665m/tUhh8o1WJ9zRuigdpGLvNkNFfyVCrpIEjS+R+t8YIrpaswhZ7bseAgzOK/USsFrRg/9A3k+vHPeAeEZmFgnl6Zgk1dvd/I2dMvc30skIJJh1RHHgkelO1/YrR8xEl9/SC9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(346002)(396003)(376002)(39860400002)(451199021)(8936002)(8676002)(41300700001)(316002)(4326008)(450100002)(2906002)(5660300002)(52536014)(66946007)(66556008)(54906003)(110136005)(66446008)(76116006)(66476007)(64756008)(71200400001)(478600001)(7696005)(53546011)(55016003)(83380400001)(107886003)(6506007)(9686003)(122000001)(186003)(33656002)(26005)(82960400001)(38070700005)(86362001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?VVc3L0xDMEtxUmQ4WUx1cXhJeHBJZ1duWkVDUjNnSUlRcTBSS1pkREF0?= =?iso-2022-jp?B?M21XZUpPdXFGbmJldDkwb2JnVDZwZzd2R1hMdEw4VXpwYnVwdmI0Tit2?= =?iso-2022-jp?B?ZHhSMEVaeVlaWXZqa2lGYUxaT0IxRkdmcXE0cWJvT0FFV3BvSUN3QkVR?= =?iso-2022-jp?B?bnl0ajQxR3Jaa2VsUDNiZXAyL2FWRmcwV3Qva3NHNHFXbHBqL2tqZy92?= =?iso-2022-jp?B?ZnR0VHVpWnptUzl1VjI2c01VMGM0K25iMnNiWThiYWUvVCtIS0xYTmc4?= =?iso-2022-jp?B?aGJLSlhYa2JIRlVDb1pxSmk5M0Z4YkR4S2ZwazM5VVBENDJHWW9EN2Ny?= =?iso-2022-jp?B?dnp4UlJrMm9vWXRPT3p4ME9ReThGZlVPYzJOSzN1ZUw3dGRIRitmWjJi?= =?iso-2022-jp?B?RHlqT1hSbWxJamM4cktGT2c4dzlOVUJ4aXN6VENlMmE5MW16VjhHM2dm?= =?iso-2022-jp?B?b3k0VlVCV09rZWVEVG11MW53dThZR1Z5NTc1TktmMlFMOVZaOThudlFI?= =?iso-2022-jp?B?NlRpWWg1L1J3Q3JpQTVGV2JQVTkwWHVYUEFMdjdrbVZaY255T0ZiZjFB?= =?iso-2022-jp?B?OGd4RTNjMGFaL2FOd1lSZ0k5MEZHL0VmZklJN1lqT2M2a01DMGVDUUhU?= =?iso-2022-jp?B?b3B5emk3WTJNVEJCbVJUTG1KcDliUjVJczZBM01wTGJTUXhsNGMyYlpQ?= =?iso-2022-jp?B?Nk1JdmZhWk5TRUlkQnQvWFJ6Ymx3SUlaWkNKYnBPeVloK01TWWpuWnpZ?= =?iso-2022-jp?B?YlpyNlU5c0p4V2FPQ3ZxL3U2cnN3cTZiY1kvSWExR2luOGlRbVBkWEo1?= =?iso-2022-jp?B?SEhkTFZrei8rNnNQdlpnUTdtTkcxaHF3ejJsTW9pRTI1RTlRQWcvSXhV?= =?iso-2022-jp?B?Z2lvVGZQNm5JMENKOFl5QlJpd2hybXJtQThXZ0N5TGptT1d3bjBleVdt?= =?iso-2022-jp?B?amNab3NnOWtHb0NyZHBwb1E0RkZQdWRHQzMwZllvRS8wQnB3eUxiZ0xS?= =?iso-2022-jp?B?K1FmcnZlNkpZN043bXdBVi9rMlpiejlUeXVySEcwZndkVzlCRFVqTXJ2?= =?iso-2022-jp?B?Wmc4L3lwQWQ5WDdGNG0wd3VmZmZGc2F5cE1HV0RwWmllWUlQd29oeFEz?= =?iso-2022-jp?B?dUY3R09YQTB3SzRBRUZSOERjcEpIUnRBOXRSMzdvYyt5dHVYUnppYzd0?= =?iso-2022-jp?B?V2U2MlNUeHUrbWFRbEJlTTZabFZFdmlNR2hvdGROZjVvZWl6ZEE2cytw?= =?iso-2022-jp?B?Ry9wdWFaYUJ2YXdOZEE2Tjd4SC9JR0daTkVaRkRDaHF1VnlldDkzeEE3?= =?iso-2022-jp?B?ZzBMdjF0eFFuYTJHY0ZJWWliNFA4T3ljZVZ2L2VQRHo2QUFLS1QxK3Fw?= =?iso-2022-jp?B?Ykk0OE94Z1htK1RCYW82dWtSUFZRZjk3R25hSWh1MUF1dk1rMzVac05R?= =?iso-2022-jp?B?S3ZxSWNzanZBekx2ejJRTkUyQlpvT0RqUzFXYzRhZ0wrYi9SNUQ5S3di?= =?iso-2022-jp?B?eXVoZE1ROVRYanNMcWJmb1lJL2xrVm5sdnh2MThiZW1VZTA5NU1lTHVO?= =?iso-2022-jp?B?Z1ovMjg4dmh4bVpCUFhxWnV5UDV4bWFERUxNTDBvK2dVb3c3RnR1Snd4?= =?iso-2022-jp?B?NUpEakF1c1RySWZUc2VVMnhwU3FiM0RFWlkrd0VLUzNwQS85eisxZDZx?= =?iso-2022-jp?B?N2pvSU54cEg2a0thcUJoQ3ZWa3R2SFozVHc3SWFGU2xWWVFScGp6Z0F4?= =?iso-2022-jp?B?K1grVkdtY3BlaWpVck0veDJPaTIrMm5leWRaMU96VDJ0WTRYYVVwNmhL?= =?iso-2022-jp?B?M2lzMXd2ZUs2TlJ1eER2bTVvbld3RW5ZQkgyd1FaZFJkQXFLeGo0RHpX?= =?iso-2022-jp?B?aXZSeVU5Mnlxd2liTmZNQ2Vhbkw0cVdSSUdsWmhaT2tJUHB3endvdHZQ?= =?iso-2022-jp?B?VGJxV0VlZnFSV2YzU0NWWEJJY044QkdzZ3RaYk9pcHZGSzIrR3JxUUlV?= =?iso-2022-jp?B?RWU5WUZJSUJsMVBYemtITmRIWThZa0ZOdFJEUkRFVFp4WmZCWGVaWXJh?= =?iso-2022-jp?B?ZjBYaS9wUC9UVFlYK0J1TC95SndtVUdkZEUvamk2Sms1TWs4MnNhK1Fy?= =?iso-2022-jp?B?Y3V6NXZjUmU5dW1vMW9LM0pPWHFTdG9DV0szb24zc0pYc1RMWHVyL2NJ?= =?iso-2022-jp?B?eUhVNVY1WHFONjJOTlRvQk5PN0srQWhyV3pjUW83M3hUNG1DU3oxTkhW?= =?iso-2022-jp?B?Q1pUb3IyVUovZnFjWEM0dW5jU25ab2NNUFJ0V0sydlR4SnBXTElVUXN1?= =?iso-2022-jp?B?WWVYTw==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbd1fde1-30d9-45c1-3eb7-08db6c9fd27c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2023 06:23:08.9447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A0sR2v+eCKAn6SEK/GXKmP8aExtS6T1vGfVX17TcyVDKKHkQ8BITDmLs6d+rbZ/mMERlGDjbVSiNj9/6UOgVRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7244 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, June 12, 2023 8:40 PM > To: Ye, MingjinX ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; stable@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt >=20 >=20 >=20 > > -----Original Message----- > > From: Ye, MingjinX > > Sent: Friday, June 9, 2023 11:20 AM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: Yang, Qiming ; Zhou, YidingX > > ; stable@dpdk.org; Wu, Jingjing > > ; Xing, Beilei > > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: 2023=1B$BG/=1B(B6=1B$B7n=1B(B9=1B$BF|=1B(B 9:48 > > > To: Ye, MingjinX ; dev@dpdk.org > > > Cc: Yang, Qiming ; Zhou, YidingX > > > ; Ye, MingjinX ; > > > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > > > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > > > > > > > > > > -----Original Message----- > > > > From: Mingjin Ye > > > > Sent: Thursday, June 8, 2023 2:23 PM > > > > To: dev@dpdk.org > > > > Cc: Yang, Qiming ; Zhou, YidingX > > > > ; Ye, MingjinX ; > > > > stable@dpdk.org; Wu, Jingjing ; Xing, > > > > Beilei > > > > Subject: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > > > > > For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the > > > admin > > > > queue has the issue of access overruns after disabling interrupt. > > > > That results in FW disabling HW interrupt for protection purposes. > > > > > > > > The updates/changes in this patch: > > > > 1. Remove the polling admin queue processing and use the generic > > > > interrupt processing instead. > > > > 2. Release redundant queue resource before stopping processing > > > > interrupt events. > > > > > > > > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > > > > Fixes: ef807926e148 ("net/iavf: support requesting additional > > > > queues from > > > > PF") > > > > Fixes: 84108425054a ("net/iavf: support asynchronous virtual > > > > channel > > > > message") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Mingjin Ye > > > > --- > > > > drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- > > > > drivers/net/iavf/iavf_vchnl.c | 48 > > > > +++++++--------------------------- > > > > 2 files changed, 23 insertions(+), 50 deletions(-) > > > > > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > > > b/drivers/net/iavf/iavf_ethdev.c index e6cf897293..ba5c88a1ec > > > > 100644 > > > > --- a/drivers/net/iavf/iavf_ethdev.c > > > > +++ b/drivers/net/iavf/iavf_ethdev.c > > > > @@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) > > > > } > > > > > > > > ret =3D iavf_dev_stop(dev); > > > > + > > > > + /* > > > > + * Release redundant queue resource when close the dev > > > > + * so that other vfs can re-use the queues. > > > > + */ > > > > + if (vf->lv_enabled) { > > > > + ret =3D iavf_request_queues(dev, > > > > IAVF_MAX_NUM_QUEUES_DFLT); > > > > + if (ret) > > > > + PMD_DRV_LOG(ERR, "Reset the num of queues > > > > failed"); > > > > + > > > > + vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > > > > + } > > > > + > > > > adapter->closed =3D true; > > > > > > > > /* free iAVF security device context all related resources */ @@ > > > > - > > > > 2772,18 +2785,6 @@ iavf_dev_close(struct rte_eth_dev *dev) > > > > if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled) > > > > iavf_config_promisc(adapter, false, false); > > > > > > > > - /* > > > > - * Release redundant queue resource when close the dev > > > > - * so that other vfs can re-use the queues. > > > > - */ > > > > - if (vf->lv_enabled) { > > > > - ret =3D iavf_request_queues(dev, > > > > IAVF_MAX_NUM_QUEUES_DFLT); > > > > - if (ret) > > > > - PMD_DRV_LOG(ERR, "Reset the num of queues > > > > failed"); > > > > - > > > > - vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > > > > - } > > > > - > > > > iavf_shutdown_adminq(hw); > > > > if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) > > > { > > > > /* disable uio intr before callback unregister */ diff --git > > > > a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c > > > > index > > > > 8cc5377bcf..579c0d0d70 100644 > > > > --- a/drivers/net/iavf/iavf_vchnl.c > > > > +++ b/drivers/net/iavf/iavf_vchnl.c > > > > @@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter > > > > *adapter, struct iavf_cmd_info *args, > > > > > > > > switch (args->ops) { > > > > case VIRTCHNL_OP_RESET_VF: > > > > + case VIRTCHNL_OP_REQUEST_QUEUES: > > > > /*no need to wait for response */ > > > > _clear_cmd(vf); > > > > break; > > > > > > Have you tested the "large VF" case ( > 16 queue) with this patch. >=20 > You didn't answer my question. >=20 > > > I assume event VIRTCHNL_EVENT_RESET_IMPENDING need to be handled > > here > > > then to trigger a device reset. > > > But I didn't see related part in your patch. > > > > The processing related to the "big VF" is moved before > > "adapter->closed =3D true;" > > to make sure it can be handled correctly by the interrupt function. > > >=20 > I'm not asking what happened during dev_close but the init scenario in th= e > large VF case, >=20 > dev_configure-> iavf_queues_req_reset-> iavf_request_queues >=20 > this happens at the situation that is no interrupt is enabled and it need= to > handle event VIRTCHNL_EVENT_RESET_IMPENDING >=20 This is not correct, as the interrupt has already been enabled in dev_init. But I still have question for other part of the implementation, will raise = it in another thread.