* [PATCH] net/ice: fix missing MTU value setting
@ 2022-04-07 19:57 Kevin Liu
2022-04-08 1:43 ` [PATCH v2] " Kevin Liu
2022-05-17 7:49 ` [PATCH] " Zhang, Qi Z
0 siblings, 2 replies; 8+ messages in thread
From: Kevin Liu @ 2022-04-07 19:57 UTC (permalink / raw)
To: dev; +Cc: qiming.yang, qi.z.zhang, stevex.yang, Kevin Liu, stable
In the DCF module, Missing maximum and minimum
MTU value settings.
This patch adds the settings of the maximum and
minimum MTU to correctly calculate the MTU value.
Fixes: 2fe6f1b76279 ("drivers/net: advertise no support for keeping flow rules")
Cc: stable@dpdk.org
Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
---
drivers/net/ice/ice_dcf_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index 8005eb2ab8..0da267db1f 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -713,6 +713,8 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev,
dev_info->reta_size = hw->vf_res->rss_lut_size;
dev_info->flow_type_rss_offloads = ICE_RSS_OFFLOAD_ALL;
dev_info->dev_capa &= ~RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP;
+ dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
+ dev_info->min_mtu = RTE_ETHER_MIN_MTU;
dev_info->rx_offload_capa =
RTE_ETH_RX_OFFLOAD_VLAN_STRIP |
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] net/ice: fix missing MTU value setting
2022-04-07 19:57 [PATCH] net/ice: fix missing MTU value setting Kevin Liu
@ 2022-04-08 1:43 ` Kevin Liu
2022-05-18 3:48 ` Zhang, Qi Z
2022-05-17 7:49 ` [PATCH] " Zhang, Qi Z
1 sibling, 1 reply; 8+ messages in thread
From: Kevin Liu @ 2022-04-08 1:43 UTC (permalink / raw)
To: dev; +Cc: qiming.yang, qi.z.zhang, stevex.yang, Kevin Liu, stable
In the DCF module, Missing maximum and minimum
MTU value settings.
This patch adds the settings of the maximum and
minimum MTU to correctly calculate the MTU value.
Fixes: bf89db4409bb ("net/ice: complete device info get in DCF")
Cc: stable@dpdk.org
v2:
- update fixline
Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
---
drivers/net/ice/ice_dcf_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index 8005eb2ab8..0da267db1f 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -713,6 +713,8 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev,
dev_info->reta_size = hw->vf_res->rss_lut_size;
dev_info->flow_type_rss_offloads = ICE_RSS_OFFLOAD_ALL;
dev_info->dev_capa &= ~RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP;
+ dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
+ dev_info->min_mtu = RTE_ETHER_MIN_MTU;
dev_info->rx_offload_capa =
RTE_ETH_RX_OFFLOAD_VLAN_STRIP |
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] net/ice: fix missing MTU value setting
2022-04-07 19:57 [PATCH] net/ice: fix missing MTU value setting Kevin Liu
2022-04-08 1:43 ` [PATCH v2] " Kevin Liu
@ 2022-05-17 7:49 ` Zhang, Qi Z
2022-05-17 7:59 ` Liu, KevinX
1 sibling, 1 reply; 8+ messages in thread
From: Zhang, Qi Z @ 2022-05-17 7:49 UTC (permalink / raw)
To: Liu, KevinX, dev; +Cc: Yang, Qiming, Yang, SteveX, stable
> -----Original Message-----
> From: Liu, KevinX <kevinx.liu@intel.com>
> Sent: Friday, April 8, 2022 3:57 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Liu, KevinX
> <kevinx.liu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: fix missing MTU value setting
>
> In the DCF module, Missing maximum and minimum MTU value settings.
>
> This patch adds the settings of the maximum and minimum MTU to correctly
> calculate the MTU value.
>
> Fixes: 2fe6f1b76279 ("drivers/net: advertise no support for keeping flow rules")
This does not looks like a correct fixline
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] net/ice: fix missing MTU value setting
2022-05-17 7:49 ` [PATCH] " Zhang, Qi Z
@ 2022-05-17 7:59 ` Liu, KevinX
2022-05-17 8:06 ` Liu, KevinX
0 siblings, 1 reply; 8+ messages in thread
From: Liu, KevinX @ 2022-05-17 7:59 UTC (permalink / raw)
To: Zhang, Qi Z, dev; +Cc: Yang, Qiming, Yang, SteveX, stable
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: 2022年5月17日 15:50
> To: Liu, KevinX <kevinx.liu@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: fix missing MTU value setting
>
>
>
> > -----Original Message-----
> > From: Liu, KevinX <kevinx.liu@intel.com>
> > Sent: Friday, April 8, 2022 3:57 AM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Liu,
> > KevinX <kevinx.liu@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ice: fix missing MTU value setting
> >
> > In the DCF module, Missing maximum and minimum MTU value settings.
> >
> > This patch adds the settings of the maximum and minimum MTU to
> > correctly calculate the MTU value.
> >
> > Fixes: 2fe6f1b76279 ("drivers/net: advertise no support for keeping
> > flow rules")
>
> This does not looks like a correct fixline
>
I reconfirmed that fixline is correct.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] net/ice: fix missing MTU value setting
2022-05-17 7:59 ` Liu, KevinX
@ 2022-05-17 8:06 ` Liu, KevinX
0 siblings, 0 replies; 8+ messages in thread
From: Liu, KevinX @ 2022-05-17 8:06 UTC (permalink / raw)
To: Zhang, Qi Z, dev; +Cc: Yang, Qiming, Yang, SteveX, stable
Sorry, I misunderstood, I will send v2
> -----Original Message-----
> From: Liu, KevinX
> Sent: 2022年5月17日 16:00
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: fix missing MTU value setting
>
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: 2022年5月17日 15:50
> > To: Liu, KevinX <kevinx.liu@intel.com>; dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Yang, SteveX
> > <stevex.yang@intel.com>; stable@dpdk.org
> > Subject: RE: [PATCH] net/ice: fix missing MTU value setting
> >
> >
> >
> > > -----Original Message-----
> > > From: Liu, KevinX <kevinx.liu@intel.com>
> > > Sent: Friday, April 8, 2022 3:57 AM
> > > To: dev@dpdk.org
> > > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > > <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Liu,
> > > KevinX <kevinx.liu@intel.com>; stable@dpdk.org
> > > Subject: [PATCH] net/ice: fix missing MTU value setting
> > >
> > > In the DCF module, Missing maximum and minimum MTU value settings.
> > >
> > > This patch adds the settings of the maximum and minimum MTU to
> > > correctly calculate the MTU value.
> > >
> > > Fixes: 2fe6f1b76279 ("drivers/net: advertise no support for keeping
> > > flow rules")
> >
> > This does not looks like a correct fixline
> >
> I reconfirmed that fixline is correct.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] net/ice: fix missing MTU value setting
2022-04-08 1:43 ` [PATCH v2] " Kevin Liu
@ 2022-05-18 3:48 ` Zhang, Qi Z
2022-06-03 9:17 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Zhang, Qi Z @ 2022-05-18 3:48 UTC (permalink / raw)
To: Liu, KevinX, dev; +Cc: Yang, Qiming, Yang, SteveX, stable
> -----Original Message-----
> From: Liu, KevinX <kevinx.liu@intel.com>
> Sent: Friday, April 8, 2022 9:43 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Liu, KevinX
> <kevinx.liu@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/ice: fix missing MTU value setting
>
> In the DCF module, Missing maximum and minimum MTU value settings.
>
> This patch adds the settings of the maximum and minimum MTU to correctly
> calculate the MTU value.
>
> Fixes: bf89db4409bb ("net/ice: complete device info get in DCF")
> Cc: stable@dpdk.org
Fix for current version no need cc stable.
>
> v2:
> - update fixline
>
Change log should not be part of commit log
Please remind these next time.
> Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net/ice: fix missing MTU value setting
2022-05-18 3:48 ` Zhang, Qi Z
@ 2022-06-03 9:17 ` Thomas Monjalon
2022-06-04 1:21 ` Zhang, Qi Z
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2022-06-03 9:17 UTC (permalink / raw)
To: Zhang, Qi Z
Cc: Liu, KevinX, dev, stable, Yang, Qiming, Yang, SteveX, stable,
john.mcnamara, ferruh.yigit, andrew.rybchenko
18/05/2022 05:48, Zhang, Qi Z:
> > From: Liu, KevinX <kevinx.liu@intel.com>
> > Subject: [PATCH v2] net/ice: fix missing MTU value setting
> >
> > In the DCF module, Missing maximum and minimum MTU value settings.
> >
> > This patch adds the settings of the maximum and minimum MTU to correctly
> > calculate the MTU value.
> >
> > Fixes: bf89db4409bb ("net/ice: complete device info get in DCF")
> > Cc: stable@dpdk.org
>
> Fix for current version no need cc stable.
It is a patch from 20.08, so need Cc stable.
In any case, you should run devtools/check-git-log.sh
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] net/ice: fix missing MTU value setting
2022-06-03 9:17 ` Thomas Monjalon
@ 2022-06-04 1:21 ` Zhang, Qi Z
0 siblings, 0 replies; 8+ messages in thread
From: Zhang, Qi Z @ 2022-06-04 1:21 UTC (permalink / raw)
To: Thomas Monjalon
Cc: Liu, KevinX, dev, stable, Yang, Qiming, Yang, SteveX, stable,
Mcnamara, John, ferruh.yigit, andrew.rybchenko
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, June 3, 2022 5:17 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Liu, KevinX <kevinx.liu@intel.com>; dev@dpdk.org; stable@dpdk.org; Yang,
> Qiming <qiming.yang@intel.com>; Yang, SteveX <stevex.yang@intel.com>;
> stable@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>;
> ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru
> Subject: Re: [PATCH v2] net/ice: fix missing MTU value setting
>
> 18/05/2022 05:48, Zhang, Qi Z:
> > > From: Liu, KevinX <kevinx.liu@intel.com>
> > > Subject: [PATCH v2] net/ice: fix missing MTU value setting
> > >
> > > In the DCF module, Missing maximum and minimum MTU value settings.
> > >
> > > This patch adds the settings of the maximum and minimum MTU to
> > > correctly calculate the MTU value.
> > >
> > > Fixes: bf89db4409bb ("net/ice: complete device info get in DCF")
> > > Cc: stable@dpdk.org
> >
> > Fix for current version no need cc stable.
>
> It is a patch from 20.08, so need Cc stable.
Yes, it is. I messed it up with another patch , have fixed this in dpdk-next-net-intel.
> In any case, you should run devtools/check-git-log.sh
Of cause I did. but I didn't notice the tool will skip cc stable warning if the fix belongs to the current release, thanks for you hint.
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-06-04 1:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 19:57 [PATCH] net/ice: fix missing MTU value setting Kevin Liu
2022-04-08 1:43 ` [PATCH v2] " Kevin Liu
2022-05-18 3:48 ` Zhang, Qi Z
2022-06-03 9:17 ` Thomas Monjalon
2022-06-04 1:21 ` Zhang, Qi Z
2022-05-17 7:49 ` [PATCH] " Zhang, Qi Z
2022-05-17 7:59 ` Liu, KevinX
2022-05-17 8:06 ` Liu, KevinX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).