From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4E1042CC2 for ; Thu, 15 Jun 2023 08:22:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF38140E0F; Thu, 15 Jun 2023 08:22:39 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9434B40A84 for ; Thu, 15 Jun 2023 08:22:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686810157; x=1718346157; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0ktJHzLkfF0XOPieMQ2YcOuCSJbw3uERixSSiwu2L+0=; b=S7cgiZx+OWpkqvBDOEdU4hGTKJazN+1b8IFVXWFtXuiODdkL93TNiCaX 2GtGJj/aiHsTV71flJZEWTBdE2HCc7BCZuK1lgCmk0YNrosBZRHhQAy9l zejhdINNS/twGghUUKoEUbiIOyPxP+/0FYId93+L6hq4ayB791M9x8DPs p5Ny7+VGMXOv2ZrijeObUbXojUGAvATlTMDspC0XqdnMHjRoL8Z7qVqBr 3GCupLOgBjcga0hvcVie8Q49LKEqUwo4Fr4Wg7OfQ5YNhlSZ6zKSy0JlV QcMs9ee+q9zrrb32iXSIwh9ldD2lZs8W1pb4ErlN/Q8HFTCDmpxp52d6B g==; X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="343525417" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="343525417" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 23:22:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="712343965" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="712343965" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 14 Jun 2023 23:22:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 23:22:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 23:22:35 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 14 Jun 2023 23:22:34 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 14 Jun 2023 23:22:34 -0700 Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BL1PR11MB5351.namprd11.prod.outlook.com (2603:10b6:208:318::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.25; Thu, 15 Jun 2023 06:22:31 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 06:22:31 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "Ye, MingjinX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH v2] net/iavf: fix abnormal disable HW interrupt Thread-Topic: [PATCH v2] net/iavf: fix abnormal disable HW interrupt Thread-Index: AQHZnqc3Dh4HDt4MNkeNM0vF07X5Y6+LZhaQ Date: Thu, 15 Jun 2023 06:22:30 +0000 Message-ID: References: <20230608062305.99819-1-mingjinx.ye@intel.com> <20230614095303.425160-1-mingjinx.ye@intel.com> In-Reply-To: <20230614095303.425160-1-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|BL1PR11MB5351:EE_ x-ms-office365-filtering-correlation-id: e3ffd28b-785a-4216-94b5-08db6d68e63a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jWGd8wpdITzOrNYsYte7OiXiQgN5UDmOzd57aUFQUavbbXX6MPBHv3+ICabkw+ZttMqrr4QwGcbOeRHDpOeFqOc6nz7KZWGW8GHOVkiNqFPoj4ubSeSMotlGkoxVSOQOtu93X+i5EnWpxUpEZ6rYZXYsxll1bBsyUMhWa4veMlltdItD9uWwOaCUTaYwppIg9tUxeMg2wio38a7mytHRszW023qswwqNTufsIAvJIGgAcw5f5Ls2XbNRKE2pL0QSOdqJOWeOGmAj6YZqyMLFoee2y1kkTRf1D8sC7TCtvGGuNQb1g8grsFKiCk1NWqfkKNqd7XkRr4fqb/9HbgdUWffMJoS+8V+Mslqan7nQmN0PyZSyIcKW/ZxoQcDcI//0IhrnsoecicVYbiCpxEJ12Qv5YfzJjjFqqbl9ATML+NWJY3rViTwdxcKmP2OWRdnR/bf+xJc/EH7Kc+KFc+5tCt+FZQm7Y6YlUMhsyv9SHVP7WgaD2yx07zeyN43LOYwzZ2IexNgkFv6QYwnFX6iflPP8yiJtNe4DONWqPDdHA30cdShWZgH/QAHsBZlKoEoJR1bGtiOVj5+4r2LeI/xgSnSl2As7N1eToug98bLqVIezmFPkg0s2X+xdbk57MX+z x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(376002)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(9686003)(26005)(186003)(83380400001)(55016003)(66946007)(76116006)(66476007)(64756008)(66446008)(66556008)(71200400001)(450100002)(82960400001)(4326008)(41300700001)(7696005)(8936002)(8676002)(316002)(110136005)(54906003)(86362001)(33656002)(38100700002)(478600001)(122000001)(38070700005)(53546011)(6506007)(52536014)(5660300002)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V+xgSc0VTlfzFMdnrFjrGbwx0GuIYAnIfYFFg+6by8OjL1ksLoFENvGrMEdO?= =?us-ascii?Q?mUADGX2QGSuCSXt4OzT7jw5Nj2IYp3ypKTj3M3WWMcl94ZNUuAr0Tgnz/F8b?= =?us-ascii?Q?rUcXQKOLv+zBbu/V79lYsltA9hLUShNY8ZlXBToqLNETAJnuFrQRZqt5Zire?= =?us-ascii?Q?FUiixwl9gAKwQ06hvJdxbCC3CMpcNNa7zycmo6pu2GQCQa4Y8AH4V0u0xT4M?= =?us-ascii?Q?YESyrT2E5bbG3KAXkZP3ZnldjZBZQDo7ncfCPGSjlXUO51lS8ESqSiPIWONC?= =?us-ascii?Q?7pmom0FgOlBtCgx6qhsxVVXNASE/4vsV2ssx/pj9DZ1baROfCb9SaDv59pLh?= =?us-ascii?Q?uXeJsY5ABx/qFoy0SeeJ58R4ZwGdh0ILfJh+VtWYsX2D8MqYQzPgoQK/a8GC?= =?us-ascii?Q?8iaEo6EQ7rJBOYkXFaxDGij2/vX8Ut8kzY2di92OiIwaQwISRYEXN6CVvZ8z?= =?us-ascii?Q?2oFsECukCwYpu4kgEMLtsRot/FHOOpD8c63Itkra/qzPTW+Hce1pogTWsJBj?= =?us-ascii?Q?E3Uau5tpsvzr0M4QpwJlCvNHHBDvwspLLSSIcRttQ5TodF1s/4PA8Uf+4vc9?= =?us-ascii?Q?wfCM9SA0aWgucM0uvOo6ZGMb6gqcBPgA7aKnTvm/gEjEoLLzKbWqAAo3LH1E?= =?us-ascii?Q?i+CDu6JWIdhLmvf5hwSElpEh4A+hOIowfctAOEzobC+qFaBd69HpPTAEswyZ?= =?us-ascii?Q?hdGZSEXD5Fl9ai+MkPovmXn92ooO1KH6ZCP/mkjjgOIhrRuZw7ZjncHcjMg8?= =?us-ascii?Q?2FGphKacs+Ht7csyAMs/473uZPrgafJxqJnQr8icubiDlJ6cMo+yqgfItT5R?= =?us-ascii?Q?xuD5x3Jl/mBxpRDj0aRBWUZGfQqaJGQTNTjh47uNgeG+rY4eiq8FVfyM+FZG?= =?us-ascii?Q?6EFHPJRR1C0x7DQhQSF0UThHI/MkIdBRwZLbmKfL6oJH/ezD1UcgLSav3KUS?= =?us-ascii?Q?bhSclLNiopaPTRMXGw/5JFDhBuInsnv1hLSPtmQTmu2tPD7h19N1J5KLETwh?= =?us-ascii?Q?54RdpvCEwPHz0WjUe6iJzVu+gtnpjAHRvbQuT1H1pXQOqmeMKxxlUWZaJopN?= =?us-ascii?Q?F/VFFchWN/wh6qK4Tqc/5xxeJJf+tUMnO77WSedeDJmWwPmMbulovcZTGuRL?= =?us-ascii?Q?MxS+gF2OOGzl+gomFMdEHTwClwOS6AICGJTrhh2mSNPLwbAseMsP2kin9h4j?= =?us-ascii?Q?JdZHg67c6bBWtAICkvUBY8dSA0DsO5t4We2s2Hcwqqo/333HuATsJvfQ4Tzh?= =?us-ascii?Q?ZOSKXjwz78Til9FhkMY0hZMMN4LqYLU06VX3tuT7IGZb3a2EAq4+RuIS/8xN?= =?us-ascii?Q?YLzvLnNJaR6O+de44C0SBxJ1BeYdujEuSATkFpyv1OsyL6L8n/3ETcoRJRe3?= =?us-ascii?Q?+oMgm2G74+WH45dJTxlgWRpd4N3lBE4Vc7meDzSwh7l50nwFQsNbsut57vpl?= =?us-ascii?Q?psGFcBB0GWVh6BshzanLldkxjtQgrN3N2cb8a30EeJA0dhKXAAYcbfOYjeRf?= =?us-ascii?Q?1kRn3H9ZEIDHiGJBgHmOj28M1Uv4v7V6XCgbeo3aM0C1nwD5PMC8L4EyRMCj?= =?us-ascii?Q?vvTp4NU/17ie+STvQa5FgX1SJiLn6WECEnavgImI?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBmNVKKCJeKaPFXL7SC/7f8MHjXcE5qL3Zcc6S/owpxlucR4EPmbXV8ETjySBd3oI5PnIvf9lvpe25RQ6o04BlBb1HmaP9AeQXExe3Vv+N84DB8cXQ57/pY8Nra58uq7fRgOqG/ihQGCuBfRjQR/FB+wEJqv1FBdXO2qgfvxkYbDcSbdYHoYNQDufV7vO45tCUXfhjmyHTW3b8x1+DHV5kRJ9BnhONmaTUHzdKrUsFa0XOih4KrG5VrwtOUZtu9Dk6btgn2a59inKp0bp0fRCAobJFd78ioL3WonNRtrb/tbja1vcwVGaV21NTS/uDpJ3w3i2N1W4GWGchQg7G8UMA== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KjrpCI3uGjc8MxwZFKUEydCfrpybukvvkSOLl9gRGtA=; b=Il94XRDGAZ/n8Bz0IzOSGeSeXfkxGqP9A78xqWf544UlLDBmdwPbWi3+JWxLG8fkuXwSQatJjE+2iNoIMOsAuERaIbjPfLS4dhVCrpHOf1473ciArKRW98Qgl7Y+itzE4tHz/pBxqpIdOxRAYsZYgST9neAKN0xn20phHLBKdbHJVE0IPVn538IpLXVWu+ti9UOhtP6toWt25BQFcJRnA0u4G71b8hFRsfYU6LkXtAVLXHp4OZIrUu8uANEGtkuz8MsWHCDVVrdFkxONnILDmSg3nSjc3Rw+o8UWIs8lKj7e0hUPZ+qxEmEkEAyEGFKKp6CXmPYpfZicn2eGI43w9w== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: DM4PR11MB5994.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: e3ffd28b-785a-4216-94b5-08db6d68e63a x-ms-exchange-crosstenant-originalarrivaltime: 15 Jun 2023 06:22:30.9127 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: fdTQGRJQDT0dKIlW7sB9yO8B250PtvEhkam2o1cnXVyRgJ1RX1v8Ka3ZI6dgO+A+O24uZecDDrhyeB+HeeWD+w== x-ms-exchange-transport-crosstenantheadersstamped: BL1PR11MB5351 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Wednesday, June 14, 2023 5:53 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH v2] net/iavf: fix abnormal disable HW interrupt > > For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin > queue has the issue of access overruns after disabling interrupt. That re= sults > in FW disabling HW interrupt for protection purposes. > > The updates/changes in this patch: > 1. Remove the polling admin queue processing and use the generic interrup= t > processing instead. > 2. Release redundant queue resource before stopping processing interrupt > events. > > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > Fixes: ef807926e148 ("net/iavf: support requesting additional queues from > PF") > Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel > message") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi