From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B4A542C67 for ; Fri, 9 Jun 2023 03:50:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61B4B41148; Fri, 9 Jun 2023 03:50:40 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 7D44740A7D; Fri, 9 Jun 2023 03:50:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686275437; x=1717811437; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fokhLrKSZgSfMUAb0+T1MJyyhkI38kdTiGpuVtHRK8M=; b=HCcacmUXHu09GZbeLzSfNtPhVtYsx9kewPcRjxcrnCaPbc0/vmYAOiYZ c+NxqIo8/fird1HWKR1iiCFA7DaQVMuYC2yjQC8R+5MAR5c8scbvUnA0l X+NWqpwzv7xtxxHV93YLolgFZlKbYVvKkBHTMOBXX6IVV7anBUIl1x2+3 oY/GCGON8XJ7JgDZppMaT7gzGWujKfIWt3LnxWAr5RkW6YXWMt4NauGk1 mmmccjrPe/ojyOHQsBgJLWZNmSXUnrFfXu7oFkAuwsp1+ow5EAhr3ri+M zvh/HvROEyQS0FCLOMAcQYtveOqjlAdT674v8wKOv0hbIxSYBJp0Rj/Jz Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="337119809" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="337119809" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 18:50:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="956953949" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="956953949" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 08 Jun 2023 18:50:36 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 18:50:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 18:50:35 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 8 Jun 2023 18:50:35 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 8 Jun 2023 18:50:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDAoZvNxvOkaRgpZ+B8mjznjy8cCDMiHrBxto0lM12fGRycLiJNdT7yHw2rc6cuit5DTLPsIEArZ2JI3Gdty5CbfeasjQgvSfaOF0zvPt4oWk+FvWZ334t5v6tyYP8ygsceqbkPY5EClwQJRrV2Od67xUAo32jhLUpV0YpnHtMIticLIWIi+qQdVNZ1n3R9BzP71OymmGx4cgIDABmtIjLdtY3XHbvj2JI+f14xkH3C9Vj5otTYX1+a9xXyziFekBMikyWh7RdLenC3K77FliU/iCNsOybRUTQWLgYKw+AeEGNPblr2y6DYaeYWECEuujRtSbN7VbK1foKyDFlNNQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bnkn0WD35FVVbsGud8GienBsrjLD5zRG16PTTJ+LzMo=; b=byVQPGZS+TQlqdMTqGp/MY7YjwDE4AQBp5SupYc99DYQXOwmWBWei3XeOo2a0kqzwPGa+e8ujTHuNTmmV+Q49eOOcPG5q7un+81gkRKhTHd6SRfcnwQPXAHTxEn4EE94vkqQ6CTSQSZtRUlTR2P6CkU3wz6J5RK1hFNWRphZIc+S10kwWANXJ172fqWO5g4l2uWeLCKuew0Pu4WG2rH5WFt2RSbdWEbaCwTIV48Wf4aM2ZT4cLFc9TUCXxtjAReRETM6zrdd4Xp9SAZ+Pu1fSVUZtkvhVA0GbSxrgYtu/3hE+76T+lg0+HNiTr7qZ2xOhGEA7eWh6vyuweFhlkBRgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MW3PR11MB4620.namprd11.prod.outlook.com (2603:10b6:303:54::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Fri, 9 Jun 2023 01:50:35 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023 01:50:35 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] net/ice: fix data length check Thread-Topic: [PATCH v2] net/ice: fix data length check Thread-Index: AQHZjRyLD6UftJdClEWkmjQVJ0iJ7q+BzuXw Date: Fri, 9 Jun 2023 01:50:35 +0000 Message-ID: References: <20230522181447.2747713-1-qi.z.zhang@intel.com> <20230523103509.2918185-1-qi.z.zhang@intel.com> In-Reply-To: <20230523103509.2918185-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MW3PR11MB4620:EE_ x-ms-office365-filtering-correlation-id: 53159ce2-235b-48ba-4ad6-08db688beaba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5WvDl8mu0H58Vv3Fryxy57Z81WppjS4TiWhVHb89pYIuFhdmcv+l5+lSe4Q/YNSo/VmvSd6W8vVMONGDrT6uE9NG8uV8CU4JuECDa+a/Biqau5F75aQANFGQ8K4VeYc9urkKzO3HCVwk7G1rHWbPbyHLw6ig47cySCoZjqrLYti9M3GDS41mXrYRS5htmcgYolcQC3menKnCDBohFSuDuqJctg8uZ8AX9p2u8jor6gMv2eqeLvyS0rcb6jNiIbV3ZMkbIrhrvw+PcLuzCN26TXqDYlaY03J5d/W6WId01cFjRD/06ImY5N+cvSCpYavneFapcd0kxoiBZupbZzxrwREMUORXDVFEcF9RazwRDMb7s/qQzpqws41Vpq+WHDka+B3hVAs9AW2oqvCZ9uXq2RAxwJEFskY5sUOgmYEG3LfJ3lUb2fnM33wlbj1BWaetHpn81680njyFcwBVpIaZsJTGrcPW695ai0FiCzksGFHl0wgi7qYbrOXHxFHr7CqoaJguL/7U1Qi900swTToD8a+MoCwTWnSLWV6F9WDCdDuTxmud2QUM/0xfKNPKn8fTPFBh9dnalrCIvQ9ZM+AjXyHSIZCq851GiwlszDLFtb6YCxU3ck5aeTcR1DxeQlpl x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(38070700005)(316002)(41300700001)(6862004)(478600001)(450100002)(64756008)(66556008)(55016003)(66446008)(33656002)(2906002)(52536014)(5660300002)(66946007)(86362001)(8936002)(66476007)(122000001)(38100700002)(82960400001)(8676002)(6636002)(76116006)(4326008)(7696005)(54906003)(83380400001)(186003)(71200400001)(53546011)(26005)(9686003)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hPoRjj5Ejy2qA44UxIngFYEDD79vM3cG7jnigIMU+oKH7QOy4rIUFOvBwnqh?= =?us-ascii?Q?r954CRirZDDdEqEC4HgaPauwo9f4Q42wFq+LkEkmqngQtYI7fNOLNwVkaBIe?= =?us-ascii?Q?wWSjT2gPSeoH8hpv5zaO82EYBlQsANbnxV7uh7HfdIFNNJFAcwTK4Q54wUNu?= =?us-ascii?Q?P/j0hkCwEbKueP+yu2WXSCkBnpuliLbSCNX0c/aUkfe/yrhSgs5Uk4/ROg0R?= =?us-ascii?Q?NJ66IXIPSqK2mP8Gvwc4i34B3qrxMoxApiSjcXmDvbK/ngEP3tStxFzzSWcr?= =?us-ascii?Q?lWprUPdo6rD1mRlzHU9WD0+mp36JJ5248EfSPF1UW35AYWINEUnu4i5WCmcC?= =?us-ascii?Q?+BtZaD74NzqXaceUNnM6trfMCzH4u1Jf+s/JJVPq5dx+DuFixXD+ZcEXM3SS?= =?us-ascii?Q?vLizMezaqT7Gbv+6RWaHqPVNc/Ulgrwc9XCdnonVI8sXapDDcw+9UZlILk3W?= =?us-ascii?Q?Tk1KyE3V3Vovd4ITdveo7iSX8syHSGGz3d0qvFvYw27mWESm0vf+msf+2dD5?= =?us-ascii?Q?Fh5eSCDouZSUkpU5gETbrr4qVrMwuBJnGA3QIxmHxkXujwXikJ8BoMCzXONg?= =?us-ascii?Q?WS/xLMnkKyEswhS7vgbpIog7eRK/r2SEigsIyJtcw3H+QqZifnxHCl0xm12x?= =?us-ascii?Q?O0CceL9T+S9NnfnrYGXNOkClL64h+P+GhhcnaqqoXc4uWgqfpXMj03D3ik9K?= =?us-ascii?Q?VON+1uTgcMaU1KJeekwXZ/u37VuBbDbVPE5VjB8jaWa2rcdLqh/EZrD1kzmM?= =?us-ascii?Q?SPIxtMuwceR1n7zisPjYF4XeVAu0zB9ks3uouftgH0RIZbvpyBPni2O7a/OS?= =?us-ascii?Q?dZyVlaEIgTuznBmVwLfPSXkkmfjUIaaVipG72Nlt6LJz6qEy89xrgDidUSBq?= =?us-ascii?Q?gWXEXduQ5vG0qgZdNVuveeRb9G4BYqciSnqtaj+Qc/3QnomS4J9A29HD54Vx?= =?us-ascii?Q?2ngmqbZh/j97Rn4yxoAihMTpW42/C7OOMGpNQonx3kT/qWzc98qH0xijXPVS?= =?us-ascii?Q?cL/5Qopr+uqAFIYNGXl6qF7x0ZEOK5opI8A8C2UBcnAVUhVR/74U/TfvTcwK?= =?us-ascii?Q?SO7SUZ0rHDnAnSgbq8g/ptVb9autv6xHvq9YAdZUWlJqyhiy7h57nSgSw1Pd?= =?us-ascii?Q?MFfLHL9E/RdCYHgJdIv9olh3XN4ep4IuG/coPLRQ1NEiEDicK1RIOcZVhX22?= =?us-ascii?Q?zujwZOBUiEOHIgWN2kLriMEtupS4b0gycPBGajDzleHGxY5+dO6DIflZyLjT?= =?us-ascii?Q?bgM0C1/aLrCsx3F+AiUJKTmRWLM1dMdYc8at/By3hBpkxNpI1drGH0Hnd/5s?= =?us-ascii?Q?G5mwY5d6StCmYXlxEmCDoa6QqRDjQCgGZrlyBIQgbAYjL+YYNukFtxAIdR6U?= =?us-ascii?Q?jrOcWsX6LPAMEsRw7Yh1WEwDjkhdCeK+gVSfCghVyXZA78JtGwhLQlz7LZBT?= =?us-ascii?Q?JVSp5nvMeENc9yR//uZQzQDKBogPF6xg9wr9Tntuh4PEMSBEF39I0hkwYg0a?= =?us-ascii?Q?iwOZOFdO9Fmbk2xwJpnAkjW0PjEwdX49KIFVdiVGnHxJFaTI+oT3A3x/8FyT?= =?us-ascii?Q?piqAhUQtyY14WtDUWe3+YDENH5jH6+jlc+z+rXTK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53159ce2-235b-48ba-4ad6-08db688beaba X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 01:50:35.0871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u2nxCfVF2oXerGtwYrcAEtOD6E+3LHgor+9N/QL+3T9A4ic/ODOKCLvN1EElPT/rJhgb19wUFTzG4UO7mhzK2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4620 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, May 23, 2023 6:35 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH v2] net/ice: fix data length check >=20 > In TSO, It is possible mbuf->data_len exceed mtu. > Fixed the incorrect data length check in ice_prep_pkts. >=20 > Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > v2: > - fix build warning >=20 > drivers/net/ice/ice_rxtx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c inde= x > 560c1a4af7..cd0e61c85f 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -3669,9 +3669,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, > struct rte_mbuf **tx_pkts, > int i, ret; > uint64_t ol_flags; > struct rte_mbuf *m; > - struct ice_tx_queue *txq =3D tx_queue; > - struct rte_eth_dev *dev =3D &rte_eth_devices[txq->port_id]; > - uint16_t max_frame_size =3D dev->data->mtu + ICE_ETH_OVERHEAD; >=20 > for (i =3D 0; i < nb_pkts; i++) { > m =3D tx_pkts[i]; > @@ -3690,7 +3687,7 @@ ice_prep_pkts(__rte_unused void *tx_queue, > struct rte_mbuf **tx_pkts, >=20 > /* check the data_len in mbuf */ > if (m->data_len < ICE_TX_MIN_PKT_LEN || > - m->data_len > max_frame_size) { > + m->data_len > ICE_FRAME_SIZE_MAX) { This is wrong, actually check max_frame_size guarantee the data_len not exc= eed the buffer size. Rejected. > rte_errno =3D EINVAL; > PMD_DRV_LOG(ERR, "INVALID mbuf: bad > data_len=3D[%hu]", m->data_len); > return i; > -- > 2.31.1