From: Raslan Darawsheh <rasland@nvidia.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx
Date: Tue, 17 Aug 2021 07:54:17 +0000 [thread overview]
Message-ID: <DM4PR12MB505420700317BFB42C4AF89DCFFE9@DM4PR12MB5054.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM4PR11MB5534033610426A2F118F944199FE9@DM4PR11MB5534.namprd11.prod.outlook.com>
Hi,
> -----Original Message-----
> From: Li, Xiaoyun <xiaoyun.li@intel.com>
> Sent: Tuesday, August 17, 2021 4:54 AM
> To: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Cc: jerinj@marvell.com; dev@dpdk.org; Raslan Darawsheh
> <rasland@nvidia.com>; stable@dpdk.org
> Subject: RE: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx
>
>
>
> > -----Original Message-----
> > From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > Sent: Monday, August 16, 2021 15:10
> > To: Li, Xiaoyun <xiaoyun.li@intel.com>
> > Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram
> > <ndabilpuram@marvell.com>; rasland@mellanox.com; stable@dpdk.org
> > Subject: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx
> >
> > Fix verbose mode dump for Tx to dump tx offload flags instead of Rx
> offload
> > flags.
> >
> > Fixes: d862c45b5955 ("app/testpmd: move dumping packets to a separate
> > function")
> > Cc: rasland@mellanox.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > ---
> > app/test-pmd/util.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index
> 5dd7157..14a9a25
> > 100644
> > --- a/app/test-pmd/util.c
> > +++ b/app/test-pmd/util.c
> > @@ -275,7 +275,11 @@ dump_pkt_burst(uint16_t port_id, uint16_t
> queue,
> > struct rte_mbuf *pkts[],
> > " - %s queue=0x%x", is_rx ? "Receive" : "Send",
> > (unsigned int) queue);
> > MKDUMPSTR(print_buf, buf_size, cur_len, "\n");
> > - rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf));
> > + if (is_rx)
> > + rte_get_rx_ol_flag_list(mb->ol_flags, buf,
> sizeof(buf));
> > + else
> > + rte_get_tx_ol_flag_list(mb->ol_flags, buf,
> sizeof(buf));
> > +
> > MKDUMPSTR(print_buf, buf_size, cur_len,
> > " ol_flags: %s\n", buf);
> > if (rte_mbuf_check(mb, 1, &reason) < 0)
> > --
> > 2.8.4
>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Raslan Darawsheh <rasland@nvidia.com>
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2021-08-17 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 7:09 [dpdk-stable] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum Nithin Dabilpuram
2021-08-16 7:09 ` [dpdk-stable] [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx Nithin Dabilpuram
2021-08-17 1:54 ` Li, Xiaoyun
2021-08-17 7:54 ` Raslan Darawsheh [this message]
2021-08-16 8:48 ` [dpdk-stable] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum Li, Xiaoyun
2021-08-16 10:55 ` [dpdk-stable] [dpdk-dev] " Nithin Dabilpuram
2021-08-17 1:43 ` Li, Xiaoyun
2021-08-17 10:58 ` Nithin Dabilpuram
2021-08-17 1:44 ` [dpdk-stable] " Li, Xiaoyun
2021-08-25 12:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB505420700317BFB42C4AF89DCFFE9@DM4PR12MB5054.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).