From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E1B6A0548 for ; Tue, 17 Aug 2021 11:47:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D06C4014E; Tue, 17 Aug 2021 11:47:42 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2053.outbound.protection.outlook.com [40.107.93.53]) by mails.dpdk.org (Postfix) with ESMTP id 790BC4014E for ; Tue, 17 Aug 2021 11:47:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hM76Q6ZhW9xTj13k4TzXbyRJYN+TSQov1JQFd4LPSc5LaJsfzPnoYmLiRRBSHKQtroLpB2C82qABD2UNZ2vQvAOyK40JsUtMHfJ7jSwVhFAA/pWcDrOMloVZFXalykLJI3PnAcdmnWE2MjQCLQfRBsi5q3Vg5SwwS+kcc4Lbk2AC1nhZ8VTv9Fgjn4jLQhhu9c59gs2YkigR4NnvAueRu88TIbW4/NmUuReMdQjykmOHRWNPjapclRP2S6WZKmz6ypK8+WH3091AaLMOW2YBVN7UAL5NmLvCZYi8NnhSK1oCrKzhWIzKL5Wj4RXNlPeQmfhToEWq+Vmyz5NhsnLTdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iWf51v8YAPqxm0FNYAr5l+1hLQJedE1sAgsPEU9CaMg=; b=ShG0cszaUrxaefaGRcs0qe98AWFmNfyXDGkv8CmD3h9LpKmouWxq2Ijp1Usm5CDVvyUNfz1XaKvEJqvujWlXQRvAUEHyb1lO6rmWhz5jrezVC7rOimV6/OWMtMH+1D696ZawqOZZkOV5MlDuHkhE5uYJk92/DjlLw+6KTKXzwASpVPoLpcBzmVwYOf4PYy2+J9CJ6BHHV30PHz5nsfZItR6aNoB15yF0MX+lbuEJZLhatcnvcS1y5N/66t3a0Ph/yqL3MbHoAffSV9FW08e7iKAIgeWZ/CFX358DQF9tAxtwZb03QXdBlLSG3xgwDRgX+SCUXsZGuh0gCvY8IHZrFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iWf51v8YAPqxm0FNYAr5l+1hLQJedE1sAgsPEU9CaMg=; b=fZBb+8KA28OJl0g8SjtFReOvJSsacfTzjv0LmKCBRmMZ1AWPoiGJz03M40IOL6W2ExoUBY23X9g6AsLGIa/kXZvVLNDMShPKtS3jZztDesyZFVo8et0LJEcDb1qDrz9uSHFpmakNtC6so29nzpocr6VbI2OIdbSMOsyiG4aInGLUEanRBrAMh8k/ZwWNkOhi8SAkMnckWGLVml4H8QHxYcm7pIYbxaBymt7bLGs52sJeXerzLkX59Ohv6jIvGDTYE8rU3PYLTWhNSmK0Ge7IpLmXtN/kfCOWh4WHxrNV0R4jmYwmdE/4H+SZwJkUZG8Y9xbToQ8/EyiL2e4NhOeluA== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM6PR12MB5552.namprd12.prod.outlook.com (2603:10b6:5:1bd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Tue, 17 Aug 2021 09:47:36 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::803e:a800:9fba:4550]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::803e:a800:9fba:4550%8]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021 09:47:36 +0000 From: Raslan Darawsheh To: Lior Margalit , Matan Azrad CC: "dev@dpdk.org" , Lior Margalit , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for inner tunnel VLAN Thread-Index: AQHXiJNRTvfcd0473k+8I4CbMkNAh6t3iGuA Date: Tue, 17 Aug 2021 09:47:35 +0000 Message-ID: References: <20210803181322.1409492-1-lmargalit@nvidia.com> In-Reply-To: <20210803181322.1409492-1-lmargalit@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43315b97-0676-42b3-1c62-08d961640b20 x-ms-traffictypediagnostic: DM6PR12MB5552: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cPRUS/8OskyF75Q37vJQqxXuRoVjcpxR06Ui3+T9dGsavNVGm+jTthx29YhQy2IavdOivIPjTIaD7LQladzF1rmhtFGRVPH2XauLTB3ymKanlAJrv67uplYdVfn5wEFl3+PWfpRx0sfcSmoDMqfzF6VaVJsLVOI17nANfPxaQWpz4NxZEoXc1XUznrxuuHdf85EulYhbajPdcrYZRLfXgwGaTtLeU0jUTNZqm5GFG4WuX37WKKVB/Np3R7u2utD33Ll5U7DJCq4ugzdwt3SQxR/s7obAMlLex1v+e+1uW9Sr1wK/KaMxI1oLdM1aTHtOBFZf5eYSs7V2RtuQVKgS52RZC4sFn7igW8sB9A+mrs/gy4d/7oMRpe6yIBgbJql1dap217f3+WV4z4OSyFmVlC+20VbqtCC9+Zv0t8UQC89bgPAdqvi9VLr9v3gKkg7d2n+5pWfpVth4dBWLD9r6tTymRdNm1yixQa50K5yeJexI9nCiXnUOVqcu56errtaJaBxjOBEbbco1+7L/mNNWDzmY49tJeq6BPOj8oWyp3M5MICXdAuSoy6gQ2p1jrWLCI/aC1qYsoq0E+JGMv3F/3tcCfA8q3a0bNsCtePlkicAkvd/zNj2HZ4YyTRYSYp0r/cpHt5/+8wzHky6ohihD41hlYdbCbq/YsPAbHas4jQZNUQWIvzNjmg728dSsvxvZ8Ol22SXRvLr54ZRJymTwxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(346002)(136003)(396003)(376002)(38100700002)(122000001)(55016002)(33656002)(9686003)(110136005)(86362001)(76116006)(54906003)(66476007)(66556008)(64756008)(66446008)(2906002)(83380400001)(26005)(186003)(66946007)(7696005)(53546011)(6506007)(71200400001)(5660300002)(316002)(6636002)(8936002)(450100002)(8676002)(478600001)(4326008)(52536014)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wrINVdiABt1xe/0tWzCD8ZMriw6Z+VnYbPuv5DVvyIYPJr7IHalFWS+fmFqL?= =?us-ascii?Q?coTNL0uyE3pcuSX8fUgt7hSITsqXINd8EIg6Fn1Za+tQWj9ITxyNxBaOGghW?= =?us-ascii?Q?dE5c4ZgsC50Idgl1pyo4HwaMX1mLQLncu9cuM0Q85e0swtf9X5pmgAH7TGc3?= =?us-ascii?Q?hsbT5tkXd+YKP6cT6lHnfJhxVmrO0obTHOYrUWOBpWnEsnSDfRFYQ5iukCTH?= =?us-ascii?Q?qdy1ewO6xT/kpa6WPJ3xSE3LNAZrgyn0XJv8cnPpEQw+w+lzMZmoEk4VtNQq?= =?us-ascii?Q?OsFBkVrth/HAE80nIfQVW8Pi3fltEAf985c94Eu6OG6PgMUdrQXPDt7aFoCp?= =?us-ascii?Q?DzLL8GnWR3D5qNwDPwAboNaexJuX1P3ZCWtisAY6vQZjJdB33/w7fu1uAZtJ?= =?us-ascii?Q?PGIrlJzeVaKJDAmFnAXOsV9THU6kRME2Mhy2ZwMnObvyL/mdHvMc92QRx0hJ?= =?us-ascii?Q?Xvpnt+PlNhvZIvLf0DyVf2fL79hLAF0luVzVxaJ/JMo+SAOUMutp4DE5mE2j?= =?us-ascii?Q?hwnHQ6snCTxmbiAygcBcDQuVyyFHVRjkAp12iUBL0bilYnKasqDJxts9qz4D?= =?us-ascii?Q?rFChbtDDNrdcrDuUvKM3/YOezSytlsxzaT7d+uQGiSQjcPQQPe7CrrONNibG?= =?us-ascii?Q?/lk2Kf6eExq3YoNOuB9W0RMrr8ZAwwrmiASi8qfEY0jCoDgyOjq7cU48xvg8?= =?us-ascii?Q?giKEcg9f+Uj3l+Sx1tt6Xp7Ephag9tJCNt4aFU6vrX5IaFoGiNfnvTdaCNn4?= =?us-ascii?Q?40M5FmErBiaC/pWd+oJKPgpUJWzCc56ZMDOEvCsAqXk+BchBwj1HO9vuxE0W?= =?us-ascii?Q?v++m27PWFJCB4aWdliQEsNRq/OekzBcVpvPozi0+OEeXunnlIoYjwu/t3vN5?= =?us-ascii?Q?O/mBi56gfYyT0s/AhHWZMhZnBOGhOc7ApRpfDf3Ttp5kYZH41mE8goHKnM7q?= =?us-ascii?Q?Si/DGDNcn5KS4Rb/2wQ/pF+G7Qd2HsJA6VFq5/ba/XrN0njDV+c2ljPkrWDQ?= =?us-ascii?Q?vIemLps57oNqo/ytgkeJlST0qIRkJQVzg8VlEsYA0aLgyJoPb3KeCCIc/+4c?= =?us-ascii?Q?bQct0EEP/HIMpCFgL4w50BQ+9beBz5WPTKQb32B//HSxP6XXV0xdmS4HiF09?= =?us-ascii?Q?x6xL17LjMypzFEUkHxNIttBRIHFH04TlcgB80LIawx5f1RxohABol/rapggn?= =?us-ascii?Q?Fsemo3L58wOuQstHjbSpC7eTyeJJdcDEgwr4pgGKWq7Brs5ruYt6t/LCmnrA?= =?us-ascii?Q?s/pb4V3/ed9+7pWh2nG0pxCgacX11QyKRuhfyiXwduK7H7HoyGAkQmt8PnDq?= =?us-ascii?Q?YBO02EAyNaYKCDfsDZu7M35H?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43315b97-0676-42b3-1c62-08d961640b20 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 09:47:36.0166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: csy/9hygJEc/2dzLQwfJdYf3y+i4atvUGP63KYs0hp+ds7RpkkSlHm+SkaCOA25UHfJN8Ag8bdy2dBXLXASNow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5552 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for inner tunnel VLAN X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Lior Margalit > Sent: Tuesday, August 3, 2021 9:13 PM > To: Matan Azrad > Cc: dev@dpdk.org; Lior Margalit ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for inner tunn= el > VLAN >=20 > The RSS expansion alg is using a graph to find the possible expansion > paths. The VLAN item in the flow pattern requires special treatment, > because it should not be added implicitly by the expansion alg. > If the flow pattern ends with ETH item, the pattern will be expanded > with IPv4 and IPv6. For example: > testpmd> flow create ... eth / end actions rss / end > ETH END > ETH IPV4 END > ETH IPV6 END > If a VLAN item follows the ETH item in the flow pattern, the pattern > will be expanded with IPv4 and IPv6 following the VLAN item. > For example: > testpmd> flow create ... eth / vlan / end actions rss level 1 / end > ETH VLAN END > ETH VLAN IPV4 END > ETH VLAN IPV6 END >=20 > The case of inner tunnel VLAN item was not taken care of so the flow > pattern did not expand with IPv6 and IPv4 as expected. > Example with inner VLAN: > testpmd> flow create ... / vxlan / eth / vlan / end actions rss level 2 > / end > The current result of the expansion alg: > ETH IPV6 UDP VXLAN ETH VLAN END > The expected result of the expansion alg: > ETH IPV6 UDP VXLAN ETH VLAN END > ETH IPV6 UDP VXLAN ETH VLAN IPV4 END > ETH IPV6 UDP VXLAN ETH VLAN IPV6 END >=20 > The fix is to introduce a new flag to set on a graph expansion node > to apply the 'explicit' behavior, meaning the node is not added to > the expanded pattern, if it is not found in the flow pattern, but the > expansion alg can go deeper to its next nodes. >=20 > Fixes: c7870bfe09dc ("ethdev: move RSS expansion code to mlx5 driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Lior Margalit > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh