From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75D48A0C47 for ; Tue, 6 Jul 2021 14:46:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 698874128B; Tue, 6 Jul 2021 14:46:27 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2044.outbound.protection.outlook.com [40.107.223.44]) by mails.dpdk.org (Postfix) with ESMTP id 39D014128B; Tue, 6 Jul 2021 14:46:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ob/IVCS3YG3minjlx87px5KCK6llmNfYXD41o6JigLdBNIoFORmTqb03QkQ56H5j29mqgDCjQlPAr3fhl/sRIBoeqfNxnjLIP5nBP0BXDhrkg9zhRMkZGSJrZWobNsVCRqzzisgAkaa4SRHprm/zYQf33WkoAYQ4YMrE0/I/HdeKbNWt6heSusduAJ7G1to3/4i5gx6KWE2I4yV5FNi9l/dK1ET6hbLIEno2smjBWj3kkfj2tRHnhGIMWC/DhPHhwzRq48IlqaVpBLfqzXq1RNkTIp+KjuNVTeN5FdtBpmSWnZRznDapGcbih/gxhjayFzOjObU460JBjx04df3v5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ZOCXMgTVraT1p9s29eIlP+kzwLJhauT2e6DVkYLm/k=; b=A6ClQP1/y9wm6/twB5wneIqmwcvlfqofJYoVVjJGJxPm+SrAtbr4cxwIdY7C21WMazMKrKO9Ws1JTT6VrdfJNZuf/tBoL4XBa5J0m8z/4jdMGqcv8JahfoIhuu0FDDZUsCxBIhyxCnEmKjVXpZ5zkdWpfhxpUDQhQb8sP+YwrW72pMxaLJul7q5zUTRjpyW3/yAQwz/5BBzzsum+XPHTX2ph3gIeJIQFb1z/UvzOeEhntlz9aLPvTNwka2TW4r8QalUa1D0rmeshw94viv11XM6l7Ja1S0JyYgUxE7+KbCa2ZZad/7H6kAxYSAWNAc7/GXYFROR42xcjbTFprsas0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ZOCXMgTVraT1p9s29eIlP+kzwLJhauT2e6DVkYLm/k=; b=jbmNrGVhzVOT/mz3UTECt5wPy4n49V+DUITAdKn7ELwUdGLqO6I8nIHaRHBYiqPHb2BbzaFHdAa6BLGBe1JOZHeXu0Hp5x5+IArw7rDOaQgR9958JKwA1zbzvHdHXhTuU0WeIxjmrs9chosCgLmy8d3gr26J3nJ0VfEvzQvoOXo8p3/aqYo6fJTifnQUc5oLCjZ7CXbVf6DiTUMCRf8WRcauZ1kmOIWeglLL3NFTrUDGeLdXGF/IaaKy0uhBLuxcm6g2NKpf1212DSPtWgGr8/wpTZ+VEsv5ZmdbXuIxdqWocqMz2mcUa0vAfSCBrE7zA073+384Vp5fLojlP/rr6g== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM4PR12MB5246.namprd12.prod.outlook.com (2603:10b6:5:399::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.30; Tue, 6 Jul 2021 12:46:25 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a%4]) with mapi id 15.20.4287.033; Tue, 6 Jul 2021 12:46:25 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix offset calculation for modify field action Thread-Index: AQHXcYLO4/dy+KePi0O+LPmN/dobJKs15sFg Date: Tue, 6 Jul 2021 12:46:24 +0000 Message-ID: References: <20210705094704.26585-1-akozyrev@nvidia.com> In-Reply-To: <20210705094704.26585-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1523dbb9-c536-4fbd-6de1-08d9407c10c4 x-ms-traffictypediagnostic: DM4PR12MB5246: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CAGHZDAirYQ/aX3zhogrUC8deIntpUcP3/et2PKavyJLeBR+ywULNltovAgqFnKcZjPEv6zQ2bQl5ev3UVj31lUMd0OFF9TVfS+wKS+rWo1hT8ZZHzVsXvRVKY+ogYdUXND4aHLbNATNl7v6VRtZBZcC2Bh3tboAd3ZxrJVdhB9sRJ1lY57dgHed1ZPuWVyo4yqlaKubCaL6XeGDVOq2o8XqU7oCaMpXL/vV/6245B7C1ojj/OiuKdRc8BF+aKEeSTvIvYl7U8HlxARlg8IgedAfTarHyIOAoVilEsctppy1mXIoVGM3J2cPatS63hggTKfHgCLiARyyfBbzyaeu1+9ax5yoGTOG8wdtS543N6WdgDZWU8ZeeSB4LcHHMFHbFI5xUsWLRzhRB2gtyMLa2bxfc+3cT4BLg2P4kaO/9Z0REmfNnMk6L3LuAA4fuAk1yN+wSashpzDekCTY67pePzxpYkHHWHJiEYMJXz12l4QUG+FhXBokT0CBpicoHOxLfGzcLtiDAek0XVxxT5tuWMtUs1G1xwap3HgpVLUamgOEwfEaHyYPQVZ5BomL+soKxtpcb+rAUo4EnktOeIEO2G6EvphaWeXZttXRlvOsN0EWxFxUHkc2GlI+6f8WztPDNyfZNtl5Tju++3J6PILJ1Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(66946007)(107886003)(8676002)(4326008)(55016002)(316002)(54906003)(66476007)(66446008)(52536014)(66556008)(2906002)(450100002)(9686003)(110136005)(76116006)(5660300002)(4744005)(8936002)(64756008)(7696005)(83380400001)(38100700002)(86362001)(478600001)(71200400001)(186003)(122000001)(6506007)(33656002)(26005)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?664DoX7KsXgynjl7VFbSZ8iCYDqQBhxrp04b2AlIc2/buC9v9s7v6/TgJl0B?= =?us-ascii?Q?DiyBqbsMMpuXxlTs9hbm5AoJi0lZtMp0Q436DrKOFlEYB1Ds7tnh+W5NOQ6o?= =?us-ascii?Q?SYrZU+0jDHnndQk57ymcIwmvdUtKjp5Z9nys3T0GlRbdPEAJV5f9rHufbLE3?= =?us-ascii?Q?2iCSjNYlBExdTJ4Pxagf8PpLg3CIuKT8RgV00EYkFQJLG1x5kR5w+CnwTY0C?= =?us-ascii?Q?1NnsTU0/NKjmdAfvSSM7av4oPz5el59Qh5sw9vItOMlCivf+PRskK56m0eus?= =?us-ascii?Q?NjI3mjxI4mbA4Vw+6CUUyv5nrp4Qmc89dCsBPMIIwBYR5x7P1cRz1Q4ZOPDb?= =?us-ascii?Q?2E9KUB50qOtr6xrHNm4YvXeqsP5nKAZzhqsaGd6KnwjQ9IiQD+TIkvPW1Xnk?= =?us-ascii?Q?TVcRGUqXMffoyrOCprYtp4nSunNUdlprAn33x0uV5lHGrI+ihxsohiJOwZby?= =?us-ascii?Q?XpHUBwJHBPLWzpa84FdnB/P9Jk92ba54zr5v6IFp3vpXi2MJjZgfEn4aUz/e?= =?us-ascii?Q?Ig7rqwJlu2Td2Mj0BGuJlThZE2DI2DlmmV7ytV8GwYwZ0QCQ3ImPnY8a9Us5?= =?us-ascii?Q?JPrdprIi805kv2IOpfiDyRF8+djjivV6937xeeScRLEPn0gjOq7OZgzq+POT?= =?us-ascii?Q?DMyqA9iJneK4kr7VSr+GpWJDVil6bkMEBs6bic+An0zJbkewULKgrcDKCNzN?= =?us-ascii?Q?ItEleSeqBYqKqtxMHpmeD4MzRQcTZfjftMIxj1R7oGxSlPVZyhT6WDdGPGiV?= =?us-ascii?Q?YvwLgzdu26tP0TUANyjSbbN6NXYh8zpyiR5rNJwvmfUdiHKF/sxwEafcaRsz?= =?us-ascii?Q?v4fNm+sQxeYYB0fidOJ4Tt9CHufN+ZafvclZJarFbIz9gBDrXDEqv78zCtqA?= =?us-ascii?Q?SOwS0lVnyy63+3lzPQ30pQqgShOwI/sOoXycut7hqmcfQ2u7i/r7HfZvVb7r?= =?us-ascii?Q?RPLkjbB1NXhAubI4WGezwpLeP6u09Pl+YMLBEdKW9QRE7gC9HCUxmfjngJBm?= =?us-ascii?Q?pdt9llsSMMYS3nyf6lyRDklYO68yYA/Lf1Q5bfD/AwY29f2sV3TZsDqgpSNO?= =?us-ascii?Q?cIU6k5BZW6DwM3PRGb8R+HvpMvV/KnQHjldZHdBpxVkKZmsJ56etZTFaA/GQ?= =?us-ascii?Q?tWYr72bCZKl2a2+qhS2KtSgDxKZAHlJk+UUF3apHcz05+qsJArv0jd5V45N2?= =?us-ascii?Q?diXPfV2VzPSiNUZ/OziHKov8U2QE/DaToWigHS053ZxY/Hi5Ovpzq93voqKl?= =?us-ascii?Q?Jry06zTVVbEe1ZGqXWSfoGNnwviWsdZYsPLJsjdu8jUwG4YK+uINBKnHltY5?= =?us-ascii?Q?vYxnvNnLbifwjB8ho/tZRUpL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1523dbb9-c536-4fbd-6de1-08d9407c10c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2021 12:46:25.0200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PXD4XCdzQgK22/BeekPt70j0P1RSGppRDI/5AJcE/AaTiGjkWdhIenSpctN0PmidDBbR/0qAqbm9ESZqemA9PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5246 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix offset calculation for modify field action X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Monday, July 5, 2021 12:47 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix offset calculation for modify field action >=20 > Offsets are not taken into account during MAC addresses > manipulation for the MODIFY_FIELD action. That leads to > a wrong split between 0-15 and 16-47 bits and corrupted > data being copied to/from MAC addresses. Use both source > and destination offsets to calcucate the proper modify > header action specification. >=20 > Fixes: fdd0c046f4 ("net/mlx5: fix modify field action order for MAC") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh