From: Raslan Darawsheh <rasland@nvidia.com>
To: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Shahaf Shuler <shahafs@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation
Date: Wed, 28 Jul 2021 13:07:36 +0000 [thread overview]
Message-ID: <DM4PR12MB5054AE3852073D5A7CBA5059CFEA9@DM4PR12MB5054.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210726062233.30657-1-jiaweiw@nvidia.com>
Hi,
> -----Original Message-----
> From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Sent: Monday, July 26, 2021 9:23 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; Shahaf Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation
>
> Due to hardware limitations, the decap action (such as
> VXLAN/NVGRE/RAW decap) can't follow the sample action in the
> same flow, to keep the original action order of sample and decap
> actions the flow was internally split into two subflows by PMD,
> the sample action was moved into prefix subflow in the original table,
> and decap action was moved into suffix subflow in the new table.
>
> There is a specific combination of raw decap and raw encap actions
> to specify "L3 encapsulation" packet transformation - raw decap action
> to remove L2 header and raw encap to add the tunnel header.
> This specific L3 encapsulation is encoded as a single packet reformat
> hardware transaction and is supported by hardware after sample
> action (no hardware limitations for packet reformat).
>
> The "L3 encapsulation" with mirror actions in the same flow was not handled
> correctly in the previous commit.
> The patch checks whether the decap action is part of "L3 encapsulation"
> and does not move the decap action into suffix subflow for the case.
>
> Fixes: cafd87f62a06 ("net/mlx5: fix VLAN push/pop and decap actions with
> mirror")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v2: update commit log
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-07-28 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 12:43 [dpdk-stable] [PATCH] " Jiawei Wang
2021-07-23 12:57 ` Thomas Monjalon
2021-07-23 14:01 ` Jiawei(Jonny) Wang
2021-07-23 14:09 ` Thomas Monjalon
2021-07-26 6:26 ` Jiawei(Jonny) Wang
2021-07-26 6:22 ` [dpdk-stable] [PATCH v2] " Jiawei Wang
2021-07-28 13:07 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5054AE3852073D5A7CBA5059CFEA9@DM4PR12MB5054.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=jiaweiw@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).