From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31155A0C4A for ; Wed, 14 Jul 2021 13:57:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2146641331; Wed, 14 Jul 2021 13:57:21 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2085.outbound.protection.outlook.com [40.107.223.85]) by mails.dpdk.org (Postfix) with ESMTP id E922F4069F; Wed, 14 Jul 2021 13:57:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1Ct3YWQuY2k+cob+so3l3XbE/BR1J/IchSU2i5xZhkPygawZ95g9GEMPtvKzrJi+iRN44D2IfjGlTmuQpltnwslWQ2KCNzEEHQfe84HNinCvxFABZQM1gcUatoYeWf+GyX+HTDe0dLL8VHGSTTZAGsmmuxHR8JSBPKgZ6a/+5d6oYHboltkoaSzDyGBos5nZa1FPtofGjqLw1UCoidaXQ/uQmuzzg3ojI+W600updfH3U5SJ2qK4LZWpO1cwE8TscTlPIAPb/FNnzQf/9Xb6e7+W3PDY7yylki/DfzB+IuesTdPEy7CeoxsjFb+ayNvD5cK4Tl6qpqyH4L8NweALw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=scL2tWYJl9WUw2QigO/KMluM8RBc2zoEb/2p+Tg5Sz0=; b=TlPvcOey8VZ8luzD5TROUZCd7BcNe0wpIiqy9Dl8//FFU6NAmDcBBYpLiYpIV3I+W2lIG86iRtRYw10K7D6QHtXxzZYpbVhVyKfmAdd5o78ks59xSxiq3R6NXsmAwJTKlywO2Rfw4lmYCMMQGFM0cVNrul62uYgSK505s6uwRZjvleQX2zXygu5FQHE+XcR9GrofKL/7IBxm4aEhZolSDSjak4jpi9Kip7Ea5UC2ylojRLOaixW7Yrh1074dz4+kPQ0LRDgKVpPH3adR+X54HKgTDyzD2OmMCmxqk6L7anKTDPnExxjrY6QTOKA6mR3jHE3QZTbnjtyq6RLmQHmL0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=scL2tWYJl9WUw2QigO/KMluM8RBc2zoEb/2p+Tg5Sz0=; b=mz5a7uKRq87GUFFrFAoOeF2mORiDlHEg33pKN+JjtYJA906ONC2qWdy62HkZVVlcYMNXLV1aM6k4EQr4Aiyu6wz9g1rAi0LeIVAuG6uVjqlsOcY1urn7bNmVrFxshl7i+7c7q9NYYYqggBUrM80rsx4oN6DpZiWjXC4YqQNSrgcyQf3+cEMbiQ+55WG3vWOgc3DKDO2jIFmhbk4yGrdlPgvCJZa1Bfq7yw6ZMy9UFvjPqspT+kN/OhoJMEB5KSVxCZ+N0KVmjO9rAp1KHCspcnJnrGeaTs8U157S4oxThCiryPk4bkLV4WSjZYD7sfKJ70G4kNzdQBNErSwsM/jgHw== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM4PR12MB5168.namprd12.prod.outlook.com (2603:10b6:5:397::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Wed, 14 Jul 2021 11:57:17 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a%4]) with mapi id 15.20.4331.021; Wed, 14 Jul 2021 11:57:17 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix threshold for mbuf replenishment in MPRQ Thread-Index: AQHXd/rH5E4cfB+Kn0uTgahTz53+RqtCXrmg Date: Wed, 14 Jul 2021 11:57:17 +0000 Message-ID: References: <20210712142910.314572-1-akozyrev@nvidia.com> <20210713152112.393741-1-akozyrev@nvidia.com> In-Reply-To: <20210713152112.393741-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b9e83b6-2192-412b-2a6d-08d946be873f x-ms-traffictypediagnostic: DM4PR12MB5168: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RHwnmVooAj/Kunx29EuqFzwc0DcRJczLVx2fXa6j1PqWtuVA5zblfe+xA++ub2SGtYfuQbcdv9e/CTGxdG/rI93z3jYxEHxrHldtyrggPTec1S6eA7524YdVZXHNiaFrdN0Q6QF3P6nN+/ZD8BllUsL9cc45oXqdKoqltk2pWvwdsIg4Iz3R25c5IFqPEor3KOpxiAiqZOZye3CwVZkIAX7Cw9de5vg41Su1B1V0lAvafNg/QijVzk3PEedL1Y2w58cNqdo0n3FHhzRasX2KvuggwxUhGZ0eH7Ocp8EL26JzaKnrlChDpp2wisFu1n3DP4k+ZXapKB39sXEv9BhKaQbUROCnFBzZjhzZfZTzLDNhjwEUhrfjX3bVppTphntkyG0mxtg37lpYd+Zhrr1G7pokAkY4eXjHX6sIu3UgYOzPVAIqma1sieVTsf6S0lwr//zPDoj3LJcGdbxvHVmos797FcmqcYv2kj3Pbb6sQMlJpRAWyXmUDlv7V34H4aJ3PiaY3IqGmpzOuoJqmSlzGnhdFKvig2D/Xu2Zajpeglpm/w4JJRlkA0pUbLYiBBEgoH0ucxoSrEKvYTtKD1gxYj4wZVY9XssIgrKRzXts/Lh7k3/cNe1a2a69hb7C9upF5KLxVaw+1+SFJ+x42yxZ5kAMQj/Rv1b/1sGuNOV65i6ZP62VebYkiHBGcGQIYu5G2F3nUH67jD6LG81uu6sZjFjYQwI3AX1QDxUZQyazk/1G4bhlKwQcejdQamzqoqegReLiIHDD3KcLP51ceYYSWYCUXfamtOX5Jd60UFm/d7k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(136003)(376002)(366004)(396003)(76116006)(122000001)(8676002)(8936002)(38100700002)(450100002)(4326008)(66446008)(83380400001)(54906003)(9686003)(33656002)(7696005)(110136005)(86362001)(2906002)(186003)(26005)(55016002)(66946007)(66476007)(316002)(64756008)(66556008)(6506007)(478600001)(966005)(53546011)(5660300002)(71200400001)(52536014)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ms02m3C+lYH/WwbsTfPzeU8+j4rWF8dGZTVZL61cV6KCB9CLdNJiB3xQcEbU?= =?us-ascii?Q?iAuK0j/EE5UGj2hKqkpI6Iw6MgGslK7Os1VGQF64a9RfOm3NJVIyB7uYVV1r?= =?us-ascii?Q?nU8he/9piWbAX4vBr0G9hdcEV68hTcW1f9rtQ0GOzv9zPev/m8H5uB/HgXQ6?= =?us-ascii?Q?To4u7TvxzL5rNk+uez3Z8BTrGtOi3cizZTVL2pokx2LgDnRZhgEuworSpwH9?= =?us-ascii?Q?osA4g+r5SvM9WX2aJ6bvkQPYA73LsLtOSaEZfMZb0o5yLwS/CeUGEWUajmJZ?= =?us-ascii?Q?F7R0dVRavERhu9ktsgci+CLUaUC/iKLsLTa87xeaKFNG5TzmeCjpCvF76N45?= =?us-ascii?Q?B1ntHpTb48cFQOhhKMwNg9pPQp9AKioM9NzYZVDWhRy6EbUNKqfibhsrubQD?= =?us-ascii?Q?B8e+uX/hI5W+xSRVHhulnMmW9ZupwRtcamGjlLdb04RFG8rdr0TL41oqnRaj?= =?us-ascii?Q?E4+VO5VLYN9F9k7x+cWtdrm/kt5Hl86Bt7Z3Bp2CLcAga3WxVQb23yhiE9/+?= =?us-ascii?Q?br4cdPTmwKbCbY43WU/G6lSMuIqXkaxn+2JM0An78aa9+rzTQRGw8QcdrOop?= =?us-ascii?Q?4svvKFJGA4HhAWRznGiw56RUrksqiEEyiXve+Bm61NpD3cESqB2XDJlHA5w0?= =?us-ascii?Q?CYHJ9NH9vQwx9TIXy1LHVuYed5wCgZMeYbTuVZLH52ZenuMUQYtqIgivDnl+?= =?us-ascii?Q?aswi92VE3PpofxI1XiNYqOxNHgwbHS9ue6im7gb6BbxuF/jHXk5gDlw+zJJ1?= =?us-ascii?Q?/J7T2UYMFFW2ZhcgMfFm4Zc2GdjlNlIpe8ilFZNqcYownmAnMHwr5D2dH1Bn?= =?us-ascii?Q?gTrbLF3KkEMXviWYe8cv9wk0TA/dkLXY600tApDGVDEHz2wnFVa9TSBXY/SE?= =?us-ascii?Q?l6frsKYFa+R2B7EOOowh+MAnQUugv7RGXkakgpV+3VwRJ4Omm9U8By5qL8b/?= =?us-ascii?Q?glBrcZAn44XTV8/nJ4ZqrNcW3DpV7w/ismSikS6lU7Y2iLyWlV7Uun9Uo1UN?= =?us-ascii?Q?rj+wJ2WQzbamJ9LHSvfUzffcNpLRBLmJpFaMNif0G7cetXFmyCIcfrcFaqSC?= =?us-ascii?Q?dkZ2/X5GLf7WBfl843kq0Irg8ls29S9KEs4narXZrLHyLgadKbxqUERc6FdK?= =?us-ascii?Q?gWXieNCv9nWELTNwDd9+z7UpC15niJwH+CBBXfuTpFVXQtQ7WufcN5vxsxLZ?= =?us-ascii?Q?ShfJcPbZ/CWZYvE93s1620/47wsEz4/ADTmkzPAhMzi+004mJqX7MUslJyH4?= =?us-ascii?Q?jk9QXOadfvgsyI7Xzlrc3NWNcnUruPXjur7mVFII2O36GWBXEsx3RG52/bBx?= =?us-ascii?Q?wO4+WGadL9YVeYZOz+OndSKB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b9e83b6-2192-412b-2a6d-08d946be873f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 11:57:17.5394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c90F4JevEAFrZzDzEdYpVCVfp1F4Vyo/NjpOsAy57YRWJv2rg4E94YT994I/t2opK26pD041wMMsTV8EkYMkdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5168 Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix threshold for mbuf replenishment in MPRQ X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Tuesday, July 13, 2021 6:21 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix threshold for mbuf replenishment in MPR= Q >=20 > The replenishment scheme for the vectorized MPRQ Rx burst aims > to improve the cache locality by allocating new mbufs only when > there are almost no mbufs left: one burst gap between allocated > and consumed indexes. >=20 > This gap is not big enough to accommodate a corner case when we > have a very aggressive CQE compression with multiple regular CQEs > at the beginning and 64 zipped CQEs at the end. >=20 > Need to keep in mind this case and extend the replenishment > threshold by MLX5_VPMD_RX_MAX_BURST (64) to avoid mbuf overflow. >=20 > Fixes: 5fc2e5c27d6 ("net/mlx5: fix mbuf overflow in vectorized MPRQ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- >=20 > v2: increased the replenishment gap to MLX5_VPMD_RX_MAX_BURST > v1: > https://patchwork.dpdk.org/project/dpdk/patch/20210712142910.314572-1- > akozyrev@nvidia.com/ >=20 > drivers/net/mlx5/mlx5_rxtx_vec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh