From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 769DB44077 for ; Mon, 20 May 2024 12:41:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 691D440695; Mon, 20 May 2024 12:41:41 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2081.outbound.protection.outlook.com [40.107.94.81]) by mails.dpdk.org (Postfix) with ESMTP id 4C48A40693; Mon, 20 May 2024 12:41:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I63vVlohZm4t3SpaPMOH9QQJwQEJG5gzHxOZy4ywGKufLJAUvUcU1apq9G/4+TR3zJNYSUdR2VWU4vMV0QGA2KIJB29rqTluHFqYrHKAGmgwuIi0D6WhLEhvtRULyDrfHysWjjmmnwy1NlHdw5A+7L7bg/cr6vuDiP99ZrvoHyp+vB29x0Ey8mPXG5WGCxVcXD1OvbsagCaov5Jo1FBIrqxUZ9KsCoQiD0tT2UGZ4gvOi1j5xnMyErwG1TTulClrBbiT7ncp2BIKWFDkbxEaC4290bGHs5TJ/WjwrZSWmdycgw2XwmqYrEWq/+68aCvMQAZsjO2yPCspZ+D3t/+LUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DWjtIuEEnxbZHU2Jf1iKpnPI5bVPIgHYW9TaRRhTkPg=; b=DGPVzT23k8LpBWonkCHeQg8evsX70ElZWSuHqsTGo4EHX514mGC+AhZyZvayYdzliy2UkeX4Dm9/8aIBIfC1j+D8Yzkfe0xgQ0H2PZKWxb/L/oI9ySkBmwKoOYmOVstWnlOUajMLPMA4JCy1dDp6dZv41vLyarXM6crGYbm5VErQLISK4qYr9xQ7QCFjRANS4Yipqy2FptM2OVlKgYtvydoNzktS82hTuKqJyqe38PBFRBfJofoq6SyIQ2YxZkaLgWb0/9AAwOSxKXg3chiVdA1KzPPt8CbzHKsc4OGEFzlKrjj7SuTkFiKUZYH2G3ZRaecTld6td6RcAQEcBjcICQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DWjtIuEEnxbZHU2Jf1iKpnPI5bVPIgHYW9TaRRhTkPg=; b=3kJ1Ax5CFHqYEMWZsJqx52tNLnW7lFf+haJoKz8KYCh8IwNKOTmxhrYbJPWjpALaqFYgdcr2LfWRloDoRZBpNKrZg0nHjj6nz4PKE60hj6f1RvXPpkAkb4sG+0YPwRw2hOXQb18wLtFkdaJpaIMNIquZTFbzJreXdeP/nTRnKg0= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by CY8PR12MB7123.namprd12.prod.outlook.com (2603:10b6:930:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 10:41:37 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:41:37 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v2 06/25] net/axgbe: yellow carp devices do not need rrc Thread-Topic: [PATCH v2 06/25] net/axgbe: yellow carp devices do not need rrc Thread-Index: AQHaoHw2RYsv2QXnzUiurLec6gmoxLGgA5cA Date: Mon, 20 May 2024 10:41:37 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-6-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-6-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=695d2904-c53e-488e-b84b-2c071315e833; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:41:33Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|CY8PR12MB7123:EE_ x-ms-office365-filtering-correlation-id: 92393a86-5bec-4596-3c3d-08dc78b96cf5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?wAHg2IMLBkVDKILvyd+VFz96B0qYzvk2ynwizCoe9DPF00rQx+TbmLRRwA6m?= =?us-ascii?Q?rrizwiOu200RQ47lLtC062CO8YcdhQAl4nMOZSgPgASOlU5qU/tXInWmSChb?= =?us-ascii?Q?Oo2+r1krfurimogeNCmEsz+Yum6XVBOy9bD4WXoWjnExNWRO9QJNE8J/fPDt?= =?us-ascii?Q?UybqR4Bj8o0PxgU3PCAhBlDpKsi4AreYZLD2dj0mRFIrGXblLd/ZPXVhzNsH?= =?us-ascii?Q?x3RXUGj2OkCE8tSqDAUo+v2wQcPYvkxGtY3bAXRgtFAz5mFbwXChUTmBdMkD?= =?us-ascii?Q?/jbJTH8NyM9u4kGiZ6RumcQG4+1t7BNmKNG2RlQ1AO1yGhwOEdpQe1D76wHm?= =?us-ascii?Q?W+DF7QhssNVPZA8gaVY+eDkFKQrwiZHXXMPd0AEuktEKppGBDVftXdudVpsh?= =?us-ascii?Q?OUx9NOxvxGyTd8lTCxLW2rXlNm6uFw8zYNx+tyfNOYiTbGa4y8oVr+gvj/jH?= =?us-ascii?Q?FTfnPXV+tPwtIxb2Shr+cVzo0oq44P4Yk0Mi0DqVBbwZ9mm9h13cW/2moz3b?= =?us-ascii?Q?/fM9od8AVy6hOMc3PvYzTt2zvq7d5g2UV0GrvWdzmlSZrmmXcFa26tZWgELd?= =?us-ascii?Q?kVQiJ4FxM85BridrJhtwATFa/SuYYwcA9O27Cm4jpsYkEvYb/JOdjnHgHwaq?= =?us-ascii?Q?VCY7BJFmEY3ZaGVEpFv4VIWRLA8bnjYnNUSsW2wrWI9ETuAoCc5w34ub2BY7?= =?us-ascii?Q?AjlY2VRZzX/JvOTFaeVZIqoBlZntuJ4j8jrbPmPviuA1c6Qs3p/ky1eOgW4y?= =?us-ascii?Q?QUK7IRbkL2I9bqxHxqYuhQufQLQS9VARyRSTZdAuHRg/Bf+WXqJ6uXW5of37?= =?us-ascii?Q?cXxFT4+lXBvROpHThHtsVOda7Ig9Bds2Vg4SutDD9VE6zTTUyDfv+V8BeJzw?= =?us-ascii?Q?IBOIb4RLUGHSnuT3PfAglJ6tgFIk9bc6JxSi5ojS2XdRYK3hg2DEQ0THXUxY?= =?us-ascii?Q?BqSnYQUPjWt51pLe8gDFxgfbniButeeySHULVaUxg0O0fvsHYZkgTC8TajFA?= =?us-ascii?Q?wuiRbPtfUClRJ976Qf7uATVQUcaTn2u/mCtpr8VAMYN1caSkU6YdQb9I5qjB?= =?us-ascii?Q?UV1YG7AWNsZYmtc5nMjcCzdMjt1tOA1pTjJM5vE6LU2yTqBba1TmxCK7FDMn?= =?us-ascii?Q?HQ0GLVsPRKmVtThORoqDonucRSPGChBvPQMRjiNGQQx54QcmjB8pAev8Vku0?= =?us-ascii?Q?Mkm0x09VYJu1bJY0AuniwTPhA1XcUE+vXz7ASh00HNp46ohMGRkraw/sCz2F?= =?us-ascii?Q?F483J8kghzSQQ6geRogtSNWvEwWRekdDck89MmsvGKg0DC18XURMaigbCLSI?= =?us-ascii?Q?9JAPi00yqlkMo4nLEgc/O0icSC5Vw/a6eGOJF8ovMGRakA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NN3jDWEtLd/iwbbfH5fjHXbbgySql88MuxPKK/KTMsN0lHGz4rvYgeubwB0f?= =?us-ascii?Q?wkLiZ2qTfyrRmQMHwaJUlHM27FT1hEYu35ah7Mj3ErJNNcTet1yrRdukWOav?= =?us-ascii?Q?+6m7tjtgZSz+K5BnFsYcbfzMuL9C1EivCEPYf/wZSUTwz352pECmymFlMPVe?= =?us-ascii?Q?iLzm3F1GI5WHA46+O89EIBoh/oRXWXFOUorPmJYWgzknfrKbyp6xgjsdl7gJ?= =?us-ascii?Q?maTGtHQLtDL88ZBJ4hr6hIEDqTsAfJSIqhMyfyc5/3qo7LPi+yKFNO30emdB?= =?us-ascii?Q?NroNY+sqAKtUvHFwcTjyqtJm/z7cqHFDbuaA2fBmtNuleDLtr4JZyuprCfqC?= =?us-ascii?Q?phsaKAJRR4YFJcWVGmNTzvmHfaXM/aSPNlSb5908fZScTDw5TIQj+UAsR/RL?= =?us-ascii?Q?hQBQO+k9lS4oirTU1auuyNKVWrdv7o4uH1GmRCjrDPFA45hZcfQSsXwuPyi0?= =?us-ascii?Q?8WepwvPiL8ffmMwomZZj0awA7nsk7Ps7K3utNKJBB0MbUBk03Ko1J3N52gmA?= =?us-ascii?Q?UEpfWXyVTnpwzhKnEa40t7rjxiCXC0jbey+CW+oM8FpgS/vw+F22kzhn73x0?= =?us-ascii?Q?FW2C26ALZTxDtBQ6NxoZPWErn/XnDB/EPMycKqZKO621u6FloN7DB5mKhs/O?= =?us-ascii?Q?TgT/eYQEdgV53iZcknzcDAlH6phrmPv3vaR3K78T3/phMYqV4XN8VfNbPRt+?= =?us-ascii?Q?nVg7vKsfNKsol8avM6D92giDtDj5t/62JInLOlqRe818km0S1kK5WlMJEbs1?= =?us-ascii?Q?iJ3DqV8hXDmotgK3iE5ynjvR9uobCm2aPIeyIL0iEXBPZgiiVmB4ZIzj0Cql?= =?us-ascii?Q?UiRMr5f3VNX6Vx/wb1t6C0UjiNb1B5fjFyNloTRmndyiLdowuSoq5KlAZMaq?= =?us-ascii?Q?76qlbaVkKsbrKWtTO5E20ERDziZ+xmszXPTAuj+Qmxh0kHXoLErQin11Gu/n?= =?us-ascii?Q?dfTdq69hIqvyfVnnERMItbO63TRsh6nOZdWMOqoC8/CyCgiZp595b7IV8ZG4?= =?us-ascii?Q?jxiopXdiZJAzKAm6z3R1f1RtC/bzUd5Jf8kxQGtueYtY56qlkJaZl5pm98xt?= =?us-ascii?Q?UPOm1qVgdoc0gXKv+SHVgq0M8PzTBcpFbpu09IIkz42K1nDzLuL7f7fBRInM?= =?us-ascii?Q?oX+/DXW7OYtfOAbvCI8zOxIkAm6FLphYEhZQ48xEH/mXGVjcWBlhaTUuMSyh?= =?us-ascii?Q?xuBF9zaQy3rNA8a4bbLlKLY68gR7BWd9VeUHL9R3Df2OOgrb58jyB/Fg07Wn?= =?us-ascii?Q?6zZ+FZARm+rxgKGPyFLl6zx8msIJXDcPPRs3Ea2EQBmml4m3Ly8Y5p11hAtp?= =?us-ascii?Q?BHJHW6higOH4Zigak4yoD1iypmw/P1BTIEE14qbgkCeM8TiyZDy3bpq0gCVh?= =?us-ascii?Q?NzHKSyiZJBr1DIijC1lDj5AX86j89ulYJg2OFFmQiU2foyfg+0Allu7VMlIQ?= =?us-ascii?Q?pHjSazEv46dtx73TyAPJr8SSAkibOma5Q/4qSTwpIa6nspEGxPzE4MohvC1y?= =?us-ascii?Q?oaeQCJTOTEesuQKzbyuQqOrHxEdHjDWi+3qGpUHJ8xrHK8hJ4TS6EMxk55pY?= =?us-ascii?Q?x15OtRBI3XRCRhnRQhYRf+fUvhp8SHdDWYEJAGCI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92393a86-5bec-4596-3c3d-08dc78b96cf5 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:41:37.1979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ar3fSnXhiy5eY7tJ6NrpC8XMfJ8lBiUeggc/LimoTyInp+2kFtbtglIxObu1VOtKW1l0VV7Nk2d377uBUlxv+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar ; stable@dpdk.org Subject: [PATCH v2 06/25] net/axgbe: yellow carp devices do not need rrc Link stability issues are noticed on Yellow carp platforms when Receiver Re= set Cycle is issued. Since the CDR workaround is disabled on these platform= s, the Receiver Reset Cycle is not needed. So, avoid issuing rrc on Yellow carp platforms. Without the fix the user will not get the link UP. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ drivers/net/axgbe/axgbe_ethdev.h | 1 + drivers/net/axgbe/axgbe_phy_impl.c | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_eth= dev.c index e5d8f7db02..86c2ec64e0 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -208,6 +208,7 @@ static struct axgbe_version_data axgbe_v2a =3D { .ecc_support =3D 1, .i2c_support =3D 1, .an_cdr_workaround =3D 1, + .enable_rrc =3D 1, }; static struct axgbe_version_data axgbe_v2b =3D { @@ -220,6 +221,7 @@ stati= c struct axgbe_version_data axgbe_v2b =3D { .ecc_support =3D 1, .i2c_support =3D 1, .an_cdr_workaround =3D 1, + .enable_rrc =3D 1, }; static const struct rte_eth_desc_lim rx_desc_lim =3D { @@ -2269,6 +2271,9 = @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) /* Yellow Carp devices do not need cdr workaround *= / pdata->vdata->an_cdr_workaround =3D 0; + + /* Yellow Carp devices do not need rrc */ + pdata->vdata->enable_rrc =3D 0; } else { unknown_cpu =3D 1; } diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_eth= dev.h index df5d63c493..f122dfd516 100644 --- a/drivers/net/axgbe/axgbe_ethdev.h +++ b/drivers/net/axgbe/axgbe_ethdev.h @@ -463,6 +463,7 @@ struct axgbe_version_data { unsigned int ecc_support; unsigned int i2c_support; unsigned int an_cdr_workaround; + unsigned int enable_rrc; }; struct axgbe_mmc_stats { diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index ee9dcbe3da..f51830f800 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1708,7 +1708,7 @@ static int axgbe_phy_link_status(struct axgbe_port *p= data, int *an_restart) } /* No link, attempt a receiver reset cycle */ - if (phy_data->rrc_count++) { + if (pdata->vdata->enable_rrc && phy_data->rrc_count++) { phy_data->rrc_count =3D 0; axgbe_phy_rrc(pdata); } -- 2.34.1