From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEFF244077 for ; Mon, 20 May 2024 12:41:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A5A140689; Mon, 20 May 2024 12:41:22 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by mails.dpdk.org (Postfix) with ESMTP id 470594064C; Mon, 20 May 2024 12:41:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VMzpHrxnKEYmkRvlWlI8ubc1nHd4f0uhD5/10IYeAcjA354tRcEdMgy5c1HNobP/jp3qVyh9AnXpTmLPm9fXuXTy9evPApdnwfZG1U7OfzFr29NYUcELedx0Rqzu6zanFEWTz8iafvsmRzgukgw9y6CUc8rP1rHT4oYoU90MNNsUIsVUVegsc2x4BH1zhQUwYDDp+u9tJkTvKwPO8mOW5z/Va3Di4FEsXluUucE4ZoU91b+/WLoPkduLmDOLLuuCpcd/Cv4RHCrGdMVEZoLDh1j+vKbxH6WvmYQiCV4rQ9yv46Z7luGm3pEURu0GMKTSzm5/n3iBOG53jR0o7/XonQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jA8CBgXVx2t01Z9MgPA9NaWrOU/qQJd7/owbJWGejc4=; b=Ud5M2u4hrVzA36J7nU75t4kTiVu9Pp+xOIasKWj3xTguqtOc21TbykAQR5+k1iGXqF0Wglw00qyw2waq4lqYgK8QgzBnRVJXYV6NGXbkFS73FwESYoFNVNVCjVgSWWaL5U9zESzGiOu+SG8AGpTkT62p9kwG9amTFP+FAPttdQDljLDEc2X8tLDwMtxSNvSZVr3BhT/pTEfAWPZhVm/oI2ZybpSgHKXfSRNWlJcsRO1sD+L7v32KS1zhcEA92Q/Ez1JxJGOvusEwmwNLRBnewlcxCMB5YBSztlQWz53vwoANZjET+SciHQSK5zVJ1pr29vcWoXPZ0cxDHRMv2xLmQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jA8CBgXVx2t01Z9MgPA9NaWrOU/qQJd7/owbJWGejc4=; b=DPdlQVWk3vxzWnSBWyoQ62GBZTPxSOg3/Z758rkp/Lze6nhDxYpB3PwzGXlUxlVoPgSQhA+4N6jnjqMi0WHXx0LNxpld4MwQJJ/cW/vlq4xq2rbHK+LOtdgQ42MXlgrl0IpVDMPKMVIXRVnx15NHqChovhhZkMdcV48oB7d/Iys= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by CY8PR12MB7123.namprd12.prod.outlook.com (2603:10b6:930:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 10:41:18 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:41:18 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v2 04/25] net/axgbe: update DMA coherency values Thread-Topic: [PATCH v2 04/25] net/axgbe: update DMA coherency values Thread-Index: AQHaoHwyxphuYxYGJ0e3oF2r6pJlW7GgA30w Date: Mon, 20 May 2024 10:41:18 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-4-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-4-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=31babbc2-746f-49b1-8b61-931113f540b9; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:41:11Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|CY8PR12MB7123:EE_ x-ms-office365-filtering-correlation-id: 549045df-b1ac-4677-c1b3-08dc78b96193 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?upTg9iQ6dbS9MseSgqJmG6IiVgFXIBgSMgzImboLgUxFlo8T+tCO3Dt8WH/Z?= =?us-ascii?Q?JT7PeeEdH3yW6F7SaPyNM/fjOT1lkflfDuD1sJBTijIy4nIg+DAgp3w8vlKC?= =?us-ascii?Q?xf24NqS3nC29EzC4mFNcngQ3r2CsxSRbI27axxoyMon5z13iIrr00Z0+Zd44?= =?us-ascii?Q?aD23/GQymIt8XAEcqAr9jOD2//a97HVj4G7Y6MoejFsuf4pyfU7ChrQL1JTz?= =?us-ascii?Q?/w3TnAo7WChO0VMhZ4uqWnBPPHt6bTP3aU2/BZYOYm3pm1bTXTdVh0NPFbuI?= =?us-ascii?Q?g6/Uhrjxgtxe8trSPAYurEJ6RXOK0Z0SAgnsKnbumytWKDdrigN5d76FrzkN?= =?us-ascii?Q?Q+ZbcFgPu84GgVah16mFGMuHj2vDYV/kXZ7q/m59QadqZE/JXHF/Kc4W8TDR?= =?us-ascii?Q?Clgy9nXRIxxRhLml8co2MbUdfrF545HKLCXP/lf+oHW+GBX5I39aZ/4uu+CS?= =?us-ascii?Q?Z3lCFTOPZjY5Jybf5HCE0/BMX49//0GDTZgFedYxkZasr2XV9wziWkAMKbzN?= =?us-ascii?Q?ObgiBcwbygoJgmtUPuysYv+qu10Wz2JaKnOMmjTHtrRT97SyikEQaZeN6L8E?= =?us-ascii?Q?iwWm+bOi50Ixaa8kyA8sR0FCCgOO+E59p5/DgiNfWa8zTaQpIJuuy+3sdmdo?= =?us-ascii?Q?JEEnSRZvyjnq/MJHHq9F6wiSOpFVAyJfVKDKotx9e8bHKUQdXt+tzZ3WB+Hi?= =?us-ascii?Q?X1xDWH/saExO3dP862DFPDHBVHAvUqoQzgP7JkfNqK0PSO41KEnIZ8JDQaGJ?= =?us-ascii?Q?n0N0l5Z0/Xd82CPBt2UwBtw35R98RFH9a6WkVtDOqsGleFO7hDyLShQo1BHH?= =?us-ascii?Q?iMSdjw65r5rx6pPr5cgxPVfSKWSutNFz7VWbBg3Zr85yQHTOQFUNFcB3RHii?= =?us-ascii?Q?xl7YOFR6wWvdwueOc1WfKlcpcFzImugC05LgjkwBkj/J732cCzaOj5LxcHSO?= =?us-ascii?Q?cqcPed21lB0inyeGVCsnthDfc+Tb4G4XIsvgFp0COzOubMQvyYuo92XvFVpO?= =?us-ascii?Q?Wl3DdhrMq12TrVN8Qc8xdSBEBNeDPIVufR1ZPd/Tf4xANS8vuHrK7c20hrp/?= =?us-ascii?Q?jvsLyGn6IssWcekkchxIjE1ZG74KdTtf5x4pctMNSCCO69R52okHLW176cRV?= =?us-ascii?Q?7z0fzo6gDl06h3bSMQ18Tm40yJ/pRjpT3vNunMGt27Gdu9BzV5t9+QAU3xsx?= =?us-ascii?Q?qT02vCTBetS9soXF0Fjn8PgsVY4TNJNHtvryf5mbi9OoyWXgqz1/F9TiYARg?= =?us-ascii?Q?qMJeJq6q7JyC47hi49DuQ6yxeo+i97EKtuGbJJeEeqazwSWYCZDKp03GTvhI?= =?us-ascii?Q?bGEt+JQyNkAOsDCapZquC3mmOpQSfWfUVz/jExXUQnkvyQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fzKW1R/OW586Z2T6zUvojszdYsnN1X9h0W5cqi5PaLbQEsZQMBv1KrSUN5e6?= =?us-ascii?Q?iKBPpRfFVgwFCZ0dAdoql75lCYxeoJcnVOznRbyO5SXZZJcw6rlJFnJ1A8CK?= =?us-ascii?Q?3X6Rz1FoKxzIjSck62qvtop20dvfM642LsADKBqDY8HQFqnNM0jE3p9ZciKE?= =?us-ascii?Q?p51pxlDMesCMR3mbHLKCEQEZMw9wOAcApN1GwCPL7hSTzq7ypVZF/rNGqCEb?= =?us-ascii?Q?w+6VpS4GPPYYBTTyB+MRlsMTSdvTCNmmOgNo032R5Hktnr96LtxsqdqW6eQ/?= =?us-ascii?Q?J6rByF6xmGU7o1MZnsYe6O543kEp5Rfy/sxhX8cDp0HQEDH2DqbJLZupOVdt?= =?us-ascii?Q?4/4NQpN3DY5HKivcF9QgKXngM89kFsLWouzU0BKhsPAWTMwcnDL3rmS9ro2E?= =?us-ascii?Q?3s8ZWVOHbMFX5Fc92AEUQvaiweWItvLPfOROOlo2fyVLULANL1IgZdGT+QEx?= =?us-ascii?Q?KgIUBgQGvbOltZR368Darj/88bnuNrGlnUynrVvUwZsKFntzW5ALr4nch7xK?= =?us-ascii?Q?iaeE3XWQYl0oZKfJOwbgEnm8CxuFlUcqz+s4VxjrmBiD9KMI8rmvpr1Zs++S?= =?us-ascii?Q?DwolAh0Dp7uimv9rqPFKDrja68LxQrVu14a+MxThWfKOzs9PGBIIkAv5K03h?= =?us-ascii?Q?er4+dy7orricR8ISPZEkGmECcUpBmOdEfUk6GKVHrfbP+zQsADOIrE9ByeSn?= =?us-ascii?Q?iEmMs+gRdz1JWsbU9q+88cQMKD95dAkISVidEubYxkFm3SUeUJeqx3RaX1Se?= =?us-ascii?Q?UiEPYMtUeAO4m/d6c8QruvWyg/6ui6u4U1W8d3z9ah938t4t7WCUD06Yt5Tu?= =?us-ascii?Q?AyeE9m7ByVpyN4Uxm0pUlphNNi5NmM7OZqhFflitB6zsyc43hESDsAarN1+A?= =?us-ascii?Q?/lHVVnOJZq5quKciE574H0SKUKp3mLouNcgvCT7uqBzSN8K2xmaGD6whHzKE?= =?us-ascii?Q?L2GAOamB3Be9gR2pneBZgXzW74+Fomm9l8Bxc2pCcC2OjeVPvAkT06jIKg2S?= =?us-ascii?Q?cp0kVNxSzxlV6EXCakkM7HFeKEAXVi/wlzQ28IEc8RkOyeYkmZUq+joGmrw2?= =?us-ascii?Q?m0PmVFjgcUWGiau6mAiWBukQ4+TymBbObsSd0CAka2QXtLFgag9QlmshHYQa?= =?us-ascii?Q?V9C+LLwSByQJ6b4aJncKGOxp4xH+hztsthQFNYJLy4DnvQef3AVq3QZNedgD?= =?us-ascii?Q?3hWrVdLE2kXN3kpyjPnBf/AdoDSzhiD7hLbjUw52ltwL2WYvLMlnGT5GZDnw?= =?us-ascii?Q?UPHIAzmFTpY5gkiqAWO2EvFdrmqhx1uUuiwTxClbRTS5JAiXFmVm7aH8KhXy?= =?us-ascii?Q?9ocXollnJycagBXtQOYmI03q8/ahlGPlru9IW63bvbHoNZyhBfTCpKWqR8fu?= =?us-ascii?Q?MxXBnfYvfP8NCIvmNKCNoz2sokLZPxCnCgvHb1WW7TwTigzLaRjMPJ9OhEM1?= =?us-ascii?Q?g1KOTM/20lyyNNDTsR0aUkTGNQaynHIOKn2J5/CJEKMEATb9y16ZJiRXeHgD?= =?us-ascii?Q?MaXzo5fZ9YBSnIwhgr6T4cxNJbXHeLCJJo7SzU/R2Vt00rmcsDBO9+x0Q1A7?= =?us-ascii?Q?P7nmEEev/cxFzBd3A3o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 549045df-b1ac-4677-c1b3-08dc78b96193 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:41:18.1103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y5HLDWn+2pFnSA3FxnxAnxYnYQzzER7IFpDyLfdPZnw3O1F8RO0w0eWSLH7aQpOCgoMEQ7BxjpwXCExVTaqMQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar ; stable@dpdk.org Subject: [PATCH v2 04/25] net/axgbe: update DMA coherency values Based on the IOMMU configuration, the current cache control settings can re= sult in possible coherency issues. The hardware team has recommended new se= ttings for the PCI device path to eliminate the issue. Without the fix the user will get incorrect data in TSO functionality Fixes: 7c4158a5b592 ("net/axgbe: add DMA programming and start/stop") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_dev.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c = index 3389954aa6..9b0073eea6 100644 --- a/drivers/net/axgbe/axgbe_dev.c +++ b/drivers/net/axgbe/axgbe_dev.c @@ -647,23 +647,21 @@ static void axgbe_config_dma_cache(struct axgbe_port = *pdata) unsigned int arcache, awcache, arwcache; arcache =3D 0; - AXGMAC_SET_BITS(arcache, DMA_AXIARCR, DRC, 0x3); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, DRC, 0xf); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, TEC, 0xf); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, THC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIARCR, arcache); awcache =3D 0; - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, DWC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPD, 0x1); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHD, 0x1); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDD, 0x1); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, DWC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIAWCR, awcache); arwcache =3D 0; - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWD, 0x1); - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWC, 0x3); - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, RDRC, 0x3); + AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWC, 0xf); + AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, RDRC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIAWRCR, arwcache); } -- 2.34.1