From: Bing Zhao <bingz@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] common/mlx5: fix the sysfs port name translation
Date: Thu, 23 Mar 2023 08:23:48 +0000 [thread overview]
Message-ID: <DM4PR12MB51848B14909CB625ACD1675BD0879@DM4PR12MB5184.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230322075946.4a9a5b6a@hermes.local>
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, March 22, 2023 11:00 PM
> To: Bing Zhao <bingz@nvidia.com>
> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; dev@dpdk.org; Raslan Darawsheh
> <rasland@nvidia.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] common/mlx5: fix the sysfs port name translation
>
> External email: Use caution opening links or attachments
>
>
> On Wed, 22 Mar 2023 13:34:12 +0200
> Bing Zhao <bingz@nvidia.com> wrote:
>
> > + tail_nl = strchr(port_name, '\r');
> > + if (tail_nl)
> > + *tail_nl = '\0';
>
> This is a file provided by Linux kernel, there is no way it could have a CR
> character.
Correct, thanks for pointing this. I was overanxious. I will remove this as well.
next prev parent reply other threads:[~2023-03-23 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:57 [PATCH] " Bing Zhao
2022-11-10 16:21 ` Stephen Hemminger
2022-11-11 5:41 ` Bing Zhao
2022-11-11 17:38 ` Stephen Hemminger
2023-03-22 11:34 ` [PATCH v2] " Bing Zhao
2023-03-22 14:58 ` Stephen Hemminger
2023-03-23 8:20 ` Bing Zhao
2023-03-22 14:59 ` Stephen Hemminger
2023-03-23 8:23 ` Bing Zhao [this message]
2023-03-23 10:54 ` [PATCH v3] net/mlx5: " Bing Zhao
2023-03-27 15:00 ` Matan Azrad
2023-03-28 8:39 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB51848B14909CB625ACD1675BD0879@DM4PR12MB5184.namprd12.prod.outlook.com \
--to=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).