From: Raslan Darawsheh <rasland@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: David Marchand <david.marchand@redhat.com>,
Raslan Darawsheh <rasland@oss.nvidia.com>,
Xueming Li <xuemingl@oss.nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Harman Kalra <hkalra@marvell.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Matan Azrad <matan@oss.nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@oss.nvidia.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device
Date: Thu, 21 Oct 2021 10:36:01 +0000 [thread overview]
Message-ID: <DM4PR12MB531200FF783BC4B82003D50ACFBF9@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211014085528.2992805-1-dkozlyuk@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dmitry Kozlyuk
> Sent: Thursday, October 14, 2021 11:55 AM
> To: dev@dpdk.org
> Cc: David Marchand <david.marchand@redhat.com>; Raslan Darawsheh
> <rasland@oss.nvidia.com>; Xueming Li <xuemingl@oss.nvidia.com>;
> stable@dpdk.org; Harman Kalra <hkalra@marvell.com>; NBU-Contact-
> Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
> <matan@oss.nvidia.com>; Viacheslav Ovsiienko
> <viacheslavo@oss.nvidia.com>
> Subject: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last
> device
>
> MLX5 PMD exposes a socket for external tools to dump port state.
> Socket events are listened using an interrupt source of EXT type.
> The socket was closed and the interrupt callback was unregistered at
> program exit, which is incorrect because DPDK could be already shut down at
> this point. Move actions performed at program exit to the moment the last
> MLX5 port is closed. The socket will be opened again if later a new MLX5
> device is plugged in and probed.
> Also fix comments that were deceisively talking about secondary processes
> instead of external tools.
>
> Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
> Cc: Xueming Li <xuemingl@nvidia.com>
> Cc: stable@dpdk.org
>
> Reported-by: Harman Kalra <hkalra@marvell.com>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: add Fixes tag
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-10-21 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211014085026.2991677-1-dkozlyuk@nvidia.com>
2021-10-14 8:55 ` [dpdk-stable] " Dmitry Kozlyuk
2021-10-14 11:20 ` David Marchand
2021-10-21 10:36 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB531200FF783BC4B82003D50ACFBF9@DM4PR12MB5312.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@oss.nvidia.com \
--cc=hkalra@marvell.com \
--cc=matan@oss.nvidia.com \
--cc=rasland@oss.nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@oss.nvidia.com \
--cc=xuemingl@oss.nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).