From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F60FA0C58 for ; Mon, 1 Nov 2021 09:55:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FC96410FE; Mon, 1 Nov 2021 09:55:46 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2084.outbound.protection.outlook.com [40.107.237.84]) by mails.dpdk.org (Postfix) with ESMTP id 96CE840DF6; Mon, 1 Nov 2021 09:55:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kwqSLUBkU+V0zIW8AZ+ekMigZcAD1uYYzdRmysxNcQqrT6RBwSn/CQK2FUco/MR80fF/27nGgoNfbJRXIAAqXsUISNStesqUzBL8BAQKlehOvySBgKoMGrp1NKVZtqYKmELZAvJJ50W23N0HqKQ5jXg2rdgK+oMsiYz6D5iIT70zEG02OHyVYxGHj0uSJJXatZAjFVsGGq+OaS5i5KFz5+BMXjYZLZJxGTTwhp+TmCf12PwnykG6wr7rRJPiZBIY/y9eZnJojwqnQUJYdCZGeqyeDxSF2Igc4QYwlnd6iO/vHVci3lZwcyj7DJLfmd8OCFvihLamKeBiNOfkMrZjvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AV3FWdkF46ygRAsVyIThfpMlzDax9GXbACc8XlNl+K4=; b=O1aY3rXNlhU591/s91unicLob+/3EI6vlYMJGwYDu7SjXTFW/LMyzqFJUveoKJz3NJr9OkgyBf1QS/Giui8NW36wF2gLMjaz3097H2xZm0X+Koyphqhajd9b69judPaPFsICPJxmaQDc9VkrO+CY/+TrWLrIljA4qCkM4EbLgUHJYoJsN63H5MOdPQPmVPXxBievf9nFtUyAps+OyWSxRgUjy/aweM/YdnfviqCa0EA5gE4L6Cn8rN90AM20bOam3LDziHyAG66Q41XlvSVqwsLsoih1H+2PkXekm6AIS/YAmx0gn4A5swB+k9HPfSRnK3Ef1hKnwgDt+YrV0YZvqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AV3FWdkF46ygRAsVyIThfpMlzDax9GXbACc8XlNl+K4=; b=MY+GmRMnImqqErX09/2eE9+GqFV8Oi7B+6xKSMYB3VTZm+Vx+w8EUEhYJuM51iSxgaXtYEiLPjESFs4LuGKXOp/2S1oKMlq08BNFYzQW52TRJNOGerq5WdMjauaDwJfppeGGe5Msmsr3sLIX/vrxNSM4BVBpdoGV2Eis+S1c5SIgSkVzEHDKDZlH8sgQTigAtnA5h308hEz/TEutRYrT3NMdzpOEHDS9gQTHYXJhfjnIvYfIyPLD7tY73R4np5S5d3aTagM6fM4DEbuXWZ1cnQDJsgY+lbNIL30L8Zx5iNkRiNbWkHm5zYaugE3d0BNDt9NGJ3F9uEjcgNabK8VZ6Q== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5245.namprd12.prod.outlook.com (2603:10b6:5:398::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov 2021 08:55:43 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665%9]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 08:55:43 +0000 From: Raslan Darawsheh To: David Marchand , "dev@dpdk.org" CC: Dmitry Kozlyuk , "stable@dpdk.org" , Matan Azrad , Slava Ovsiienko , "Xueming(Steven) Li" , Jack Min Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: do not close stdin on error Thread-Index: AQHXwO/nDodtb1StykO9G5eyezHnr6vueorA Date: Mon, 1 Nov 2021 08:55:42 +0000 Message-ID: References: <20211014113718.12487-1-david.marchand@redhat.com> In-Reply-To: <20211014113718.12487-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 753a5ba4-74c9-428a-3c24-08d99d15633c x-ms-traffictypediagnostic: DM4PR12MB5245: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KQxy02gZw8lb7c2PnUij7AGtQrkG4ljEYwjwT8x9haIw8rlFTh2YFBJLArpliu+WSCDkLbXkBoW9E0JFvYHFeDZZg9HBJ+itJ7aQJDZvUkmAp1R1Q10nk+7RnsFTx53TwLl8JYyKm1c83tmWAg2Y8lZDpNF99UMgU8jMMHk/cMD3ogOYArH5Y/mHK0U3mPyPBHA0jnZLjhWedKOF90WAkFSLx/g4zsc15aNVblUH47YYVVE30ju69QFQ889sH33l144uNSxMNlUJ1BaZuRX/GwuoaPJKck4JLd+tu0NnREdGCqC/WMmMoY8moQnwaauvx2Q2mV/F1ZlVbH3NmfDKQuuA6W6XXwiuJmtY7Fyumcqvegb4CcAIMgFApZ9w4z7tFXhHFFSHzeRT2Xm7A4Gp7fR/153TVOFzRfDYQVFzDz3WfKToMziEPhCJYhPUDHBi3vuWYL2atxp9MLpwlcYZv+EOqvUBm6za9ddgEtIXgyLcqtl841mHBiLYpBUIfNOJFn4+TRK81apLRcjwpcmcGHnl0CSKB+yLizrPRV5ri5/ccdGVQScl0vyCAJjqGc5YAcvdrfzIyeSOblTt+Up4rBhKM3EPTY0pbMblI+mn14fzxy3Qi4XXCCZCLd/og2zC8itgwL/Hp1l7WC0a+IOpgxiABIDOev7UU5/vqDjtngLba6T/jmWyTy3dMIqUBLAWIi3er9wWCXaPHY7I+SDssw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(6506007)(53546011)(107886003)(83380400001)(8936002)(4326008)(508600001)(71200400001)(52536014)(7696005)(86362001)(4744005)(186003)(122000001)(66556008)(38070700005)(76116006)(9686003)(8676002)(64756008)(316002)(66446008)(66476007)(66946007)(2906002)(55016002)(33656002)(26005)(54906003)(110136005)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5SBFnog4wEONXjGB6yUu95CYxxB77o0xLd+z5mMp/0phzjYq32II9+F0whiJ?= =?us-ascii?Q?H3porHrhB/WgeA4sRq2Wx1fY6D4H19PekEp8scGekpJM0KScAYoOA/SMA3m4?= =?us-ascii?Q?RvwbsSkI7RbpKmE9pPHhpriZBX93fqrk815K5PY4HKB4t09gDsPdpCkW0ufm?= =?us-ascii?Q?CMihbKV2DDrbXiISX3QjQMuy6Ih54CDytv8WlAflnENLW6OGCrO/x7UHP+nc?= =?us-ascii?Q?m864MO/qs2dvTxDHXfdkGERno21f3/7u315bGObASrqLi9qhSWwwdqvWnxjG?= =?us-ascii?Q?+c7fEZVg63cMmpTELhXI9hata0NYu3Hq8nqe90rbNNmfBKlY4xVJQNN7cjH5?= =?us-ascii?Q?LGIdJEhJOxJBcM2lzJWoRjmhZ743Une0Rr4SrXz/SS/BgQWiW6MaLrE8T5HV?= =?us-ascii?Q?+z9Tnax2EYa4090QxsUCOfRyHpQsrVQ9Th8CmcdgFjiAWFO5y0af9pXOHlZ7?= =?us-ascii?Q?NBL2+w07//3RvAPrmKV7Kz+m2s+FndwqDOySM5iKd38LME+XbAHyliD7AdWY?= =?us-ascii?Q?S3G9iz6M/eoqQkcc9WrpHdRQ2VAbMwsGC3bifDzQvBD+T2kRLCkT3H6fwXP9?= =?us-ascii?Q?w1wgLLVlMLBScd3tCs76l9J0k8RIZ4vxd9mw+hH9DhS/24xEPSKD5N9EikXq?= =?us-ascii?Q?TJZSMeH8dh1nyqUUpWnvWrD6MF6K1x9oLNLlTagccmsQq3FfDrdwlm0tyK3A?= =?us-ascii?Q?1aAgSR+0ynbktSrl9vjTxqPT7amJ1G7rFHpMRSUhusk4CpXPWztomLjVHfzO?= =?us-ascii?Q?hfd3TbqJ3eufnNjaPhUur0TShQ05VXsEyuq4UPNopX6s4YzwFjCkgDVMqncf?= =?us-ascii?Q?wudGyTZqu/h3bgrI/R/7JsLtLWau3KQaPV+X0hABGRVTNmUdIaniwXWl1Sjw?= =?us-ascii?Q?wHFo/hQDr4X4OB7/CJc/919/sqChZTuD/jXrxwH86Li9MWTkc27pe97Schic?= =?us-ascii?Q?QO7LJXctq8daS9FisBZl0mobxav0WepldNRMjliaggt4lCZtyRcLdzmURaz0?= =?us-ascii?Q?gCiyMhXPwhCbtM1vGWc9O5tg0yILCFYClcgKHPpv8m+y/fxU2ssQw/lZfM1D?= =?us-ascii?Q?9P6qDmaCGhG93px2G38MiNj0cvgUFZ1uG48k7GLp9LLvMHyZzK6/dBw442C0?= =?us-ascii?Q?W4qr5HgFVIWD6FJDT5vrZDgew+aBdlB+05bbnMnzEtap/hWzXWh0DKG8ORM4?= =?us-ascii?Q?5uJZTgd24XU3suKTrAKcjbLesYuf4IrfaeKOzqruXN/ZtNpnPLfAs1efY8oa?= =?us-ascii?Q?RyHHS3DkdkDD7tLtsMEXbr/OTo85RHM79j46cdE/XPs6xhoQ+Ac50+VEbIkn?= =?us-ascii?Q?T4jwwAgDpysyGH9txHmfeKPBzmvQ96e0Apy3iuMJBlqJh+BnGH3sgka6kHc/?= =?us-ascii?Q?6hWGYLrYAe06tdjOXGojQWeATK674q1ZJC/uKW8NpI83RYegS4TUjhkwbFe2?= =?us-ascii?Q?lloCXwNGmXSJv9KOxRuApWSDWE7PoKNInJoF+AYJxSzffbHOyqVSiaWGWzOG?= =?us-ascii?Q?Cm0gdFLLaJR0cXS3OZFMgnDdrSEnAal1qySUNl3kt+qUsQoB1ckKTkDA3eyP?= =?us-ascii?Q?SnP/i2Ap1uYMdegq5Vid0aP4iH+JQ7Iw4d5vSnZutymZ32A4NWH/wddsbc6g?= =?us-ascii?Q?Ihue7ZGzMCb3LdYe64lKtFg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 753a5ba4-74c9-428a-3c24-08d99d15633c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2021 08:55:43.2370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m2KvE731BhA95kzcbEoKdZEzvM7WLn5iM+g0WY/AkZtLnjNDowQzeBt6md3MDWG4+A1umJYD6dNCwfaCM1KCOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5245 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: do not close stdin on error X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of David Marchand > Sent: Thursday, October 14, 2021 2:37 PM > To: dev@dpdk.org > Cc: Dmitry Kozlyuk ; stable@dpdk.org; Matan Azrad > ; Slava Ovsiienko ; > Xueming(Steven) Li ; Jack Min > > Subject: [dpdk-dev] [PATCH] net/mlx5: do not close stdin on error >=20 > If for any reason, a socket could not be opened, mlx5_pmd_socket_init() > could close the 0 fd (which is valid, and has a fair chance to be stdin),= since > server_socket =3D=3D 0 from the variable being in .bss. >=20 > Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/mlx5/linux/mlx5_socket.c | 29 ++++++++++++++-------------- > 1 file changed, 15 insertions(+), 14 deletions(-) Patch rebased and applied to next-net-mlx, Kindest regards, Raslan Darawsheh