From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0232DA056B for ; Tue, 28 Jun 2022 15:39:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D524D400D7; Tue, 28 Jun 2022 15:39:43 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2076.outbound.protection.outlook.com [40.107.101.76]) by mails.dpdk.org (Postfix) with ESMTP id C2B12400D7 for ; Tue, 28 Jun 2022 15:39:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k9ZbMItu3k0moiiuylXfqt5KxuIvAAMg3HRteB0IjL1qIrc/ypMYkRlRMbGvwl6a1AeSGgnQqkBUuSjpF3LypaQ3x6x6KPyudyjXjbFQ8euvsY7bHVHs7LuhyPltKaVyqsbNBqn0EPlPrYuFS9BtuWzXZkSqGMav8Hc4UL+xozYnENblF/O3uo9fr89dwK61l06nEs0QRcgBMHGFxPVmfQKPp/VOaRT86UF+3GpE6ZQ2Qro/Av7lOBVq6R+/Jszpuc1fPiK4bm+Xl2iWs4JkH0LTKwT6sCM5mZ8bW6gERER+UygssVlBPA4DaSEEq5TJJVo4Ppr170R978+89L/S7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IczWoDo8ob9IwWEhd54k+VzFLQFfrVv3903AG79jFm0=; b=lSmGK1Dz8qmuFYsGB5dscMBT1sXvWXweAKI4IGOraJwqqthDQGkf1KVTmoGcUtxFF8DMSpn07XtYC012sQBiFTowq+A/mt6Mn5ZJ5A2snH1A5ZU7W+1d/a1c3QOBrMFjQSeajii545gCkYwOWwKvvKj60KegMHoim+ATknb8ZKpCo5htz7wiKIijBx8KkpHEUVpUKZIN4VvG20Auo8Ir69ivp/84bw4l095VfHyr3hcPHXdSVKqiPPsOLciko8NbP7ZkvF85nZT48zWE935W31NYo6ALDtRfBLpCXsVWGxXv2Y20TbFvLPmqf2IDJoXQYsp8E+iCU9A8ffQsgunZCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IczWoDo8ob9IwWEhd54k+VzFLQFfrVv3903AG79jFm0=; b=dTfBYPfo2TdRRz//tg5FOjvkMeBxz7wG/HDu5y/vAYCWixyJ23qCS1cENDfQfqSPlcsWtzq1jP+5wspJ6UrXj3/Sp9aDXfywaN3cOI7fHhKp3kKTFhhKnuEWHaHGF8AcuR4sgG+dph5TeeJ8swWcjkf3oZ/exchIV9uWZJ7CP7E/aTepKIugRiXh29ESaJtGi6gi65IziAsCwTImTI0m3RfWr+SGiviWpQVrgrgyuymODeFYJ5KU63nWB2kwCDCmfZ30yxClAl5Pn6BIqwziMS9uwfWfBKRVhbjsMl3FxuSceorXb0BOGDj+JlkygeamdYeil+Q9wrkxVVmktzx61w== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by DM6PR12MB5568.namprd12.prod.outlook.com (2603:10b6:5:20c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.16; Tue, 28 Jun 2022 13:39:40 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::9416:525c:ef8d:6bcd]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::9416:525c:ef8d:6bcd%9]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 13:39:40 +0000 From: "Xueming(Steven) Li" To: Michael Baum , "stable@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Subject: RE: [PATCH 20.11] net/mlx5: fix LRO validation in Rx setup Thread-Topic: [PATCH 20.11] net/mlx5: fix LRO validation in Rx setup Thread-Index: AQHYiUmhPXcSwyC3qUW5Uv9Y9EDCLa1k1aGg Date: Tue, 28 Jun 2022 13:39:40 +0000 Message-ID: References: <20220626104344.3047555-1-michaelba@nvidia.com> In-Reply-To: <20220626104344.3047555-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1dfb97b-2c5f-46bd-166b-08da590ba6a5 x-ms-traffictypediagnostic: DM6PR12MB5568:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RFiPfr3t57ngw+c1p2bKPBfIz252CW/o9o8NVNO9rS8oSFHM1wIxP30jaW+goueZP+OH1+SqBh6O7qR6OPzYdIPUJMG/UF2swRYS9S4Wii01a4P6O4/ahblxJ184XJ/XmRHTdi11C7VSOGZR02YgTvbgxs0PQzlSkmxbMTQDNGAhJrMDAfSuHsLhVqfyVlFmRymXnv24wrAknnO18PxuSAg01kCVCy2ue86hxNtTKLXMWGM4BMsu8n8f8hoD3MN/R1fj9MYH8G2mahgvwf6FwNYd6Q1uShQvwWgvG3hnHKS6ehBtFCx57cAZ1bj+e5Ixa+Rs0g9//LnI2Vz6/5yCclwHh11b07oxpar2vLZ55KCIkOLik7R9HI9GC/4oaoh3xia+N76r7v+ZImMZO/ulfgZJ39shrYc1LoVEIZrhlahDMGtA9Jw0qgesex8eTtpgSU91WfYMMWc6smi6QwC+8HQhAvyPFbObJr7gnICCTmRpVRcidZ7KFcdgQtRbD569PlqEHG+s+vRSXnQf1T4ICclNSAh6eMuA7tAPkvK3xi8CS86fuw2tEHvptSDR02f7ZssBdgyK7UMoYAsPBod/iYEICwSzpiUP/Zmdyctuv2OJH2RS6U7ewjeI89KY4IzjHSKFaYmq+OjPDGWfpgldZChZOUzkmR020K0ltM8Gmtd2Vjt1+KOS4J2TJb+o02PA31PnjkSisyuMDW5kkIcy8EPZ/cNbRWzgYzqR4XUZ+7j1/huEHPt+Mxs+tStAjV8nnajMiPpHk0/gyLucDIzBrO9qKt3Vu5X9OLqIMER38Zvtrs/dKnonmk3gqgeosVm1tPvCxsxsN1dmwJOa9o76t8iZ5ZzaJLc7B+0q5lVQlNrDojMOEmmHaKrOVoq+mlXJ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(346002)(366004)(136003)(39860400002)(376002)(54906003)(55016003)(4326008)(110136005)(38100700002)(38070700005)(53546011)(316002)(966005)(66946007)(41300700001)(76116006)(66446008)(2906002)(71200400001)(122000001)(83380400001)(26005)(64756008)(33656002)(478600001)(5660300002)(107886003)(7696005)(86362001)(8936002)(8676002)(66556008)(66476007)(6506007)(52536014)(186003)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VeRD6Z1gw7wFpv3pJJbf7bx+7WmtfiFVSwmpxhW3dAKe+0pRKm9G8szUyLxl?= =?us-ascii?Q?sJ8+ilw1duGKt3PKM3F5mYaorIWGsmG4ltQf7F14Q66JXlOze0v67WuYL1vX?= =?us-ascii?Q?rwwrY+c7jLszJpJqgLBndMm49bQdJvpJy8vw410BLagfpU8tBYuzT2fIaxqc?= =?us-ascii?Q?IOUlZOEcaCKqYE6RXy+mHiHR82uMtNXymLdnFEOc1KOUH2VR5hSkPR7TtXR4?= =?us-ascii?Q?aLUnsXzbeX6v7oBUuPq4gBis44+NSk1AkJxg7fbp9wEtHkifl3nQi1mjMu6n?= =?us-ascii?Q?E1UubqIiR5XPUjAwWi43pgP2jHIhNubjXwGSqnVB8nHRb4PhmqXKL/UO8tPW?= =?us-ascii?Q?Wo9Xs5ZS1fb8P/n0h5vQ4dZy2ziJEUTtcKm9iWa2eisSSvOghobNKAn1oHl/?= =?us-ascii?Q?K5AYfuVYda3Hw3Ioth6BeTrMwSESdyDDwpUQ1nGg/WWt3tJxKeGWWemJIv+W?= =?us-ascii?Q?5LdQRDnZb6fAl7Vc9yTl6BsDzxDHEMAftiJeM/K3pgYdXpCaKzxoJehNGRXd?= =?us-ascii?Q?m8B7dJtE93EyiHMWEeEml2NBBPiZIfnGR2QSeFrjcJlGz1yytAcZRbpyoN3B?= =?us-ascii?Q?MoVpcVCa84+TTzIZiM3S8gST9hcK7LCy9r8V10bjlVVQEkuyHgalrN5Cw5mJ?= =?us-ascii?Q?zBtpdPcgQUerPFE9zqwo900LPIBu4m3/5B93tJK9AofIUuQA3L3JrrlR1ChD?= =?us-ascii?Q?dI9gh/UwP67lX7sXjn5V/VrqgqGnKyIVSZ+07a6d5Vk0mQmpdoOJkSSaJ9Ax?= =?us-ascii?Q?y8+blyZeeY2bXIj0v/KwGab1HqyXGOx5+cwQudUF17c6+/y2qB5H4BsYF/+B?= =?us-ascii?Q?lYpUINpLbeJcOepWvufPd2RlRv0Zth8h1F7qEj0TBLEesdQ2E+e2XbO1dkIJ?= =?us-ascii?Q?mJlckr8873LM88Gat5d5JBhIToY3JkSi74VrVLh32VXogM7MF2Rpqfwxc2N1?= =?us-ascii?Q?bF/u8OxZjmzo5KeHBD3mm17oCYh6FI7OWwLMTUKT5ivCOtScSYC+WZ7WJHAZ?= =?us-ascii?Q?eC3+dheFTCjQ6OkezSERiY5fRfs/wM0L1eY+EnBs/S86uZvqEtHUOg4mUQKx?= =?us-ascii?Q?XrXW2X8FOCaBfGh4I/thkxLOCFlgodRuScsp/pf8eaCsDgrnYfFF7FkWQn0O?= =?us-ascii?Q?72U90L5ZO2JFT+G9Q7D8FO1BeW7JgAW4NpHF4S//oIAj33dAEOgvi8iaOoFJ?= =?us-ascii?Q?vfEIAICFsulbsNiYtzGuYqSR63nTflLBpbsJMqUZCYzsfBA7QnNa3OP8QFeL?= =?us-ascii?Q?WZVf8zaJ3r9iYQtY2Uw872DNL5KLSl/eCbdvvbxYdr95fmsR6mgsbmywt7dR?= =?us-ascii?Q?eDjoHhZKne/xD6yY4HsSq5uQDGzDWKW+068VmHxQZ4WQFGDtGEndKo06KiA6?= =?us-ascii?Q?ZEFSTsMvvIPuRkuxUsAJ2GPFzyigmFzYay6L4rbJycgRf4GWM8oCUlSHA8W8?= =?us-ascii?Q?S+gtMnfd254JfSTCfH5pPFPDWz12H39muN3dVt2On0le7BciJqIMVqtaAkdR?= =?us-ascii?Q?sXFj/lqfKZjFwkMJif8spPKyJ4VcqjiqSInuYhBdosca3i1dRQ7i7R/5Y+zE?= =?us-ascii?Q?OkDGL5bju8cvrLkmSKRD4IHc8/PzL+DEMuDdDWxk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1dfb97b-2c5f-46bd-166b-08da590ba6a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 13:39:40.1227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L70INEgdXKqBZ5SGbKyth9nI2eN9wBZWyUqNi7ncQuE1IKjorAHq6J4Db5ye2gpwiDXV4BJIORLanw06WK6Mhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5568 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Michael, The patch can't compile with the 20.11 LTS work queue. Please rebase with t= he below branch: https://github.com/steevenlee/dpdk=20 Thanks, Xueming > -----Original Message----- > From: Michael Baum > Sent: Sunday, June 26, 2022 6:44 PM > To: stable@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko ; Xueming(Steven) Li > Subject: [PATCH 20.11] net/mlx5: fix LRO validation in Rx setup >=20 > [ upstream commit a213b8682117711c8e92475c5bbb321a3d8428dd ] >=20 > The mlx5_rx_queue_setup() get LRO offload from user. >=20 > When LRO is configured, the LRO flag in rxq_data is set to 1. >=20 > This patch adds validation to make sure the LRO is supported. >=20 > Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue") >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c in= dex 4a263a5803..6fad968eee 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -756,6 +756,14 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_= t idx, uint16_t desc, > uint16_t n_seg =3D conf->rx_nseg; > int res; >=20 > + if ((offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) && > + !priv->config.lro.supported) { > + DRV_LOG(ERR, > + "Port %u queue %u LRO is configured but not supported.", > + dev->data->port_id, idx); > + rte_errno =3D EINVAL; > + return -rte_errno; > + } > if (mp) { > /* > * The parameters should be checked on rte_eth_dev layer. > -- > 2.25.1