Hi David,

Thanks for pointing this out, fixed and pushed to 23.11-staging.

Regards,
Xueming

________________________________
From: David Marchand <david.marchand@redhat.com>
Sent: Friday, July 12, 2024 7:05 PM
To: Xueming Li <xuemingl@nvidia.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>; dpdk stable <stable@dpdk.org>
Subject: Re: patch 'eal/unix: support ZSTD compression for firmware' has been queued to stable release 23.11.2

Hello Xueming,

On Fri, Jul 12, 2024 at 12:46 PM Xueming Li <xuemingl@nvidia.com> wrote:
> diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
> index 1a7cf8e7b7..33e989188e 100644
> --- a/lib/eal/unix/eal_firmware.c
> +++ b/lib/eal/unix/eal_firmware.c
> @@ -15,6 +15,8 @@
>
>  #include "eal_firmware.h"
>
> +static const char * const compression_suffixes[] = { "xz", "zst" };
> +
>  #ifdef RTE_HAS_LIBARCHIVE
>
>  struct firmware_read_ctx {
> @@ -36,7 +38,11 @@ firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t blocksize)
>
>         err = archive_read_support_filter_xz(ctx->a);
>         if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
> -               goto error;
> +               RTE_LOG(DEBUG, EAL, "could not initialise libarchive for xz compression");
> +
> +       err = archive_read_support_filter_zstd(ctx->a);
> +       if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
> +               RTE_LOG(DEBUG, EAL, "could not initialise libarchive for zstd compression");

EAL_LOG (in the main branch) appends a \n.
However RTE_LOG() won't do it for you.
So a \n is missing in both calls above.


--
David Marchand