patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Marcin Wojtas <mw@semihalf.com>,
	Michal Krawczyk <mk@semihalf.com>,
	Guy Tzalik <gtzalik@amazon.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Igor Chauskin <igorch@amazon.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	NBU-Contact-longli <longli@microsoft.com>,
	Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [dpdk-stable] [PATCH] bus: clarify log for non-NUMA-aware devices
Date: Tue, 15 Jun 2021 11:08:02 +0000
Message-ID: <DM4PR12MB537352A3A1CD5242B45F95C6A1309@DM4PR12MB5373.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210615104409.759899-1-dkozlyuk@nvidia.com>



> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, June 15, 2021 6:44 PM
> To: dev@dpdk.org
> Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org; Marcin Wojtas <mw@semihalf.com>; Michal Krawczyk
> <mk@semihalf.com>; Guy Tzalik <gtzalik@amazon.com>; Evgeny Schemeilin <evgenys@amazon.com>; Igor Chauskin
> <igorch@amazon.com>; Stephen Hemminger <sthemmin@microsoft.com>; NBU-Contact-longli <longli@microsoft.com>; Sergio
> Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> Subject: [PATCH] bus: clarify log for non-NUMA-aware devices
> 
> PCI and vmbus drivers printed a warning
> when NUMA node had beed reported as (-1) or not reported by OS:
> 
>     EAL:   Invalid NUMA socket, default to 0
> 
> This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or
> intervention.
> 
> Reduce level to INFO and reword the message.
> 
> Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe")
> Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
> ---
> Hi Xueming,
> Please align logging in the pending bus/auxiliary patch.

LGTM, updated.

> 
>  doc/guides/nics/ena.rst          | 2 +-
>  drivers/bus/pci/pci_common.c     | 2 +-
>  drivers/bus/vmbus/vmbus_common.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 0f1f63f722..694ce1da74 100644
> --- a/doc/guides/nics/ena.rst
> +++ b/doc/guides/nics/ena.rst
> @@ -234,7 +234,7 @@ Example output:
> 
>     [...]
>     EAL: PCI device 0000:00:06.0 on NUMA socket -1
> -   EAL:   Invalid NUMA socket, default to 0
> +   EAL:   Device is not NUMA-aware, defaulting socket to 0
>     EAL:   probe driver: 1d0f:ec20 net_ena
> 
>     Interactive-mode selected
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 35d7d092d1..bf06f81229 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -190,7 +190,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>  	}
> 
>  	if (dev->device.numa_node < 0) {
> -		RTE_LOG(WARNING, EAL, "  Invalid NUMA socket, default to 0\n");
> +		RTE_LOG(INFO, EAL, "  Device is not NUMA-aware, defaulting socket to
> +0\n");
>  		dev->device.numa_node = 0;
>  	}
> 
> diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c
> index d25fd14ef5..ef23af90ec 100644
> --- a/drivers/bus/vmbus/vmbus_common.c
> +++ b/drivers/bus/vmbus/vmbus_common.c
> @@ -112,7 +112,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr,
>  	dev->driver = dr;
> 
>  	if (dev->device.numa_node < 0) {
> -		VMBUS_LOG(WARNING, "  Invalid NUMA socket, default to 0");
> +		VMBUS_LOG(INFO, "  Device is not NUMA-aware, defaulting socket to
> +0\n");
>  		dev->device.numa_node = 0;
>  	}
> 
> --
> 2.18.2

Reviewed-by: Xueming(Steven) Li <xuemingl@nvidia.com>

       reply	other threads:[~2021-06-15 11:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210615104409.759899-1-dkozlyuk@nvidia.com>
2021-06-15 11:08 ` Xueming(Steven) Li [this message]
2021-06-15 10:51 Dmitry Kozlyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB537352A3A1CD5242B45F95C6A1309@DM4PR12MB5373.namprd12.prod.outlook.com \
    --to=xuemingl@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dkozlyuk@nvidia.com \
    --cc=evgenys@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=longli@microsoft.com \
    --cc=mk@semihalf.com \
    --cc=mw@semihalf.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=stable@dpdk.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git