patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: Kevin Traynor <ktraynor@redhat.com>, "stable@dpdk.org" <stable@dpdk.org>
Cc: "bluca@debian.org" <bluca@debian.org>,
	"christian.ehrhardt@canonical.com"
	<christian.ehrhardt@canonical.com>
Subject: Re: [dpdk-stable] [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning
Date: Sun, 13 Jun 2021 07:37:37 +0000
Message-ID: <DM4PR12MB537399848A650EB3EBCA91D7A1329@DM4PR12MB5373.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210610110028.230803-1-ktraynor@redhat.com>

Applied, thanks!

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, June 10, 2021 7:00 PM
> To: stable@dpdk.org
> Cc: bluca@debian.org; christian.ehrhardt@canonical.com; Xueming(Steven) Li <xuemingl@nvidia.com>; Kevin Traynor
> <ktraynor@redhat.com>
> Subject: [19.11 20.11 PATCH] test/cmdline: silence clang 12 warning
> 
> [ upstream commit 5ac070cfed17111ccaf5aee0cc08119ebb1c4e5e ]
> 
> clang 12 gives a warning about string concatenation in arrays.
> In this case, as it is a long string test the strings are concatenated.
> Add parentheses to indicate this.
> 
> $ clang --version
> clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
> 
> ../app/test/test_cmdline_num.c:204:5: warning:
> suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma?
> [-Wstring-concatenation]
> "1111000011110000111100001111000011110000111100001111000011110000",
> ^
> ../app/test/test_cmdline_num.c:203:3: note:
> place parentheses around the string literal to silence warning
> "0b1111000011110000111100001111000011110000111100001111000011110000"
> ^
> 
> Fixes: dbb860e03eb1 ("cmdline: tests")
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>  app/test/test_cmdline_num.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c index ec479cdb3a..9276de59bd 100644
> --- a/app/test/test_cmdline_num.c
> +++ b/app/test/test_cmdline_num.c
> @@ -201,6 +201,6 @@ const char * num_invalid_strs[] = {
>  		"-0b0111010101",
>  		/* too long (128+ chars) */
> -		"0b1111000011110000111100001111000011110000111100001111000011110000"
> -		  "1111000011110000111100001111000011110000111100001111000011110000",
> +		("0b1111000011110000111100001111000011110000111100001111000011110000"
> +
> +"1111000011110000111100001111000011110000111100001111000011110000"),
>  		"1E3",
>  		"0A",
> --
> 2.31.1


  reply	other threads:[~2021-06-13  7:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 11:00 Kevin Traynor
2021-06-13  7:37 ` Xueming(Steven) Li [this message]
2021-06-14  4:53   ` Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB537399848A650EB3EBCA91D7A1329@DM4PR12MB5373.namprd12.prod.outlook.com \
    --to=xuemingl@nvidia.com \
    --cc=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=ktraynor@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git