From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7601E4297D for ; Tue, 18 Apr 2023 14:38:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7000940EDF; Tue, 18 Apr 2023 14:38:59 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2059.outbound.protection.outlook.com [40.107.212.59]) by mails.dpdk.org (Postfix) with ESMTP id 4676840698 for ; Tue, 18 Apr 2023 14:38:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/6AFVuG+KNBW3ZvqHbnPrVLDPvl/3W38B9tW2OGzdnmRDo6poNWJbgWUDduBQrf58CRMFH+ZAMEsCtnc/PeSosB9euk/Hsd1BDzsxBkf9yRb83wsM7FGfYYVfGsjzl/UNSzRJGJ5whuPXfBJskgD8a0btbYgDVQQ2wzvwj2HLO67zxCrl0vn41hbvioLkEFtGcewhe4R6auVoMEXYUMQsGbnyuybzdfkiw1wwBdcRcf2s6f42CaOPDhN0OuR8AIZ/1qdRP22pGdZImB4V4lGS6oSsdlbUCfq++UmD00AtPTecfg2H8pWZTNXi0uothgshJnwiiqpBe+/CVWgP8ctQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IBT13IjSdS5ZaRNpyu2TE9WkZfdb2afH/PBwKRUfR6c=; b=nrB7Xa/hCNNI1Lii8+wU0B9By7RH8pD57QOIONgOTy5I3kY8BVVnHgQoybwzJWVsHsThOLNGhGCu2kT1m+KMQlvnuYHwr3Ms31f2rJRk+l4sIM1+otofA8HlQHhLTvIvHEityFElo78whVjLGv/icoJvPPCdBDhV+WYrdQ1VOMvQfnDWL2UT+G1pmCv5L1yX1yKbsIqyhOD9SGZ5pxru5PcCleHDoxZmnM/27mVQJfcSh5m7H0y/bryI/lQ1f9Im9uoU7uycKfV+72M/ONSh1g9YUC8ApYMS3QFHoi7KrLL+VEPuApdPALgR2NoGF0zNuuVoZ8VwTbx6P+8MMUL2xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IBT13IjSdS5ZaRNpyu2TE9WkZfdb2afH/PBwKRUfR6c=; b=kKV9GHrKUcyWg+BOGC6R/aztCb+1iFQ6JHzV1tt6GzYqotm47a7gF+P8UQvL8bb+qn9QmNuCsLyNYaDnklapAUDQGS2gxi/PAtems12EjHnEFYpG8s+xQ79O1ZQIdygvqYOb1SZbtjGgrh6oVkQxaCgnWtSBTR+2PRt47uffyvM0zBZShjkn7PteeYImptUdlfHPBJ0ri9qQv2rtFGNnSPMxJu5wugLZ1M6l0vU6nEvRY0bRTAlRcCGmD3kc8ivyV/tYlLkQF0LC9MJJ3tGqC/dar5k2ZUzMiyHGNJ1kCqJUHBCfqy6rOhmrgX440PfJJmzHGyicVIzrH5SVsazXIg== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by DS0PR12MB7876.namprd12.prod.outlook.com (2603:10b6:8:148::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 12:38:55 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::95e7:39c2:fac6:f6c8]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::95e7:39c2:fac6:f6c8%6]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 12:38:55 +0000 From: "Xueming(Steven) Li" To: Gowrishankar Muthukrishnan , "stable@dpdk.org" CC: Anoob Joseph Subject: RE: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters Thread-Topic: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters Thread-Index: AQHZbEj2tfuXdhiJAUepN0Dkcpa5qq8woYiQgABVIQCAABC0gIAABXsQ Date: Tue, 18 Apr 2023 12:38:55 +0000 Message-ID: References: <20230411074050.789415-1-gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|DS0PR12MB7876:EE_ x-ms-office365-filtering-correlation-id: 9e9467fd-5394-47ca-356c-08db4009dfde x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SZWHNfRRDVw1ZHzNUXNa5B78v5K6P/S8AWEHfJnO/P9dBIax/Ug+eIfHe7OkIy1pbkOpIBwDgcFwDbXzXJE429DDldZaUq+ORPOpHuA98wqd9nFIvNHD+ip9eMmao5F+jIrL8eP6pInm3ljwkMcUfvy1taIIGtLGgoAIZOZhj/WX1xzD7G6qgVkTYHySurswoK+DXL+AiSZ22vUpKZz1DSbt6JVqv9/w5NGVIIh1FK+pUdpOcn4kMY3bblIygpp/Gdyvr8OxsIOAmZOaqf4OocKfQPorYuc2PdW6eoO9aVAp3RWCMZECAetga5dsrx485LO6hazCeVygz+S6AzDL/qVb6f5zjUMTmvwS3ojZQN2yBeadmkD7ARBaWoNEw9hHFJrKHO286r1lOLIDQ05JY68it+BSBfzfSuXu/VmjJUOIhSHm0Jt+u8L6/BUT3uxv6+QX2Nw67IzY6qP9hNLC2Hq/6Butn4WfdIH1rHHMjJyVPybOKYqf4BfShvPCTYBBiBH/E1O4W3RibetUGiNH+myXMr2iulsz3vmzzdKPNW6ERg3F85OwyHFEjkJ+WRs+B7R7e3s81U+9b7jJ05ZqJy9j5NVff1s4sGpPIeSmNS8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199021)(38070700005)(52536014)(2906002)(5660300002)(8936002)(8676002)(41300700001)(122000001)(55016003)(86362001)(33656002)(38100700002)(478600001)(110136005)(26005)(6506007)(53546011)(9686003)(186003)(71200400001)(7696005)(4326008)(64756008)(66476007)(66556008)(66946007)(76116006)(66446008)(83380400001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?auw7wD85aw+sE9bmX354TDLMzbbKxszRjRMMWxfOn2+OQk5fsSJzdsruLNzl?= =?us-ascii?Q?QBbqkX7gPf681G9//uVuAUWetmldk2oqzPy7tHCcJgt2qKMdkXsVSAc3ELIs?= =?us-ascii?Q?WUQbmwQullC7A7jioiaKrdXONjqtR7ZIyWrGmslEDC4YkJ52EQmVRRHlvZ+M?= =?us-ascii?Q?7quThMK9Wq0CczdUpBi5UHgB4WEysKJb9xoXLW0O0Y7eqNRm27KQpgpIAmYn?= =?us-ascii?Q?ClSBCZ4aaHruiK4xmh1Z0FLols9WkwBVpkesvrlMd4u6IhrDSqNN6a6adjtV?= =?us-ascii?Q?6tsp96m1tDtHEKtm64wu2/rhFzVa9bsCld2UXV9PWfDUlPZTZ7Xs5abI4DJC?= =?us-ascii?Q?rTt2oeD09Dz/PFIjkZRGuQn7dWFbZphMgQFkpjoJRa92GM2kY9GmzDtGCH/1?= =?us-ascii?Q?v+Dk9wpbZOQTErvAn9YFT6Cn1OlnIMXx7If14WCJZYkYU3/g+e4tOhA7wrh2?= =?us-ascii?Q?Q2teNcD3bWSx1EXwS5B/ly/k+Ilo99Jw2/wxx7LPv+PXaZ+EtnBM5+vBL4q7?= =?us-ascii?Q?+zlE4ndiA2Mt801Omxiy6IUbCWEKvXgMcV4sJ4jXBNaoiQSMyn5vN8gkj0F+?= =?us-ascii?Q?B6PB+rgzHgIqT7IgyJLJGmsV0o3C59XD55dRkLGCnAHdiR9bww1gRIV8BkNO?= =?us-ascii?Q?yfn7RL4qRBlNWic3TdNLrAsQjEamFotrll5q1sekBEI5wv+R0WmVxBYsCyqW?= =?us-ascii?Q?TzzJJ1k/muf0K/zBa5cU+FF/paqaHjKLJYLNXdhhR5wSpXuvjZVkxqWYTfxk?= =?us-ascii?Q?KmxLCB6z+mkVFtBpuP7c/LdjK/QjsiflYMBep6mXIZDOWneA0qCxs/xI+FZ1?= =?us-ascii?Q?VQe8oXlcsghXS7kb7uJYidfIAMnBTqz2V8Guy9T+svW0t7NmARHiBmfsIjOB?= =?us-ascii?Q?UVSjFsWaqXMv/NL8xLKGuMuG5rZPsMNqrozUZIIwcNqtQ3UMvabi53Ak+9JS?= =?us-ascii?Q?hz5O1m1NRVqCq25/AaNm9CrydbyJIL1QWqaNWksj98fwXOAFWP+3+aJT8GQJ?= =?us-ascii?Q?B+5q44xLwVjJfih28ycuR2ghcUSxmPL+NrbZnEsNyoUso3V7rRK5FcefRWr1?= =?us-ascii?Q?E/ujIxaYcZdDaRIpr50orj2YKeYXrXI05ahrbl4B/1E5uP78Cww7lX7Tih1k?= =?us-ascii?Q?PeKMICa25AoNNnQa+U/TcBYqAFjv2mgQQJIxHvlmfm86y8ruC4r/7E2x9pRe?= =?us-ascii?Q?1mbRjPYMW67A3aaY6HaeU3m5eJ6w0TeP5S46LtznFkHfNIw89Oldj/vtrT8a?= =?us-ascii?Q?MuLodpFLCnuYgJZhoBXTRBvxtMpdPkcGBLS4yiJJPeHZC+jLnEgi/fE3kCK/?= =?us-ascii?Q?QXTy4wFOZNiNQvA0YtJ9PViP2VAnC5OzbruC0z5sLCdkUob9q/p2/F81jjqB?= =?us-ascii?Q?jNbvfsRxNt1L98tHbwhKcrh6JElt8nzABOmRhzkU1YVndqSg56KJMyl0TF2b?= =?us-ascii?Q?C0p958JmXRW9QOQFje5z/NGAztQdWpNh38f2U2pBH/HigGcPlxh+CII87zHR?= =?us-ascii?Q?E04USzZFfOXwbOSPO4HmO8E25YgKA4Gk2qCfb/sk94npJ+3HIOJo2RJzX1+F?= =?us-ascii?Q?HakWHS9A28NcHO8KLiFYrtSSSNm07B6sIzvN3mAn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e9467fd-5394-47ca-356c-08db4009dfde X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2023 12:38:55.7502 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 88q2VYcMPeZqytAaoCTDgaj0fNqxa7QQuYe07NTgiI9QPUJ88UYgB/HOHRpanau40J02r9mIX6aO+R6BWRGBiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7876 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Ack, thanks for update. > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: 4/18/2023 20:19 > To: Xueming(Steven) Li ; stable@dpdk.org > Cc: Anoob Joseph > Subject: RE: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters >=20 > Hi, > Please drop this patch as we would not need this fix for 22.11.2. >=20 > Thanks, > Gowrishankar >=20 > > -----Original Message----- > > From: Xueming(Steven) Li > > Sent: Tuesday, April 18, 2023 4:52 PM > > To: Gowrishankar Muthukrishnan ; > > stable@dpdk.org > > Cc: Anoob Joseph > > Subject: [EXT] RE: [PATCH 22.11] crypto/cnxk: fix order of ECFPM > > parameters > > > > External Email > > > > ---------------------------------------------------------------------- > > There is a compilation error: > > > > In file included from > > ../../../auto/mtbcswgwork/xuemingl/workspace/dpdk/drivers/crypto/cnxk/ > > cn9k > > _cryptodev_ops.c:15: > > ../../../auto/mtbcswgwork/xuemingl/workspace/dpdk/drivers/crypto/cnxk/ > > cnxk > > _ae.h:958:13: error: no member named 'lf' in 'struct cnxk_ae_sess' > > sess->lf->roc_cpt->cpt_revisio= n); > > ~~~~ ^ > > > > Please provide a new version if we do need it for 22.11 LTS. > > > > > -----Original Message----- > > > From: Xueming(Steven) Li > > > Sent: 4/18/2023 14:23 > > > To: Gowrishankar Muthukrishnan ; > > > stable@dpdk.org > > > Cc: anoobj@marvell.com > > > Subject: RE: [PATCH 22.11] crypto/cnxk: fix order of ECFPM > > > parameters > > > > > > Thanks, patch applied. > > > > > > > -----Original Message----- > > > > From: Gowrishankar Muthukrishnan > > > > Sent: 4/11/2023 15:41 > > > > To: stable@dpdk.org > > > > Cc: anoobj@marvell.com; Xueming(Steven) Li ; > > > > Gowrishankar Muthukrishnan > > > > Subject: [PATCH 22.11] crypto/cnxk: fix order of ECFPM parameters > > > > > > > > [ upstream commit 76618fc4bef616f16b6c92f15681ea080eabb486 ] > > > > > > > > Fix the order of ECFPM parameters according to target board. > > > > > > > > Fixes: 8e39b133235 ("crypto/cnxk: support fixed point > > > > multiplication") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Gowrishankar Muthukrishnan > > > > > > > > --- > > > > drivers/crypto/cnxk/cnxk_ae.h | 48 > > > > ++++++++++++++++++++--------------- > > > > 1 file changed, 28 insertions(+), 20 deletions(-) > > > > > > > > diff --git a/drivers/crypto/cnxk/cnxk_ae.h > > > > b/drivers/crypto/cnxk/cnxk_ae.h index adf719da73..f1183376d0 > > > > 100644 > > > > --- a/drivers/crypto/cnxk/cnxk_ae.h > > > > +++ b/drivers/crypto/cnxk/cnxk_ae.h > > > > @@ -678,7 +678,7 @@ static __rte_always_inline int > > > > cnxk_ae_ecfpm_prep(struct rte_crypto_ecpm_op_param *ecpm, > > > > struct roc_ae_buf_ptr *meta_buf, uint64_t *fpm_iova, > > > > struct roc_ae_ec_group *ec_grp, uint8_t curveid, > > > > - struct cpt_inst_s *inst) > > > > + struct cpt_inst_s *inst, int cpt_ver) > > > > { > > > > uint16_t scalar_align, p_align; > > > > uint16_t dlen, prime_len; > > > > @@ -697,26 +697,33 @@ cnxk_ae_ecfpm_prep(struct > > > > rte_crypto_ecpm_op_param *ecpm, > > > > scalar_align =3D RTE_ALIGN_CEIL(ecpm->scalar.length, 8); > > > > > > > > /* > > > > - * Set dlen =3D sum(ROUNDUP8(input point(x and y coordinates), pr= ime, > > > > - * scalar length), > > > > + * Set dlen =3D sum(prime, scalar length, table address and > > > > + * optionally ROUNDUP8(input point(x and y coordinates)). > > > > * Please note point length is equivalent to prime of the curve > > > > */ > > > > - dlen =3D sizeof(fpm_table_iova) + 3 * p_align + scalar_align; > > > > - > > > > - memset(dptr, 0, dlen); > > > > - > > > > - *(uint64_t *)dptr =3D fpm_table_iova; > > > > - dptr +=3D sizeof(fpm_table_iova); > > > > - > > > > - /* Copy scalar, prime */ > > > > - memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > > > > - dptr +=3D scalar_align; > > > > - memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > > > > - dptr +=3D p_align; > > > > - memcpy(dptr, ec_grp->consta.data, ec_grp->consta.length); > > > > - dptr +=3D p_align; > > > > - memcpy(dptr, ec_grp->constb.data, ec_grp->constb.length); > > > > - dptr +=3D p_align; > > > > + if (cpt_ver =3D=3D ROC_CPT_REVISION_ID_96XX_C0) { > > > > + dlen =3D sizeof(fpm_table_iova) + 3 * p_align + scalar_align; > > > > + memset(dptr, 0, dlen); > > > > + *(uint64_t *)dptr =3D fpm_table_iova; > > > > + dptr +=3D sizeof(fpm_table_iova); > > > > + memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > > > > + dptr +=3D scalar_align; > > > > + memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > > > > + dptr +=3D p_align; > > > > + memcpy(dptr, ec_grp->consta.data, ec_grp->consta.length); > > > > + dptr +=3D p_align; > > > > + memcpy(dptr, ec_grp->constb.data, ec_grp->constb.length); > > > > + dptr +=3D p_align; > > > > + } else { > > > > + dlen =3D sizeof(fpm_table_iova) + p_align + scalar_align; > > > > + memset(dptr, 0, dlen); > > > > + memcpy(dptr, ecpm->scalar.data, ecpm->scalar.length); > > > > + dptr +=3D scalar_align; > > > > + memcpy(dptr, ec_grp->prime.data, ec_grp->prime.length); > > > > + dptr +=3D p_align; > > > > + *(uint64_t *)dptr =3D fpm_table_iova; > > > > + dptr +=3D sizeof(fpm_table_iova); > > > > + } > > > > > > > > /* Setup opcodes */ > > > > w4.s.opcode_major =3D ROC_AE_MAJOR_OP_ECC; @@ -947,7 +954,8 > > > @@ > > > > cnxk_ae_enqueue(struct cnxk_cpt_qp *qp, struct rte_crypto_op *op, > > > > ret =3D cnxk_ae_ecfpm_prep(&asym_op->ecpm, &meta_buf, > > > > sess->cnxk_fpm_iova, > > > > sess->ec_grp[sess->ec_ctx.curveid], > > > > - sess->ec_ctx.curveid, inst); > > > > + sess->ec_ctx.curveid, inst, > > > > + sess->lf->roc_cpt->cpt_revision); > > > > if (unlikely(ret)) > > > > goto req_fail; > > > > break; > > > > -- > > > > 2.25.1