patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: Michael Baum <michaelba@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH 20.11 v2] net/mlx5: fix LRO validation in Rx setup
Date: Wed, 29 Jun 2022 07:24:27 +0000	[thread overview]
Message-ID: <DM4PR12MB5373B3FA51D63582003EE5AFA1BB9@DM4PR12MB5373.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220628153356.3390193-1-michaelba@nvidia.com>

Hey Michael,

Applied, thanks!

> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
> Sent: Tuesday, June 28, 2022 11:34 PM
> To: stable@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Xueming(Steven) Li <xuemingl@nvidia.com>
> Subject: [PATCH 20.11 v2] net/mlx5: fix LRO validation in Rx setup
> 
> [ upstream commit a213b8682117711c8e92475c5bbb321a3d8428dd ]
> 
> The mlx5_rx_queue_setup() get LRO offload from user.
> 
> When LRO is configured, the LRO flag in rxq_data is set to 1.
> 
> This patch adds validation to make sure the LRO is supported.
> 
> Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue")
> 
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> 
> v2: fix compilation issue.
> 
>  drivers/net/mlx5/mlx5_rxq.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 4a263a5803..cb743a773c 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -754,8 +754,18 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
>  				(struct rte_eth_rxseg_split *)conf->rx_seg;
>  	struct rte_eth_rxseg_split rx_single = {.mp = mp};
>  	uint16_t n_seg = conf->rx_nseg;
> +	uint64_t offloads = conf->offloads |
> +			    dev->data->dev_conf.rxmode.offloads;
>  	int res;
> 
> +	if ((offloads & DEV_RX_OFFLOAD_TCP_LRO) &&
> +	    !priv->config.lro.supported) {
> +		DRV_LOG(ERR,
> +			"Port %u queue %u LRO is configured but not supported.",
> +			dev->data->port_id, idx);
> +		rte_errno = EINVAL;
> +		return -rte_errno;
> +	}
>  	if (mp) {
>  		/*
>  		 * The parameters should be checked on rte_eth_dev layer.
> @@ -766,9 +776,6 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
>  		n_seg = 1;
>  	}
>  	if (n_seg > 1) {
> -		uint64_t offloads = conf->offloads |
> -				    dev->data->dev_conf.rxmode.offloads;
> -
>  		/* The offloads should be checked on rte_eth_dev layer. */
>  		MLX5_ASSERT(offloads & DEV_RX_OFFLOAD_SCATTER);
>  		if (!(offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT)) {
> --
> 2.25.1


      reply	other threads:[~2022-06-29  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 10:43 [PATCH 20.11] " Michael Baum
2022-06-28 13:39 ` Xueming(Steven) Li
2022-06-28 15:33 ` [PATCH 20.11 v2] " Michael Baum
2022-06-29  7:24   ` Xueming(Steven) Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB5373B3FA51D63582003EE5AFA1BB9@DM4PR12MB5373.namprd12.prod.outlook.com \
    --to=xuemingl@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=michaelba@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).