From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21B36A00C5 for ; Tue, 19 Jul 2022 13:11:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECA2E40A87; Tue, 19 Jul 2022 13:11:25 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) by mails.dpdk.org (Postfix) with ESMTP id 1E2AF4069F for ; Tue, 19 Jul 2022 13:11:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eKjnpJDkUjAQgsM+/bn9HllGe4Y1pDS2VSGUBlbM4Thn7LYTmcQ/qyddy7AUVPHmwDsrOdKzkDWtdrw8xy7MehrP30XbT9UXoQWQ74SXOALtlWH6+J9BDJgM01//J34g2zAfXTajlqptyvCGsJ3bmc6r0BCJAhtxo43z/LXcwczjlBGhWwgTZ5zQmrfom4467MVw22GqcZdRzqagQYNyzGdIaR0ra5X1hGEjfIcKFG+/rC2p2I9n3nWOiaTBRofn9Ir3PyJPMLu53Qehe3RxOadDyi5rG/q6gjM+Mrmbptr8gBegplUpz3RPZR8OJnG6g/rHx97oZsND7bIb6l662g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y5LzkwgFZSZGOiOZhzmcKKhhkAiO/KnoCHWBKLs/Sxk=; b=Xj9M2g1xaRWTcv0g60LkqYEX4mjJiDGzqL7ca+UFyW9TeFKeAPClybPPw6UON0yux1wqcH0fW4HdKBPUTPFc9b8n3twL0lzK66l0TPlFm4eRaEjJYKzWgAAm9zvW2JqteKzx8m3Q1LPIFWSb4QniFPuTJ/343+5lU+vhHQAZ0UXxl6i1b845Jt0Cn4C171nMYtl6G8dUb0tCxYkwliiceWrmmumgnEIWlGHzq0YHHfEB/B6g4Ta2Zq3ifiFank6EPY0z6sCtowtVyUQymkISLkqYgSXzw3z49rTdrrhnb/KwCmx+pxC0qQGEJf4wv/yykmKjsORRRn3H71Olg81RqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5LzkwgFZSZGOiOZhzmcKKhhkAiO/KnoCHWBKLs/Sxk=; b=rG7ivnt/odTEu/jln10YQcGhgcg2+ddX+pXYXjCY3+0mmiB5zSfqiBEz+Om4zGtqGl+u9WxwoXjvdM4rf8obBqi6u8fYFZLVzcqQf1CpTFZFxIbkBjVVftW6xOThjODZ4/Y5LJPZUZGCrPLRW0XK3miZKWSF1zLPomL0z6CVc/HZ0rul4EnGC7zNQl8YxnTdouzE5DN0DmC/S0AAc0xX2oxx5P03E3Q2jOw+GaCQPazkBOBYfdJ70jV9LXIsgJ8SJpjlpdxFJIdSI7vXNtKAf1MKB+VZDHAESKrYyGtEeRQKK3Ku9P3Entgt0Kwl9aMD6Xlv++GBYFAfsIJegN644Q== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by CY4PR12MB1928.namprd12.prod.outlook.com (2603:10b6:903:128::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Tue, 19 Jul 2022 11:11:22 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::8f0:3589:7050:3d9]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::8f0:3589:7050:3d9%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 11:11:21 +0000 From: "Xueming(Steven) Li" To: Gagandeep Singh , "stable@dpdk.org" CC: Akhil Goyal Subject: RE: [PATCH 20.11] crypto/dpaa2_sec: fix crypto operation pointer Thread-Topic: [PATCH 20.11] crypto/dpaa2_sec: fix crypto operation pointer Thread-Index: AQHYiqFnYAsXJZ9en0WBAn5u9O/alq2Fqytw Date: Tue, 19 Jul 2022 11:11:21 +0000 Message-ID: References: <20220628034410.1522591-1-g.singh@nxp.com> In-Reply-To: <20220628034410.1522591-1-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ef7c0c1e-407c-4071-5e15-08da6977698d x-ms-traffictypediagnostic: CY4PR12MB1928:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WA2vabdmy2CrAXtQcKLHp8+4BATdNMtIoeYu6uCQ1aUnFDg2R+6wx5OBx1gcka/ov9sv/gtK8afi5ellfb1G9y1DMw0jej5hOa/VLeMprNF4Ku5l3Gs5CCRNrM6rnmXiTjZmpo9sLVwTRkyLYC6U1/Yvc+qs46I3uXtM/T1spMV/lv7IQ6LPJwCpDf3yj+0+isAGaYbd8HPmHkjb4BgtPn/7jIWNfuGSQMo//3jfOGk74Db3YKnXbYqo9ktOvNOhW0oV1vYozUrAIjfD3iHQW7TmqFDIhYskoolbpWq0Bpu2bGPMZkugMtAeHJzb4X2edEgHQ88yCUKIInucI6pFqwrJqljOadCwZ4eC00v7yg00bh6T1hzhp95NTac4UDVQ835LYiug42CumYL1h0zz7GojnkWiuTsgQPbgu/3qxE7RmcpfFPZUhILZWRhVJpnVXVjOpWYiKzwBqPFHqv63v5Nacr0FF/jHryUIHukyS8uCKRC/Mh1UhOdsngF8qBwIUMDanIg7NMrkVnYoZTMBDevJUAzfm+BR6KFr+/CMme8R5xg8MxETjaxmyG+uY6m4zUDfqpJBbm56Wm+ehrFzlqMf8P29HwkxTLX9gpJiO9wr5qQeL3cGYnqnWPn+eHdbKfZ95Qbzq/Vnkugoxm/v9MQE8DhXTCJbYtpDqzQwiFNKs7fjVe4thNTaY7B/W2XgUxdbj45JRW87ZeM2nWISDMOYovsbCm1PBrm6BLFvOua0fJOkvyB0Ps1kaQw1JT7dYP/i53IqioirdTeAhLbnBI6lVV3HAVTUANUTgk0A8s8++vLpV9CewmUoN5qC81Yx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(376002)(39860400002)(346002)(136003)(396003)(86362001)(38100700002)(33656002)(38070700005)(110136005)(9686003)(478600001)(26005)(7696005)(71200400001)(6506007)(41300700001)(53546011)(186003)(66556008)(316002)(52536014)(66476007)(8936002)(64756008)(8676002)(4326008)(76116006)(55016003)(5660300002)(66946007)(122000001)(83380400001)(2906002)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bPxp5wzPu4UaSl4Il/GtfIM7VwnT/ZyBEv51lrdkj4piI2cLhHlcpF6w7Rpo?= =?us-ascii?Q?VxWPGiVVgfGETgNcvb4SwO0nOOfpwns+0DYAlBTbWDlXo3JBDLpLm0SFJD8g?= =?us-ascii?Q?o+pu9qcxK2TGWI4wguCFcblOHQT2DJHCIwCbCcudsS90a018IUydDf69BxoS?= =?us-ascii?Q?a70ZIB3nljGsU6SHXVsWz9rfGejso0bQegchwhXhcJqt+JvTDUp+GTZPT1gF?= =?us-ascii?Q?0HBpEUtJ5Vyddfj3KSu7eNO4IDFFBstY3BJfd1+kUxgqzWE+mfvJaIZCROLc?= =?us-ascii?Q?QmVkH8u6kRSryd4xenuRly9C3HTPlDgj/pdIzuhjR0HkJHd/j5t7C8l12fdB?= =?us-ascii?Q?/LjKoUuDwakEn1dlV4VhbPpNX4IEIsyQD2eeK4xuMU93OnK0RQdJkI7UMCd9?= =?us-ascii?Q?Z9w7neXhTC0AJgBvDbK7QUGhRE2Lx1GEXuF8Hv3+fKCIzx2VRzI+y2boRzeO?= =?us-ascii?Q?QRBddbM8/u1qgph7SDeP4nLBzJUiCMjpI63ru4JDb2ZaQqa1nVGaAACYpF+C?= =?us-ascii?Q?dV3C7uXk025xUkuS9oZJ8sHQ8YWGmBfUCNVnJypzl8+x3k6gHaPu04jpQslr?= =?us-ascii?Q?Ce1UMatg0HppBS0KNSmDlcXiNbDNEK3MSTiAVODQ9es56zzuMp6/QAbVrqVc?= =?us-ascii?Q?us5TPxZHa0MPzFAUeGSjFxLdx/3u25K/SufJrytq41dQnLCXatV7X5SwuV20?= =?us-ascii?Q?82B/wqlJOZWwYzufcAHxgpWDcjUYNvoPehCBSefCRM029Fngppn+/ml5ugU1?= =?us-ascii?Q?K42qIZtJwgfd+/OLSjjQQJMoH03kSdIjtsljoVLjN+Y4zKsfC5jEQCigLJPp?= =?us-ascii?Q?QStMF6so3Rxh+jxS0yc6PHl2oiEzofN2l4XPVu2Y5WNQ/Jxj2thfxhX05dWP?= =?us-ascii?Q?h2y1dUnkxsG3klPG8LAvkCO5A/XOdmt/GMVtrbasgdPZk8qYY0jv1ov0kze7?= =?us-ascii?Q?NbMzPZ/4mTIN6AhoC+RI/ylqWgU3WgpHMBs1Cb3uczPsqx/R3aaQS9tChPBA?= =?us-ascii?Q?Yyu0aoS3Lqcc4jA8M0m7ULJ0xc9sV2n//ZCEuWHtM2OM7zELfSEiKaIcYU+s?= =?us-ascii?Q?G4KSaSpHSRfkqyiLUx+hqb621lps3/j5JOhJNAibQhqRe+NjXsLjJasENZi3?= =?us-ascii?Q?lnIvhp8scEr1vMs5tgs9HkehX/bnEhKOTYqxFEhlnCEixA2krCi+MxwDBPnt?= =?us-ascii?Q?pGb91IyOn1amHsgdAZB2jE6JpTpUzMCFQ4zwEQB8MqK0m3d8VS+q2IaJNOtV?= =?us-ascii?Q?lU3dG3fb+qzDSmpM2p5NHQcH7YR/zCaBQqhHg8Ld5nd8d+CsP/xAF8kBgBd5?= =?us-ascii?Q?8tt0pd4hdiq0CzAuY4aF7jDGvECZot1LKhK7g+OhABLvWWXXzR1wjDIOIwfk?= =?us-ascii?Q?kgYzwoEJK9bjxQZbbsLfIkXSmgtM+vaz6crG0XpL8O37r2nwac1lLWyp4xMZ?= =?us-ascii?Q?RTvkfIVDxIoYeyreCJtx1OihyHbRDOKBKd+Yx9LYs2jfMlKJ2SDw9zonuXih?= =?us-ascii?Q?R2EDpyHVgtCKcY/PEqOXQaRWJ+TSMbMSCrTod9HRvOur3zq9uYOFoYtTt/Av?= =?us-ascii?Q?zzU/1kcna0jto7fJMMlbjJEQafwuDzoGyPjLNqre?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef7c0c1e-407c-4071-5e15-08da6977698d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 11:11:21.8931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ryHm04ru1wIdS0wPkl1WagB9bSu/LNYME9iJ3crZ3/wa7Gx36YAQsmwm9SXRSmR6O0ZwsAdEp7hor4CKUIQBYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1928 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Thanks, patch applied. > -----Original Message----- > From: Gagandeep Singh > Sent: Tuesday, June 28, 2022 11:44 AM > To: stable@dpdk.org > Cc: Gagandeep Singh ; Akhil Goyal > Subject: [PATCH 20.11] crypto/dpaa2_sec: fix crypto operation pointer >=20 > [ upstream commit e3d264383b560a447806d9ff478bad234fda5675 ] >=20 > Driver is filling the crypto_op variable with an invalid value for atomic= events which can results into segmentation fault. >=20 > This patch assigning the correct crypto_op and event buffer pointers by e= xtracting from FD. >=20 > Fixes: a77db24643b7 ("crypto/dpaa2_sec: support atomic queues") >=20 > Signed-off-by: Gagandeep Singh > Acked-by: Akhil Goyal > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto= /dpaa2_sec/dpaa2_sec_dpseci.c > index 64ee56e7c..839c11ed2 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -3705,7 +3705,7 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *sw= p __rte_unused, > struct rte_event *ev) > { > uint8_t dqrr_index; > - struct rte_crypto_op *crypto_op =3D (struct rte_crypto_op *)ev->event_p= tr; > + struct rte_crypto_op *crypto_op; > /* Prefetching mbuf */ > rte_prefetch0((void *)(size_t)(DPAA2_GET_FD_ADDR(fd)- > rte_dpaa2_bpid_info[DPAA2_GET_FD_BPID(fd)].meta_data_size)); > @@ -3721,12 +3721,13 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *= swp __rte_unused, > ev->queue_id =3D rxq->ev.queue_id; > ev->priority =3D rxq->ev.priority; >=20 > - ev->event_ptr =3D sec_fd_to_mbuf(fd); > + crypto_op =3D sec_fd_to_mbuf(fd); > dqrr_index =3D qbman_get_dqrr_idx(dq); > *dpaa2_seqn(crypto_op->sym->m_src) =3D dqrr_index + 1; > DPAA2_PER_LCORE_DQRR_SIZE++; > DPAA2_PER_LCORE_DQRR_HELD |=3D 1 << dqrr_index; > DPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) =3D crypto_op->sym->m_src; > + ev->event_ptr =3D crypto_op; > } >=20 > int > -- > 2.25.1