Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD

["Xueming(Steven) Li" <xuemingl@nvidia.com>]

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Friday, June 18, 2021 9:57 AM
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; Luca Boccassi <bluca@debian.org>; stable@dpdk.org; Kevin Traynor
> <ktraynor@redhat.com>
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; christian.ehrhardt@canonical.com; ktraynor@redhat.com; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD
> 
> > -----Original Message-----
> > From: Xueming(Steven) Li <xuemingl@nvidia.com>
> > Sent: Thursday, June 17, 2021 16:53
> > To: Wang, Haiyue <haiyue.wang@intel.com>; Luca Boccassi
> > <bluca@debian.org>; stable@dpdk.org; Kevin Traynor
> > <ktraynor@redhat.com>
> > Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> > christian.ehrhardt@canonical.com; ktraynor@redhat.com; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Subject: RE: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new
> > VLAN design for Intel ice PMD
> >
> > Hi Haiyue,
> >
> > > -----Original Message-----
> > > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > Sent: Thursday, June 17, 2021 9:16 AM
> > > To: Luca Boccassi <bluca@debian.org>; stable@dpdk.org
> > > Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; NBU-Contact-Thomas
> > > Monjalon <thomas@monjalon.net>; christian.ehrhardt@canonical.com;
> > > ktraynor@redhat.com; Zhang, Qi Z <qi.z.zhang@intel.com>
> > > Subject: RE: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new
> > > VLAN design for Intel ice PMD
> > >
> > > > -----Original Message-----
> > > > From: Luca Boccassi <bluca@debian.org>
> > > > Sent: Wednesday, June 16, 2021 23:47
> > > > To: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org
> > > > Cc: xuemingl@nvidia.com; thomas@monjalon.net;
> > > > christian.ehrhardt@canonical.com; ktraynor@redhat.com; Zhang, Qi Z
> > > > <qi.z.zhang@intel.com>
> > > > Subject: Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new
> > > > VLAN design for Intel ice PMD
> > > >
> > > > On Fri, 2021-06-11 at 15:15 +0800, Haiyue Wang wrote:
> > > > > When LTS 20.11 was released, the Intel ice PMD has a basic VLAN
> > > > > offload, which can only handle single VLAN mode for firmware
> > > > > limitation. Now the firmware is updated to support double VLAN
> > > > > mode and single VLAN mode at the same time. It depends on the driver to do selection at the boot time.
> > > > >
> > > > > As VLAN protocol handling like strip, filter, flow is very
> > > > > common use, we request to support the ice PMD can run on the
> > > > > latest firmware for enabling the new design. This is compatible backport as the main tree.
> > > > >
> > > > > v2: Fix the subject fix with messy code like : PATCHÂ
> > > > >
> > > > > Haiyue Wang (4):
> > > > >   net/ice/base: do not set VLAN mode in DCF mode
> > > > >   net/ice: fix VLAN strip for double VLAN
> > > > >   net/ice: fix VLAN 0 adding based on VLAN mode
> > > > >   net/ice: update QinQ switch filter handling
> > > > >
> > > > > Junfeng Guo (1):
> > > > >   net/ice: enable QinQ filter for switch
> > > > >
> > > > > Qi Zhang (12):
> > > > >   net/ice/base: align add VSI and update VSI AQ command buffer
> > > > >   net/ice/base: add interface to support configuring VLAN mode
> > > > >   net/ice/base: fix outer VLAN related macro
> > > > >   net/ice/base: add VLAN TPID for VLAN filters
> > > > >   net/ice/base: support checking double VLAN mode
> > > > >   net/ice/base: support configuring device in double VLAN mode
> > > > >   net/ice/base: update boost TCAM for DVM
> > > > >   net/ice/base: change protocol ID for VLAN in DVM
> > > > >   net/ice/base: refactor post DDP download VLAN mode config
> > > > >   net/ice/base: log if DDP/FW do not support QinQ
> > > > >   net/ice/base: add inner VLAN protocol type for QinQ filter
> > > > >   net/ice/base: fix QinQ PPPoE dummy packet selection
> > > > >
> > > > > Yuying Zhang (1):
> > > > >   net/ice/base: add ethertype offset for QinQ dummy packet
> > > > >
> > > > >  drivers/net/ice/base/ice_adminq_cmd.h    | 268 ++++++++-----
> > > > >  drivers/net/ice/base/ice_bitops.h        |  45 +++
> > > > >  drivers/net/ice/base/ice_common.c        |  38 ++
> > > > >  drivers/net/ice/base/ice_common.h        |   4 +
> > > > >  drivers/net/ice/base/ice_flex_pipe.c     | 302 +++++++++++++--
> > > > >  drivers/net/ice/base/ice_flex_pipe.h     |  12 +
> > > > >  drivers/net/ice/base/ice_flex_type.h     |  39 ++
> > > > >  drivers/net/ice/base/ice_protocol_type.h |   1 +
> > > > >  drivers/net/ice/base/ice_switch.c        | 124 +++++-
> > > > >  drivers/net/ice/base/ice_switch.h        |  15 +
> > > > >  drivers/net/ice/base/ice_type.h          |   4 +
> > > > >  drivers/net/ice/base/ice_vlan_mode.c     | 451 ++++++++++++++++++++++
> > > > >  drivers/net/ice/base/ice_vlan_mode.h     |  16 +
> > > > >  drivers/net/ice/base/meson.build         |   1 +
> > > > >  drivers/net/ice/ice_ethdev.c             | 455 +++++++++++++----------
> > > > >  drivers/net/ice/ice_ethdev.h             |  10 +-
> > > > >  drivers/net/ice/ice_generic_flow.c       |   8 +
> > > > >  drivers/net/ice/ice_generic_flow.h       |   1 +
> > > > >  drivers/net/ice/ice_switch_filter.c      | 114 +++++-
> > > > >  19 files changed, 1545 insertions(+), 363 deletions(-)  create
> > > > > mode
> > > > > 100644 drivers/net/ice/base/ice_vlan_mode.c
> > > > >  create mode 100644 drivers/net/ice/base/ice_vlan_mode.h
> > > >
> 
> 
> > > ...
> >
> > Kevin happens to updated the documents on new feature backport 4
> > months ago, thanks for checking them one by one. Luca's only concern
> > is size of the series, driver vendor is on it's own risk to backport a big patch set.
> > The series supports new fw and QinQ, is it easy to split?
> 
> Split the patch ?

Since the major concern is the scale of the patch set, is it possible to minimize the patch set with basic new fw support?
A small patch set to support new fw is acceptable anyway.

> 
> >
> > Kevin, is this the first case of feature backport? How do you think?
> >
> > >
> > > > https://doc.dpdk.org/guides/contributing/stable.html#what-changes-
> > > > shou
> > > > ld-be-backported
> > > >
> > > > --
> > > > Kind regards,
> > > > Luca Boccassi