From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1344845633 for ; Wed, 17 Jul 2024 11:18:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78102427C3; Wed, 17 Jul 2024 11:18:21 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2076.outbound.protection.outlook.com [40.107.101.76]) by mails.dpdk.org (Postfix) with ESMTP id E10224025F for ; Wed, 17 Jul 2024 11:17:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dENEn3uEa8vbA/os61op7N5roA0S0/mS170KIITsRFNFEeuF+fTkEyRzYvWPCJGSNeO5cLDO5AXdCcEmYb3GzwKfzIxngkttGdvAV7VVl+WpapJWOMOPsLysW93oHhSsO1FKT42QmL/j+CMUbZtjuW7Sr8+cRuTbMW/l6T7Pru0M3iYSc0cQ/CyrJKUWz9c6KG22fSlQm3Yrol3nMBgO9ANfst/LDYOYE09cHyfoNH/yVh7aWkuHH/oSvHL8r/KscohfEhVqEwFlg/N+SHrBjJRmFv5SMashGXP2oGxSJKaWHXLEgxtTeADnL7ZPXPC5LHmYRW0kUM1xTuuyQLc+Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Tno9oUbUVt073Muh/82+1NSF/J4yI7N4EWvKAVrUrA=; b=nW7OlZM/x2lctspovaRjJaThe51UK5A1cTQ6RD7ig64+dMH9ONSyVeOCjeIrQJVSkZw9pgMFx5ePQemfbKG/KFdjCQ/s7/QmHJsrp1l65H+aSxc00iyg7c9QDlCgqoeng2lqf3QkfiO+guF//zcyDLGJoGxCYXyEJhCDyLnp8eQTCtJGJ2nFlrjhvOtLk7kNwWHh8/Bzx/3dYRtA9YPz9YnIJlqXg7H+27JTWI5hbhRx8nXRXgmob7GkdCsrNq0Wm+bEJ8JTvw+DSvU5cyvaN8Se1bidNDk98K2y4559BgqUjWB7fXsZvAcGS5t5ZsQDQS4zUUJX19c90wpWz9FBrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Tno9oUbUVt073Muh/82+1NSF/J4yI7N4EWvKAVrUrA=; b=kE1YsMd1jw1XKtxhH7nMVjAgRJWEoQRw6usO8ho+U4+ARBjVJ9X7RQw4EJz9uSR5I8qoOMFwAJYtp/JrZqv9ndulLGP6eHOvXLpiaOlY31MrbLrPxxs4a/o94wyp5h81QwU4u935aTYCEFJjiQZq1IH7T7fJPlGauUw4Vb2yTPj2HyihUQ3xardVq6RxXVMaV0yHGbYlSSJ/d5XSl8Y+XwxlZIOubeh7gosPlXe4k43N2lYqgZCxU7wx90XXi+2mFQ4uCaZyv1ihv9dnKD0UTc97YOyYbOk4q0ErPIPMt8zT+vGiKgth7raFnCEdi92bmFqWJIKQnuBQWSyU67EwuQ== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39d::14) by PH7PR12MB9201.namprd12.prod.outlook.com (2603:10b6:510:2e8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Wed, 17 Jul 2024 09:17:05 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::79ae:2610:e503:b15b]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::79ae:2610:e503:b15b%5]) with mapi id 15.20.7762.027; Wed, 17 Jul 2024 09:17:05 +0000 From: Xueming Li To: "Ye, MingjinX" CC: dpdk stable Subject: Re: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Topic: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Index: AQHa1EtHfPPnkrN6C0OUF0DCQUGlcrH6N38AgABz4Ew= Date: Wed, 17 Jul 2024 09:17:05 +0000 Message-ID: References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712110153.309690-1-xuemingl@nvidia.com> <20240712110153.309690-21-xuemingl@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5373:EE_|PH7PR12MB9201:EE_ x-ms-office365-filtering-correlation-id: 3d42c68b-a45c-4be6-c624-08dca64139c2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?7Wz91w7urgRpx9WwpXlaUR/adTuD9ODi09/fqNpZjRl1OR1T8bQmP83I1pKi?= =?us-ascii?Q?clX3tff79X1lUnX7ouyTVLauXzckT2BDYhj4/QrRwVSzsDYWx8t4BErEaHLI?= =?us-ascii?Q?/VFEgRIA6BgbRgP6G4OfcftRb/IsD0GCPuINp+Wo5WCEHmm83sJedoNQz7M5?= =?us-ascii?Q?aFhMFNL7u4m+7/tYCu0ZHLxFGIhsEf80XyHGZQTnJfpajp04Jbve7aLpLESn?= =?us-ascii?Q?qHmFeVRNnAeOHCeA5ZcxYcDbPqZpPlGbC/ZsTrmrkILcaqxbuL9Un5RQdAoH?= =?us-ascii?Q?jQ9ptnjU9N1Y36ZXAy3ptuw1UJyQ6FglRW8VzbVIkLImKZ9TJyJkbQq+xjxy?= =?us-ascii?Q?wzthUvED7c8FgSduwmt26NMep0UbwLVlr+KRwklTZa42vhqJMO3mhAeOFZpy?= =?us-ascii?Q?a51Pc/ideMC3c8naiIRGWIm8br38QiYK7IjkGscjhed2nezd8gKdETkYjOBj?= =?us-ascii?Q?uY943aQ7hzPsainJaAonZG9b2botMN/oTQx4gwgx6EqaXjyhZDtOpyNTl2NN?= =?us-ascii?Q?zoEzDT63ffMg+Lx0C+ucwZpmhInlYqrgucpAXVcrzk4KOVeYwrK6VxAtAmkO?= =?us-ascii?Q?DowDcTvC5ktZsgTZ5lG/cDbPL2WkWEdzb27MvhFrtUkg+fMBepI4cR+ep7VF?= =?us-ascii?Q?W6W9wqg8z0zI3YVLlfh3RJZ4pRtXIAF6fHiJqUrown0GrempGNcG0Yaj2upA?= =?us-ascii?Q?E+coR3uqVYu09lJ/CRpAiRsYitJ2vIhW7aQeWyDorDGO0JszgmYCggdYri6z?= =?us-ascii?Q?9bydNsix8UEziI5frxv9AHdu9O3Su21SHEmgkVBP2Rez52b+AVQK1nycUPJ5?= =?us-ascii?Q?gOdmHxLmC1SCxytcsd/o2oZ0IzBw86UMAl5Y3+3Li2KcigXP9sQdyeoxmfj/?= =?us-ascii?Q?FEQ1kMVPtLj4iVvKiad7vNtU9jE9+eubrWP55YPkcpwt0d8XSahxnxSQU+fo?= =?us-ascii?Q?VB8vSKSiO4tbbX6m+ryypwipQkOxASkWUaOTObF1t4AtyoD8HEnG5kkOIfsL?= =?us-ascii?Q?1ladpCEIv3hrfJYYhHhJzlf1gEBlVFmub1tIrRmmnjnxqKIb58SbTspJZNB/?= =?us-ascii?Q?/iuChMD0VqUSE5NUPNQxINTVsyXn0ZhUA5etS2tv3uG2l+7V7TnPiFrE0Vjc?= =?us-ascii?Q?d7wJkT7RrZZKEcYKNOI++c3IJdo5mLn7w/7+4HhbcmqvgsJSjOHZMCkodEfk?= =?us-ascii?Q?Lz5Rt/hCwhlBBPnHOgRPEfH0oiFBS4Q/oCrjg3QkdPILzruPWtCezXThGbOB?= =?us-ascii?Q?DML0xdO1Lcvawx4MNjMEbpPgHMld39I99kKHvmgq+GEtPSTmR+1qFswKfz9N?= =?us-ascii?Q?VcwZqg8f0RwYwJn7y2wrcp1o0A9zX51FWJ4yeTw10vsbkZMYAzTl2bhrV8Dt?= =?us-ascii?Q?3xwriTGc54eQwtNuAU9jrWa5KWw7QITE0eD8qWAnDUIAxlWBxw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t87ru8saqMo4ogT95CNJ1rbVVfbMhEwqWyipCAEJnq406UEBOO4L1JDpCxe8?= =?us-ascii?Q?oTWdg3QnXz9BR0o8kCdf2mhfODOmFnXBdnbUo9QA47Ph1yhkpRSBjfD+ovCZ?= =?us-ascii?Q?XQFdmARy0YcUdoaaMD6uOY1VpEVQ9RG+93v9ZApwRl6XLqnnX0YSQhDi/FCE?= =?us-ascii?Q?ohA8mSYFta1XRwyFaI82+p0V5xKKj7c5WN3huj7xcA4PNZjAvIi3qT9LbAil?= =?us-ascii?Q?toFCZ43KycldMlp8aqlZqDIOTzbx/uLn+yUVFZR75+91TLylzOCpmaH5LJn2?= =?us-ascii?Q?EldR/PPj1zYQ+GfYJ4JtNDJnOSEyfMLsVt9nGNBCf0gwe2owLAuLQc4es3Os?= =?us-ascii?Q?EweYADKma4Ermf/U86W+ReGV+jDWcCHgFhTpoV/Erg1Ur2+E2//RwiwaWrx3?= =?us-ascii?Q?LgPUlpwGyi7CYjKwbxiqZ8LuGP5cNG/8CN06WDAR9nPIl3erhd/98eKzckf0?= =?us-ascii?Q?YdH2JhqKy9cEZOPvafi1CEWd2SlveZS+nYZ/oL1omxTOwBzwj/e22sJtTp74?= =?us-ascii?Q?k/q+6mgMftlOCtdLdYnvAxI6K9sd+c5nXC4LxmH/pMqDzAj5wOYNugblKASu?= =?us-ascii?Q?QLAerj96hlnCO4PKYSpNn8goeN/kjAURfXpIHnia/RyV5sf2V7VhWMAxZadu?= =?us-ascii?Q?kPwxdSL41hDvLZKskeznqvZxFys4TgcMqoY47NgsLUG7c4YrBKmjX67pdbg7?= =?us-ascii?Q?i5ehDXuWm+CVnbPWDu3ud0KF7DNwTVa7acINWJXnR6qECZijTwKFQiSVdGS6?= =?us-ascii?Q?BhGI7OHmXXUmkz/eRiTH3yy/FHWNPqmxKl/4l2/iwxPgK9KG7j32DgRgzWi7?= =?us-ascii?Q?p85E7afnN2AdHPKhZuvPiAFqoyi0laVVGDs3LShi0us5swopPGfl/EBgRJYN?= =?us-ascii?Q?1FAYMyBP2Aaa+bcdVrY72uvEF5OS4wh8kzvoCzhpai2lljRBaz8O0N/Ek84R?= =?us-ascii?Q?YujPtruNVGb1J1d7bqrWcLwQhBS5PV9ZueVQH/d5cy5cEEZGErvh6FYEdIre?= =?us-ascii?Q?EkcYKzPmXKWuvGuRlkIf9dMwba9jION9+rJ+Qdy09g2nE0cqpuBTlura+RtD?= =?us-ascii?Q?dDKyhnleXdpSf6PaqA01HwkZHqJBgGLf0xOaGLJ7JAEQKi6Z3G5Quz+qVPSE?= =?us-ascii?Q?ngu9b7cDT/gj7/KUG4ZkS31nCHm2iNXxLVp9XE7NQ8YG0Gn1JU3lYnqHifB9?= =?us-ascii?Q?sre+BeX/D2k5a4jSWyfmSbbPCIFnHnZ6JjthfnTZLz2KpAfw5viOfehWZQhe?= =?us-ascii?Q?eHxXx52KKiBtCYDnX5zl8e3snElRnzC2V7xFTl0yCBnNNPRT9+1k+/HLNvPO?= =?us-ascii?Q?s+YQuW/6VK1bfugononXYBhpmdR6NVhWnysXG3UpKrrT8mgLmRbhr4zf5Ywl?= =?us-ascii?Q?3R5U41jkjfriaPsi8VoIq8dvtK+dWZWXIaHbKrWL4JIlhIdOCn9yiSBmw4WS?= =?us-ascii?Q?/0lH0XZFk9iIKXheC9RMYZoyPs6IQYguo5x5QGTVF7v3ErUaqjhztlOR26om?= =?us-ascii?Q?U48n3WLqgqxl3vKlstdbTa2AM/qpvkOLLAdVfjgeCOrDxhPhXvbv3onfo6sg?= =?us-ascii?Q?hQyatrSI6sQLY0JcHcJ28G207sj60VKWkrMMvNrC?= Content-Type: multipart/alternative; boundary="_000_DM4PR12MB5373F0A22750B5AC773B1D1BA1A32DM4PR12MB5373namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d42c68b-a45c-4be6-c624-08dca64139c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2024 09:17:05.1320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wvr+ux7zL7ItROpwtX3gZnxF010JtyKlTmvt0rY4atOyJjnhbLaINOm8sNNhDXNR/CMjrdNrfjuLhqvSrpXj/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9201 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_DM4PR12MB5373F0A22750B5AC773B1D1BA1A32DM4PR12MB5373namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mingjin, Thanks for reminding, will remove it. Best Regards, Xueming ________________________________ From: Ye, MingjinX Sent: Wednesday, July 17, 2024 10:21 AM To: Xueming Li Cc: dpdk stable Subject: RE: patch 'bus/vdev: revert fix devargs in secondary process' has = been queued to stable release 23.11.2 Hi, Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything. Thanks, Mingjin > -----Original Message----- > From: Xueming Li > Sent: Friday, July 12, 2024 7:02 PM > To: Ye, MingjinX > Cc: dpdk stable > Subject: patch 'bus/vdev: revert fix devargs in secondary process' has be= en > queued to stable release 23.11.2 > > Hi, > > FYI, your patch has been queued to stable release 23.11.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 07/14/24. So please shout= if > anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging > > This queued commit can be viewed at: > https://git.dpdk.org/dpdk-stable/commit/?h=3D23.11- > staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b > > Thanks. > > Xueming Li > > --- > From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > From: Mingjin Ye > Date: Thu, 14 Mar 2024 09:36:28 +0000 > Subject: [PATCH] bus/vdev: revert fix devargs in secondary process > Cc: Xueming Li > > [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > > The ASan tool detected a memory leak in the vdev driver alloc_devargs. Th= e > previous commit was that when inserting a vdev device, the primary proces= s > alloc devargs and the secondary process looks for devargs. This causes th= e > device to not be created if the secondary process does not initialise the= vdev > device. And, this is not the root cause. > > Therefore the following commit was reverted accordingly. > > After restoring this commit, the memory leak still exists. > > Bugzilla ID: 1450 > Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") > > Signed-off-by: Mingjin Ye > --- > drivers/bus/vdev/vdev.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args) > return devargs; > } > > -static struct rte_devargs * > -vdev_devargs_lookup(const char *name) > -{ > - struct rte_devargs *devargs; > - char dev_name[32]; > - > - RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { > - devargs->bus->parse(devargs->name, &dev_name); > - if (strcmp(dev_name, name) =3D=3D 0) { > - VDEV_LOG(INFO, "devargs matched %s", dev_name); > - return devargs; > - } > - } > - return NULL; > -} > - > static int > insert_vdev(const char *name, const char *args, > struct rte_vdev_device **p_dev, > @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, > if (name =3D=3D NULL) > return -EINVAL; > > - if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) > - devargs =3D alloc_devargs(name, args); > - else > - devargs =3D vdev_devargs_lookup(name); > + devargs =3D alloc_devargs(name, args); > > if (!devargs) > return -ENOMEM; > -- > 2.34.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2024-07-12 18:40:18.570682691 +0800 > +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch 202= 4- > 07-12 18:40:14.356594197 +0800 > @@ -1 +1 @@ > -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00 > 2001 > +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > + > +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > @@ -20 +22,0 @@ > -Cc: stable@dpdk.org --_000_DM4PR12MB5373F0A22750B5AC773B1D1BA1A32DM4PR12MB5373namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Mingjin,

Thanks for reminding, will remove it.

Best Regards,
Xueming
From: Ye, MingjinX <ming= jinx.ye@intel.com>
Sent: Wednesday, July 17, 2024 10:21 AM
To: Xueming Li <xuemingl@nvidia.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: RE: patch 'bus/vdev: revert fix devargs in secondary proces= s' has been queued to stable release 23.11.2
 
Hi,

Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything.

Thanks,
Mingjin

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Friday, July 12, 2024 7:02 PM
> To: Ye, MingjinX <mingjinx.ye@intel.com>
> Cc: dpdk stable <stable@dpdk.org>
> Subject: patch 'bus/vdev: revert fix devargs in secondary process' has= been
> queued to stable release 23.11.2
>
> Hi,
>
> FYI, your patch has been queued to stable release 23.11.2
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 07/14/24. So please sh= out if
> anyone has objections.
>
> Also note that after the patch there's a diff of the upstream commit v= s the
> patch applied to the branch. This will indicate if there was any rebas= ing
> needed to apply to the stable branch. If there were code changes for > rebasing
> (ie: not only metadata diffs), please double check that the rebase was=
> correctly done.
>
> Queued patches are on a temporary branch at:
> ht= tps://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging
>
> This queued commit can be viewed at:
> https:= //git.dpdk.org/dpdk-stable/commit/?h=3D23.11-
> staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---
> From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Date: Thu, 14 Mar 2024 09:36:28 +0000
> Subject: [PATCH] bus/vdev: revert fix devargs in secondary process
> Cc: Xueming Li <xuemingl@nvidia.com>
>
> [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
>
> The ASan tool detected a memory leak in the vdev driver alloc_devargs.= The
> previous commit was that when inserting a vdev device, the primary pro= cess
> alloc devargs and the secondary process looks for devargs. This causes= the
> device to not be created if the secondary process does not initialise = the vdev
> device. And, this is not the root cause.
>
> Therefore the following commit was reverted accordingly.
>
> After restoring this commit, the memory leak still exists.
>
> Bugzilla ID: 1450
> Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process&= quot;)
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
>  drivers/bus/vdev/vdev.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)=
>        return devargs;
>  }
>
> -static struct rte_devargs *
> -vdev_devargs_lookup(const char *name)
> -{
> -     struct rte_devargs *devargs;
> -     char dev_name[32];
> -
> -     RTE_EAL_DEVARGS_FOREACH("vdev", de= vargs) {
> -           &nb= sp; devargs->bus->parse(devargs->name, &dev_name);
> -           &nb= sp; if (strcmp(dev_name, name) =3D=3D 0) {
> -           &nb= sp;         VDEV_LOG(INFO, "de= vargs matched %s", dev_name);
> -           &nb= sp;         return devargs;
> -           &nb= sp; }
> -     }
> -     return NULL;
> -}
> -
>  static int
>  insert_vdev(const char *name, const char *args,
>            = ;    struct rte_vdev_device **p_dev,
> @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, >        if (name =3D=3D NULL)
>            = ;    return -EINVAL;
>
> -     if (rte_eal_process_type() =3D=3D RTE_PROC_P= RIMARY)
> -           &nb= sp; devargs =3D alloc_devargs(name, args);
> -     else
> -           &nb= sp; devargs =3D vdev_devargs_lookup(name);
> +     devargs =3D alloc_devargs(name, args);
>
>        if (!devargs)
>            = ;    return -ENOMEM;
> --
> 2.34.1
>
> ---
>   Diff of the applied patch vs upstream commit (please doubl= e-check if non-
> empty:
> ---
> --- - 2024-07-12 18:40:18.570682691 +0800
> +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch &= nbsp;     2024-
> 07-12 18:40:14.356594197 +0800
> @@ -1 +1 @@
> -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00
> 2001
> +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> @@ -4,0 +5,3 @@
> +Cc: Xueming Li <xuemingl@nvidia.com>
> +
> +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
> @@ -20 +22,0 @@
> -Cc: stable@dpdk.org
--_000_DM4PR12MB5373F0A22750B5AC773B1D1BA1A32DM4PR12MB5373namp_--