From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0C19A034F for ; Mon, 7 Jun 2021 09:29:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C82B640041; Mon, 7 Jun 2021 09:29:13 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2086.outbound.protection.outlook.com [40.107.93.86]) by mails.dpdk.org (Postfix) with ESMTP id CB1C240041; Mon, 7 Jun 2021 09:29:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UofUG84PosP1O88SL5PRfBjaZv2Hb26AWz1H6KD19tUq+SUL4DYhhiffHaQBq7M/NujXIqElf74o/BUSN0Z6XvdSX2FdX4whRS0U9NVs+lv88dOajdLAkB+uq2+/OMgnXbqr+ixewmIEBsJzMqUl0o+vKBK49NE5yOW21vBGNzPjJGF2TZnSqcAlnbvAKPSwuOYtm0O3rqe0sF5EUwuXUBoVKisEfEfqQMz9L+DFMRKUl5sYQIqEGkmZE+Ehrot3zBh0n2vX0Ydzr03f2uzldcE4kNWNoRINMrwMU2IckXd1CMxKM1B/pbPd6LgPdpIJa93RxrN20m2NS15F0ba81w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DPfQ4+4KnrB7o7J+xt1dhgFqWJ3CjujXB5O3qK+hcJE=; b=GtNQiMKjcjsQnPEzQtIA5GcESrL3OtJEFmDVhwnMnnWgkB2a1daAFQ2Uqnx8Ts7vPJMuUUBrEwur55TKuqYlLDTi9dRIaoyaMTaHY0Et+O65UBn4CB7VtfefxV/JEntOIZRWseSC/wDdOl48hgv+jxzhEcgQpbZosaNslG30nKQ4hfeESTxnZIdNlmXxmBfycjS1Vbw7ugovD4JID84mlCuJCtmRGF0jwKtgR34Andb/mDbL6iJFEYzmU3DgeM4kL+NhBkJTP5rt3sNI0/k+JhhDWFJmCLTQ7m3WwycCJn0ciKKQk/j7zgv+95pyDK2yBFz6wXiwdSEMgA4Uj+KFlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DPfQ4+4KnrB7o7J+xt1dhgFqWJ3CjujXB5O3qK+hcJE=; b=GBdfnC8h8JQVnOUNRfLrcldzFBZqpdVHAbWteMN+akns0BeNNL6SMYeq4nYrgEnU2dY/4z2wS32LNugrB1To1jLFFifnBbCfAXiYdWAXaxdOMrzZeDSJiqyYqLefAgOvDE0OKdbZgP4JlChTOt7V7vP+glXmW1NwIlpxFbWM3jAptcuqvmMk9DQ427gXVkQHQFLWQQqfq3V71eByr+jAMoQ5gfbpZ7oMnJeMsHf3veb+ku+k+0HLsZVUJXDBNPEtITimLvjucatoqlwK2ZtRinvXRZlAyH9ammszMZ4G7X8mh3IAQAGnitNZ0//BxfqD6v48atD40OcfGONsXoe2Dw== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5293.namprd12.prod.outlook.com (2603:10b6:5:39d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.20; Mon, 7 Jun 2021 07:29:10 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4195.029; Mon, 7 Jun 2021 07:29:10 +0000 From: Matan Azrad To: Michael Baum , "dev@dpdk.org" CC: Raslan Darawsheh , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH 3/4] vdpa/mlx5: fix constant type in QP creation Thread-Index: AQHXVrVpGsg/56nD70uU3nWt7rxWiasIMB2g Date: Mon, 7 Jun 2021 07:29:10 +0000 Message-ID: References: <20210601071122.1612432-1-michaelba@nvidia.com> <20210601071122.1612432-3-michaelba@nvidia.com> In-Reply-To: <20210601071122.1612432-3-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1a81f4c-bc9d-43fb-71d7-08d92985f185 x-ms-traffictypediagnostic: DM4PR12MB5293: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ziEQT38aq64CUYaxVfYuJZ5Tdbk2IDerukdmjUI+kobwMqJ5mOjx0VEPF5Xb/e7pDFoFC5wQFXijLL+e7JAYhsTCcS7tC2RfgdkGKo6GpPh4DtU/swX9iLIqJ4Bi26hcPGAjwRWZB5blveynRp6L9YedVMdO+6x+/LVf9b7sAo0sIK4CGVxwc3PdGIYOTow35NNw78nBLOB1WBBFtC/RamtP+engmHSuJuZknfDSyF7D9gfAjq1GI6q0hI7SweQALRQBTQl+dudnrx3vSG7ls3WsOI1/VEc7T82YUoGrCCuYB7esCl1E4kCVR/J+f5Fq1dkrsbCUpmHXunGsIxmVu1z/6qpABPJOKIyLahtC3ByBF870FSiHpSbO6DZQ10feKqxerpmZUtSTOPIDArok02lvucJyyFsBpzPDN80whxyfFOpNGwTHPpVPR9iu7drjYVj6EfWlVKCuxYafTOKQRyA2PDD62l9wG1v98S5Td7Ye5PmwrqSFCJHwL8dcXpHYw+Nq3VYuh7MkNi3E+00YyAvlndUq9b4FcphVm2gXfWvNgQx6dGmB9UHjW/GTeZLbHYN5QWujTAJ4HEflz24gPf8fORa6J8Kb/AkSbJ6Yht4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(9686003)(4744005)(8936002)(110136005)(316002)(26005)(5660300002)(2906002)(66556008)(66446008)(38100700002)(52536014)(66476007)(186003)(4326008)(86362001)(66946007)(55016002)(54906003)(450100002)(7696005)(76116006)(478600001)(33656002)(122000001)(71200400001)(8676002)(64756008)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jh56q2BYUvK+Mf4q6XyltYjJGJA7PrfS6Lg4g6AJY/YFPqcns2zDud03tH3c?= =?us-ascii?Q?hxQADKuymOlQ5AIKDyvAQe9JU4mEQC4BUxta/WpenURNhC/tef5Zr3G4wq1X?= =?us-ascii?Q?GG84MOIMRipTpsgu4LmLwgcU9eBlIU7NtpQQn+CtBCFhYHVBQijGG3CSaQ/9?= =?us-ascii?Q?/elsA7jwO0Eb5ZeEF9fyUjTn/VKBFfYpVeKdy52G1S0imbnbEFQHDB5naZLx?= =?us-ascii?Q?VBINnHeLpkiM/Qa++a62oG8sziSl9SUAzCb6thcDm653ARxcbgjRdMLeI9u7?= =?us-ascii?Q?K6Pvcj+i6bBFxKieju3pZbsavUzxHOZSI2WeHKOqpoY2yWXJ2BJH2+yLK7TE?= =?us-ascii?Q?9SShXuO4y5jjTcrDWnNqcjDMCrKFyGS0H4Ocjwh9W24Z5TnQhDR76FtSQuBO?= =?us-ascii?Q?qhIcZvdM7udPEClr06yLHvGGlNmlAcOyk1NbRO4z0kcbIOcNAL+nsvsbwMoT?= =?us-ascii?Q?2szjTkWt8tisBKEZilURrgGR3haf2P/ftMmwI50hkTrBISd/Gbgc69aK/0Zj?= =?us-ascii?Q?PKorMJd5qf6Ma3o72zHXNJE3n9qLSGbAK4UiRNqA1LV4GxO0s55HF+nwY7oH?= =?us-ascii?Q?POVuTBrVAMoIkoPx1F0dlDybQO2zxDxwt0Z8/DLPIrfoRLiv3miwVBa6h+rK?= =?us-ascii?Q?zk+3FyzP3xraaEqRX7Q56BjRfSNbaxGkvP6WypzjGRZ0k2/Km5dSZDAUZq/q?= =?us-ascii?Q?PLZwq/ukPrKTnKnNbp/OnSsKd/yBB/Zuvq2UrQ6LAyGoUn4Sg332qjdu+fd9?= =?us-ascii?Q?7GQ4ZV1Pms8huxUQm4pZhc+JFc3vKDRozzWGqH8c3hhnbdr883nbS+g1i32A?= =?us-ascii?Q?3Y+wo5AfYDkNP7VMA6gzVudHt1NhrcXLG0ou+UrmHLi6PRHhrswMYHlk6Dwh?= =?us-ascii?Q?nSDKq44TBUxRH0wi//usynS16AJ76nx/FsjWj/dhPpLmX5APjeE6Gk+S0dim?= =?us-ascii?Q?ToV83xNjPurOA4IoxdH2oLbdWto9r0tEPokwUJyKU1ZT85/4U38sNqtTpV8M?= =?us-ascii?Q?Uqhg4+8R0wUQoZN9x5yyFlxUHiAPmMLyX94hiCMFHehFMQhJOLZWbisDLx+b?= =?us-ascii?Q?mlc789TtAvKGHCevivWiQn1jBhmcyaE8O2l4ggFVI16xreYkoUJJxn6Sr7x6?= =?us-ascii?Q?yCBdZKyB0/A4XFG2LaXm6GWLZ2ANMgYPu7XZh0JdrCDyQeH8hrHnn3f0rVqM?= =?us-ascii?Q?raEnYTb92IXJViBg57D5bJAHPuiMSxehgfp9j2mu2tKPjpIZoK+j3fs+eJDb?= =?us-ascii?Q?A1+gghotVuU10Bri4p/rVL1YNNEsuPZsYivjAMeAOe0Br1tGRgZeOYmVQXT/?= =?us-ascii?Q?amvLTIXFw9x6R0hgw8tvSDSS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1a81f4c-bc9d-43fb-71d7-08d92985f185 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2021 07:29:10.8302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xlIDCs6jvEvDgplqX8TUbpov6LCtlryKflajL3dVPyq8xNTgjHDL6lShDtEfT/Vpm8/1kGxVrl+9W9Ubj0Vkkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5293 Subject: Re: [dpdk-stable] [PATCH 3/4] vdpa/mlx5: fix constant type in QP creation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Archived-At: List-Archive: From: Michael Baum: > The mlx5_vdpa_event_qp_create function makes shifting to the numeric > constant 1, then multiplies it by another constant and finally assigns it= into a > uint64_t variable. >=20 > The numeric constant type is an int with a 32-bit sign. if after shifting= , its MSB > (bit of sign) will change, the uint64 variable will get into it a differe= nt value > than what the function intended it to get. >=20 > Set the numeric constant 1 to be uint64_t in the first place. >=20 > Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum Acked-by: Matan Azrad