From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77542A04A2 for ; Mon, 18 May 2020 04:56:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5444E1D508; Mon, 18 May 2020 04:56:32 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D4B441D441; Mon, 18 May 2020 04:56:28 +0200 (CEST) IronPort-SDR: k/+yBEs8rBYoFwP1gqXyLt6W5okIoMhAIArAK7HakMmxbbCx1aOYUfJ6nldlQKTokNyTBA4A/O ffvDak9Ue76A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2020 19:56:27 -0700 IronPort-SDR: eFV6+aPKVeSil6LHoczdmcRn0h4U4l7B30vz9j281sDjJjXjF7r/UpDkkoI9YwXxGQzfh1RpTd BLL4pwHNFu8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,405,1583222400"; d="scan'208";a="411104271" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 17 May 2020 19:56:27 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 19:56:27 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 19:56:27 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 19:56:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OSMswWgTReILOHOCTc5JKZKzn7crfssDCwt/YoAD76mFCugY1bkw0eyVBcrl2BqYBYITsXPEIR3rSfmxIdghBcpylJ/Q0KZH/S/Z3XwAho2dgAglMJLmJLZ2zGmLMxgeYkJ9XJGHwK6Sp2kwPvC0Y1muVNmEzfxwtwzyKklC4zDZ0Ksgsna3XtGFbyWeWUVs2s7jkEgA8UMoYFkp27XPNf+684LcvunOegAPaXWJfZyYvEHpkK+ga58isUjRmbUifcBvtH8W7KTbyYCf37dUxkAgJI/+W08T7J7Kk6fyTh7X3i5OEixW7+bjgN2aJekBP4WC6s3UnSJlZnSk9Ru+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JU5zZ7wGjWhYNsYO8Hcyd7wYk0pkLAxp0NV9OvXyG0U=; b=MbULjVtr5PkjEN7HD3KuAaqr4bs1RVge0N5aid9bmL3LXGRUFj+X67EgQ8R8nm01zueimnhCW4u66i8oAJgyU16eox/ZWF8jRKhshc3bx2Mf4Rssy0PuqcHEYWz477axA9HaEqIEyIOBWxMU3ErSaOup3R0Pqr9ve+xaUiLYQ2jzwdj2sgzs7rMB1qMtsaUVYDzPOAxlS7CDR8uytqVLbOShpIGAFEQcInR8JDpitBXO9YUVP0PHCnKF6mLRiBKpNbqbk7XrPqTLmLausqhtWMY4JhqSmuEQ4Be0UgHKw93528ZOvE4ymB7KQpL05Zq9sBndYBQ1cC28IBQd0mIvGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JU5zZ7wGjWhYNsYO8Hcyd7wYk0pkLAxp0NV9OvXyG0U=; b=o5dvzUi1F4De7lCe0l+nB3CGMUAh4Ud78swpgS6Q2MtXDCv7giC+5BC9GWKPjY9d7dzaGBRAZtZUZBgnkWubcqJdssT0XgrEVZaDXr9e+Zte1vpAc5n9drMITh0MvVrTD0VXu4b8H/9LF84qsIAKUZ1a/9ki8ObPdAeZ6cR1JMc= Received: from DM5PR11MB1387.namprd11.prod.outlook.com (2603:10b6:3:7::21) by DM5PR11MB1324.namprd11.prod.outlook.com (2603:10b6:3:15::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Mon, 18 May 2020 02:56:25 +0000 Received: from DM5PR11MB1387.namprd11.prod.outlook.com ([fe80::440c:3fe7:849b:3aa9]) by DM5PR11MB1387.namprd11.prod.outlook.com ([fe80::440c:3fe7:849b:3aa9%9]) with mapi id 15.20.3000.033; Mon, 18 May 2020 02:56:25 +0000 From: "Zhao1, Wei" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Yang, Qiming" , "Sun, GuinanX" , "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting Thread-Index: AQHVj52aqNTbLrC+jUqMXaBDLfDoLqij1mBw Date: Mon, 18 May 2020 02:56:25 +0000 Message-ID: References: <20191030142736.54683-1-guinanx.sun@intel.com> <20191031113152.3587-1-guinanx.sun@intel.com> In-Reply-To: <20191031113152.3587-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDBmZDExMTAtZDJhOS00MjQ4LWIwMTEtZTU1YTlmNjY0N2U2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWGF0RkpEOEVpYUNVdG9JT1VBMWxhYlRkM2t5eW1MbWVVRjZLSEYxcHBwQTg1T0xERVA5R2hUSGQrZlF6ZnBPayJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4766c75c-bb83-496d-8e53-08d7fad70dda x-ms-traffictypediagnostic: DM5PR11MB1324: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 04073E895A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EtaxnLVN/tuis6DwVjMbo8Go0jAHIDe+iCBJDTRrItLHaOZaNipTe2DrfVTGJxPvZiSYnb71/oBB4mTCQbXdWB9l13bL4qUhBcL6bhOl0HXs4OxLqqn8JYOPGoQZh6No3seGTdDE7iSqR/SaLE2mml4u/tVvijXzrv9xtDow76RrP3Xx4bv/Wf6dtmQg3+XLDtJKquBF4IcPZRMM3k7RVgzMixdGAei+TLEhVx+4N+5TNnXosmaIA/dPF3WhkvdyBkED5o1Od5UYQZaNOvjzhRzx6OD+ddzs8HAT3aO77X08AiDQpaiq8zuoo8/yRBQzfWWsLgmDVzeBAASROV0RTkycN65sKJdnNRcV64q5vIQsQxUZ7tbTucFPMcx6U/+cUpypfgmHiqgK5201g8+5jznGQQXsLy7dgeivdzzUtPoczSxXpLLUsXB+s51j+anu x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1387.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(136003)(396003)(366004)(376002)(346002)(71200400001)(7696005)(53546011)(478600001)(6506007)(450100002)(316002)(110136005)(4326008)(26005)(33656002)(54906003)(52536014)(2906002)(186003)(8936002)(5660300002)(8676002)(107886003)(66446008)(66946007)(86362001)(76116006)(66476007)(66556008)(64756008)(55016002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 9lYZI1MYg179NhvCvlNdUrwhrcf7Ta8OA2K82R6HFPTQdmrq0FKxqLDHueKmtx0sWb3lMM/bFINI5k/5/b2YY6PE/JR5VeMwAAg/gdnzeKz+JKzKvZrN8z2tOYbuuX9y9KFuXgBinp7F+FJr9EkEE7PwnloGetNMhj0OKdVNAGZFDGCLQ3XL1T5xv7EMnPT3pes/6B8vEc7XmKvKMksQiKmupQizfGBNYd4xb6kb/AvzUByWf0zX5SCBhepvl5GzVD6wjP9kVN0Byq11nCfuDYZHwykF8LfF+jH2R4cgDVsyv9YMUFYUahXulL/tsITyHRXwoSnEKUxafjm4LDkENE0RDTTeNMSneKtmlM7Nda9OeLd4cYY2PWbB/K/ymWor0mS9wKjibiMSM8K0CPninX6FlafSntlt4rbhpwKpxYJ/+mz+uV0sEENKpY7yYu0A3+ELJQ9VH3tiuDeEubEu3GNusB67fZTrTU3RZ7QGWFs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4766c75c-bb83-496d-8e53-08d7fad70dda X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2020 02:56:25.2044 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kLepbV3i4XF3ftllSgcEiRGkcfBsf9laWrPdt2fHarGG+uBzCVB2KTpSQy+gOzyRUbqkFu56JcACh0gL+P7qZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1324 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Guinian > -----Original Message----- > From: dev On Behalf Of Sun GuinanX > Sent: Thursday, October 31, 2019 7:32 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Sun, GuinanX ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting >=20 > macsec setting is not valid when port is stopped. > In order to make it valid, the patch changes the setting to where port is > started. >=20 > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Sun GuinanX > 19 ++++ drivers/net/ixgbe/rte_pmd_ixgbe.c | 125 ++----------------------= - > 3 files changed, 175 insertions(+), 118 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c > b/drivers/net/ixgbe/rte_pmd_ixgbe.c > index 9514f2cf5..073fe1e23 100644 > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c > @@ -515,82 +515,19 @@ rte_pmd_ixgbe_set_vf_rate_limit(uint16_t port, > uint16_t vf, int rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, > uint8_t rp) { > - struct ixgbe_hw *hw; > struct rte_eth_dev *dev; > - uint32_t ctrl; > + struct ixgbe_macsec_setting macsec_setting; >=20 > RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); >=20 > dev =3D &rte_eth_devices[port]; >=20 > - if (!is_ixgbe_supported(dev)) > - return -ENOTSUP; This driver type check of is_ixgbe_supported(dev), is very important for PR= IVATE API function, You can not delete it, Please add it back, rte_pmd_ixgbe_macsec_disable() a= lso has this problem. Although this patch has been merged, please commit fix patch for it, thanks= ! > + macsec_setting.encrypt_en =3D en; > + macsec_setting.replayprotect_en =3D rp; >=20 > - hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + ixgbe_dev_macsec_setting_save(dev, &macsec_setting); >=20 > - /* Stop the data paths */ > - if (ixgbe_disable_sec_rx_path(hw) !=3D IXGBE_SUCCESS) > - return -ENOTSUP;