From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44E1CA0C4A for ; Wed, 14 Jul 2021 03:06:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 317F4410F4; Wed, 14 Jul 2021 03:06:35 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 0CEA54003E; Wed, 14 Jul 2021 03:06:31 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="210244620" X-IronPort-AV: E=Sophos;i="5.84,237,1620716400"; d="scan'208,217";a="210244620" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 18:06:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,237,1620716400"; d="scan'208,217";a="570942831" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 13 Jul 2021 18:06:30 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 18:06:29 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 13 Jul 2021 18:06:29 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 13 Jul 2021 18:06:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUQScwWxo/Ybdslag406ij0DKHqwNT84HwNkrz6JV50Q9mZ+lDwrDqzZNn4nXD20OvK6f44jvy5QKkLSsOaAo4ov5/4Lvwf6YzghrFZRcXJA0f8KFcQN4LOHJPK6gaBGMDjkyQNbu5d3KgllevbRLl4WMmLe5fOp0utdsQjlK9FAvbtYWP2UhUH4p/py3fNdprBc83fTwenLlgkqBz5BNJL7evSs6mHrFWuQVSTgB2d2UiwZ+AV4oYwRdLuhS5LzTyJ4ReKr3MP354Igfncr9MFouXx9UnmMQgyEORFOJXzGt0qZljEVMJ4CIfj5DdTKUTapwH6KfxNMHMnveA2OHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYqf4l4M7uO9t0X3ZQziXi7I2IgRjdMmx8OJctrUFsA=; b=RXxFJ1qcorZTwkMyOuHRArOH9eanLyArc41GOeBNI7DISPucykhqN2cgOaKLmnFApKmMw2iwIT8ltQxPXDYdUISBKbHkrf1oOqMCSORQ59DXoTAGA3O/xhNpMmYseYss/xFRdOCGi+ABoXxjUSjhNa2qsgopj/4rEK26dgMarCDEuwLYDWLvwJlnhCBR/nQRt3MK5JQBSiyK8mxjg6J93LX9Nmuwknr44rg8ZARNp96YzN6VkSSHCjXFDe0TMZpQKx4cifYy8dgqoPRfjxmT7c+gO2x+7oOQMDL/RsPuObUfvq/Bx2cB2QlzTcXM6XIjB5NxBnJl8lCgxuMHQw5hvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYqf4l4M7uO9t0X3ZQziXi7I2IgRjdMmx8OJctrUFsA=; b=qPGwKQAfZDE/4HSNDB3hD1xglqcbKde5r3+tcnXpNmoCJS7WW+8KR9sQWYE6Lk0DuXupVMscE5pdd8+JypP6Zh3hMrjS9GfJJOlgaMIP1JykOsrZNR/k3mpR77LNvuNeBYx4/waOXJ2+y4mYVl6JxpHZKp/KRjqaPOSZ6v/Fz3k= Received: from DM5PR11MB1787.namprd11.prod.outlook.com (2603:10b6:3:112::18) by DM6PR11MB2716.namprd11.prod.outlook.com (2603:10b6:5:c7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.26; Wed, 14 Jul 2021 01:06:27 +0000 Received: from DM5PR11MB1787.namprd11.prod.outlook.com ([fe80::e87b:57a0:3648:9244]) by DM5PR11MB1787.namprd11.prod.outlook.com ([fe80::e87b:57a0:3648:9244%6]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 01:06:27 +0000 From: "Lu, Wenzhuo" To: "shaikh@niometrics.com" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Xing, Beilei" Thread-Topic: RE: [PATCH 1/1] net/i40e: fix compilation failure on core-avx-i Thread-Index: Add4S7RJeg85aOxhSP2qFpIg1Oq2PA== Date: Wed, 14 Jul 2021 01:06:27 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: niometrics.com; dkim=none (message not signed) header.d=none;niometrics.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: deb18a35-df35-4148-5011-08d946639b81 x-ms-traffictypediagnostic: DM6PR11MB2716: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JZLDqKIWVGnOaLQTGyMbMsYROmlGlAeHKe/q2c3Yl7GB3Ux2IAyAolq9AGvQ5tzmA7B2mk2tHP5T1Wudogt86PKRwXDmVgnA0y5ToT1nOgCv2UelwvGp3EtFm0qyUs84Mmh49fS6hTZ8pRpoQkUBQi8shk0zZeURQmu/FtbCK86TGivuTw1Im0HIa/bbHGi90adr7eDftG+G5UCjwZL7fyLnpJOpxLy3XmKrxaXrUUqa0JBiZgkNpJlhnr7hv1Ar+nqzt2YlN6GlDTlYjKlJF+EGDa1Ub1tZFy0pM0FbWn9NVmTmYH4mLqYhQ8C+PpYwLlqAv51lG7QBeIgn00MrNPudY4WIqzPWz4UCHX70dRgUnudrRNB3hHvU144fFn/KYSBZj02AAB1fwlvBboJxpD1Ldu1IbpGVGZbBIo7cFAtJjYvvtjPsITnaeG0SDwodlCpAWEVbkvs6ZBhiAP16sx2EFtS/HaiteJnJOGFKnQIHCRQmOjNio437Q/nQfkUVJM4eAdH37x4pzN3bVTajMm5GEtUZ0ps3EGcK7Tsbh7YycXamllb5gLpfA54FmqKjwzDlHVs2CaoylgMea0AuwUewqYiCKIMJBSUBeV/J5nTRDwqjVGSO4PhStU2Kc+ioNoloTvdJs8zDPfQtW+ZmhxvJ0BndMi3OaAOJjMX79XXC7gpYgtCJy7NaH9YNkCJBogokzG161vMlFPDNh6NNxg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1787.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(136003)(39860400002)(376002)(54906003)(9686003)(316002)(38100700002)(478600001)(8676002)(4326008)(2906002)(33656002)(5660300002)(186003)(86362001)(7696005)(6506007)(83380400001)(52536014)(64756008)(66556008)(66446008)(71200400001)(8936002)(122000001)(53546011)(66476007)(76116006)(107886003)(6916009)(9326002)(26005)(66946007)(55016002)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cXxyLBticDKljpbPbpku3fCyBmqxlvKgz6tyygZoFI0ZMrGsS+9l7wF+CyVa?= =?us-ascii?Q?hel/F+ITAzK8pnjC2/FZVSl47h/WH5B/ZUpHEEDK4DmWrARP9fFcyZDMrFBg?= =?us-ascii?Q?aUSQMomDC4mFLV6qbje/7MrcfhyeMoSa1GR7JXlucxIs1BCqal8kNwhkFfQF?= =?us-ascii?Q?iTsPk2JkFR/aIxcMa9N6VJwWhV0rHh/k/glAguZnZyNOEtr4HwLgTL1zYh5w?= =?us-ascii?Q?jNHZwbFEadRKbhUMmjxvyM5UBcB1L9h2OnMb4y32/fm6bqd6uCNxJpuxnVFz?= =?us-ascii?Q?vSnGhLuuXXw6BxaIQBid0B+tVxVSBfzKW6CKkWzOIRF0ynnPbhQ4slTV2Xh7?= =?us-ascii?Q?xsVe0NFPn+haUtCDzVID96nd+lBqVxsZTnEzmrKCkO3jGkwOFWOOPunrYH+Q?= =?us-ascii?Q?H6ctZK7DwcdSrMWK6YE9xbyLzUHFNDHGSuqCqfHAz9e5fup5D/Xrc8md0A+q?= =?us-ascii?Q?1w5l343FHtqRzoNmXPIEQFITcyZTUJoBXfOamC11++3oKMqjW86sA0tHaxTu?= =?us-ascii?Q?eqblukbO0Rt9GOo3YL8QHZNjjB/qzoHWF6d9X8VZ7722d2vHMrxoGOYWmPfb?= =?us-ascii?Q?r02rFmB3CnzHAnbT7Jz6zLx3cyYF8cN4agRC4O5Ks25ITOxRlY5ax/YVhAqk?= =?us-ascii?Q?rPEN43MmedYR6rFU4WFJsciUt+qkLOpNpD9gXjjscuthvpOt3lTAdXytqp1X?= =?us-ascii?Q?erfvTXO7TGCeGIkwuk3d5AVcqPEuOAFEW1Mmcg28qLemJn20XaHGwXm1cGM/?= =?us-ascii?Q?ydpIYzCmvtwsB0Wyg62dvPM9OUwLdmlkEOZKFj0KoERu761LK4AGvtWdOZCt?= =?us-ascii?Q?id7jeexubf4K2Sl0SIgT6pWZQ7jxa3nd5NZMg5FDV/j1HfClNhaI3PnltwcU?= =?us-ascii?Q?/Q3r3cd7OZDorr7QZ265PuCYzPcqPJmBBdNdXNEIAszf8dLzWSdYlFuZ5Dbl?= =?us-ascii?Q?TP2uGLlKJNtBDooVTJc9m69ywc6m+L9zFTRfHn7Ze/OyB0kScu/UBIrAq+2F?= =?us-ascii?Q?5b+YghxJGq96sNTiSdlBDaHuGPaH6pza0+VLnt19A1Hg3PYBgc1Rp7OONd6i?= =?us-ascii?Q?h9+fVXWchnNHrzUvLEn8/Q3visLDbnnlhO68rNaptf9R3zh9Q2aqdhOBBR3B?= =?us-ascii?Q?8w8pWnYDQszQRPGHAeuJT+a0yiVtKmZdfYSFl942ppFwGoGd756kqqabkAnm?= =?us-ascii?Q?AVbo2QT9Ggquz9MaYjJ+twRhjFKE+ThezwzxYabh8diltmWrbwTLHDoqVAgw?= =?us-ascii?Q?tmGRHAV0TKYYyp/CuWAZGdPjzz4sJAm+gBWrOsienIoAbjmgRWhBbSL4RBDn?= =?us-ascii?Q?6gcpNz9JSTaq/R2wEDf0c4YW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1787.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: deb18a35-df35-4148-5011-08d946639b81 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 01:06:27.3515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +BL5qMCLC7qSZmaWazoaMsUmqeUNrX7JeLppK142+Fa8IMQwmHvEz4aYJDuP3XqF88WgFJ5SwQ5cZ9jYEFzC1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2716 X-OriginatorOrg: intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [PATCH 1/1] net/i40e: fix compilation failure on core-avx-i X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Shahed, > -----Original Message----- > From: Shahed Shaikh > > Sent: Tuesday, June 22, 2021 5:37 PM > To: Xing, Beilei > > Cc: dev@dpdk.org; Shahed Shaikh >; > stable@dpdk.org > Subject: [PATCH 1/1] net/i40e: fix compilation failure on core-avx-i > > i40e_rxtx_vec_sse.c fails to compile with below configuration: > - #define RTE_LIBRTE_I40E_16BYTE_RX_DESC 1 in config/rte_config.h > - cpu=3Dcore-axv-i > - gcc which supports -mavx2 (e.g. gcc 4.8.5) > > This is because commit 0604b1f2208f ("net/i40e: fix crash in AVX512") > added > i40e_rxq_rearm_common() to i40e_rxtx_vec_common.h which is included by > i40e_rxtx_vec_sse.c. > > This function is enabled for compilation if CC_AVX2_SUPPORT is defined. > As per drivers/net/i40e/meson.build, CC_AVX2_SUPPORT is defined when > either CPU supports __AVX2__ or compiler supports -mavx2 option. > > So for given configuration, CC_AVX2_SUPPORT gets defined but we don't > pass -mavx2 explicitly to gcc while compiling i40e_rxtx_vec_sse.c. Looks like it's better and more clear if a new specific avx head file is ad= ded. Just want to understand more about the problem. I don't see the same proble= m when using 'gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) (GCC)', don't u= nderstand why -mavx2 is missing. And more, if so, why the avx2 code doesn't meet the same problem? Thanks. > Hence it fails due to avx2 specific code from i40e_rxq_rearm_command(). > > This patch tries to fix the compilation by moving > i40e_rxq_rearm_common() to a new header file which will only be > included by i40e_rxtx_vec_avx2.c and i40e_rxtx_vec_avx512.c. > > Fixes: 0604b1f2208f ("net/i40e: fix crash in AVX512") > Cc: stable@dpdk.org > > Signed-off-by: Shahed Shaikh >