From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C06D5A09EE for ; Sun, 13 Dec 2020 09:30:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9AF76C872; Sun, 13 Dec 2020 09:30:51 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 76EA72B9C; Sun, 13 Dec 2020 09:30:46 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 13 Dec 2020 16:30:45 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 13 Dec 2020 08:30:44 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 13 Dec 2020 08:30:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwSlCUlVV2GFwmRLy+Sq/T9T3OBBg/AjwWBRU63UVyNEjvjAML5fEZbTIibSBnm/MtzeS6SnOhKjAGeJ+4yrQOemhDk8UJ/gRLbva8BU4dD0JHjQHyESQKwFwUnhInEZt846ixw9qF6XFtOJOsmOyw6WCvhYcxLpDlwhf6mRIOfIOzakDiCGmbOofm2jQw8hT8uY3VbEGzDzaWbJu/1YUFcIrZsmp/PzP0ih9E90W1ZYbPaxq/PHz8IsSQpSs68isom6bSa+2mn1EHEVqfoYYeubAwppA8gvGjjIhLyAlhrFLZpABpSTxn+PpoCgdFWXl3pmSgcsqOXyMvBPkchkow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tNR9wiyZczCqUcn+5E/EV6qQ1KSiq5mFKhGzTDhOf0c=; b=bBvW9zcDAtbgyHOUSnzQv+Q/HP2fZNhjLlKssr6pWsdfkKdVS3GAWgnhB6MTnR/K0hCNX03mXTRLfzN7B2rU1d8BXaNgbhYRZbpWeapMVDvxP5VtNYmsxI5FlIZ2XrYBruq9nZX4rzIzgbJUVvUqEHoXoReb0I62R2cQ8HPcREv95mi+5DGEGlSkHpFaMfwgAt7sIatt5Y/eHwtdk/WSI0W4gAWnOAdJLnYUXaw8nXYF8jqY+KDZ7Lg4Kgykwz1hEHO6MBmMEGN9rdfiLMrrsSeAzPRMi7bb7my2y4b7J4vK4z3V7d+7awo/ztWXDEH6I2kExh0pr2PTwUb7VGpHQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM5PR12MB2406.namprd12.prod.outlook.com (2603:10b6:4:b7::23) by DM6PR12MB4108.namprd12.prod.outlook.com (2603:10b6:5:220::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.22; Sun, 13 Dec 2020 08:30:41 +0000 Received: from DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::192a:9150:ff5e:10b5]) by DM5PR12MB2406.namprd12.prod.outlook.com ([fe80::192a:9150:ff5e:10b5%7]) with mapi id 15.20.3654.019; Sun, 13 Dec 2020 08:30:41 +0000 From: Asaf Penso To: Slava Ovsiienko , "dev@dpdk.org" CC: Raslan Darawsheh , Matan Azrad , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix buffer split offload advertising Thread-Index: AQHWz7MZu8RwA7inKUWqXSd7sLE91an0tNXA Date: Sun, 13 Dec 2020 08:30:41 +0000 Message-ID: References: <1607687092-6620-1-git-send-email-viacheslavo@nvidia.com> In-Reply-To: <1607687092-6620-1-git-send-email-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [87.71.140.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ad423ae-5f6a-4178-1d99-08d89f416085 x-ms-traffictypediagnostic: DM6PR12MB4108: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Cp4KCopkhixWdZBccbQ0UdwsCdev7aWKMb5k8apEbRVuZVgFTk+Cw3fyHL20HXpf9USxL6lEnYZ2BaToRy0GcbAnq3d+mNwtg1wyB6RWfJyGsE1h53c52TRTjwfTmzU2/8mJln7QfjyL0XArG7itjBWXIs1Cotfw6tVBA5eiKJScYDxuexnxJh46i47Gwx4jmblnRkOVJDNtDFm14ql6IYyvhHlMVbxTfCXqPZ/uccqeUriIExgJlW/5oHCB1nUxRetLyJKGE5e/lfD67wKBRtX2ATAuqDhmUVydMYvJkKhsMZUR1Rmush8vmH45J6SXkPTQa34BUuF3WLpJI3UUpg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB2406.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(346002)(66476007)(33656002)(66946007)(66446008)(64756008)(86362001)(8936002)(5660300002)(66556008)(9686003)(54906003)(83380400001)(8676002)(6506007)(26005)(71200400001)(52536014)(110136005)(76116006)(508600001)(2906002)(55016002)(186003)(4326008)(7696005)(450100002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Hk8l4gJzYugb3ybgM7B4ErgVPVlz7xX8V6oxKeTg5eozfs2LTb6TKnH7NgKc?= =?us-ascii?Q?M7TWaDTYMj/pxboFPYWwYLFbW742niZKBVlDrGAc0Sx7XEAVstkacR1bQFa5?= =?us-ascii?Q?XvRFDkqUCAzVpZ8CPXDGQZp9XcXiiUfLqbU1y27SFntqR//eq+XObsxQBYtE?= =?us-ascii?Q?sVJMZi3AxrjUehJT/H5FtSe/7hmyBFdFcqclKasSBoyyO3YBduk5i3Po+Dcf?= =?us-ascii?Q?EyPO+7EUlH2QGQGGKBFF708t8AY1vaMfVbLBCsFAunmGVxqRpbSgwPuBdPG4?= =?us-ascii?Q?V/2dBQBc8Y1TrzC6El1VRIf5OWT3mfsW1vhz1AJBbkjrgszPBfp9v4+HMaJ/?= =?us-ascii?Q?yURnqbpq+9RqtGD08MnwLL9YwizpJ8Hh4f43ABBSdxF592lq1GIiXdiEgyso?= =?us-ascii?Q?+kesKZjGParIJJe3jyuHvzpPia1/Ba+VUlWDQ2XE4O0sqy9WiMe8BYiXc1Ms?= =?us-ascii?Q?uOOrdV4SMylMWMrEtYwcZhbHHxDldM5l5BsgAwGswsVack4sGsu9VlimlaVC?= =?us-ascii?Q?G/WQOdwnmM5HFHakw4C21EhtE2K/MqCCoC9FpDnr+3xRnqIzL2yC3iO/5780?= =?us-ascii?Q?l8vHRN9sejR4LO3FtnP9olbl4Ocrd7Wblhi/BJf5v+iyou2kWMbF3Q9JayRB?= =?us-ascii?Q?RdqQ9eAdOXY6LmW7/zIWOHJL+o8fBi6iLRzNaJbIIhcJRii6Sz1MC4pQej36?= =?us-ascii?Q?QoaAU5MtSQEUc9J5pLtfpBLxD0maqq33Qs9Dd26vwiPrv9QpIoqtE2Mg1Afq?= =?us-ascii?Q?Rnf5t5IcyIKK7VzvdSPyR07sdKJsoVYZmAkuKcRngAJNALHfO1sOoHNuDlv5?= =?us-ascii?Q?wRem/De+kmYKCgTh/DVoE5fQHOzJ1gGguv4FdZ+L2mbBRS3F1hNlB4htYktK?= =?us-ascii?Q?ub7TAmMNXfxyiLG238CxGklDW9yHQWgK/mvcb/nNaazJswEeV5KSk2Zi+FTo?= =?us-ascii?Q?nzVOP9EcdnxhjHCRMazY43BZDveK1FJqdvUdCetlzh4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2406.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad423ae-5f6a-4178-1d99-08d89f416085 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2020 08:30:41.2283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cvimCSE+Xy5h4eVaSYC8AxswrRgXx9RB3FPRv0WSyoFSgTXkDBvTABXwQRc6Jxd2qDcLflNnUrFo5er4XMvs9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4108 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1607848245; bh=tNR9wiyZczCqUcn+5E/EV6qQ1KSiq5mFKhGzTDhOf0c=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=R9eODCtGYtFcxhLLG/PzVVRfnIwP4VGBpN7CJwAWu1LaXB8JDys2jcgPwymaIkBst DnqsZVv0NXmVuhMFKmmmbPbrf+L0Pqo38BgxTAnBZisLHKOvStiwUYOo/kW8XhOV2p 4Kik0gA1byBOJXH49tJG9UpuR7MLc/9eOHL3dpZUVb1YA9ofSBGxbo1KAAt+TEeiFs nKozBZ7+pdxH3iGSareilxGR0ATDzpgZ7bRllj0jXTOUjeD3g1vwoWlNsI14RU8UtT egEKwENPHkGIIY9sF6sl1XH5kqRxpr4TznmNl4uqIJl1XoZP6HV4L6YBvVJIuL563d sXpCFW1F89hYQ== Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix buffer split offload advertising X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" >-----Original Message----- >From: dev On Behalf Of Viacheslav Ovsiienko >Sent: Friday, December 11, 2020 1:45 PM >To: dev@dpdk.org >Cc: Raslan Darawsheh ; Matan Azrad >; stable@dpdk.org >Subject: [dpdk-dev] [PATCH] net/mlx5: fix buffer split offload advertising > >The buffer split Rx offload is not compatible with Multi-Packet Receiving >Queue (MPRQ) Rx offload, hence, the buffer split offload flag >RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT and other related values should be >advertised only if there is no MPRQ engaged. > >Fixes: 6c8f7f1c1877 ("net/mlx5: report Rx buffer split capabilities") >Cc: stable@dpdk.org > >Signed-off-by: Viacheslav Ovsiienko Reviewed-by: Asaf Penso >--- > drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- > drivers/net/mlx5/mlx5_rxq.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/drivers/net/mlx5/mlx5_ethdev.c >b/drivers/net/mlx5/mlx5_ethdev.c index a3910cf..45ee7e4 100644 >--- a/drivers/net/mlx5/mlx5_ethdev.c >+++ b/drivers/net/mlx5/mlx5_ethdev.c >@@ -310,8 +310,8 @@ > info->max_mac_addrs =3D MLX5_MAX_UC_MAC_ADDRESSES; > info->rx_queue_offload_capa =3D mlx5_get_rx_queue_offloads(dev); > info->rx_seg_capa.max_nseg =3D MLX5_MAX_RXQ_NSEG; >- info->rx_seg_capa.multi_pools =3D 1; >- info->rx_seg_capa.offset_allowed =3D 1; >+ info->rx_seg_capa.multi_pools =3D !config->mprq.enabled; >+ info->rx_seg_capa.offset_allowed =3D !config->mprq.enabled; > info->rx_seg_capa.offset_align_log2 =3D 0; > info->rx_offload_capa =3D (mlx5_get_rx_port_offloads() | > info->rx_queue_offload_capa); >diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c ind= ex >da7a8b3..a2613b0 100644 >--- a/drivers/net/mlx5/mlx5_rxq.c >+++ b/drivers/net/mlx5/mlx5_rxq.c >@@ -402,14 +402,14 @@ > struct mlx5_priv *priv =3D dev->data->dev_private; > struct mlx5_dev_config *config =3D &priv->config; > uint64_t offloads =3D (DEV_RX_OFFLOAD_SCATTER | >- RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT | > DEV_RX_OFFLOAD_TIMESTAMP | > DEV_RX_OFFLOAD_JUMBO_FRAME | > DEV_RX_OFFLOAD_RSS_HASH); > >+ if (!config->mprq.enabled) >+ offloads |=3D RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT; > if (config->hw_fcs_strip) > offloads |=3D DEV_RX_OFFLOAD_KEEP_CRC; >- > if (config->hw_csum) > offloads |=3D (DEV_RX_OFFLOAD_IPV4_CKSUM | > DEV_RX_OFFLOAD_UDP_CKSUM | >-- >1.8.3.1