From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF1B3A052A for ; Wed, 23 Dec 2020 10:43:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2BA2CA87; Wed, 23 Dec 2020 10:43:38 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AE654CA87; Wed, 23 Dec 2020 10:43:35 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9UhZw002385; Wed, 23 Dec 2020 01:43:34 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=cQ7NBQ2w/h5ZFegd754Bd+O4NVLweGTYccLSeYVB6xg=; b=eemmdprNbbmMJ6mxvpFzktZX7p0H2ZdYoE/sDiKuXLuukSoDI4hpeR9gRkRB8KBVOAtZ D7kfTxF8Us6XD00+XmNvExH7NiSZbSZAYjxM/iaeWtwgmi57v+tapSnoECdhA+mfNj63 TTTsde8iySi7aTkcjQH+iNcpiIv00DM9OcbeKCvkvaDTIHxOAR4gRgh4hkLpa7ArakNu PHc/RF1/7olaqluCVKmasPll5UsUMVrAx+kc1CVA8uQOYp74yYLlD4giXGJkNlPGubHS pnuaahqgki5sXyJOlE2ZjBF0PKlxzR3OupUmNjydtERz4340n7tW9Ar5c9+MgjUQdtjI iw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5nc9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Dec 2020 01:43:33 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:43:32 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:43:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZB2AVXHul4B8HwhcDH++iBVA6sb4GWGczvN4IRalUOO1hq4PE9TIoCWHoISCv7LvgdQbXQL4yNtK8uwZ0FE5sq//8QoDTDlwnPeICewT/d21WRi2OS40cSaU8Z4VZst+JluzmTBDmpowJYABrUDVUX2ZPINfDAj+6ETEekX7aa3iCR/x1BHjmGQUoy0RCJh2rB1dRLrSs3u1ytxbupRv2uiQl+yQRbEnkTA8GUMRK30bqshZRbe15LSyGY1D13/CZED2mVsT1aYAv2B6sGvwUWo1Cx8XkOM/9Xwb/iME9dma1iwLMvh/FOPUGQEoQ9CZXspfzxiTZj/BLmVpxHZ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQ7NBQ2w/h5ZFegd754Bd+O4NVLweGTYccLSeYVB6xg=; b=nhag+hxYzsihmnVDbh/zH9rI8ovQRgnxdD1e1xVHvUBk6FoNUtCdxPtBQjEWG22Xm9VSqK7O7qffp1dnS+Xu0FU8z3FZ99AosW9/Wux0uvarZIGKrMqKa3smVA/lIdXJ3Dy2U4pivC3T1swsJ200Vp9qUkE68Yk3Cw2dqh8TuFl62ytOldMsb0IsGsnHamaxCRZnbRR9UuE1rhSqDpErc7MepL2cNJP6Vy9/tdncONmYHttza+VHFmMQzjL1UXvIatizN1ganDhMjyyf/QEeO83q+BQX3LLXmxHWZQAM9ZWB7ZjuaQvTpR+I3CYCPqGx9wXZKF2BSyVszn3VmwmO8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQ7NBQ2w/h5ZFegd754Bd+O4NVLweGTYccLSeYVB6xg=; b=i6WEfca8paLEkrJzh0yu6hKaNJykww1wf075jHHAKx85HCvbHytLLKbrIyPUozDKa8YneCMSX3B0jjtTU/Dm9xeWUu9VSJShHOF19rguRLi3kRZPhCfqEvuUYEsle0uN1c87pk/r8t36a1Utj+e/WR2wBQNz0cTpQGAFD+TKQQg= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB3603.namprd18.prod.outlook.com (2603:10b6:5:2a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:43:31 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:43:31 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Yuri Chipchev , "stable@dpdk.org" , Liron Himi Thread-Topic: [dpdk-dev] [PATCH v1 01/38] net/mvpp2: fix stack corruption Thread-Index: AQHWyJPr5DllQ+1KgUKZjexZqKyPUKoEjuZA Date: Wed, 23 Dec 2020 09:43:31 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-2-lironh@marvell.com> In-Reply-To: <20201202101212.4717-2-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d08afb52-ca29-4ef0-7801-08d8a727358e x-ms-traffictypediagnostic: DM6PR18MB3603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lF9A83HpRPybw7KXm3DTY8lX2aQVEQblEVeOLnRis4P5GlvoF1xXtaOymBjeB78vRr1PaCrv4tR0IEZkPZcoYqpQdo+P4eU8b127DCaV9Pro9lGKhRE6MEMCG0n8Nvr4cEacKEyb9BqBE3ox+KZfWD1ZUJWtH1/+3PejNM8VtY+6ArCJP/KDxUzZgSBBECxAjkAjc783BNxkExPtXBlPVDRvbMPNsJcrdOHxooxVWEtLFSu+XffyNcPhQ5A0hBNFaR1m4vkxS1MCvu0OTrF5UrXd9/AMoxcwiwg7up2ZSbeA2PO9WyHi9S9hsHfjQSwGF2Z1aOqk34sSs76gbZ81ALYCTWVS9ECxyRKiZq/71k5adHNNdv7q1YYDSb3btLy8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(66446008)(53546011)(54906003)(450100002)(66556008)(52536014)(66476007)(66946007)(4326008)(5660300002)(64756008)(107886003)(33656002)(8676002)(9686003)(6506007)(76116006)(55016002)(6636002)(86362001)(71200400001)(478600001)(7696005)(186003)(2906002)(110136005)(316002)(83380400001)(26005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6zpWF2sns2erSp+E9a5qW67xQADGEA2KhgeU3ZWJfo7EHwd6YZTtZhoQjkSq?= =?us-ascii?Q?nd1O8HlLCyZONuEEA7U5jNf1sqOunc9jXq3pooJ0w63+uOzrfB8Qfca+66vV?= =?us-ascii?Q?nTvOoYot947nG3RYVY+/FAIxpDAtgPWQAYHrUtg8I2fBekfienror0+6ksnm?= =?us-ascii?Q?uDI6mocSW25+htCIDlseN18bBwevDlsl85lHGn/4nXYPhjruPMJdW0fL4nX+?= =?us-ascii?Q?6IWfQN6aY7A6bLDaqkOFADdjdVbSjgQYQ5n3jjs+zchCb6lhRgjIh6pDWqWJ?= =?us-ascii?Q?SbkJVueoTK03L/qwwlaWnKxzGlznYVV2v62Ej+RWdYyiHXRRS8vRK+iUuBsM?= =?us-ascii?Q?0sFfiM07vC8dPFLvJryA4BVAEqyAqLmKPJ+AApI9AuZst0uyVAO+e1HvUXNJ?= =?us-ascii?Q?HGApC5GsK5jWbaZsEPng4IMJLqIH3kmsq4+Y7nmATNW83ZBK7lUZWCUZpg5o?= =?us-ascii?Q?w9Ji+6qAxdFTLddb4roIc54rBuCoaS8buXC9wM409//E2KS4QJIoqE+NpolX?= =?us-ascii?Q?d5sMheNOiPd2hFr93pYKwdyyLJfVfxI3rGiaqbCe5uVYCL5WHjCNoIuXeKje?= =?us-ascii?Q?7BCokD8Fyrd4DUkBOS9SHk28x4Awx/PTawFNCrG0cuVw1I1HktLmSvHqVqpL?= =?us-ascii?Q?blrEbSFda1TXraLowd/e4V3xUxHEczL2IP4OXmZ+166M/DfddgnPO/yZ0Oct?= =?us-ascii?Q?3wx+6L3Bov4+v3WXXj2tkdGM8xQALj/oYRU7iUBrqfuQowhQMC7GPmdrR09r?= =?us-ascii?Q?9ygPZX8Dc+qgo8N1MOwZN/j8jhnZuv70zWE0zdlz3Bqbi/8aj6YikGuspCOa?= =?us-ascii?Q?irOumzIhMq43dIhGsZgSgJRkrfcnCKfrYzuvqNd940dqWF0//uxqncK/U/ZP?= =?us-ascii?Q?MIMhUMUp/smUA6BCZuNXpuleX6IzTB5xfGKNgA1c6znH+Putp2jf/APuXTm2?= =?us-ascii?Q?NbES6c9JCB/Fv2lChGAz8LM17Vz3yylYeLsX1h1jviM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d08afb52-ca29-4ef0-7801-08d8a727358e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:43:31.5208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6ammGD+R9lY5PYIFYYPABdTrCTz9HOZJWst6oofZS260qWzkTlUqxkl8f9Gj67oK3PvIcAAE8YSvM0iSth5mWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3603 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 01/38] net/mvpp2: fix stack corruption X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; stable@dpdk.org; Liron= Himi Subject: [dpdk-dev] [PATCH v1 01/38] net/mvpp2: fix stack corruption From: Yuri Chipchev Fixes stack corruption in mrvl_fill_bpool function in case num > MRVL_PP2_R= XD_MAX Fixes: c3637258d894 ("net/mrvl: fix Rx descriptors number") Cc: stable@dpdk.org Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index f25cf9e46..93fb30cdb 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -1614,8 +1614,8 @@ mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_= t vlan_id, int on) static int mrvl_fill_bpool(struct mrvl_rxq *rxq, int n= um) { - struct buff_release_entry entries[MRVL_PP2_RXD_MAX]; - struct rte_mbuf *mbufs[MRVL_PP2_RXD_MAX]; + struct buff_release_entry entries[num]; + struct rte_mbuf *mbufs[num]; int i, ret; unsigned int core_id; struct pp2_hif *hif; -- 2.28.0