From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06410A052A for ; Wed, 23 Dec 2020 10:42:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE3A5CC79; Wed, 23 Dec 2020 10:42:45 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 91A44CA39; Wed, 23 Dec 2020 10:42:42 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9UhZn002385; Wed, 23 Dec 2020 01:42:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=bptqicvM1CzgoZotCIQ6xksoUZk9K/XrQ9Jj2HK21XM=; b=EJwzaEARZP0TN99X/YQjwkPYpAsg0b8D3Orl8YVYhSRuyeqiqjRKMgqWPMM7OWolOmfZ f+F5KYUDSl/lqBzft6ToUC5TRrsPwIEL8VnE981oLfNx09DND/NH0AdK0aVfitm0Iq+Z 8Od1Jr2o/f32lhUBcI5S6+1HE1s/Sq8CjSqZQ9y4vXeEeUUgV/LY2XTLO7bH2A78fRve NzfC6AB8keBrScHlzlRTkoYMWb2CyOfXiStIEynE2eTnGtdCFuuZGenyPo5HIqgIvQnL mTqmwbtmvGtHAh7bcUUbr8yBIk+oGu0A847SeJ/UihK59HQ5ehH7i8yhzV6KR0zdDGkz fg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5na5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Dec 2020 01:42:40 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:42:39 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:42:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cV0xysU93Ha9BJMriiI6jqSYZJyp3oKlhVdJBBhVmXghrTrJzYe0GoU7DIZem+EelUWEcmClCdc07LXqFY6BK1PWxTLnxE+SH3y2VyXVE/hBigeHpFGnTkozDf5s0foLbrTTQJjni+SjmlcvyUQE4b43G5nJthsCfFw1urC2vMhMKnPUDDzANTWJ0Mw+vblrSjO2XiJHAEnfKij9qEGoTlSBiGgfK8TrMG10aXHtf3ehcemXkeIyDQiZxO26koJlMLI64dcxYDJwF5t4XVxMY5KQUN6CVsNB63tXJW6WNjQoyp23y6f24jtKr89R6b+9qSVqKyl56B9V9JPUiiDsjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bptqicvM1CzgoZotCIQ6xksoUZk9K/XrQ9Jj2HK21XM=; b=F9rlBDoJamxgOSBuZPgzu4PyOFc+RjZHppt3ZScCxl/q+nTdejEfA8VBmkECW71NEatZl7VxSNmgcySrCRDRLLPjZzvLP2HDq+h5mnuegSOyXg4CuW3RFYN1eo6zSQiR6xcEJEOJfTkxcxSgW3z68yJy3ugTVqQJYWreMJS3i1qo+RMexgSKDJOf+3SM0bhuaqWqx3Zxc84sOwv8G9ebvXoprnPx4P8UlcbgqT7h/+ayhP8WjRe5NToqIMCP+RBG6I8zpb/ehkDsO6OgzlW7XqoCJn0BaNT95NflJL6wEZsFkpkkYaCoLRagFB19jk/35yZXDNo3s2MVmFmZilvkVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bptqicvM1CzgoZotCIQ6xksoUZk9K/XrQ9Jj2HK21XM=; b=LqdCShMHlFz+DKpvhKWxkxPFSzgOuxwmhEKmfkPDFDHbHUNatb5c+xH66HviaUNT/bIMb669Fkoz0TKxs1ERZs3uNpHalttXExSyzH6RYZl+ScwaHHDwbHSSZgGShlJ6vMrzpb5+PTmpV/iW/0OVeZV+g3/RvG5hZmvPKYdqIMQ= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB3603.namprd18.prod.outlook.com (2603:10b6:5:2a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:42:38 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:42:38 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Liron Himi , "stable@dpdk.org" , Yuri Chipchev Thread-Topic: [dpdk-dev] [PATCH v1 06/38] net/mvpp2: fix frame size checking Thread-Index: AQHWyJQC/SXhgnX+jEyKd6QKmuXk36oEjrLg Date: Wed, 23 Dec 2020 09:42:38 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-7-lironh@marvell.com> In-Reply-To: <20201202101212.4717-7-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ccf391a-9fcc-4857-ad10-08d8a72715e3 x-ms-traffictypediagnostic: DM6PR18MB3603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:741; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eYxfebp5+EZErw7i04FExCeveNhy/9eOed3y4gBwKhrq2LEvGdlbfh4/8vg50KuXZjqUeIkwRDYXLG82w7VXHs7oGLK9vo/2MYjDI4a62t9mMchKsj7bQVTt2epOyhezaRoxbwNHeWZ9rpHSXVLvzhj83+M9C7MgqO6SGtJE7U2MI53a7IU74UE2354EgYytCwTvVM3Dh/TupCMlDfdmAhCTRrqhOFQCaZyNZb91XSdNuLxDm0Bafzes3+RnFhfHw9QwiA5yz/OYXLAPNk6kcH+4a8lt+lUIZ9e/U02CuBoeVP89f/hy0goQmqZb1s34YggmCPpJPnZ68B48LmfMFgLhj67096WZKEQt0YuVvE6/GC4lStUdz9zEfdKb0RbkvoJVX6RDbDanujyM6BR9vg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(66446008)(53546011)(54906003)(450100002)(66556008)(52536014)(66476007)(66946007)(4326008)(5660300002)(64756008)(107886003)(33656002)(8676002)(9686003)(6506007)(76116006)(55016002)(6636002)(86362001)(71200400001)(478600001)(7696005)(186003)(2906002)(110136005)(316002)(83380400001)(26005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qs6hqVozYwjCQgERlJROOVnCWSzHoCv8/oLC+4Iuo8kfpsF0fh/bVPy9yQXq?= =?us-ascii?Q?PZm4a04XxYMEF5gXYt6c0kN9b0T/CbKyIMu/L33graDNB/1rd+K3IqX2PulL?= =?us-ascii?Q?FlxeWgOgLVKvpp5eI9q5z+bRPc0Mze/0PCs9nqTVvSkQz35ZXfqbePKhPsOm?= =?us-ascii?Q?W4GSrtWo37n/JVNzNzoeqvs/J/wf+DyFBiRS964OsYbdCYXP9del2bZAxv+K?= =?us-ascii?Q?KqELnj9upmnh2S4oQcrdcheSyF2AXXNea00Oco9grxGFCapefrDNLthy8VC4?= =?us-ascii?Q?JlRbjF9+uR48hFmwqNAGx0NJPXqzHVoyjYeZDbw2T8EeWhUEVJd+ApGx7CfU?= =?us-ascii?Q?AReme/QuOAmkmnoSvAaMw4FXWfD0WE0aWoqjJ49vpPMAnhXqiSx7YNq5fzHj?= =?us-ascii?Q?ZUsAgCHreQEROXbrSLjZLvauitw8gVr/QdOf6hD5rw4dssQcXq4aKMo3uY7n?= =?us-ascii?Q?FxTJSxaip7X9vn/c5DMSnJrzdWF2G/IYpaZpAjyz5OxnWQiNXMP/2BpUbIhD?= =?us-ascii?Q?gRbNenoW9BmsDRxgZAk6Aatbxyj2v02iwmnaH18E4QMxRYoeJZ8fZ7fZ5O0c?= =?us-ascii?Q?4Gn8Dwl8K6BMXKbxqhzqPxD1yXEMfwO31uh5BL3MiYJGf3jIh1MKOFdb6s1O?= =?us-ascii?Q?sBBbDre6YStnDE9xCTjxHp+Hgb0zNu0Mk4cuLgrIDqrakmbqsJkLmFm77wIb?= =?us-ascii?Q?9zeNDA1a8liLCEZrQgUnUEvcIdxGJA4SQUEEMAqkLTTV6RuOUC1yLrKHZFjh?= =?us-ascii?Q?WCPb3LJNjjM7HLeUeJQKoPdITOZnJtQlm9pUuCRqZB25M6dXqtff2rg1ONhN?= =?us-ascii?Q?hBgqHpRzVIYVBNLpBTFICErwL4YNAiq3df8qMQzagROAo83umMf+3RAMi8gR?= =?us-ascii?Q?leL3pWgly9Tr05f2+1FAzOXRRpOf49pNdyHLiHo7sBRERPJv/FI5fYueHIxQ?= =?us-ascii?Q?YsQ7zSsaVj6MWMIExyORKkR9fu0fiiHQbeI/vtO7DpA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ccf391a-9fcc-4857-ad10-08d8a72715e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:42:38.4771 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DiaxCN9ikNFJVrHBfHAKBRBL8cx79Bp5EWFKkh7alBuMaVikog2bI6bEuaTOY30n4QI5r8F7Goat6Yw3Senpcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3603 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 06/38] net/mvpp2: fix frame size checking X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; stable@dpdk.org; Yuri Ch= ipchev Subject: [dpdk-dev] [PATCH v1 06/38] net/mvpp2: fix frame size checking From: Liron Himi need to add CRC len to the frame-size to compare against max_rx_pkt_len whi= ch includes it. Fixes: 79ec62028 ("net/mvpp2: update MTU and MRU related calculations") Cc: stable@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/net/mvpp2/mrvl_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index dbb193496..3f05ebe00 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -1711,7 +1711,8 @@ mrvl_rx_queue_setup(struct rte_eth_dev *dev, uint16_t= idx, uint16_t desc, return -EFAULT; } =20 - frame_size =3D buf_size - RTE_PKTMBUF_HEADROOM - MRVL_PKT_EFFEC_OFFS; + frame_size =3D buf_size - RTE_PKTMBUF_HEADROOM - + MRVL_PKT_EFFEC_OFFS + RTE_ETHER_CRC_LEN; if (frame_size < max_rx_pkt_len) { MRVL_LOG(WARNING, "Mbuf size must be increased to %u bytes to hold up " -- 2.28.0