From: Liron Himi <lironh@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Liron Himi <lironh@marvell.com>
Subject: Re: [dpdk-stable] [EXT] [PATCH] net/mvpp2: fix non-EAL thread support
Date: Tue, 16 Jun 2020 09:49:38 +0000 [thread overview]
Message-ID: <DM5PR18MB2214A104A0DAE2CB9AC4B3A8C69D0@DM5PR18MB2214.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200616094700.31749-1-david.marchand@redhat.com>
Acked-by: Liron Himi <lironh@marvell.com>
-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Tuesday, 16 June 2020 12:47
To: dev@dpdk.org
Cc: stable@dpdk.org; Liron Himi <lironh@marvell.com>; Natalie Samsonov <nsamsono@marvell.com>
Subject: [EXT] [PATCH] net/mvpp2: fix non-EAL thread support
External Email
----------------------------------------------------------------------
Caught by code inspection, for a non-EAL thread identified with
rte_lcore_id() == LCORE_ID_ANY, the code currently arbitrarily uses lcore 0 while there is no guarantee this lcore is used.
Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/mvpp2/mrvl_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index b98b1fd667..9037274327 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -816,7 +816,7 @@ mrvl_flush_bpool(struct rte_eth_dev *dev)
unsigned int core_id = rte_lcore_id();
if (core_id == LCORE_ID_ANY)
- core_id = 0;
+ core_id = rte_get_master_lcore();
hif = mrvl_get_hif(priv, core_id);
@@ -1620,7 +1620,7 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num)
core_id = rte_lcore_id();
if (core_id == LCORE_ID_ANY)
- core_id = 0;
+ core_id = rte_get_master_lcore();
hif = mrvl_get_hif(rxq->priv, core_id);
if (!hif)
@@ -1770,7 +1770,7 @@ mrvl_rx_queue_release(void *rxq)
unsigned int core_id = rte_lcore_id();
if (core_id == LCORE_ID_ANY)
- core_id = 0;
+ core_id = rte_get_master_lcore();
if (!q)
return;
--
2.23.0
next prev parent reply other threads:[~2020-06-16 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 9:47 [dpdk-stable] " David Marchand
2020-06-16 9:49 ` Liron Himi [this message]
2020-06-26 4:45 ` [dpdk-stable] [dpdk-dev] [EXT] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR18MB2214A104A0DAE2CB9AC4B3A8C69D0@DM5PR18MB2214.namprd18.prod.outlook.com \
--to=lironh@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).