patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] test/flow-classify: fix failure on dual socket systems
Date: Tue, 5 May 2020 11:02:26 +0000
Message-ID: <DM6PR11MB25376CBABC4FA0CFB9AD5744EFA70@DM6PR11MB2537.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5c661d4e-7ac5-d825-ab12-83d207b47bdf@intel.com>

Hi Harry,

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, May 1, 2020 12:51 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH] test/flow-classify: fix failure on dual socket systems
> 
> On 5/1/2020 12:08 PM, Harry van Haaren wrote:
> > This commit fixes failures of the flow_classify_autotest when ran on
> > dual-socket servers, as the sample application does not support more
> > than a single socket. Increasing the NB_SOCKETS value allows the test
> > to run successfully.
> >
> > Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> >
> > ---
> >
> > DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot easily
> > statically allocate the array. As a bugfix patch, I'd prefer not add
> > complexity of dynamically allocating based on rte_socket_count(),
> > hence just increasing the value seems the most pragmatic fix.
> >
> > Fixes: tag is a bit complex, code was moved in previous commit.
> > This fixes tag is against when the NB_SOCKET = 1 was introduced.
> >
> > Cc: stable@dpdk.org
> >
> 
> Thanks for the fix.
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
Tested-by: Bernard Iremonger <bernard.iremonger@intel.com

The Cc: stable@dpdk.org line should be after the fixes line in the commit message.

Otherwise

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>


  reply	other threads:[~2020-05-05 11:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 11:08 Harry van Haaren
2020-05-01 11:50 ` Ferruh Yigit
2020-05-05 11:02   ` Iremonger, Bernard [this message]
2020-05-11 20:56 ` [dpdk-stable] [dpdk-dev] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB25376CBABC4FA0CFB9AD5744EFA70@DM6PR11MB2537.namprd11.prod.outlook.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git