patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] rte_swx: fix typo
@ 2021-05-24  8:53 Thierry Herbelot
  2021-05-24 11:25 ` Dumitrescu, Cristian
  2021-05-24 11:28 ` [dpdk-stable] [PATCH v2] table: " Thierry Herbelot
  0 siblings, 2 replies; 18+ messages in thread
From: Thierry Herbelot @ 2021-05-24  8:53 UTC (permalink / raw)
  To: dev; +Cc: Thierry Herbelot, Thomas Monjalon, stable, Cristian Dumitrescu

Check Bucket key for all possible indices.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 lib/table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ?
 		1 : 0;
 }
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH] rte_swx: fix typo
  2021-05-24  8:53 [dpdk-stable] [PATCH] rte_swx: fix typo Thierry Herbelot
@ 2021-05-24 11:25 ` Dumitrescu, Cristian
  2021-05-24 11:28 ` [dpdk-stable] [PATCH v2] table: " Thierry Herbelot
  1 sibling, 0 replies; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-05-24 11:25 UTC (permalink / raw)
  To: Thierry Herbelot, dev; +Cc: Thomas Monjalon, stable



> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Monday, May 24, 2021 9:54 AM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH] rte_swx: fix typo
> 
> Check Bucket key for all possible indices.
> 
> Fixes: d0a00966618ba ("table: add exact match SWX table")
> Cc: stable@dpdk.org
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>  lib/table/rte_swx_table_em.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
> index 788e25f6b912..03b28c4c9da0 100644
> --- a/lib/table/rte_swx_table_em.c
> +++ b/lib/table/rte_swx_table_em.c
> @@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
>  static inline int
>  bkt_is_empty(struct bucket_extension *bkt)
>  {
> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> ?
> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> ?
>  		1 : 0;
>  }
> 
> --
> 2.29.2

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Thanks very much, Thierry!

It would be great though if we could send a V2 with "table" instead of "rte_swx" in the title:
	[PATCH] table: fix typo



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [dpdk-stable] [PATCH v2] table: fix typo
  2021-05-24  8:53 [dpdk-stable] [PATCH] rte_swx: fix typo Thierry Herbelot
  2021-05-24 11:25 ` Dumitrescu, Cristian
@ 2021-05-24 11:28 ` Thierry Herbelot
  2021-05-24 11:30   ` Dumitrescu, Cristian
  2021-07-07 11:19   ` [dpdk-stable] [PATCH V3] table: fix bucket empty logic Thierry Herbelot
  1 sibling, 2 replies; 18+ messages in thread
From: Thierry Herbelot @ 2021-05-24 11:28 UTC (permalink / raw)
  To: dev; +Cc: Thierry Herbelot, Thomas Monjalon, stable, Cristian Dumitrescu

Check Bucket key for all possible indices.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V2: reword patch title
---
 lib/table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ?
 		1 : 0;
 }
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-05-24 11:28 ` [dpdk-stable] [PATCH v2] table: " Thierry Herbelot
@ 2021-05-24 11:30   ` Dumitrescu, Cristian
  2021-06-17  7:01     ` Thomas Monjalon
  2021-07-07 11:19   ` [dpdk-stable] [PATCH V3] table: fix bucket empty logic Thierry Herbelot
  1 sibling, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-05-24 11:30 UTC (permalink / raw)
  To: Thierry Herbelot, dev; +Cc: Thomas Monjalon, stable



> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Monday, May 24, 2021 12:29 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH v2] table: fix typo
> 
> Check Bucket key for all possible indices.
> 
> Fixes: d0a00966618ba ("table: add exact match SWX table")
> Cc: stable@dpdk.org
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2: reword patch title
> ---
>  lib/table/rte_swx_table_em.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
> index 788e25f6b912..03b28c4c9da0 100644
> --- a/lib/table/rte_swx_table_em.c
> +++ b/lib/table/rte_swx_table_em.c
> @@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
>  static inline int
>  bkt_is_empty(struct bucket_extension *bkt)
>  {
> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> ?
> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> ?
>  		1 : 0;
>  }
> 
> --
> 2.29.2

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Thierry, thanks again, you could have actually added my ack from V1 :)

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-05-24 11:30   ` Dumitrescu, Cristian
@ 2021-06-17  7:01     ` Thomas Monjalon
  2021-06-17  7:11       ` Thierry Herbelot
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-06-17  7:01 UTC (permalink / raw)
  To: Thierry Herbelot, Dumitrescu, Cristian; +Cc: dev, stable

> > Check Bucket key for all possible indices.
> > 
> > Fixes: d0a00966618ba ("table: add exact match SWX table")
> > Cc: stable@dpdk.org
> > Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > 
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
[...]
> > -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> > +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Thierry, thanks again, you could have actually added my ack from V1 :)

The root cause looks to be a typo indeed,
but the impact or the scope of the issue
should stated in few words in the title please.
No need to send a v3, please suggest a title and I will apply.



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-17  7:01     ` Thomas Monjalon
@ 2021-06-17  7:11       ` Thierry Herbelot
  2021-06-21 15:44         ` Dumitrescu, Cristian
  0 siblings, 1 reply; 18+ messages in thread
From: Thierry Herbelot @ 2021-06-17  7:11 UTC (permalink / raw)
  To: Thomas Monjalon, Dumitrescu, Cristian; +Cc: dev, stable

On 6/17/21 9:01 AM, Thomas Monjalon wrote:
>>> Check Bucket key for all possible indices.
>>>
>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
>>> Cc: stable@dpdk.org
>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>
>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> [...]
>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
>>
>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>
>> Thierry, thanks again, you could have actually added my ack from V1 :)
> 
> The root cause looks to be a typo indeed,
> but the impact or the scope of the issue
> should stated in few words in the title please.
> No need to send a v3, please suggest a title and I will apply.

table: check a bucket is empty for all bucket keys

	Thierry

> 
> 

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-17  7:11       ` Thierry Herbelot
@ 2021-06-21 15:44         ` Dumitrescu, Cristian
  2021-06-21 15:54           ` Thierry Herbelot
  0 siblings, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-06-21 15:44 UTC (permalink / raw)
  To: Thierry Herbelot, Thomas Monjalon; +Cc: dev, stable



> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, June 17, 2021 8:12 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> 
> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> >>> Check Bucket key for all possible indices.
> >>>
> >>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> >>> Cc: stable@dpdk.org
> >>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>
> >>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > [...]
> >>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> >>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> >>
> >> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>
> >> Thierry, thanks again, you could have actually added my ack from V1 :)
> >
> > The root cause looks to be a typo indeed,
> > but the impact or the scope of the issue
> > should stated in few words in the title please.
> > No need to send a v3, please suggest a title and I will apply.
> 
> table: check a bucket is empty for all bucket keys
> 
> 	Thierry
> 

Hi Thierry,

I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?

Thanks,
Cristian

> >
> >
> 
> --
> Thierry Herbelot
> Senior Software Engineer
> Tel: +33 1 39 30 92 61
> http://www.6wind.com/
> 
> Follow us:
> https://www.linkedin.com/company/6wind/
> https://twitter.com/6WINDsoftware
> https://www.youtube.com/user/6windsoftware

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-21 15:44         ` Dumitrescu, Cristian
@ 2021-06-21 15:54           ` Thierry Herbelot
  2021-06-21 16:14             ` Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Thierry Herbelot @ 2021-06-21 15:54 UTC (permalink / raw)
  To: Dumitrescu, Cristian, Thomas Monjalon; +Cc: dev, stable

On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> 
> 
>> -----Original Message-----
>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>> Sent: Thursday, June 17, 2021 8:12 AM
>> To: Thomas Monjalon <thomas@monjalon.net>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
>>
>> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
>>>>> Check Bucket key for all possible indices.
>>>>>
>>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
>>>>> Cc: stable@dpdk.org
>>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>
>>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>>> [...]
>>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
>>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
>>>>
>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>
>>>> Thierry, thanks again, you could have actually added my ack from V1 :)
>>>
>>> The root cause looks to be a typo indeed,
>>> but the impact or the scope of the issue
>>> should stated in few words in the title please.
>>> No need to send a v3, please suggest a title and I will apply.
>>
>> table: check a bucket is empty for all bucket keys
>>
>> 	Thierry
>>
> 
> Hi Thierry,
> 
> I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?
> 

Hello Cristian

Sure !

What do you think of this title:

"table: check a bucket is empty for all bucket keys"

	Best regards

	Thierry

> Thanks,
> Cristian
> 
>>>
>>>
>>
>> --
>> Thierry Herbelot
>> Senior Software Engineer
>> Tel: +33 1 39 30 92 61
>> http://www.6wind.com/
>>
>> Follow us:
>> https://www.linkedin.com/company/6wind/
>> https://twitter.com/6WINDsoftware
>> https://www.youtube.com/user/6windsoftware

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-21 15:54           ` Thierry Herbelot
@ 2021-06-21 16:14             ` Thomas Monjalon
  2021-06-21 16:56               ` Dumitrescu, Cristian
  2021-06-21 17:23               ` Thierry Herbelot
  0 siblings, 2 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-06-21 16:14 UTC (permalink / raw)
  To: Dumitrescu, Cristian, Thierry Herbelot; +Cc: dev, stable

21/06/2021 17:54, Thierry Herbelot:
> On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> >>>>> Check Bucket key for all possible indices.
> >>>>>
> >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> >>>>> Cc: stable@dpdk.org
> >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>>
> >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> >>> [...]
> >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> >>>>
> >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>
> >>>> Thierry, thanks again, you could have actually added my ack from V1 :)
> >>>
> >>> The root cause looks to be a typo indeed,
> >>> but the impact or the scope of the issue
> >>> should stated in few words in the title please.
> >>> No need to send a v3, please suggest a title and I will apply.
> >>
> >> table: check a bucket is empty for all bucket keys
> >>
> >> 	Thierry
> >>
> > 
> > Hi Thierry,
> > 
> > I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?

No need to send a v3.
> 
> Hello Cristian
> 
> Sure !
> 
> What do you think of this title:
> 
> "table: check a bucket is empty for all bucket keys"

This title suggests it was not the intent before.
It should say that it fixes this check,
or better, name the area of the API which is fixed.



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-21 16:14             ` Thomas Monjalon
@ 2021-06-21 16:56               ` Dumitrescu, Cristian
  2021-06-29 11:35                 ` Dumitrescu, Cristian
  2021-06-21 17:23               ` Thierry Herbelot
  1 sibling, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-06-21 16:56 UTC (permalink / raw)
  To: Thomas Monjalon, Thierry Herbelot; +Cc: dev, stable



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, June 21, 2021 5:15 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> 
> 21/06/2021 17:54, Thierry Herbelot:
> > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > >>>>> Check Bucket key for all possible indices.
> > >>>>>
> > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > >>>>> Cc: stable@dpdk.org
> > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > >>>>>
> > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > >>> [...]
> > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> >sig[2])
> > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> >sig[3])
> > >>>>
> > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > >>>>
> > >>>> Thierry, thanks again, you could have actually added my ack from V1
> :)
> > >>>
> > >>> The root cause looks to be a typo indeed,
> > >>> but the impact or the scope of the issue
> > >>> should stated in few words in the title please.
> > >>> No need to send a v3, please suggest a title and I will apply.
> > >>
> > >> table: check a bucket is empty for all bucket keys
> > >>
> > >> 	Thierry
> > >>
> > >
> > > Hi Thierry,
> > >
> > > I think Thomas is asking for you to send a new version of this patch with
> the title updated. Is this OK with you?
> 
> No need to send a v3.
> >

OK, so you're going to fix the title while applying? Thanks, Thomas.


> > Hello Cristian
> >
> > Sure !
> >
> > What do you think of this title:
> >
> > "table: check a bucket is empty for all bucket keys"
> 
> This title suggests it was not the intent before.
> It should say that it fixes this check,
> or better, name the area of the API which is fixed.
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-21 16:14             ` Thomas Monjalon
  2021-06-21 16:56               ` Dumitrescu, Cristian
@ 2021-06-21 17:23               ` Thierry Herbelot
  1 sibling, 0 replies; 18+ messages in thread
From: Thierry Herbelot @ 2021-06-21 17:23 UTC (permalink / raw)
  To: Thomas Monjalon, Dumitrescu, Cristian; +Cc: dev, stable

On 6/21/21 6:14 PM, Thomas Monjalon wrote:
> 21/06/2021 17:54, Thierry Herbelot:
>> On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
>>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>>>> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
>>>>>>> Check Bucket key for all possible indices.
>>>>>>>
>>>>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
>>>>>>> Cc: stable@dpdk.org
>>>>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>>>
>>>>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>>>>> [...]
>>>>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
>>>>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
>>>>>>
>>>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>>
>>>>>> Thierry, thanks again, you could have actually added my ack from V1 :)
>>>>>
>>>>> The root cause looks to be a typo indeed,
>>>>> but the impact or the scope of the issue
>>>>> should stated in few words in the title please.
>>>>> No need to send a v3, please suggest a title and I will apply.
>>>>
>>>> table: check a bucket is empty for all bucket keys
>>>>
>>>> 	Thierry
>>>>
>>>
>>> Hi Thierry,
>>>
>>> I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?
> 
> No need to send a v3.
>>
>> Hello Cristian
>>
>> Sure !
>>
>> What do you think of this title:
>>
>> "table: check a bucket is empty for all bucket keys"
> 
> This title suggests it was not the intent before.
> It should say that it fixes this check,
> or better, name the area of the API which is fixed.


"table: all keys must be checked to declare that a bucket is empty"

> 
> 

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-21 16:56               ` Dumitrescu, Cristian
@ 2021-06-29 11:35                 ` Dumitrescu, Cristian
  2021-06-29 13:41                   ` Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-06-29 11:35 UTC (permalink / raw)
  To: Dumitrescu, Cristian, Thomas Monjalon, Thierry Herbelot; +Cc: dev, stable



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> Sent: Monday, June 21, 2021 5:56 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, June 21, 2021 5:15 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thierry Herbelot
> > <thierry.herbelot@6wind.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> >
> > 21/06/2021 17:54, Thierry Herbelot:
> > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > >>>>> Check Bucket key for all possible indices.
> > > >>>>>
> > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > >>>>> Cc: stable@dpdk.org
> > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > >>>>>
> > > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >>> [...]
> > > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > >sig[2])
> > > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > >sig[3])
> > > >>>>
> > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > >>>>
> > > >>>> Thierry, thanks again, you could have actually added my ack from V1
> > :)
> > > >>>
> > > >>> The root cause looks to be a typo indeed,
> > > >>> but the impact or the scope of the issue
> > > >>> should stated in few words in the title please.
> > > >>> No need to send a v3, please suggest a title and I will apply.
> > > >>
> > > >> table: check a bucket is empty for all bucket keys
> > > >>
> > > >> 	Thierry
> > > >>
> > > >
> > > > Hi Thierry,
> > > >
> > > > I think Thomas is asking for you to send a new version of this patch with
> > the title updated. Is this OK with you?
> >
> > No need to send a v3.
> > >
> 
> OK, so you're going to fix the title while applying? Thanks, Thomas.
> 
> 

Hi Thomas,

I see this fix is not yet applied, is there any action required?

Thanks,
Cristian

> > > Hello Cristian
> > >
> > > Sure !
> > >
> > > What do you think of this title:
> > >
> > > "table: check a bucket is empty for all bucket keys"
> >
> > This title suggests it was not the intent before.
> > It should say that it fixes this check,
> > or better, name the area of the API which is fixed.
> >


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-29 11:35                 ` Dumitrescu, Cristian
@ 2021-06-29 13:41                   ` Thomas Monjalon
  2021-06-29 13:51                     ` Dumitrescu, Cristian
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-06-29 13:41 UTC (permalink / raw)
  To: Dumitrescu, Cristian, Thierry Herbelot; +Cc: dev, stable, david.marchand

29/06/2021 13:35, Dumitrescu, Cristian:
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 21/06/2021 17:54, Thierry Herbelot:
> > > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > > >>>>> Check Bucket key for all possible indices.
> > > > >>>>>
> > > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > > >>>>> Cc: stable@dpdk.org
> > > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > >>>>>
> > > > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > >>> [...]
> > > > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > >sig[2])
> > > > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > >sig[3])
> > > > >>>>
> > > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > >>>>
> > > > >>>> Thierry, thanks again, you could have actually added my ack from V1
> > > :)
> > > > >>>
> > > > >>> The root cause looks to be a typo indeed,
> > > > >>> but the impact or the scope of the issue
> > > > >>> should stated in few words in the title please.
> > > > >>> No need to send a v3, please suggest a title and I will apply.
> > > > >>
> > > > >> table: check a bucket is empty for all bucket keys
> > > > >>
> > > > >> 	Thierry
> > > > >>
> > > > >
> > > > > Hi Thierry,
> > > > >
> > > > > I think Thomas is asking for you to send a new version of this patch with
> > > the title updated. Is this OK with you?
> > >
> > > No need to send a v3.
> > 
> > OK, so you're going to fix the title while applying? Thanks, Thomas.
> 
> Hi Thomas,
> 
> I see this fix is not yet applied, is there any action required?

The proposed title is not fantastic. Last one is:
table: all keys must be checked to declare that a bucket is empty

I just need a title showing what is fixed.
What is the impact of the bug in bkt_is_empty()?



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-29 13:41                   ` Thomas Monjalon
@ 2021-06-29 13:51                     ` Dumitrescu, Cristian
  2021-07-03  0:07                       ` Dumitrescu, Cristian
  0 siblings, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-06-29 13:51 UTC (permalink / raw)
  To: Thomas Monjalon, Thierry Herbelot; +Cc: dev, stable, david.marchand



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, June 29, 2021 2:41 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; stable@dpdk.org; david.marchand@redhat.com
> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> 
> 29/06/2021 13:35, Dumitrescu, Cristian:
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 21/06/2021 17:54, Thierry Herbelot:
> > > > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > > > >>>>> Check Bucket key for all possible indices.
> > > > > >>>>>
> > > > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > > > >>>>> Cc: stable@dpdk.org
> > > > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > > >>>>>
> > > > > >>>>> Signed-off-by: Thierry Herbelot
> <thierry.herbelot@6wind.com>
> > > > > >>> [...]
> > > > > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > > >sig[2])
> > > > > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2]
> && !bkt-
> > > > >sig[3])
> > > > > >>>>
> > > > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > > >>>>
> > > > > >>>> Thierry, thanks again, you could have actually added my ack
> from V1
> > > > :)
> > > > > >>>
> > > > > >>> The root cause looks to be a typo indeed,
> > > > > >>> but the impact or the scope of the issue
> > > > > >>> should stated in few words in the title please.
> > > > > >>> No need to send a v3, please suggest a title and I will apply.
> > > > > >>
> > > > > >> table: check a bucket is empty for all bucket keys
> > > > > >>
> > > > > >> 	Thierry
> > > > > >>
> > > > > >
> > > > > > Hi Thierry,
> > > > > >
> > > > > > I think Thomas is asking for you to send a new version of this patch
> with
> > > > the title updated. Is this OK with you?
> > > >
> > > > No need to send a v3.
> > >
> > > OK, so you're going to fix the title while applying? Thanks, Thomas.
> >
> > Hi Thomas,
> >
> > I see this fix is not yet applied, is there any action required?
> 
> The proposed title is not fantastic. Last one is:
> table: all keys must be checked to declare that a bucket is empty
> 
> I just need a title showing what is fixed.
> What is the impact of the bug in bkt_is_empty()?
> 

Hi Thomas,

How about this one:

	table: fix bucket empty logic

	Due to a typo, only 3 our of 4 keys in the bucket of the exact match table were considered, which can result in valid keys being incorrectly dropped from the table.

Regards,
Cristian

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH v2] table: fix typo
  2021-06-29 13:51                     ` Dumitrescu, Cristian
@ 2021-07-03  0:07                       ` Dumitrescu, Cristian
  0 siblings, 0 replies; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-07-03  0:07 UTC (permalink / raw)
  To: Dumitrescu, Cristian, Thomas Monjalon, Thierry Herbelot
  Cc: dev, stable, david.marchand


> > > > > > > Hi Thierry,
> > > > > > >
> > > > > > > I think Thomas is asking for you to send a new version of this patch
> > with
> > > > > the title updated. Is this OK with you?
> > > > >
> > > > > No need to send a v3.
> > > >
> > > > OK, so you're going to fix the title while applying? Thanks, Thomas.
> > >
> > > Hi Thomas,
> > >
> > > I see this fix is not yet applied, is there any action required?
> >
> > The proposed title is not fantastic. Last one is:
> > table: all keys must be checked to declare that a bucket is empty
> >
> > I just need a title showing what is fixed.
> > What is the impact of the bug in bkt_is_empty()?
> >
> 
> Hi Thomas,
> 
> How about this one:
> 
> 	table: fix bucket empty logic
> 
> 	Due to a typo, only 3 our of 4 keys in the bucket of the exact match
> table were considered, which can result in valid keys being incorrectly
> dropped from the table.
> 
> Regards,
> Cristian

Hi Thomas,

Ping,

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [dpdk-stable] [PATCH V3] table: fix bucket empty logic
  2021-05-24 11:28 ` [dpdk-stable] [PATCH v2] table: " Thierry Herbelot
  2021-05-24 11:30   ` Dumitrescu, Cristian
@ 2021-07-07 11:19   ` Thierry Herbelot
  2021-07-07 11:23     ` Dumitrescu, Cristian
  1 sibling, 1 reply; 18+ messages in thread
From: Thierry Herbelot @ 2021-07-07 11:19 UTC (permalink / raw)
  To: dev; +Cc: Thierry Herbelot, Thomas Monjalon, stable, Cristian Dumitrescu

Due to a typo, only 3 out of 4 keys in the bucket of the exact match
table were considered, which can result in valid keys being
incorrectly dropped from the table.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V3: reword commit log
V2: reword patch title
---
 lib/table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ?
 		1 : 0;
 }
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [PATCH V3] table: fix bucket empty logic
  2021-07-07 11:19   ` [dpdk-stable] [PATCH V3] table: fix bucket empty logic Thierry Herbelot
@ 2021-07-07 11:23     ` Dumitrescu, Cristian
  2021-07-09 20:43       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 18+ messages in thread
From: Dumitrescu, Cristian @ 2021-07-07 11:23 UTC (permalink / raw)
  To: Thierry Herbelot, dev; +Cc: Thomas Monjalon, stable



> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Wednesday, July 7, 2021 12:19 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH V3] table: fix bucket empty logic
> 
> Due to a typo, only 3 out of 4 keys in the bucket of the exact match
> table were considered, which can result in valid keys being
> incorrectly dropped from the table.
> 
> Fixes: d0a00966618ba ("table: add exact match SWX table")
> Cc: stable@dpdk.org
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V3: reword commit log
> V2: reword patch title
> ---
>  lib/table/rte_swx_table_em.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH V3] table: fix bucket empty logic
  2021-07-07 11:23     ` Dumitrescu, Cristian
@ 2021-07-09 20:43       ` Thomas Monjalon
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-07-09 20:43 UTC (permalink / raw)
  To: Thierry Herbelot; +Cc: dev, stable, Dumitrescu, Cristian

> > Due to a typo, only 3 out of 4 keys in the bucket of the exact match
> > table were considered, which can result in valid keys being
> > incorrectly dropped from the table.
> > 
> > Fixes: d0a00966618ba ("table: add exact match SWX table")
> > Cc: stable@dpdk.org
> > Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > 
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2021-07-09 20:43 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24  8:53 [dpdk-stable] [PATCH] rte_swx: fix typo Thierry Herbelot
2021-05-24 11:25 ` Dumitrescu, Cristian
2021-05-24 11:28 ` [dpdk-stable] [PATCH v2] table: " Thierry Herbelot
2021-05-24 11:30   ` Dumitrescu, Cristian
2021-06-17  7:01     ` Thomas Monjalon
2021-06-17  7:11       ` Thierry Herbelot
2021-06-21 15:44         ` Dumitrescu, Cristian
2021-06-21 15:54           ` Thierry Herbelot
2021-06-21 16:14             ` Thomas Monjalon
2021-06-21 16:56               ` Dumitrescu, Cristian
2021-06-29 11:35                 ` Dumitrescu, Cristian
2021-06-29 13:41                   ` Thomas Monjalon
2021-06-29 13:51                     ` Dumitrescu, Cristian
2021-07-03  0:07                       ` Dumitrescu, Cristian
2021-06-21 17:23               ` Thierry Herbelot
2021-07-07 11:19   ` [dpdk-stable] [PATCH V3] table: fix bucket empty logic Thierry Herbelot
2021-07-07 11:23     ` Dumitrescu, Cristian
2021-07-09 20:43       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git