Re: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Xiaoyun,

> -----Original Message-----
> From: Li, Xiaoyun <xiaoyun.li@intel.com>
> Sent: Friday, January 15, 2021 3:19 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules
> 
> Hi
> There are two other mistakes in this section "Sample QinQ flow rules". Can
> you help to correct those too?
> 1.	testpmd> vlan set qinq_strip on 0
> Creating QinQ rule(s) command line should be "vlan set extend on 0".
> Qinq_strip is not relevant to qinq flow rules.
> 2.  The sentence "The above command sets the inner and outer TPID's to
> 0x8100."
> Should be "The following command sets the inner TPID to 0x8100 and sets
> the outer TPID to 0x88A8".
> 
> Best Regards
> Xiaoyun Li
> 
> > -----Original Message-----
> > From: stable <stable-bounces@dpdk.org> On Behalf Of Bernard Iremonger
> > Sent: Thursday, January 14, 2021 19:20
> > To: dev@dpdk.org
> > Cc: Iremonger, Bernard <bernard.iremonger@intel.com>;
> stable@dpdk.org
> > Subject: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules
> >
> > In the Testpmd Flow rules management section, correct the TPID values
> > in the Sample QinQ flow rules sub section.
> >
> > Fixes: bef3bfe7d5f4 ("doc: revise sample testpmd flow commands")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> >  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > index 9be4500..e0020d6 100644
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > @@ -4432,8 +4432,8 @@ The above command sets the inner and outer
> > TPID's to 0x8100.
> >
> >  To change the TPID's the following commands should be used::
> >
> > -   testpmd> vlan set outer tpid 0xa100 0
> > -   testpmd> vlan set inner tpid 0x9100 0
> > +   testpmd> vlan set outer tpid 0x88A8 0
> > +   testpmd> vlan set inner tpid 0x8100 0
> >     testpmd> port start 0
> >
> >  Validate and create a QinQ rule on port 0 to steer traffic to a VF queue in a
> VM.
> > --
> > 2.7.4

I will correct the other mistakes too.

Regards,

Bernard.