From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 608BBA09EF for ; Wed, 23 Dec 2020 07:22:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F51CCA6A; Wed, 23 Dec 2020 07:22:57 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2FCDBCA36; Wed, 23 Dec 2020 07:22:52 +0100 (CET) IronPort-SDR: KQaExxcywkBZPCUjzcPOOvyvdW0G1CIq8eQA1hhdGO0jiyrEsUr8FRmyoKAzSlzu8LFpbgWr+N 8vJiID6UPW8Q== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="260702862" X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="260702862" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 22:22:50 -0800 IronPort-SDR: JE1TdJowyI5LBkHAN/TyNYjq0K5OWKpwJfUh5QqIR3C3ohNOi01eaeAarjtKftPdserX5/0vWU hi0uEQumh+FA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="346093269" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 22 Dec 2020 22:22:49 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 22:22:49 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 22:22:49 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Dec 2020 22:22:49 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Dec 2020 22:22:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LAmaglrJdP8Zb59eYEX2fSik9IrkTq7Kp4Cz9UlHWSs2hNMiV437d425Db8buVkdBdl/JZSTInJP742MfFdfthGVObV3CBSD3LQF5ABCztqaXQ+At0ac6XK1eBKHZWAGaOq2IgfkWApzEjq5TltMXJ6xvVB6Jn/HP9QtBwdPQUvYoPB8bw8B8cqDkcwsMAwSJRNklUaXPPUw1KknUdNl5TdX6hAUUjSt5+hedgmiAh5Rev37mTwFymeq5U8pUl4XdnUnF9E81eG95mzMCcAdDMM203RiD/GeTbWtlZiCsUfVXcqhSr3ivXsrkWKAEKXzr6gmJW5DrwyS+gDL+BEByQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nELZAecU1r+nT2m2H+Qb+ZI2oadYr4HGxje2BZll/ic=; b=JdlLJFSMLcEZwCibxn1uE6tvtz3BbiyidV8RFrnofM8tNIF+zI6BeVnYvsfEpIsNOuCrlUuvmKGczy2n0mOtnKU517lEVFPGI6Mh2JDmGE24a8l0WJa/cOENwRgFl1cdBflxC3KBW698VhwTZ/ErgEvLz8ScQT1C12fj3lOdneutGf9LCMg+Znk9l6Bmsan4dvLhuImSSth6Xup2eqR1mke7c+1YfN8iBcNoyIWNgQaQgWdTCmABh6ea0/41kh9vT4BSLMzX2wu+yKBh/Pl1Y0fpmxZPUEVUXkW8zMWpthG9OjFKEkpb3W6TOC0DQhSAWU/Kswhx2PDNPD1iVK7Lsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nELZAecU1r+nT2m2H+Qb+ZI2oadYr4HGxje2BZll/ic=; b=acZVhsvrRTkLxfC3LU4JNpNP0NyvRfy/nOz79Y7b3jgmvGHCpak0DO7oFO596ob0/lpHrWlORJ2A+uY+8gh0ajZJNCUQVxg0hltZBdV0hl33Ku/oUDcwyNwHqgsaGdIzXO//Pov4uxL7dKBiC0QpdP06xZAFrjU8xdDeL0imllE= Received: from DM6PR11MB3099.namprd11.prod.outlook.com (2603:10b6:5:6c::16) by DM6PR11MB4411.namprd11.prod.outlook.com (2603:10b6:5:201::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 06:22:46 +0000 Received: from DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::449d:b3b7:e02d:6315]) by DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::449d:b3b7:e02d:6315%7]) with mapi id 15.20.3700.026; Wed, 23 Dec 2020 06:22:46 +0000 From: "Chen, BoX C" To: "Yu, DapengX" , "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Yu, DapengX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init Thread-Index: AQHW2Oz2lgrkFLG1jEeQIdO24IHm6aoENWiw Date: Wed, 23 Dec 2020 06:22:46 +0000 Message-ID: References: <20201223053018.103877-1-dapengx.yu@intel.com> In-Reply-To: <20201223053018.103877-1-dapengx.yu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4620392-389f-4f07-01d0-08d8a70b29ff x-ms-traffictypediagnostic: DM6PR11MB4411: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1PVIpwydqvVhAOe+dlZPLpQluQ4y098luPA8WEu45OIpDxcs005ph+XeVCowfqJ+yyV5t2gT6nPMNd2Orf+xuLla4t10wMSdajsMeKIVrAGO3Dz+MJsJvHyIYp/yWogZj2s9lSZnMeXyjoBdWVnjbkSxUQvwq1+hmCJGBu6bvsuFOL09xvX8PCc+Ru/4/CDnkZ6nyjV947qAQtiVfNv0D+xNaKEtGEh+8q4McU8ReT/MNCcqoWmNZgEiRNjlZn/EFsFz3YBF/6ux3QTV7CGfDSraZCr3+dLvTURecqgOB3lLsNZ9RBQtsB2UA7yOGPaNjX2Ad0hl2+fj0xYEuIi5z1NCFuLg8lhd68B1WqRGUmhyPAPh4XfXrYmXZqMHAyIcAhaXLWRIbqQxWMCSvL+GfA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3099.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(66946007)(9686003)(6636002)(7696005)(76116006)(2906002)(6506007)(53546011)(66476007)(33656002)(66556008)(64756008)(83380400001)(26005)(110136005)(54906003)(4326008)(71200400001)(55016002)(66446008)(186003)(478600001)(52536014)(5660300002)(86362001)(316002)(8936002)(450100002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?EVKB7YZUTYiFOZ3unxVRq4roICioopI6wmYTAA7FdxpOBUhhDQ2sLRZVXaqE?= =?us-ascii?Q?T0wtEEbumM4JRQUfrqeJWc2T2XVjz6b1pnew7ZLQe9wFeZD0QgB2sYy5aQG3?= =?us-ascii?Q?202152kOze+q8iSEmn+R9q1lXePIUWHpDhYQYaFVmAS7FgJkbWxyiBJBVr2Z?= =?us-ascii?Q?wnW67w57dgmgyhyy6ybgeaqy1qxCxF1nrRIeUw1kCus+UQ8C4xEMoU/1/2LG?= =?us-ascii?Q?MTyXidc8m7CIZuasH3LvyraGh0YHkYkcW2jdisIKueZsQeLo2pPjeo0XGbSt?= =?us-ascii?Q?0dETGb+hQx+ni7rjmDFWcTvhCPnV9C7WOgf3O0/pv5xZ2nXd3QmMsNc4HVdy?= =?us-ascii?Q?TEpgTGfCLOGkEcKT2sZ2dVvDsI5+DdbXPRmVKRI/qPkfuBAoJjMa8hgcC831?= =?us-ascii?Q?l+DcSoJLkO+cH296mRuvl0nBS1HYSPjSqBEM3Rbujq/F76k6Nohqwef8oNQb?= =?us-ascii?Q?0OvKdvUVxACWqggxNxezbNiOqD+2mD8qqFLNldReC3zHxqlua2cg4kTEghYa?= =?us-ascii?Q?JOloF9lZRyF20mpoviHd4+1BI5QHYPlvmx68QUMpXpNvn29+uFYougcQ1Q3T?= =?us-ascii?Q?/TqjDG106IdlN6UkYszbuvu2Ahl+f0F0+PjswtmexCJaWAXri1Z8VEwvpxEa?= =?us-ascii?Q?8md2hZ2wq/VR72R7XWfNARMzmHmVDMr4XYh2K6b8lkSEc6pWJCY/Vy4I16Vc?= =?us-ascii?Q?JYdN3pAdb6q2dMhkhqDbq6UYbEhYRyIULM9V5p7GPjdA/4tM12qvUdOwn6NT?= =?us-ascii?Q?3ydGb3Es3dnxubAjvFe1LTIRqPtG96yRrjQtZxkgFUvEiL+CTQhdGKqFs1Pg?= =?us-ascii?Q?VIacCUrokoGbPoGR0h+oUrVElVFp5SQbaDxMRGlmRjCACDZKOoPHr8BCkMzk?= =?us-ascii?Q?Mk9B317Mne4FJqS6t/lGtMTd14OjLBhd67KfKLuw6/kxOWCuxlw11giLMLgJ?= =?us-ascii?Q?isuk7IXrUUtjtOBNghBh67lUwYqgnKMZ2/erdAd2h9k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3099.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4620392-389f-4f07-01d0-08d8a70b29ff X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 06:22:46.2322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NI8wn5hxfyG7+JShp2XhNGNN8Bs/o0pJhu5dyhWxgzsI4b1TW0WPPerFXFMcykbqqAvreQKS8gIIhGXmPTUpsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4411 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Dapeng Regards, Chen Bo > -----Original Message----- > From: dev On Behalf Of dapengx.yu@intel.com > Sent: December 23, 2020 13:30 > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init >=20 > From: YU DAPENG >=20 > When RSS is initialized, rx queues number is used as denominator to set > default value into the RSS lookup table. If it is zero, there will be err= or of > being divided by 0. So add value check to avoid the error. >=20 > Fixes: 50370662b727 ("net/ice: support device and queue ops") > Cc: stable@dpdk.org >=20 > Signed-off-by: YU DAPENG > --- > drivers/net/ice/ice_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 9a5d6a559..bbb8c1460 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -3182,6 +3182,12 @@ static int ice_init_rss(struct ice_pf *pf) > vsi->rss_key_size =3D > ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE; > vsi->rss_lut_size =3D pf->hash_lut_size; >=20 > + if (nb_q =3D=3D 0) { > + PMD_DRV_LOG(WARNING, > + "RSS is not supported as rx queues number is > zero\n"); > + return 0; > + } > + Direct return here will introduce subsequent exceptions, the tetpmd will ex= it. testpmd> port start all Configuring Port 0 (socket 1) ice_init_rss(): RSS is not supported as rx queues number is zero Port 0: 68:20:20:06:01:00 Configuring Port 1 (socket 1) ice_init_rss(): RSS is not supported as rx queues number is zero Port 1: 68:20:20:06:01:01 Checking link statuses... Done testpmd> Port 1: link state change event testpmd> show config rxtx io packet forwarding packets/burst=3D32 nb forwarding cores=3D1 - nb forwarding ports=3D2 port 0: RX queue number: 0 Tx queue number: 1 Rx offloads=3D0x0 Tx offloads=3D0x10000 Invalid RX queue_id=3D0 RX queue: 0 RX desc=3D0 - RX free threshold=3D32 RX threshold registers: pthresh=3D8 hthresh=3D8 wthresh=3D0 RX Offloads=3D0x0 TX queue: 0 TX desc=3D1024 - TX free threshold=3D32 TX threshold registers: pthresh=3D32 hthresh=3D0 wthresh=3D0 TX offloads=3D0x10000 - TX RS bit threshold=3D32 port 1: RX queue number: 0 Tx queue number: 1 Rx offloads=3D0x0 Tx offloads=3D0x10000 Invalid RX queue_id=3D0 RX queue: 0 RX desc=3D0 - RX free threshold=3D32 RX threshold registers: pthresh=3D8 hthresh=3D8 wthresh=3D0 RX Offloads=3D0x0 TX queue: 0 TX desc=3D1024 - TX free threshold=3D32 TX threshold registers: pthresh=3D32 hthresh=3D0 wthresh=3D0 TX offloads=3D0x10000 - TX RS bit threshold=3D32 testpmd> testpmd> start EAL: Error - exiting with code: 1 Cause: Either rxq or txq are 0, cannot use io fwd mode > if (is_safe_mode) { > PMD_DRV_LOG(WARNING, "RSS is not supported in safe > mode\n"); > return 0; > -- > 2.27.0