From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F558A034F for ; Thu, 1 Apr 2021 09:48:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49AE114109F; Thu, 1 Apr 2021 09:48:47 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 4721914109F; Thu, 1 Apr 2021 09:48:45 +0200 (CEST) IronPort-SDR: MTlTXX/4MMxPbF/qL8d9ois9QjkISvZp8FAFuR5ePGref7q88eukGP7pJvCKRdhYg1H/nIo6/i chgT3tx6qrEg== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="171595132" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="171595132" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 00:48:44 -0700 IronPort-SDR: 5kCXFJacJsTQhtJiPWNkO+88zxwXVmjKlm+7vMmc/kOxGJY3OTFpotoN9md1+StJ7CV0FdooCB mLY92ya4SSwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="455865285" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2021 00:48:44 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 00:48:43 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 00:48:42 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 1 Apr 2021 00:48:42 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 1 Apr 2021 00:48:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gswcKvHroCedktw8AX7JM755sGu9YS+HK1AnKuNl/rHaKvDVgVixqd5UHFkNCnmDHgJRK2JyBOTxsWckpZev0vvb7V8Za4DHmte4V885RaaMN1GGkUq0mzDpsc1iw+fddQrUPOsM7Zpms+Tw0bPvhOleSMr+bKho05j2dbifFPCpVq3qOHiBVlo69tveC1wpNZdLFLRQvv5G19Mt0wxmdz5z4hyege0ZKoxFjlp2qaGeJLYxXe/x0kNCMM84MV6W2aHQ9VxHHrJjuI52+iDvBTgOs7Hcszk89UmamQgqCFOGU8n+XIApeD//+IFPrLQCPobDnchbbBH9DaR4TRw5ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6XCTw+ivNwJGkarH4CXTl9d4LWVtDB5Fp5SpuF1EEI=; b=bdb+PGpxCTQA6GN7CxeoJ/2G1hJrAEnUlYYhbPz90kWfT6QjzHGPclq13amUyocICt7SxL6xSI85xJAwBoAkxY2cwlPAKRuIMs6ahJbyHu5Mz9O+Ox9W2+6NnYwRTJR/eayYoEN7QhST3tk8mZ9u8a1HhcXVf+sWdSSq8QCnQUYf0fRlO9gvP84loXgeKDhLMoakM7fD2fccWIlz3t3/V4FknlirRadL9zX+2opAxMbxVduf1J0FSKlp6y8h/rK+rO1BVG3zv6SMCuOoYL1cMPZktaBCtysLziaGMXe1WeqUCgJn0ftsu5qZoQTEcLD1zczRWElV9MsnmAq+9sleLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6XCTw+ivNwJGkarH4CXTl9d4LWVtDB5Fp5SpuF1EEI=; b=GmJmCrDPgO4427Xd1MHZ6AxNT4pufYXhUql6n0z3RmnTQFvzCwfq9+Zxqug/qKkWIK2JCAiWnUjHfO8nyAKDsa9XoT+dtYi+U0bMAfkazdtpNzzsJZSZdB8eXihJyuK3aE/YKRX2eZ4Y3puFArhkiLWn45TNLjnCN6v6JFkt93Y= Received: from DM6PR11MB3131.namprd11.prod.outlook.com (2603:10b6:5:6d::32) by DM6PR11MB3468.namprd11.prod.outlook.com (2603:10b6:5:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Thu, 1 Apr 2021 07:48:39 +0000 Received: from DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::181b:59f1:8b7e:b9db]) by DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::181b:59f1:8b7e:b9db%6]) with mapi id 15.20.3999.028; Thu, 1 Apr 2021 07:48:39 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" CC: "stable@dpdk.org" Thread-Topic: [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Thread-Index: AQHXGwbdYGmmaXWf2EO4FMAoj2xSf6qfYMLw Date: Thu, 1 Apr 2021 07:48:39 +0000 Message-ID: References: <1615969417-17118-1-git-send-email-wei.huang@intel.com> <1615969417-17118-3-git-send-email-wei.huang@intel.com> In-Reply-To: <1615969417-17118-3-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 325c052a-480a-4851-683b-08d8f4e29070 x-ms-traffictypediagnostic: DM6PR11MB3468: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Pt1caQVmyhcS3R6hs0MSDZ04kWKKCC+lOkxfxNtlqljFWV0kBaq9KKdsDMzugK9JS0tAr/GsNNkw6bUX8MK8FxU4UEbSrw4PdnR3gSA5hHWn55+PaaupEAUj8rg5Z15Eo0hLY7eWKlTI7Lz/Yye9/577JxFzqezK6UtnRyJiCsWXVrbD7CrhH9XeXJkcO2ktSnd8oFJFqR9Qm81fJ55ZhQ/gdqEC/681l9EScsucjlkFaOZvsIFlnaMlCTIPduyh1qtbFrDHAPNmKRus5xjrmc6UD/A/rWxzrHxS2zo48MprqCy7hjiJes6dErn4XAOtnoXDbJNNnNcDUkNo3DAIFoIxVh8ZvwCChVYvU//g21m8JHIi+utmulII1StMIF7N/hu4Nz2Jlriftlmh2iYfEsHXTedRIKSN9yYvUEyUEyLFWwUshEef2ymM0YO8e9jE/t3YP5CH1iKx1YV4BtlliEF02vkOcjho8cgNIAsIVPyw0O8ANVxP3jt9Bimj8DwllsTUz8RI4peaABAYMMnik/MAYacUO7o2KQ9/HRqaYA5cGhYe9aWsk3hm6H1sLksNhEGvkrithD46Qbw8EGMJrrFMLr686z1QGx/dp1Qbdi52YzB8pZdI/N8/5GvGK8vjgttM1CVv42k+CGcBpAssQys9YX0EemzltWP6Fga/guM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3131.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(396003)(136003)(366004)(346002)(39860400002)(66446008)(33656002)(7696005)(66946007)(66476007)(2906002)(53546011)(38100700001)(26005)(316002)(55016002)(9686003)(186003)(76116006)(71200400001)(110136005)(86362001)(5660300002)(4326008)(450100002)(8676002)(6636002)(52536014)(64756008)(83380400001)(8936002)(6506007)(478600001)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?TTFXeGlUUUswTWMyYjc2aUk3aTFGK0ZCYkNDYTZ0RlMxR2t4aWZzeUpH?= =?iso-2022-jp?B?NTkwM0pMV2s3dGN5WUtUQ1lJS0d6RE5SODNiOHBqQS8rRkNFOVZhakc5?= =?iso-2022-jp?B?dXdCL0N4RCtVZnZ6QUkyT3M0aXB6eWltSzVwbUVYUDZSTkZndzdZcXBR?= =?iso-2022-jp?B?WjVrdTJZQjBIVkR2WXR5WTdYVXgxNGx4MkFiVldkTnBheFZRQ1FScFFa?= =?iso-2022-jp?B?cWtkU3g3NFBDS2xlaDZVTTRjWnE5YWVIWE5TQmVDZ1V0NmZqMGRqS0E1?= =?iso-2022-jp?B?eVdZdGk2NWFWMEc4MFloZG5KWnB4blBod1A5bCtHSlladHR4cFc5M3dF?= =?iso-2022-jp?B?cEptNWoraUVaRHl6T3ZVWE9TWWpkK3RkbVAxVWd1d3dNY1VSdEp5bjg3?= =?iso-2022-jp?B?THVGRW9oYVM0SThYZ3ZWSU92U1BYVVArV1NRaVI1MytQTXh0Vkk3Qm05?= =?iso-2022-jp?B?NjB3MDhGV0JMTC94ekQ3OHB6Q1NCNTdGWlRyVGcwZ1VrNWtPQjVnKzhT?= =?iso-2022-jp?B?akd5bFBMZEgxVHdicFdndFNMcUZpUWZnMlVhYVNmSnJJUlF0MXlPYVlX?= =?iso-2022-jp?B?RlU0dmVNM1lsTmhiMmhYYUk2WVdFK2N4bk5lZFU4dFhueE1ZYnkyd1Fk?= =?iso-2022-jp?B?WXpDdmlDaG43NFhpNHFUd3BsdG4rWkN0ZWlsME1qWThQdUIrQWtkMExw?= =?iso-2022-jp?B?QVdCWmxpaGZIM25IUzVxTHpkcjFaM3hHODJZcnhwZStXQTl1WlM2RHhE?= =?iso-2022-jp?B?OGVoaWlab0JaOFhPSzN2Ty92Z0NwaW1YTEVvUzU1bUxVSVl3QnNlWitC?= =?iso-2022-jp?B?STJCbFZ1akJRNHdHZk9IeDBLU2V2UTlRRXhCZ0M2SVRIWnYybmVFRzBl?= =?iso-2022-jp?B?ZERPYzBYUHVtOUZUWjVidHFBdkhTeEg5UGJJTENWd0RYUDdXbmJHenVr?= =?iso-2022-jp?B?Yk9PZGduK3QvS2xWczlWdzFQdmEzRTJHNVpRUFI1UmxqUHJnbkMrbGdr?= =?iso-2022-jp?B?WWFkZ0I3VlZzNUdGZ0htSE1Nd0IzbDh4SDB2dDlGM0hrYkpscVArUXVy?= =?iso-2022-jp?B?ZlNBRUNEeVZRVFBRZUxwZ21UKzFxZXNJR3FrcXBrQUJGVVNmUW01d0FE?= =?iso-2022-jp?B?Uld2NXVrOTY2OFQvdksvR055WUNKU2kwRCtYWUd6NTZrVlRnNU9ER0Vv?= =?iso-2022-jp?B?YWZCWkl3UWFjSmhkZlFOSlhoV3B3YjhhY2FxaTVwTDduMU9TakNEa3RD?= =?iso-2022-jp?B?c21ESkkzdkxFRjl2cURncjRqSWtJRG40aEJBNHJUVTNmNW1wY2FsTXlB?= =?iso-2022-jp?B?QjBMQ3JrY3FGYXdLdjh2b0g0ZkpNVGgySWpzelBZVmpIaWk5Vk1wVFBi?= =?iso-2022-jp?B?OFhYWEZJblNMczZMZzJLeUR4UU1adXg2QnhaKzdjcVNuU1phditmZ2ZK?= =?iso-2022-jp?B?dDB4ZDZFZHR3VE5maHRYZ0lpQkpnb0h5bFg3OFEvRFU5NDhvSlZXelMz?= =?iso-2022-jp?B?Qy96MEpVanZ2V1pGYjJZYWV6VE9VYSsrdnNuK0lWcGJVbWFTRmZOQU51?= =?iso-2022-jp?B?TTFnbjJMZXBFSkkvY1ZpWVp1aTlZZXUwcElSamk1Z24ybHBrMng5dTEx?= =?iso-2022-jp?B?eDVZSlVrU2luVWpCdERGUm5MT3E2UUliaTZqc0RkUTVGUU42NU84eHQx?= =?iso-2022-jp?B?UUdkcWFBNWFkb2dFOHNVQVF4M3Y3R085ZjZScUNjbkdnS3lUQklZVEE1?= =?iso-2022-jp?B?VDBnM2dSRDBmWEpDcGlnUUFYa3BJTTA1cTBmT0pmQXNhaUxjQVRGODI4?= =?iso-2022-jp?B?WFlvMVhGRlpYK2lEYjQrQi9weHpscjd0SVpnbEVIMkdhallVTnNaQjVW?= =?iso-2022-jp?B?ZkhtVU9ySUc5bXUvajJHcE10azcrM2czNWpUbVJzaC9heGtZRFgwcXA4?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3131.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 325c052a-480a-4851-683b-08d8f4e29070 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 07:48:39.5157 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XPaYd/329KauQgJDbnXh21uYt87YE6F1bTKiG1h2WHwwYGnDmgKJ0Kyj5//h2kG5uZaQQ3QynBh3XSjfbbEVHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3468 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Huang, Wei > Sent: 2021=1B$BG/=1B(B3=1B$B7n=1B(B17=1B$BF|=1B(B 16:24 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: stable@dpdk.org; Zhang, Tianfei ; Huang, Wei > > Subject: [PATCH v1 2/2] raw/ifpga/base: add argument to use untained > variable >=20 > In fme_nios_spi_init(), passing tainted expression "fme->max10_dev" > to function "fme_get_board_interface" has risk. Add new arguemnt in > function "fme_get_board_interface" to accept untainted variable. >=20 > Coverity issue: 367482 > Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver") >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/base/ifpga_fme.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/raw/ifpga/base/ifpga_fme.c > b/drivers/raw/ifpga/base/ifpga_fme.c > index a63f90331f..4edb9e09e1 100644 > --- a/drivers/raw/ifpga/base/ifpga_fme.c > +++ b/drivers/raw/ifpga/base/ifpga_fme.c > @@ -857,7 +857,8 @@ static int board_type_to_info(u32 type, > return 0; > } >=20 > -static int fme_get_board_interface(struct ifpga_fme_hw *fme) > +static int fme_get_board_interface(struct ifpga_fme_hw *fme, > + struct intel_max10_device *max10_dev) > { > struct fme_bitstream_id id; > struct ifpga_hw *hw; > @@ -911,15 +912,15 @@ static int fme_get_board_interface(struct > ifpga_fme_hw *fme) > fme->board_info.nums_of_fvl, > fme->board_info.ports_per_fvl); >=20 > - if (max10_sys_read(fme->max10_dev, FPGA_PAGE_INFO, &val)) > + if (max10_sys_read(max10_dev, FPGA_PAGE_INFO, &val)) > return -EINVAL; > fme->board_info.boot_page =3D val & 0x7; >=20 > - if (max10_sys_read(fme->max10_dev, MAX10_BUILD_VER, &val)) > + if (max10_sys_read(max10_dev, MAX10_BUILD_VER, &val)) > return -EINVAL; > fme->board_info.max10_version =3D val; >=20 > - if (max10_sys_read(fme->max10_dev, NIOS2_FW_VERSION, &val)) > + if (max10_sys_read(max10_dev, NIOS2_FW_VERSION, &val)) > return -EINVAL; > fme->board_info.nios_fw_version =3D val; >=20 > @@ -1169,7 +1170,7 @@ static int fme_nios_spi_init(struct ifpga_feature > *feature) >=20 > max10->bus =3D hw->pci_data->bus; >=20 > - fme_get_board_interface(fme); > + fme_get_board_interface(fme, max10); >=20 > mgr->sensor_list =3D &max10->opae_sensor_list; >=20 > @@ -1186,7 +1187,7 @@ static int fme_nios_spi_init(struct ifpga_feature > *feature) > return ret; >=20 > spi_fail: > - intel_max10_device_remove(fme->max10_dev); > + intel_max10_device_remove(max10); > release_dev: > altera_spi_release(spi_master); > return -ENODEV; > -- Acked-by: Tianfei zhang