From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F5DFA04DD for ; Thu, 5 Nov 2020 10:33:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69F28BBB4; Thu, 5 Nov 2020 10:33:37 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E936DAA31; Thu, 5 Nov 2020 10:33:32 +0100 (CET) IronPort-SDR: gXWUCwHw9uYU5jN3qib3sfpwh+8cFG5EJSHbLo9RdKEzsgBVZhG4MDBJARmRT64OhGTJ3TAUpU RThguZo41W5g== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="169463689" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="169463689" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 01:33:30 -0800 IronPort-SDR: WU5gl0siBszOUaXcad5tf2ngJbdP7BJcwu2Am42ovblosG163+SijGdHvbhjjGMqC1p1UrF9Em vDubV68R5FcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="325964313" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 05 Nov 2020 01:33:30 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 01:33:29 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 5 Nov 2020 01:33:29 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 5 Nov 2020 01:33:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uc8N1YLFRNrO72sDz0zAUXwtM6dMXgU3gHrAScpth28u18F015kDZ+8/hcVRfRta/Br9YA9P/tgrc+0Ayi4Ot3jJvRDsr2DQ++DRJ2LG/Pvd4S5chG/ISuQlvktrok4UbopkQHpSUUb2XNtUSHSiwb6oSlVloC948MA7e72tGHWyAgQaj9nXzB977rLFGkcs8RaS6xugnKdJjjDMKPcIzqe0eOF/UwqNNDeqSn+wcjroDZ6VbjHjTJXb9+H09HMGF3aYLp27vY60k96jR7xgIXKGOIKabWiLPklO0CDYhfssQ209tYQkJMRIdaQC7/bUxQLYCTTjZ9pHXtC4fy5iSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qigIct7GuoenSifedSkCW5gs82twwpcpAltzK3ZEG4=; b=UR7bcyn586XIGzd36LqjiMxLHPLrqNICbrqb6wEi6CPe1pBHy60g4jfrr/tpGnf0JVzzNGW3jtPreSTRa5bD9ywgJdgEDaCGVAfzHFz/vwfjfjb3UStArzWIT2NYagtTOPlI06/GQACy/+8jQxV94l6QY7FboR66f8l/8pw+QaVJe6+jm5hP0A6lJlIaTVnAU3TkhWZSFNvPfoJO10DSO/0rUDD0SKKtRBsrLMLxEAdxS2SDPBR11djPtt3/1RGFvu6ZhqS1IL/its1lr2w6uo4Cn56Py6eHmprATTYrTlNxhNSrl0Z8cDn+P8aC/KXHVwWrSaVyq48gG+9CMl88wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qigIct7GuoenSifedSkCW5gs82twwpcpAltzK3ZEG4=; b=DPqU8z2T8+ScHwAdkEGo7desp0zpvswQoFenm8wtVhgHPhohD/7dAAlUDXLXWdE5yZh1yMsg93Tp/AuJAXLHgaNSnva9qIchBNUmX6jhPhY1+BVytqf6pYd7it5c1oJDa2CY5zmDg8XXdQVmATYyi70MXrMk1QkPv7xFvNvfROE= Received: from DM6PR11MB3131.namprd11.prod.outlook.com (2603:10b6:5:6d::32) by DM6PR11MB4578.namprd11.prod.outlook.com (2603:10b6:5:2a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Thu, 5 Nov 2020 09:33:25 +0000 Received: from DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6]) by DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6%5]) with mapi id 15.20.3477.038; Thu, 5 Nov 2020 09:33:24 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" CC: "stable@dpdk.org" , "Huang, Wei" Thread-Topic: [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: unlock mutex when nios init fail Thread-Index: AQHWsx511zSfrt/NhkW+oBKHvJNT0am5RvrA Date: Thu, 5 Nov 2020 09:33:24 +0000 Message-ID: References: <1604540969-5503-1-git-send-email-wei.huang@intel.com> <1604540969-5503-2-git-send-email-wei.huang@intel.com> In-Reply-To: <1604540969-5503-2-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7625052d-f7ef-4a98-b9c3-08d8816dd818 x-ms-traffictypediagnostic: DM6PR11MB4578: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8vuoAWyWRJWJKUDiwMYXNcVd/b2ha4qhK2pPKf7f8ehze4XFWosxXzW73ZYSCqdKZRCuorxqS0rGYPqFcHrOOFU8VkPREyoSOgPm6cFEBwbDviDMLCCNeTX7P5c1f048eULW7ph7NppkzJfqYA0zreOnexKjGjehIjZJMwYEjH709pO7gQVQD3msjbagI3DhmcZXNpyZiXEs6q0loOsUoFnVbiRzpdXHv1F61lhxlP0wSS7ApU7FodR/MPAWNC4RHZiTuMFGMBcp3gRnzROYYVtXvFt1K6cGFzq17mtCa53RHj9iE8So38RjTM9ylEPVNo7KrJzuyr0Llt9FLOOb8w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3131.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(346002)(376002)(396003)(71200400001)(8936002)(6636002)(26005)(54906003)(110136005)(478600001)(186003)(33656002)(4326008)(450100002)(7696005)(6506007)(316002)(53546011)(5660300002)(66476007)(76116006)(86362001)(9686003)(2906002)(52536014)(66946007)(64756008)(66446008)(83380400001)(107886003)(55016002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: bP8ubjysa8thz6ACrh3bwdNvjj3NnuxlaUdwxIT4YI2R5v2mrI2DPqi0d9pVIvDv+tQR3+VXWhQwuOm2NsXjl3dXlZR0ZVzDdoO6vQ+ybGhWt+3WUKfELuHHVpAyVqjOFPvg9Heo+QlTJZFyUSDl9qQsV/fG+KvCP6IbXiDr7LDU1B2xayiHsXwzgaHbexl6ZgYf0LNN+fqktGmqaPzZikMVCWQW+9ldUWJbdSSovDD1JEqMEg6ZlvFgX9aMSMHh5Py/L4SxYFnV386p60/SH03bLx2+CYZTApKuLjxvhhChvq8l5bi+TcZqX6giJ1ytjTv29aXl6SGvndgs+pq3yoIzAkZ0bODrZIzFGh1PUFB9P3VFSaZ3n2W0Ne6uIWKrsA8K2a2CgQWb2MS5ml44w1AoLiTjnD+b3et78lvPtKrKp5N2d0B6g0ceHWHei513G1u87AeJurMX1lfIKArYnA9eweIFISWYwG+wRETY+pmq6Sk2bASQ161slgpl8pHEEAM785vTkdZZ0cm8bTnDdytyeh5p6gOecBtFWwM4A8tMA0FPr7IqEnEZEtLBL9ZdlStv7rGSgqw+qPkytto9WxuB1Gh5NyV007QHv39vDZyWQslcPy3oVwyog1ipxraRptReEnK+Q9SLRo4xLRCL4Q== Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3131.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7625052d-f7ef-4a98-b9c3-08d8816dd818 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 09:33:24.8653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EaTQMdW3Umk1N41hQRpecW3OdRpSOiMX3EX0gXAmDy/FD++ja9JLESzBSg1akoj57M1Y5izm1bt5sSZGJZevdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4578 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: unlock mutex when nios init fail X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Wei Huang > Sent: 2020=1B$BG/=1B(B11=1B$B7n=1B(B5=1B$BF|=1B(B 9:49 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: stable@dpdk.org; Huang, Wei > Subject: [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: unlock mutex when nios > init fail >=20 > In fme_nios_spi_init(), a mutex is locked for protecting nios initializat= ion > process, the mutex is only unlocked when process is successful, it should= also > be unlocked when process fail. >=20 > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in > multi-process") Coverity issue: 363751 >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/base/ifpga_fme.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/raw/ifpga/base/ifpga_fme.c > b/drivers/raw/ifpga/base/ifpga_fme.c > index 540bb1110..f29ff3159 100644 > --- a/drivers/raw/ifpga/base/ifpga_fme.c > +++ b/drivers/raw/ifpga/base/ifpga_fme.c > @@ -1115,6 +1115,8 @@ static int fme_nios_spi_init(struct ifpga_feature > *feature) > ret =3D nios_spi_wait_init_done(spi_master); > if (ret !=3D 0) { > dev_err(fme, "FME NIOS_SPI init fail\n"); > + if (spi_master->mutex) > + pthread_mutex_unlock(spi_master->mutex); > goto release_dev; > } >=20 Acked-by: Tianfei zhang > -- > 2.29.2