From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF5BEA055D for ; Mon, 27 Jun 2022 06:53:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8799427F8; Mon, 27 Jun 2022 06:53:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1D48F40E78; Mon, 27 Jun 2022 06:53:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656305597; x=1687841597; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oiIl1fInovmqod6IN8iBYvjmLtjWOMwFsXd2wlLmk28=; b=j4QFz9tVIAlDPH0XTbfjjP1vZwVRucC8YW46zUJEBR/Wy/3oUj3kd1pb +9pO3Ya/h5AHoayWRkAwzj4zxgHWKavb9nWpJu1x4A+F5UBBcmN7zDsAf wLUeaNVBnMsOaAfekaVEgxez/O0Yfb/Dq8OwgsGxDgoEa85aWvjnY2RG+ dR9uDdHUaRLc66cjkWGAw+jivpV8WcF32tzYXhVYkDrDQRGhFiwgroTbl Z5vyjSO8HHt6SdX6QNlug7DgOaTvQvgkR3kOlPj1YFmM0cs8Z27qwcLO9 HacciZNhyvBjO+i1gsGN8vTJbO7wzaV6hgKnjADzzaVROF+70XiHIYWja A==; X-IronPort-AV: E=McAfee;i="6400,9594,10390"; a="345356626" X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="345356626" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2022 21:53:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="916553213" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 26 Jun 2022 21:53:15 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 26 Jun 2022 21:53:14 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 26 Jun 2022 21:53:14 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 26 Jun 2022 21:53:14 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 26 Jun 2022 21:53:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqiCBetCkaXgA4JuLKD+3cBkcN1b+71aDXBgZBvHnKaCDynBz8q3+PTEaqU1nZRkx1SI9jvKJATDNCcOlCxeD2TGLziTSR8Kom1sCf5KJov+OCGpKhp67swjspYwY6xryQfSxOHZbYqsmLoCuW3TDGNtknGCOqUczdSgsD9A9OEtD/4lFxmzKf0OnYhJfQ5ovnWTe24SRfI2Br2VjMWnqQgMfzjeUbohmzKVvi27ZURb6fk/8P75Z56Fbtoo6DKwxX3xvJrJKAfooPpfofM/YxGqHlVktF/eTZDxnTkLPj89sWFwIrd5kJRoMlhOrAO1NCk+mUu5RNhRkvsTouE7ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jwDuL3KlgXj4TZh9CvmzYuURJYWlrFa4kQoqANmbpzc=; b=bi+WRasFQGJmg6vuifhsGtq6+IhRjqr/tXBwV604SdHKQTk7jE8k2kpCjrp8zEEySE/eqko2XGVjNHMrwj1+j+AFP6ImaCvdqXmJfDWIApFpdbeqXmzaaFJbQU7of9sKpSgWqcopyPl8f5rapl+Bb7jYjTGSzGgea/NRa7gnGcFnS0o/Gjso9xG6XiFXUc4xlHjkCthbowl+IrLBUHplsxQ+sDE7isXpIRHA/Wyem9RUnw4B8xfoiHXZZbbAiqFtx70hII5a5KkZBylxg7ohmxAXvrxv2NLXjOvKNm6hVhOBTDz5IwJKPaciup1VGHKaLzBCnCd8REanz5kz6TPgGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by SN6PR11MB2960.namprd11.prod.outlook.com (2603:10b6:805:d4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Mon, 27 Jun 2022 04:53:12 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::e5bb:2070:5248:ce96]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::e5bb:2070:5248:ce96%7]) with mapi id 15.20.5373.018; Mon, 27 Jun 2022 04:53:12 +0000 From: "Zhang, Yuying" To: "Zhang, Peng1X" , "dev@dpdk.org" CC: "Singh, Aman Deep" , "stable@dpdk.org" Subject: RE: [PATCH] app/testpmd: fix secondary process cannot dump packet Thread-Topic: [PATCH] app/testpmd: fix secondary process cannot dump packet Thread-Index: AQHYhus7Emac0m+/kECkYr5nw+F3Ja1itI+w Date: Mon, 27 Jun 2022 04:53:12 +0000 Message-ID: References: <20220623181502.181567-1-peng1x.zhang@intel.com> In-Reply-To: <20220623181502.181567-1-peng1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 302aab14-3666-4536-ad4e-08da57f8f05a x-ms-traffictypediagnostic: SN6PR11MB2960:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YOCxCA9TzSEMLXV3AEXe0CUlZyV0tR74LjR9MyRyIgtIpx0l42f6DarAk0YnddY5BnkcjuEzibnzoUGsTkjEWMZ/XFrKLXixsur7SbTSWSCM/rTMAk/NoeZiOfc/Y8nTsxcILrQ3667HPIV5Dc2It68YBPm/AdBV/4Dfx/QjZwrPZ6prw0WLwAdGdvmuTaeDKqvi9qoJLvDm3zxOe0znf+qvpK0UNjq0SBcEgJc/2RKQz+sLv2m/nVevlKNrp/xCtTGbSAFBTPa4f17gm8zTgXOoIbg2RrACgCaTojiPCYNMRTQqc23iQtrHCjgffHGeQrp8ZRfuCAsYJIn3AIsJaLgY9WSEH0h7bI/Qhr+HKyx4EoG7pprUBKEXwZI+aOK0X21uxr1aQAXaHTjGnrcbxJ3VQdl2SS2hNW35t6mc4zrfWerUVhV6tKxSXnaga78Guvay+59kHJJcRK20qcMp0l+x1fIGbBhOYUB0kH4Gy2jdKcO93dJWjZ+5WXbabAUie0MFqS0KInX1QuZSYy4zndCV9d32yhQ+TWBERYEvwbO/JulXIBfSGuoQfkzxmWV7Tk5Dp7xS6/Sdc4escbU4byhZdpb01AnQsmyEDyOgRMy+CbQgOMq33R5IgEK6Xh/w5NcNBGeAY/Iz7CqkytkhRp/tGrxaR1PgArGqg8SEA14UBbezP4qwDc+JR/JewIAtaXuQCK6X1e4f6pl6zxLA9mTR32Lvt3VQaF98f+SY4rk5kqsDU4AszH57EiE6kGPXNjFKuU+wrT/5UdWmFzumkbh10C9XLu3xUjZUXSrpD34= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(396003)(376002)(39860400002)(136003)(8936002)(76116006)(4326008)(66446008)(8676002)(450100002)(9686003)(186003)(26005)(86362001)(53546011)(6506007)(33656002)(64756008)(7696005)(41300700001)(83380400001)(66476007)(38100700002)(71200400001)(66556008)(66946007)(55016003)(478600001)(38070700005)(316002)(110136005)(122000001)(54906003)(82960400001)(5660300002)(52536014)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iqB/1AqteaYwRgODZcOUVX8z0l/ntuMnOhbMRp0jCMbtgHLycSQZ+CuWiZnu?= =?us-ascii?Q?syu7IS50n1Z2nseaAQuyppH9XfM2BgEz1/bIMMLwiP81da1+NgxzWZ1QRrgB?= =?us-ascii?Q?980ozk8brbYhVUgZA+x8hvNo7+goPS8pWhNSOsl5uemtMP+NmkY8GAeYYQC3?= =?us-ascii?Q?xKfI1B1svfq8zQBjyebyJnGspWTF6Ah6OP+c6ef9XRvtFyBnVi30UcC+xeSe?= =?us-ascii?Q?S0aJFu1SsBqPFYeh2IHdrfA+gzQrGQ9IoJkuNC1p0CHYTcpDM1F/YCZCChyl?= =?us-ascii?Q?1DqQPiPPKmbiPQ4nP/AhC1/ObswbUmQKNi/lJwdS+YPUek9wWXE/sP0YEo1r?= =?us-ascii?Q?HRtwzDvWLLT5zYp58WEchFTTXWoUHrcxXZWJPwKtljccz93Mb75gZ99LptIW?= =?us-ascii?Q?5Me6cQz0XXWLhOJu9VwyjcjUW9Y2V4JF1jfs47orFJld/OfTN+/lcD7Cob3P?= =?us-ascii?Q?6Q0bVmMF5ZD4v+bnCwbTqkBIfZ7KSKIQdDJJuRUOBeqPpxspAGuxH46w44LN?= =?us-ascii?Q?GMhP62d7OBwLTkFeRDUNvYSDpuWvwyC2O0Srr06iNYk+Gx85y1gZbnbA5Mv5?= =?us-ascii?Q?QDWnBxahWcomjwKfN6XGsPtLfz3Ire0fG4iPQEUqR2indawMmmLXcxCcCknx?= =?us-ascii?Q?kIRPhe3JuifPK12+cKmoDZ8TkZU+xN1wmv7C29/+V4TGJvM0EwUTTXcryCGy?= =?us-ascii?Q?X8SVTVD+kRwhTWpAEvYPI4Gt6WFcDbIQURHuia6Qq3mr9MlzMLsyElozuYzK?= =?us-ascii?Q?T1aaKlDVrREmLYjltlWgKLXruqrLJ4QiRqfyiQgdqjA7E1uacxMqqkNLiJ3h?= =?us-ascii?Q?GFkpXTck/WQm2pLQNJ4Yo0fBijqvZBpZR8obnUujN6qg0IoTAipKx9A1L9WP?= =?us-ascii?Q?C1vESKT+jOW43Q1em1qdeSNnhn+VkBZxz6Z9isyCrcFTbrH4SEZmIgIP3hR0?= =?us-ascii?Q?DTUeSDvLwLZO4//kuP0/HS93BUYrbwprCQ5Lsbb6eC9u5JRXZo1L1DjQEXZ9?= =?us-ascii?Q?f/yoLVgjqHC7mnU8y1eHA8BpEsyncdXaF6lF2e+p4sV/4a/6HQUG6VRJUWXU?= =?us-ascii?Q?E1QfqVVELnAnliJsGX8TuL9+Dcrpq4B9pTLF+3ox3t1zfdaQgJe+2YvXBxq9?= =?us-ascii?Q?WRgOWBaZKUpBvmN+w5i878jINmCptNvzERoAllyMH3oLwno9N93QxWj7Hl+R?= =?us-ascii?Q?jjB5QLEdv1BLYVySeCVndc8sEF+DvOavstHuvUve3jxF2hMzSsm/9OonU/6/?= =?us-ascii?Q?A4y6JR0BrdZSNhO3+2N17CnZ8dAC6nnoQPSIfC6V0IpuQTEVx2I+R4eFlVQy?= =?us-ascii?Q?aqkaaAGXmqez5U78SKWF0BvqpLLL3y4H1zRR/52lVQPw7F8tq1yaHvPFBJWU?= =?us-ascii?Q?7SpQmByLxetXddjLDy5iVaqqHr4AWcoOf5s0CjXQRRa5hw9sc9AVF17mWjVy?= =?us-ascii?Q?JupH6PbiL88uNb/wo11HfKptt54NXUgX03xWuNHCFw2UeInje8rcztmU/exf?= =?us-ascii?Q?cZ9bAP/Bahl2kM+mEQcpE1XtRoQ+y757RQhsGaa261Nzmh5AuU62IJEGUQpa?= =?us-ascii?Q?qkZ4cXjl+PqVmeGhXjA2idwvjkcc4D0WmsfIRlfk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 302aab14-3666-4536-ad4e-08da57f8f05a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2022 04:53:12.1701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4qXYiKVuFMgMlwAR7+1raJHTxXB0QoU9ulaRJL9rohWGB/yvUTIy0sGMWMyDaS3FdlEsL4t4p8unoebi6vPE3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2960 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Peng, > -----Original Message----- > From: Zhang, Peng1X > Sent: Friday, June 24, 2022 2:15 AM > To: dev@dpdk.org > Cc: Singh, Aman Deep ; Zhang, Yuying > ; Zhang, Peng1X ; > stable@dpdk.org > Subject: [PATCH] app/testpmd: fix secondary process cannot dump packet >=20 > From: Peng Zhang >=20 > The origin design is whether testpmd is primary or not, if state of recei= ve > queue is stop, then packets will not be dumped for show. > While to secondary process, receive queue will not be set up, and state w= ill > still be stop even if testpmd is started. So packets of stated secondary > process cannot be dumped for show. Current description is confusing. Please refine the commit log to define th= e issue clearly. >=20 > The current design is to secondary process state of queue will be set to = start > after testpmd is started. Then packets of started secondary process can b= e > dumped for show. >=20 > Fixes: a550baf24af9 ("app/testpmd: support multi-process") > Cc: stable@dpdk.org >=20 > Signed-off-by: Peng Zhang > --- > app/test-pmd/testpmd.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 205d98ee3d..93ba7e7c9b 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3007,6 +3007,18 @@ start_port(portid_t pid) > if (setup_hairpin_queues(pi, p_pi, cnt_pi) !=3D 0) > return -1; > } > + > + if (port->need_reconfig_queues > 0 && !is_proc_primary()) { > + struct rte_eth_rxconf *rx_conf; > + for (qi =3D 0; qi < nb_rxq; qi++) { > + rx_conf =3D &(port->rxq[qi].conf); > + ports[pi].rxq[qi].state =3D > + rx_conf->rx_deferred_start ? > + RTE_ETH_QUEUE_STATE_STOPPED : > + RTE_ETH_QUEUE_STATE_STARTED; > + } > + } > + > configure_rxtx_dump_callbacks(verbose_level); > if (clear_ptypes) { > diag =3D rte_eth_dev_set_ptypes(pi, > RTE_PTYPE_UNKNOWN, > -- > 2.25.1