patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
To: Rahul Bhansali <rbhansali@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
	"Kundapura, Ganapati" <ganapati.kundapura@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
Date: Tue, 26 Sep 2023 07:04:08 +0000	[thread overview]
Message-ID: <DM6PR11MB38683507B1CDC72D45A6F017A1C3A@DM6PR11MB3868.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230920164823.1164930-1-rbhansali@marvell.com>



> -----Original Message-----
> From: Rahul Bhansali <rbhansali@marvell.com>
> Sent: Wednesday, September 20, 2023 10:18 PM
> To: dev@dpdk.org; Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; Kundapura, Ganapati
> <ganapati.kundapura@intel.com>
> Cc: Rahul Bhansali <rbhansali@marvell.com>; stable@dpdk.org
> Subject: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
> 
> For eventdev internal port, timestamp dynamic field registration in mbuf is not
> required as that will be done from net device.
> For SW eventdev, Rx timestamp field registration will be done during Rxa
> service initialization.
> 
> Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf
> field")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>

Acked-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>

> ---
> v3 changes:
> - timestamp register move before other Rxa init config.
> 
> v2 changes:
> - addresses the review comment to have registration in rxa_init_service()
> 
>  lib/eventdev/rte_event_eth_rx_adapter.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 3ebfa5366d..8df92247fa 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -1910,6 +1910,13 @@ rxa_init_service(struct event_eth_rx_adapter
> *rx_adapter, uint8_t id)
>  	if (rx_adapter->service_inited)
>  		return 0;
> 
> +	if (rte_mbuf_dyn_rx_timestamp_register(
> +			&event_eth_rx_timestamp_dynfield_offset,
> +			&event_eth_rx_timestamp_dynflag) != 0) {
> +		RTE_EDEV_LOG_ERR("Error registering timestamp field in
> mbuf\n");
> +		return -rte_errno;
> +	}
> +
>  	memset(&service, 0, sizeof(service));
>  	snprintf(service.name, ETH_RX_ADAPTER_SERVICE_NAME_LEN,
>  		"rte_event_eth_rx_adapter_%d", id);
> @@ -2472,13 +2479,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
>  	if (conf_cb == rxa_default_conf_cb)
>  		rx_adapter->default_cb_arg = 1;
> 
> -	if (rte_mbuf_dyn_rx_timestamp_register(
> -			&event_eth_rx_timestamp_dynfield_offset,
> -			&event_eth_rx_timestamp_dynflag) != 0) {
> -		RTE_EDEV_LOG_ERR("Error registering timestamp field in
> mbuf\n");
> -		return -rte_errno;
> -	}
> -
>  	rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
>  		conf_arg);
>  	return 0;
> --
> 2.25.1


  reply	other threads:[~2023-09-26  7:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18  8:25 [PATCH] " Rahul Bhansali
2023-09-19 16:29 ` Jerin Jacob
2023-09-25 10:18   ` Naga Harish K, S V
2023-09-26  7:37     ` Jerin Jacob
2023-09-20 12:32 ` Naga Harish K, S V
2023-09-20 16:17   ` Rahul Bhansali
2023-09-20 16:32 ` [PATCH v2] " Rahul Bhansali
2023-09-20 16:48 ` [PATCH v3] " Rahul Bhansali
2023-09-26  7:04   ` Naga Harish K, S V [this message]
2023-09-27  4:58     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB38683507B1CDC72D45A6F017A1C3A@DM6PR11MB3868.namprd11.prod.outlook.com \
    --to=s.v.naga.harish.k@intel.com \
    --cc=dev@dpdk.org \
    --cc=ganapati.kundapura@intel.com \
    --cc=jerinj@marvell.com \
    --cc=rbhansali@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).