From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7366A09EF for ; Wed, 23 Dec 2020 07:29:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A19D2CA6A; Wed, 23 Dec 2020 07:29:32 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8F19DCA36; Wed, 23 Dec 2020 07:29:28 +0100 (CET) IronPort-SDR: RAUesTzVeNLxLWUiP3gkvFrUWh6MMtEjrG/srewvcHqE9l5lle/4hALZe8dA4RuKxfLXbx6nuR OItQDOsr01QQ== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="163027591" X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="163027591" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 22:29:25 -0800 IronPort-SDR: 6eV+NWIwXJshvbv4kaPpVOehJbLPPRRjBTPLd9tZaXGzj71yREd6TrojyYszlNpC/tG5c/kPQH Wvo6rfYa5Q8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="562903927" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 22 Dec 2020 22:29:26 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 22:29:25 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Dec 2020 22:29:25 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Dec 2020 22:28:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JVZgzl00sGAbbUW2IMgiuCxVIlx6qrASXfAGNFDTwjIqgb8UYTwzzMix0fIaVL2ZNow/D6zOKuUCMByuCevKLtvoloGciDxqQFtygpQ6dotKSAvWxyJDK10gYn7c9zsMYPYSWHLwNbGWkPRphdJhiFG3BCwn54HkeI4Cddy1pNWRHdeY7A/4n0GFshpQW4KA6u57JsZIeXdkzydXdWtHBsSQw8A89iBnoomrbu8YwaYJcK0pYCk7mRlF74//z9LfpMaXnUKAEZ4HQpVVY+o4p2rK7TuxZYThsx4eGKS2MSvevnIeU6RJVJppZBN2M7XiKo7qmslIUK61I9C8ZxXOuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Hr8vJUgHwtNTlSNTONEvjc2H49TbRP00faeZycYDTc=; b=oV+6To8YQNdLPqCikQejCmwPOC4wZPNRAEspClX2d4TFaTIgVDVQwe9caUzC+KtbLeIdyQiWrleIwiiQp+1URkcifPPqoJQrtOnJdxV69r8387N3Q1y0/yuOE3fzXv0i0Y9rta8EEgzQQXAiK3hvkFk3vOrDinzBn0y1tXl+7F8fy4Tx6KoWNX5J8TkoShpQm+NRq/WP7TQPBnCh6feUhsOWY0saANQM76ZIKcLuArm+uBNmr6d7QplHuySKSAh5mLMd1lWv3mNL666OTcKpewykmy7NmsaGclN8U/rloEIiOGOt4Qp6M+2K5F+EnIpfzUrkrxyvlXYYng5NwYT8iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Hr8vJUgHwtNTlSNTONEvjc2H49TbRP00faeZycYDTc=; b=ApYb876woZ0SZX246cD3IhUtOr/1yM6wHicxuFb2q0aQAZNjqCGAAfoi3sH8erSuYrS4myoEMNr6w/Yv2a3N5Un63K9JFv4+Xln3dusos6MVfm8bYXIFZUz+XL38RpfsHN/NzCeDLaQlKNvA8JLk863sAui06/sXa4mmNZfOSik= Received: from DM6PR11MB3898.namprd11.prod.outlook.com (2603:10b6:5:19f::12) by DM6PR11MB3579.namprd11.prod.outlook.com (2603:10b6:5:13c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Wed, 23 Dec 2020 06:28:13 +0000 Received: from DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::7147:c48e:88a7:f8d7]) by DM6PR11MB3898.namprd11.prod.outlook.com ([fe80::7147:c48e:88a7:f8d7%7]) with mapi id 15.20.3676.034; Wed, 23 Dec 2020 06:28:13 +0000 From: "Zhang, AlvinX" To: "Xu, Ting" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix queue pairs configuration Thread-Index: AQHW2Oyk6O/Dq1R4PkiLbnRb1dTb6aoEMaOAgAADEyA= Date: Wed, 23 Dec 2020 06:28:12 +0000 Message-ID: References: <20201223052936.7200-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55f19c72-4539-4874-34a2-08d8a70becb1 x-ms-traffictypediagnostic: DM6PR11MB3579: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JXIXkgqwHvar3xydjOkCUY18S/s13yEF/DZAIvLv2JkIyIAGt4YrAY5ZJOcYBPMa2uS4SJnpJItFWgVq3dJzU3SChv50WURFx0sVJtUXyJTq6NYO7wEJaXVeauYdHep5knWkGvFFJYloMCqNrZO/83NAe9RVDQidY27R6UBopPLTek/EUhzSeaknh5dtS4wNGquR7+O4K10IkdPMxGP1qpfjw51Bitb+jP//Y1ooUdJxudfegfopWK8g5jKB9VgcCLBMnN9KrzGCuVByBD9n7O3hWCtzAZLg1xtOgNA6U2vS+7htASd9fRHkU1x61IlNKL74gvZo/RPYzzd8tC7XPnzYIe72acL+WH3xoeJYffw1tkpzZhWTJLDc0p13TqW8BhFpfHMszrZUswKfZ2ycIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3898.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(366004)(39860400002)(136003)(2906002)(7696005)(66556008)(26005)(450100002)(6636002)(71200400001)(4326008)(8936002)(110136005)(8676002)(54906003)(9686003)(186003)(55016002)(83380400001)(76116006)(316002)(86362001)(66476007)(66446008)(64756008)(53546011)(5660300002)(66946007)(6506007)(478600001)(52536014)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FZcfo3p46oFXFqwF3W/WJDmHjTdv3+p27R30SjtzX08t3uDZ//fEr5cvA3YL?= =?us-ascii?Q?Q6jJHdY7vkHmAOFUqgdmaH/iqi0b05N79lXEqX7JMplAKVT9Zn4G70iGZDqR?= =?us-ascii?Q?apqfiWNzonKhpNglUVC0dW8c/5IFhisCJeS8GEtAGOdUG7JS/qCvmDnBdoTV?= =?us-ascii?Q?ID+U+sqDFC5dA8JiRU4oNTYVna0MUFVwGpa3mAKykzu0jegd1hgudSGwGAJp?= =?us-ascii?Q?WAs1v2RiTg3pLW64xAB4Qkdhyc+GTk0izwTFyrD/QsdxHXW6xzbyJyz9agVw?= =?us-ascii?Q?SE34ADYQ/qtzUYNDyw84P4C7f1CLAW5Gnr/iAfkJNDUm5bMPA3xiEqehHTv8?= =?us-ascii?Q?6+afxUobdHEErvPB93TAPMZVS2VmIsx9b33AyCTlfspJWfv+PYyhUB+0/11j?= =?us-ascii?Q?R9084qEAUbqCaJ6CNzFFF6NjXOvfG4ORVfIOXrK2MY5fzqNHpML5MWybCeeC?= =?us-ascii?Q?BiwRns94+0N6HOcCCsefP/2T/c3cWM9uNtD/EL72DOW5m5hXa/nzN/0b8+x+?= =?us-ascii?Q?WhYNapTjNvESsu0MD983LSEWP8O2rGwrxUntx1m3Uvys2icZku4KeR6rya48?= =?us-ascii?Q?L2vjI26jGOemRZpeuEabLz0S5CwhpX2YU7E0rUJqGvT4ABzI0RTteLwg7rva?= =?us-ascii?Q?eaLaTub7nUYlB+gdFbiOUWORoX7bU4d0fTOJPNrx5SkX+OenmSWr4B8cS6Bv?= =?us-ascii?Q?keL/ILdp5ONkbe+UtSDL1bHq4Derc4k5FWaXJ9xccpv+HjD42iUOxADylyyC?= =?us-ascii?Q?5Cmr87mbFBxcgD4ZKMpPLzrggQ6MvLl1pT8MtnD7dUyoa/1BOcPAUBzsoHMf?= =?us-ascii?Q?niZxppgyS7x34/OAr5hEZnA8n+illi75citAfzsoIBtRl6phVCK4mtn9quXq?= =?us-ascii?Q?a7oZ3IIeO2l+B2mo15zeCJreoqHxsLzV+YcYo6SF9UoaDxm/ILg46Nn+igHl?= =?us-ascii?Q?imULhY5iWoBDrE+lW0VHgt0GdKuVCDMJT8uq3ro/+SE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3898.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55f19c72-4539-4874-34a2-08d8a70becb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 06:28:12.9320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /Dy9r0wCx7YhsJIoixRPFDt3kPoNnfjyOIomg5YjEsPSflh3N9GuDpuG+D4xDsA1e3W173c60DI+EvBRo6o2cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3579 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Xuting, Thanks for your reply. It's very efficient for CVL. But the FVL PF provides default 4 queue pairs = to VF, if every VF request 16 queue pairs, there may be not enough queues pairs fo= r all VFs. BR, Alvin > -----Original Message----- > From: Xu, Ting > Sent: Wednesday, December 23, 2020 2:06 PM > To: Zhang, AlvinX ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: RE: [PATCH] net/iavf: fix queue pairs configuration >=20 > Hi, Alvin, >=20 > > -----Original Message----- > > From: Zhang,Alvin > > Sent: Wednesday, December 23, 2020 1:30 PM > > To: Xing, Beilei ; Xu, Ting > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [PATCH] net/iavf: fix queue pairs configuration > > > > From: Alvin Zhang > > > > Check if there are enough queue pairs currently allocated, and if not, > > request PF to allocate them. > > > > Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more > > queues") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang > > --- > > drivers/net/iavf/iavf_ethdev.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > b/drivers/net/iavf/iavf_ethdev.c index 7e3c26a..f015121 100644 > > --- a/drivers/net/iavf/iavf_ethdev.c > > +++ b/drivers/net/iavf/iavf_ethdev.c > > @@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off { > > } else { > > /* Check if large VF is already enabled. If so, disable and > > * release redundant queue resource. > > + * Or check if enough queue pairs. If not, request them from > > PF. > > */ > > - if (vf->lv_enabled) { > > + if (vf->lv_enabled || > > + num_queue_pairs > vf->vsi_res->num_queue_pairs) { > > ret =3D iavf_queues_req_reset(dev, num_queue_pairs); > > if (ret) > > return ret; > > -- > > 1.8.3.1 >=20 > Will it be better to change ret =3D iavf_queues_req_reset(dev, num_queue_= pairs); > to ret =3D iavf_queues_req_reset(dev, IAVF_MAX_NUM_QUEUES_DFLT); based on > the original codes? > Since PF provides default 16 queue pairs to VF. If large VF is no need to= be > enabled, it may be better to reset the queue pairs number to 16. So that = we > don't need to compare the queue pairs number and request queues each time > when it is no more than 16. If more, it turns to large VF to handle. > The original codes here are not good. > Thanks.