From: "He, ShiyangX" <shiyangx.he@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhou, YidingX" <yidingx.zhou@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
Remy Horton <remy.horton@intel.com>
Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get
Date: Thu, 5 Jan 2023 02:52:28 +0000 [thread overview]
Message-ID: <DM6PR11MB394650E993432AED2074DC3CF7FA9@DM6PR11MB3946.namprd11.prod.outlook.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87620@smartserver.smartshare.dk>
>-----Original Message-----
>From: Morten Brørup <mb@smartsharesystems.com>
>Sent: Wednesday, January 4, 2023 6:19 PM
>To: He, ShiyangX <shiyangx.he@intel.com>; dev@dpdk.org
>Cc: Zhou, YidingX <yidingx.zhou@intel.com>; stable@dpdk.org; Yang, Qiming
><qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>; Remy
>Horton <remy.horton@intel.com>
>Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get
>
>> From: Shiyang He [mailto:shiyangx.he@intel.com]
>> Sent: Wednesday, 4 January 2023 10.52
>>
>> The firmware version obtained by dpdk-ethtool is inconsistent with
>> that obtained by linux-ethtool.
>>
>> This commit fixes the issue.
>>
>> Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Shiyang He <shiyangx.he@intel.com>
>> ---
>> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>> b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index ae9f65b334..012096021e 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> @@ -3859,7 +3859,7 @@ ixgbe_fw_version_get(struct rte_eth_dev *dev,
>> char *fw_version, size_t fw_size)
>> ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh);
>> ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl);
>>
>> - etrack_id = (eeprom_verh << 16) | eeprom_verl;
>> + etrack_id = (eeprom_verl << 16) | eeprom_verh;
>> ret = snprintf(fw_version, fw_size, "0x%08x", etrack_id);
>
>This looks wrong, assuming the high-word in 0x2e and the low-word in 0x2d.
>
>Perhaps the linux ethtool needs to be fixed instead?
>
>I don't think DPDK should aim for "bug compatibility" with Linux. :-(
After following your suggestions, I read the driver source code again,
which is implemented as the solution. I will send out V2 patch soon.
next prev parent reply other threads:[~2023-01-05 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:51 Shiyang He
2023-01-04 10:18 ` Morten Brørup
2023-01-05 2:52 ` He, ShiyangX [this message]
2023-01-05 6:57 ` Morten Brørup
2023-01-05 7:33 ` He, ShiyangX
2023-01-09 6:53 ` [PATCH v2] net/ixgbe: fix ixgbe firmware version inconsistency Shiyang He
2023-01-09 7:47 ` Morten Brørup
2023-01-16 8:04 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB394650E993432AED2074DC3CF7FA9@DM6PR11MB3946.namprd11.prod.outlook.com \
--to=shiyangx.he@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=qiming.yang@intel.com \
--cc=remy.horton@intel.com \
--cc=stable@dpdk.org \
--cc=wenjun1.wu@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).