From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A080A0093 for ; Wed, 11 May 2022 10:50:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70F964282D; Wed, 11 May 2022 10:50:59 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 9B47740042; Wed, 11 May 2022 10:50:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652259057; x=1683795057; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PMp85TLDMmjjqzH0shKK5Qo9aUZzjKSisYA4BaVDwFU=; b=lLwWQpQxc4d+jVRbPvuRwv3hSu3lEQrPkw5XGJuta/SsUiTRNecGblFg D1GC/aKwdN2eCDYYSUNTukZrBnsq7+8X8XredHU3qhVrh0/LDL9G41jxJ V3lT0I53XIfar3h2DWBFQtkOXte4dcYSAdACUI7pwZhtZREaIbyjY/Dh0 vTqIWxWiJXjBMTRaU/swVqVXDlyItroicuuMx6GlAL080ZnGAGOJU2/iW dMU5UIQuG9+Da0IqSbvvGXNnsSl1TAlnoelZJlqpPLU0akbuyQwsf8Zby SRSQQZZbKZRwmq5cWS38AzhF05T0d9nOzNIcinQN/Amw15Wos+t79h8c/ w==; IronPort-Data: A9a23:W5d9VaDFDQKnqhVW/57hw5YqxClBgxIJ4kV8jS/XYbTApGhx1DVTz WcdCjqDb/aMY2DxfYp1Pd+18BgA7JSHzINiTANkpHpgcSl2pJueD7x1DKtR0wB+jCHnZBs/t 63yv/GZdJhcoln0+Ev1atANilEljfrUHdIQMMadZmYpA1YMpB4J0XqPocZg6mJTqYX/UlrlV e/a+ZWFYgf4gmcsawr41orYwP9RlKWq0N8nlgFmDRx7lAe2e649V8p3yQmZdhMUc6EMdgKIb 7+rIIKRpws1yywQ5uaNyd4XRGVRG+KPYlLe4pZhc/PKbhBq/kTe20ugXRYWQR8/Zz6hxridx DjW3HAZpMhA0qDkwYwgvxdk/y5WB7wB2rHDeyCFrc3M83z8dFHHyNhNNRRjVWEY0r4f7WBm8 uYDLT8ENkjfweC4hrO9VuRowM8kKaEHPqtG4jc/i2uBXLB9EfgvQI2TjTNc9C89gM8IHevXY cUxaDxzYRCGaBpKUrsSIMhgzbzw2yCgLFW0rnq4gKs4vjn51jdj0ZTBGd3lVPmtQd5KyxPwS mXuuj6R7gshHNCS1xKJ6n6vwOjVkkvTQ54bHrm13vJyjF7VwXYcYCD6TnO8u+K8hUfmA44ZK UJS+ywyoKx0/0uuJjXgYyCFTLe/lkZ0c7Jt/ycSsWlhFoK8D96lO1U5 IronPort-HdrOrdr: A9a23:KBQOBKs8GqbP2E7LCjbJhW6A7skCIYAji2hC6mlwRA09TyXGrb HNoB1L726WtN9OYhEdcIi7Sdi9qXO1z+8N3WBjB8bTYOCAghrtEGgC1/qm/9SOIVyCygcw79 YGT0E6MqyPMbEYt7e83ODbKadd/DDvysnB6IuwoRYdKHAPV0gj1XYHNu/yKDwmeOAsP+tAKH Po3Ls8m9PWQwVtUi3UPAhiYwGFnbb2fZTdCyIuNloC0k2jnDmo4Ln1H1yzxREFSQ5Cxr8k7C zsjxH5zr/LiYD89jbsk0voq7hGktrozdVOQOaWjNIOFznqggG0IKx8Rry5uiwvqu3H0idyrD CMmWZ5Ay1A0QKKQoiHm2qx5+Am6kdz15bW8y7CvZIkm72neNt1MbseuWsTSGqr16NphqAP7E sM5RPIi3MfN2K3oMwkiuK4Iy2DTSeP0A0feTR/tQ0rbaIOLLBWtoAR50VTDdMJGz/78pkuFK 10ANjb/+s+SyLbU5l3hBgk/DWAZAV8Iv69eDlChiVV6UkaoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBZLfMB2OfTvcdGaJZVj3HqAOPHzA75bx/bUu/emvPJgF1oE7lp jNWE5R8WQyZ0XtA8uT24AjyGGPfEytGTD2js1O7ZlwvbPxALLtLC2YUVgr19Ctpv0Oa/erFM pb+KgmT8MLAVGeUbqhhTeOEqW6AUNuG/Eohg== X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="269305177" X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="269305177" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 01:50:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="697484470" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 11 May 2022 01:50:55 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:50:55 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:50:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:50:54 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 11 May 2022 01:50:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UI4ZzzvhpnccZIMveqfIkB83iQwtuCHndPxS10Wyc5ALaO7uWzLN4YRkYfUJEA7Ru1Ct1HSOvnUaAPkapndkwrvSADEJVaTO1xuLEaKP69FD+AukA9aKECd3IaXFYQ1DA72aJSaIh8h/G9h8wsSBLvMY7xb2v0QYn4VhrRu06BjM0DCF6bUCMDFqCO427WgQmmkRmxcM1+5DQp3cqdJj8E8yF8m5CYKoj0OWyaSNqP5TeyFiV1HKZ1q4AfDcaQIT7VkNBrqdJtZEClalZcDGcdERHXrNvqtbDEFZlukH1KPDBShyXDXcp+2xDLci91CrOCnNaqyC3FjQhUwptWaP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMp85TLDMmjjqzH0shKK5Qo9aUZzjKSisYA4BaVDwFU=; b=KKzKmyxoUf+aCwMkecdI0Ob2wcvlK6jKn8qToqA4Xb4HRPh33EeQz7Ugt+1S+Wf191DrupGfMNTutlhh4U9XnCKn1r59kOJCfqlHyuKuV5/sO3acPUiPoecIMuJYHwEwEFio6AVaiUkqKWkBOfCxFh28l9OJjirQPOvofyRuyneoGbDYfmqekvwGw3OPfWvvvmVdakWPnuYld21UHVlaDqSFpwZJ7f8SuaWn3xf/I7VbqOSvE/nLKWw6vURO816ECNOLO1EsuYE78Xp6MtDUb/JZ4ReoBicia8PwiDqbsNs+G5pSmNnWwZsnHOyt2d0gnnwWpxyr0TavLzPGJy/1CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4249.namprd11.prod.outlook.com (2603:10b6:5:1d9::29) by DM5PR1101MB2315.namprd11.prod.outlook.com (2603:10b6:4:53::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Wed, 11 May 2022 08:50:53 +0000 Received: from DM6PR11MB4249.namprd11.prod.outlook.com ([fe80::bcab:23a9:6291:473c]) by DM6PR11MB4249.namprd11.prod.outlook.com ([fe80::bcab:23a9:6291:473c%4]) with mapi id 15.20.5227.023; Wed, 11 May 2022 08:50:53 +0000 From: "Huang, Peng" To: "Zhou, YidingX" , "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" CC: "Yang, Qiming" , "Zhang, Qi Z" , "stable@dpdk.org" , "Zhou, YidingX" Subject: RE: [PATCH v2] net/iavf: fix segfaults when calling API after VF reset failed Thread-Topic: [PATCH v2] net/iavf: fix segfaults when calling API after VF reset failed Thread-Index: AQHYWgcocRjVurkPAkuLLwxVKEc1b60ZdCdg Date: Wed, 11 May 2022 08:50:53 +0000 Message-ID: References: <20220421170827.2753175-1-yidingx.zhou@intel.com> <20220427152524.228930-1-yidingx.zhou@intel.com> In-Reply-To: <20220427152524.228930-1-yidingx.zhou@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4daf24b8-e13c-483b-dda5-08da332b5b27 x-ms-traffictypediagnostic: DM5PR1101MB2315:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UIxu4q8yuuMs6A/PVJfYxyzuFvHPUr3T2rR14X2JQTO0Lu2pc6A9YC/RT7+Dmj4kU52IF1g5fdMWEhCZysrobTIfStZ6O7JmIz/MFzSvJMMekYnXO/cA1KEb6LfFXPrQ18AjSECRLnRAKCPo2m1XmtFnD0yWnqTM/cYQ3L2Yt3dMfK2zDrVtn/f/kYt+Qqxw6IEs3TzBApvImSLPZDWC6pEDT/BSPz3oVYGhmORGRhxQqM1NCOFsDMru592KqR0aHa2Ft6NIaUM0br7QIO4GOBwko++LMinZX4IHM/Td6zZnGk6wf2nM015yFvs9mtiZKvrREB/30Li/QNx+Brb8TgI6wvZ9n4CmbEZxFwvi7mwzln4nSve7YZ1t7n+UuWt4+RGB5UxmOcGJaGiX94zlAV0DfNaAd1F3EcjeRLqtc7L49rDp2p2L6ss+DtPg9Qlb23ORZjxdHOYRHWQQ0ZyL0EzK6NO49ysv/YckgGr5GqeMzxU6nTGIrt8z3HKkIUqIszNR96v/XZ0X1ik0h0KfgJOXvUrI3UE30M5e5Y2coCj0BmwQPwee9ScWD5QJRfOjkJQxQadxHlec/NoY/SPpnMvdfoZUr4NQ+rXR1nfCpy95sw+wHVXZa7C6w85TkiEsHyC2ksV6K+dV8o8zPrvVuy4S4+DzhJx/0K8Cp9jPbxQ6sBTE2r88SGQUoxWO1dmafUHO2w4DZj0LMwiZ6RDKSA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4249.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(9686003)(54906003)(8936002)(86362001)(52536014)(5660300002)(55016003)(53546011)(7696005)(316002)(6636002)(6506007)(4744005)(508600001)(38070700005)(66446008)(66476007)(66556008)(66946007)(76116006)(38100700002)(4326008)(33656002)(2906002)(71200400001)(107886003)(64756008)(8676002)(82960400001)(450100002)(186003)(83380400001)(122000001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HufbaCcxje4vZCr4/JWX9snTVhJWUX7tUn+uMcGFxO0zk/ai66RLeS+QvcZn?= =?us-ascii?Q?gxttCj2jFLuDqP6CavZvulR5EUYGhUZMGtanfsiFw8pT+LUz+XfXEcFSYc9f?= =?us-ascii?Q?oFOPV4rZFah2bgBh8IrewpGND4oDx+42JA+rzECJa/XUBXi8NZwYAW3wFku4?= =?us-ascii?Q?jqXvQlcGpGjyrVR4FQvcawcJPhzXagwtFbx6R6PRWlJrvji2hDoFOFOF0p53?= =?us-ascii?Q?mt36Dz0oC+0lN6l/bFlyYqQXVtm/vxk6odI0u0QNm982fArjLsL8PVk/dh9d?= =?us-ascii?Q?mqpYSlZrAO9cqejM1W038LEHw8x0HJ67WbCmSG2Ckk78tKDvlKnPbIS//1Ht?= =?us-ascii?Q?JJ/0HpAM0maBQW/EDaB4MJJvXWJ/Xl7iRrmHbWJBtlt3Ujhqd2XTF1L8Y5Aa?= =?us-ascii?Q?MwKVp7QahsQhWraIee8TVMNwKjBXcZTxKFOzbAGbKGJNUDsq/+eqqPgkH5GQ?= =?us-ascii?Q?Y6lDloBS2foIdtY5jq5omFYbFzafWRyMw5YuOJHC8Za7AGBnudvLMAKykEx7?= =?us-ascii?Q?Tl92LcJkFTbexw54y3cHpAF1w30qJFHxdLKLFqYCrrRv0vYQdcfT4i+qe2BO?= =?us-ascii?Q?urlXL0V9+gBz3mXRNI1BkcANLPwQuKYHnD6snzIaCwSTPU9kAVUPIeZNxife?= =?us-ascii?Q?F3zvhTrAGfOtLZMlPpMqsIZaoQm5VZh/rh4216oYFfXVfVcVTNQPXV9GiRVS?= =?us-ascii?Q?jzh1b1sC0BE5R25lhJssodE5KvKDpNdbpzYFwyYsqL0TH2lYdkiWgw2kWk5F?= =?us-ascii?Q?hEMA1RxyQ0ptH5U0hCQ47YCv/s+STzKCECuqOnPTORs+c4pO1BKXTOUwOYF1?= =?us-ascii?Q?AnGuZVnfWFFcnQHTzL97j3+WBjcQ89iSH5DsBg+fNldlzc0JB5kbKQx0FC8U?= =?us-ascii?Q?sQhmSKDUvWZ3InyzIuG0+XKx4SvO3VbiXPGsWnm0EczxHFpAXa+Ns3WbHvUk?= =?us-ascii?Q?9uZTIZumuSUTzDX96o9gnljgGXv9CXpMpbrZvV/3/mNZLYw69qxN1QYuQ0M8?= =?us-ascii?Q?notNTouGcPYmiAF4AtgJCphXH6IT5LjbIMTcobSdQyqL1a8db2wG/kYJ/fYP?= =?us-ascii?Q?5cKPKZIwCT74yNhHjVkIyzIVvhPTDn8QDBb6a979x1depelGxY3m/BiOSb49?= =?us-ascii?Q?5JGma3+0fA+U3m9UwZ2XZ5hUUlGIJuEA7ROEWkZLHGb3A6cqUgA3hT8pXC3O?= =?us-ascii?Q?QK0GewUR1Ufv59vmmHRWAZzfhEP4QZMbe3T4uJ/ckV3y9sfJegj1zQNRvf5y?= =?us-ascii?Q?whjpPIorKqIblJmnEQg6Vrp21YhMMqyKrY/PG1WjnHxhtrVAKcgkMAt2c3R2?= =?us-ascii?Q?zjsiay2H9GDUPwd0u6x1cPXhuAYGE++i9LtJpJ5lNJxuorm5eTBveBVoTZPi?= =?us-ascii?Q?cBgmuabyBZRDf2jy08f7YEcjhuuGH2Jh+LPulMqp28jWwQsrZJWvxXiFHzhw?= =?us-ascii?Q?W3rOKeS7D8FiX5b9gpfk9fVWFuRduuECiDrdZe2IaD9yOOSyEWHHTiYBe6as?= =?us-ascii?Q?mC9ibtyM9zZ6uPMFmcbq+VlHBSJszs1m83OBgxKJAUVjfJm/0IVT4I8F0Huw?= =?us-ascii?Q?zsvgvZVJ/bGp390vBitdD130gH6LRsTL/3bsFy9FOVhxm7azfpnFBb036VB0?= =?us-ascii?Q?FehKGn7wXEmqsJsuoIdXwzV7wMlj1k2qFvMG3FtqK9+JoZp5pqx1+uCzFThY?= =?us-ascii?Q?ye2QFMzgdCkg2alUHyruayLGfd3NMDFaMU/dG/Wi1E+c9glxyXhPumoCVw6W?= =?us-ascii?Q?xmNrZMR4pA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4249.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4daf24b8-e13c-483b-dda5-08da332b5b27 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 08:50:53.1671 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EyzUWNR4Npq5DJgnAcmFVnWcVKJx8GZ7sxZ4uTh4rIStJsV7bnxZpIZ3++soZ9QLFSc0TX7F21m3+N1lhxXOQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2315 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yiding Zhou > Sent: Wednesday, April 27, 2022 11:25 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: Yang, Qiming ; Zhang, Qi Z > ; stable@dpdk.org; Zhou, YidingX > > Subject: [PATCH v2] net/iavf: fix segfaults when calling API after VF res= et failed >=20 > Some pointers will be set to NULL when iavf_dev_reset() failed, for examp= le vf- > >vf_res, vf->vsi_res vf->rss_key and etc. > APIs access these NULL pointers will trigger segfault. >=20 > This patch adds closed flag to indicate that the VF is closed, and reject= s API calls > in this state to avoid coredump. >=20 > Fixes: e74e1bb6280d ("net/iavf: enable port reset") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yiding Zhou Tested-by: Peng Huang